WIP: OSX toolchain bump #8184
WIP: OSX toolchain bump #8184
Conversation
clang: 3.7.1 cctools: 877.8 ld64: 253.9
| @@ -124,6 +124,7 @@ define $(package)_preprocess_cmds | |||
| sed -i.old "s/src_plugins.depends = src_sql src_xml src_network/src_plugins.depends = src_xml src_network/" qtbase/src/src.pro && \ | |||
| sed -i.old "s|X11/extensions/XIproto.h|X11/X.h|" qtbase/src/plugins/platforms/xcb/qxcbxsettings.cpp && \ | |||
| sed -i.old 's/if \[ "$$$$XPLATFORM_MAC" = "yes" \]; then xspecvals=$$$$(macSDKify/if \[ "$$$$BUILD_ON_MAC" = "yes" \]; then xspecvals=$$$$(macSDKify/' qtbase/configure && \ | |||
| sed -i.old 's/CGEventCreateMouseEvent(0, kCGEventMouseMoved, pos, 0)/CGEventCreateMouseEvent(0, kCGEventMouseMoved, pos, kCGMouseButtonLeft)/' qtbase/src/plugins/platforms/cocoa/qcocoacursor.mm && \ | |||
There was a problem hiding this comment.
hmm... what's the patch for? IMO the kCGMouseButtonLeft constant is set to 0 as well? https://developer.apple.com/library/mac/documentation/Carbon/Reference/QuartzEventServicesRef/index.html#//apple_ref/c/econst/kCGMouseButtonLeft
There was a problem hiding this comment.
See the todo in description, this was fixed in 5.6.
You'd have to cast like (CGMouseButton)0.
|
Nice! I can take care of the docs. Question: would it be to restrictive to set 10.8 as minimum deployment version ( |
|
@jonasschnelli afaik 10.7 is the pretty standard minimum these days, but we could always bump if desired. It doesn't look like that runtime check really hurts anything, though? |
|
@jonasschnelli Is that the only 10.8 related hack in the codebase? |
|
@fanquake: bumping to 10.8 could allow use to use the NSNotificationCenter without weak linking. But after thinking about it, I guess we should keep 10.7 as min for 0.13 (maybe also for 0.14). |
|
Tested ACK f5ade22. Did a gitian build, ran binaries on 10.11 and on a 10.07 machine: |
I think that's a pretty weak reason to drop support for an OS version. I'd also say stick with 10.7 as minimum for the foreseeable future. |
|
I've put together some changes to the build-notes here if you'd like to cherry pick. The 10.11 SDK is first available in Xcode 7.1, any opinions on wether we should target that for the new download vs 7.3.1 ? |
This bumps us to:
Beyond just keeping us current, this is also necessary for #7770.
The bump doesn't change anything in terms of back-compat, we still specify 10.7 as the required minimum.
Todo before merge: