[Qt] Add simple opt-in-RBF support #8182
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow to add flags for RBF and other features
On RPC level, we show possible mempool conflicts already via detecting them over the CWallet::GetConflicts() function. Currently, the GUI shows only conflicts with transaction in a block. This results in displaying replaced transaction (RBF) wrong. This PR will mark unconfirmed transactions that are _not_ in our mempool and have conflicts as conflicted.
| <string>Signal Replaceability</string> | ||
| </property> | ||
| <property name="toolTip"> | ||
| <string>Signals that this transaction can be replaced with a transation paying higher fees (as long as the transaction is NOT confirmed).</string> |
There was a problem hiding this comment.
transation -> transaction
|
"signals replaceability" doesn't really seem useful terminology for users. Maybe "Allow increasing fee later" or something would make more sense. IMO there should be some way for the user to actually control what the fee is bumped to. |
|
Unfortunately this missed the 0.13 feature merge window. We should merge it soon after 0.13 is branched off. |
|
needs rebase |
|
is anyone working on rebasing this or shall I? |
|
I'm currently not working on this and I have no near future plans to work on this. |
|
Closing. We need RPC support first. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1) Adds an option to set the opt-in-RBF flag when creating a transaction
2) Adds a fee bump option to the context menu.
The option is only enabled if the transaction
isFromMeand signaling RBF.For the full "RBF experience" we also should consider:
#7817 (attribute replaceable (RBF) transactions)
#7826 (show conflicts of unconfirmed transactions in the UI)