build: Get rid of CLIENT_DATE
#8181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK f6e201d |
|
Concept ACK f6e201d |
Putting the build date in the executable is a practice that has no place in these days, now that deterministic building is increasingly common. Continues bitcoin#7732 which did this for the GUI.
f6e201d to
d096d22
Compare
|
Updated the commit to also remove CLIENT_DATE logic from |
|
utACK d096d22 |
|
ACK d096d22 |
|
utACK d096d22 |
|
ut ACK d096d22 |
laanwj
added a commit
that referenced
this pull request
Jun 10, 2016
d096d22 build: Get rid of `CLIENT_DATE` (Wladimir J. van der Laan)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 22, 2017
d096d22 build: Get rid of `CLIENT_DATE` (Wladimir J. van der Laan)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
d096d22 build: Get rid of `CLIENT_DATE` (Wladimir J. van der Laan)
Fuzzbawls
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Sep 2, 2021
55ec1ee build: Get rid of `CLIENT_DATE` (Wladimir J. van der Laan) b22dc99 [Qt] Debug window: remove "Build date". (furszy) 4a18d50 build: Remove src/obj directory from repository (Wladimir J. van der Laan) Pull request description: >Putting the build date in the executable is a practice that has no place in these days, now that deterministic building is increasingly common. Back porting: * bitcoin#7732. * bitcoin#8181. ACKs for top commit: random-zebra: utACK 55ec1ee Fuzzbawls: ACK 55ec1ee Tree-SHA512: 21f1ca282fa55777e611644235f1ec8e5621dc7785c58a53a79470445dc458a19a460a4c52c9dae78f0c7cf16d4095bcc908c34e7dd305b8a1c56881d83e5d67
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting the build date in the executable is a practice that has no place in these days, now that deterministic building is increasingly common.
Continues #7732 which did this for the GUI.