Use SipHash for node eviction (cont'd) #8173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazy calculate vchKeyedNetGroup in CNode::GetKeyedNetGroup.
Add full test vectors from spec, test per byte and per 8 bytes. Builds on bitcoin#8086.
|
utACK eebc232 |
|
May want to re-title this PR |
|
The original had grown in scope anyway, it now does:
|
|
tACK on the purely Siphash part (reimplemented this PR tests included into NBitcoin successfully on MetacoSA/NBitcoin@c915829) |
sipa
added a commit
that referenced
this pull request
Jun 8, 2016
eebc232 test: Add more test vectors for siphash (Wladimir J. van der Laan) 8884830 Use C++11 thread-safe static initializers (Pieter Wuille) c31b24f Use 64-bit SipHash of netgroups in eviction (Pieter Wuille) 9bf156b Support SipHash with arbitrary byte writes (Pieter Wuille) 053930f Avoid recalculating vchKeyedNetGroup in eviction logic. (Patrick Strateman)
|
@sipa it's not clear who or what you're replying to In any case, it was time to merge this, there were no concrete concerns left. |
|
What is a SipHash? |
codablock
added a commit
to codablock/dash
that referenced
this pull request
Oct 19, 2017
Taken from Bitcoin bitcoin#8173/888483098e60f2a944f1d246bbfec4d14a2975f8 Needed to align code for upcoming per-utxo backports.
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 22, 2017
eebc232 test: Add more test vectors for siphash (Wladimir J. van der Laan) 8884830 Use C++11 thread-safe static initializers (Pieter Wuille) c31b24f Use 64-bit SipHash of netgroups in eviction (Pieter Wuille) 9bf156b Support SipHash with arbitrary byte writes (Pieter Wuille) 053930f Avoid recalculating vchKeyedNetGroup in eviction logic. (Patrick Strateman)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
eebc232 test: Add more test vectors for siphash (Wladimir J. van der Laan) 8884830 Use C++11 thread-safe static initializers (Pieter Wuille) c31b24f Use 64-bit SipHash of netgroups in eviction (Pieter Wuille) 9bf156b Support SipHash with arbitrary byte writes (Pieter Wuille) 053930f Avoid recalculating vchKeyedNetGroup in eviction logic. (Patrick Strateman)
1 task
furszy
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Aug 5, 2020
f980d43 Implement SipHash in Python (Pieter Wuille) 042d691 test: Add more test vectors for siphash (Wladimir J. van der Laan) ba049bf Use C++11 thread-safe static initializers (Pieter Wuille) 0f4290f Use 64-bit SipHash of netgroups in eviction (Pieter Wuille) d81973a Support SipHash with arbitrary byte writes (Pieter Wuille) 03dba42 Avoid recalculating vchKeyedNetGroup in eviction logic. (Patrick Strateman) Pull request description: Builds on top of - [x] #1768 Use SipHash for node eviction and add more test vectors for siphash (backports bitcoin#8173) ACKs for top commit: furszy: Looking good, utACK f980d43 Fuzzbawls: utACK f980d43 Tree-SHA512: 8e71322113b32a43e205a1e6dcd3b6a2b466da0f07ac59cc20856792fccb740a21edfc0f3791ddb73457676e8aa29979e155954a50361e519b7757b3aa4f007e
This was referenced Feb 11, 2021
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Feb 17, 2021
Use SipHash for node eviction Backport of bitcoin/bitcoin#8173 Commits are listed in stack order. - pick bitcoin/bitcoin@eebc232187 - pick bitcoin/bitcoin@888483098e - pick bitcoin/bitcoin@c31b24f745 - pick bitcoin/bitcoin@9bf156bb9e - pick bitcoin/bitcoin@053930ffc4 - missing bitcoin/bitcoin#5697 (not a candidate for direct inclusion), using pieces directly - conflicts with #1258 which it removes part of (this is ok) - ignore bitcoin/bitcoin#6374 - requires bitcoin/bitcoin#7906, or at least bitcoin/bitcoin@cca221fd21 - pick bitcoin/bitcoin@cca221fd21 - conflicts with bitcoin/bitcoin#7181, not needed until later if at all
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add full test vectors from spec, test per byte and per 8 bytes.
Builds on #8086 (as it adds per-byte hashing).