Test framework: only cleanup on successful test runs #8095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK |
|
ACK 64fc92f |
|
Concept ACK. Wouldn't it make sense to also Tailing the debug.log from rpc_tests.py makes sense, but would at least require #8098. |
|
utACK 64fc92f |
|
@arowser why are you asking the same question in so many random PRs? This is disruptive or development and annoying. Please, stop. |
64fc92f to
1ad9339
Compare
|
@MarcoFalke Updated with the print statement as suggested. |
|
utACK 1ad9339 |
|
ACK 1ad9339 |
maflcko
pushed a commit
that referenced
this pull request
May 25, 2016
1ad9339 Test framework: only cleanup on successful test runs (Suhas Daftuar)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 21, 2017
1ad9339 Test framework: only cleanup on successful test runs (Suhas Daftuar)
sickpig
pushed a commit
to sickpig/BitcoinUnlimited
that referenced
this pull request
Mar 12, 2018
Core QA cherries bitcoin/bitcoin#8047 - [qa] test_framework: Set wait-timeout for bitcoind procs bitcoin/bitcoin#8095 - Test framework: only cleanup on successful test runs bitcoin/bitcoin#8214 - [qa] mininode: fail on send_message instead of silent return
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't cleanup the datadir's on test failure.
I hope that this should make it easier to debug rare-failing tests, as we'll at least have the debug.log's available to go through.
@MarcoFalke: After this, we could perhaps add to the
rpc-tests.pyscript some functionality to tail the last few hundred lines of debug.log for each node if a test fails, so that if a job fails in travis, we'll have more info to look at?