[WIP] [depends] Qt 5.6.1 #8053

fanquake · 2016-05-14T08:52:29Z

Bump Qt to 5.6.1

The major changes are:
LTS - 5.6 is the new Long Term Support release, the previous being 4.8
Windows 10 is fully supported
High-DPI support, details here
Improved C++11 support by adding reverse iterators for all our container classes, a key_iterator for QHash and QMap, and a const_iterator for QByteArray.

Maybe worth noting that 5.6 is the will be the last version before some open source licensing changes take place, more details here.

Qt 5.6.0 - release post
Qt 5.6.1 - release post

Remove dbus from the qt build?

Fixes #7999

OpenSSL 1.0.2h
I had issues compiling with 1.0.1k, and had to remove the no-cms and no-rc2 configure options for 1.0.2h, otherwise the build would fail.
I also had to add a make depend step before building.

jonasschnelli · 2016-05-14T11:11:15Z

Nice! Have you tested this already over a gitian build?

jonasschnelli · 2016-05-14T13:01:44Z

Got gitian compile issues:
https://bitcoin.jonasschnelli.ch/pulls/8053/

making depend in crypto...
make[2]: Entering directory `/home/ubuntu/build/bitcoin/depends/work/build/i686-pc-linux-gnu/openssl/1.0.2h-08249684d6f/crypto'
../util/domd: 31: ../util/domd: makedepend: not found
mv: cannot stat 'Makefile.new': No such file or directory
make[2]: *** [local_depend] Error 127
make[2]: Leaving directory `/home/ubuntu/build/bitcoin/depends/work/build/i686-pc-linux-gnu/openssl/1.0.2h-08249684d6f/crypto'
make[1]: *** [depend] Error 1

theuni · 2016-05-20T10:01:33Z

Why not stick with 1.0.1k and drop no-cms and no-rc2? IIRC I had no trouble building that way when I tested qt 5.6. I'd really rather not require makedepend.

Alternatively, we could upstream the qt change to work properly without these. Either way, I don't think switching to 1.0.2 could be done lightly.

I assume the patches were dropped because they didn't apply cleanly? We'll need to check these. The mingw patch fixes a build-time problem with older gcc (4.6 iirc). Now that we require c++11, I think we can probably drop that.

The other is much more subtle, and fixes a runtime issue. See bb44d9e for info there.

arowser · 2016-05-25T08:43:33Z

Can one of the admins verify this patch?

fanquake · 2016-05-27T09:55:21Z

This is now building successfully on OSX 10.11.5, plugging ./configure --prefix=/depends/x86_64-apple-darwin15.5.0 into configure.

Still investigating dropping the patches. I'll have to push a few more minor changes if they can be dropped.
@jonasschnelli Can you retest?
@theuni Is there any value in bumping our libxcb dependancy?

laanwj · 2016-05-30T09:17:21Z

I guess we'd have to tackle #7945 as well, to make sure this gets tested.

jonasschnelli · 2016-05-30T09:21:58Z

Still fails:

qxcbintegration.h:42:21: fatal error: xcb/xcb.h: No such file or directory

Build logs: https://bitcoin.jonasschnelli.ch/pulls/8053/

laanwj · 2016-06-09T06:30:10Z

Let's try to get this in for 0.13, Qt is the single most important dependency to bump from a user perspective.

fanquake · 2016-06-09T06:54:32Z

I'll rebase on master and look at removing dbus

On Thursday, 9 June 2016, Wladimir J. van der Laan notifications@github.com
wrote:

Let's try to get this in for 0.13, Qt is the single most important
dependency to bump from a user perspective.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#8053 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AA0t8v81tM--ZJ97yk6TX_nFJqiLZfhHks5qJ7L8gaJpZM4IejtX
.

jonasschnelli · 2016-06-09T07:04:35Z

The bump to Qt5.6 would give users on Linux/Windows "full" HiDPI support which somehow is extremely convenient these days (most new computers/laptops come with a HiDPI capable screen).
There are some ugly glitches with Qt5.5 (#6472) and I guess more and more users will use HiDPI resolution on Linux/Mac.

It would be nice if we could bump to Qt5.6 before 0.13, but I agree, it is a little bit late. On the other hand, we still have the rc phase (I don't expect people reporting Qt5.6 relevant HiDPI issues before the rc phase).

laanwj · 2016-06-09T08:01:34Z

It's not too late. The best time to test it is in the rc phase as different people will be testing it on different environments.

theuni · 2016-06-09T15:20:30Z

5.6.1 was released yesterday, may as well target that.

I'm working on build/toolchain stuff atm, I'll try to take a look at the xcb issue asap.

fanquake · 2016-06-10T05:05:14Z

Rebased on master and updated to Qt 5.6.1

fanquake · 2016-06-10T05:38:26Z

The xcb patch no longer applies cleanly, will look at this again later today.

laanwj · 2016-06-14T06:41:46Z

It complains about the missing patch now...

/bin/sh: 1: cannot open /home/travis/build/bitcoin/bitcoin/depends/work/build/x86_64-unknown-linux-gnu/qt/5.6.1-697d96c0681/.patches-697d96c0681/fix-xcb-include-order.patch: No such file

jonasschnelli · 2016-06-16T09:31:52Z

Using this commit (jonasschnelli@0102b7f) let me compile Qt5.6.1 (depends/linux), but I had to manually create the Qt5XcbQpa.pc and the Qt5PlatformSupport.pc.
I could not figure out why these two pkgconfig files where not generated.
@theuni any ideas?

paveljanik · 2016-06-16T09:44:27Z

See https://bugreports.qt.io/browse/QTBUG-50073

fanquake · 2016-06-16T11:55:59Z

QT 5.7 has been released.

"
Starting with Qt 5.7, we will require a C++11 compliant compiler to build and use Qt. This allows us to use many of the new features in Qt itself, and renew our codebase using features such as constexpr, move semantics, range-for and auto. These efforts are well under way and will continue throughout the next versions.
"

Qt Core

Qt uses poll() instead of select() in it’s event loop allowing for more than 1024 file descriptors
Qt now uses std::atomic for it’s atomic classes

laanwj · 2016-06-17T08:11:44Z

Okay this is getting confusing, is it just me or is Qt now releasing a new version every two weeks?

jonasschnelli · 2016-06-17T08:13:05Z

Indeed.
Qt7 has been released yesterday. We might want to go with Qt5.6.1 for 0.13.

laanwj · 2016-06-17T08:19:09Z

Qt7 has been released yesterday. We might want to go with Qt5.6.1 for 0.13.

+1. it's the more stable choice...

theuni · 2016-06-17T08:46:28Z

Agreed on 5.6.1 for 0.13. I should be able to look at the xcb patch in the next week or so. Though it's worth noting for a future pr: 5.7 improves a few build-related things for us: - allows for split native tools build. - passes flags (like -D and -B only to the host toolchain) (I'm on mobile so those are from memory, may not be 100% accurate. I also haven't tested that those work as intended.) The first should allow us to split up the build into more reasonable chunks (native_qttools and qtlibs). The second should allow us to drop the xcb patch in favor of using more detailed flags. It should also allow us to drop the hackish env vars we use.

maflcko · 2016-06-20T11:55:12Z

Removed 0.13 milestone, as #8210 is merged

maflcko added this to the 0.13.0 milestone May 14, 2016

maflcko added GUI Build system labels May 14, 2016

maflcko assigned theuni May 14, 2016

fanquake force-pushed the depends-qt-5-6-0 branch 2 times, most recently from 2827958 to 179df84 Compare May 21, 2016 08:08

fanquake force-pushed the depends-qt-5-6-0 branch from 179df84 to dea8b04 Compare May 30, 2016 10:37

fanquake mentioned this pull request Jun 2, 2016

[depends] Bump Freetype, ccache, ZeroMQ, miniupnpc, expat #7993

Merged

theuni mentioned this pull request Jun 9, 2016

WIP: OSX toolchain bump #8184

Closed

3 tasks

fanquake changed the title ~~[WIP] [depends] Qt 5.6.0~~ [WIP] [depends] Qt 5.6.1 Jun 10, 2016

fanquake force-pushed the depends-qt-5-6-0 branch from dea8b04 to 8278241 Compare June 10, 2016 05:04

fanquake force-pushed the depends-qt-5-6-0 branch from 8278241 to 2c8ae25 Compare June 10, 2016 05:16

fanquake force-pushed the depends-qt-5-6-0 branch from 2c8ae25 to 25e17d3 Compare June 13, 2016 12:51

fanquake added 2 commits June 14, 2016 12:42

[depends] OpenSSL 1.0.1k - update config_opts

03158d9

[depends] Qt 5.6.1

9d9cbf0

fanquake force-pushed the depends-qt-5-6-0 branch from 25e17d3 to 9d9cbf0 Compare June 14, 2016 06:01

jonasschnelli mentioned this pull request Jun 16, 2016

[Qt] Bump to Qt5.6.1 #8210

Merged

maflcko removed this from the 0.13.0 milestone Jun 20, 2016

laanwj closed this Jun 20, 2016

fanquake deleted the depends-qt-5-6-0 branch June 22, 2016 02:55

fanquake mentioned this pull request Jun 22, 2016

[GUI] QT 5.7 #8237

Closed

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

[WIP] [depends] Qt 5.6.1 #8053

[WIP] [depends] Qt 5.6.1 #8053

Uh oh!

Conversation

fanquake commented May 14, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bump Qt to 5.6.1

Uh oh!

jonasschnelli commented May 14, 2016

Uh oh!

jonasschnelli commented May 14, 2016

Uh oh!

theuni commented May 20, 2016

Uh oh!

arowser commented May 25, 2016

Uh oh!

fanquake commented May 27, 2016

Uh oh!

laanwj commented May 30, 2016

Uh oh!

jonasschnelli commented May 30, 2016

Uh oh!

laanwj commented Jun 9, 2016

Uh oh!

fanquake commented Jun 9, 2016

Uh oh!

jonasschnelli commented Jun 9, 2016

Uh oh!

laanwj commented Jun 9, 2016

Uh oh!

theuni commented Jun 9, 2016

Uh oh!

fanquake commented Jun 10, 2016

Uh oh!

fanquake commented Jun 10, 2016

Uh oh!

laanwj commented Jun 14, 2016

Uh oh!

jonasschnelli commented Jun 16, 2016

Uh oh!

paveljanik commented Jun 16, 2016

Uh oh!

fanquake commented Jun 16, 2016

Qt Core

Uh oh!

laanwj commented Jun 17, 2016

Uh oh!

jonasschnelli commented Jun 17, 2016

Uh oh!

laanwj commented Jun 17, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theuni commented Jun 17, 2016 via email

Uh oh!

maflcko commented Jun 20, 2016

Uh oh!

Uh oh!

fanquake commented May 14, 2016 •

edited

Loading

laanwj commented Jun 17, 2016 •

edited

Loading