[qa] test_framework: Set wait-timeout for bitcoind procs #8047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK, this avoids an infinite wait / travis timeout. |
|
Depends on how you run the tests:
Edit: For the wrapper: As there is no traceback printed (of the actual timeout in the python test), one could add a help message to the wrapper saying something like: "Some processes may be still running. Make sure to kill any bitcoind subprocesses before running further tests. To inspect the traceback, run the command mentioned above in the TimeoutExpired Exception from your command line." But I consider this out of scope for this pull. |
|
utACK fab5233 |
|
Oops forgot about this |
maflcko
pushed a commit
that referenced
this pull request
May 20, 2016
fab5233 [qa] test_framework: Set wait-timeout for bitcoind procs (MarcoFalke)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 21, 2017
…d procs fab5233 [qa] test_framework: Set wait-timeout for bitcoind procs (MarcoFalke)
sickpig
pushed a commit
to sickpig/BitcoinUnlimited
that referenced
this pull request
Mar 12, 2018
Core QA cherries bitcoin/bitcoin#8047 - [qa] test_framework: Set wait-timeout for bitcoind procs bitcoin/bitcoin#8095 - Test framework: only cleanup on successful test runs bitcoin/bitcoin#8214 - [qa] mininode: fail on send_message instead of silent return
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we switched to python3, it is now possible to set a timeout for
Popen.wait(). 60 seconds should be enough to cleanly exit?