init: Move berkeleydb version reporting to wallet #8036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the version reporting to Wallet::Verify, before starting verification of the wallet. This removes the dependency of init on a specific wallet database library. A further, trivial step towards resolving bitcoin#7965.
37e4fdf to
3e2c946
Compare
|
Yes. This should have been don in the first place. utACK. |
|
utACK 3e2c946 |
|
ACK 3e2c946 |
|
utACK 3e2c946 |
laanwj
added a commit
that referenced
this pull request
May 10, 2016
3e2c946 init: Move berkeleydb version reporting to wallet (Wladimir J. van der Laan)
14 tasks
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 21, 2017
3e2c946 init: Move berkeleydb version reporting to wallet (Wladimir J. van der Laan)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the version reporting to
Wallet::Verify, before starting verification of the wallet (as this is the earliest point that the wallet is actually going to be accessed).This removes the dependency of init on a specific wallet database library.
A further, trivial step towards resolving #7965.