Skip to content

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented May 9, 2016

Add --c++11 flag to brew dependancies that support it
Remove release-build section, this is covered by depends/release-notes

@theuni can I get your thoughts on adding the --c++11 flag to brew dependancies?

Link to the rendered markdown

@maflcko maflcko added the Docs label May 9, 2016

Instructions: Homebrew
Dependancies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependencies

@fanquake fanquake force-pushed the osx-build-notes branch 2 times, most recently from f9c4dc2 to c200770 Compare May 10, 2016 02:40
@theuni
Copy link
Member

theuni commented May 10, 2016

Looks like protobuf supports the c++11 flag as well.
edit: whoops, misread. This is already there.

@theuni
Copy link
Member

theuni commented May 10, 2016

I don't see a c++11 flag in the qt build. @fanquake Can you confirm that it gets built that way on 10.11? I'm worried that the detection might fail without a stdlib specified (similar to boost here)

If not, we should upstream a patch while we're at it.

@theuni
Copy link
Member

theuni commented May 10, 2016

ACK adding the c++11 flags and simplifying.

Also, since it's no longer mentioned (hasn't been in a while, I suppose), we should remove the port check from configure.ac

Add —c++11 flags to brew dependancies that support it
Remove release-build section, this is covered by depends/release-notes
@fanquake
Copy link
Member Author

fanquake commented May 12, 2016

Changed step 4 to make deploy

@theuni I'll start submitting PRs to Homebrew to update dependancies (and sub dependancies) that we use.

@fanquake
Copy link
Member Author

PRs to update miniupnpc, expat, dbus, ccache

@fanquake
Copy link
Member Author

fanquake commented May 14, 2016

I don't see a c++11 flag in the qt build. @fanquake Can you confirm that it gets built that way on 10.11? I'm worried that the detection might fail without a stdlib specified (similar to boost here)

@theuni Looking at the output of brew install qt5 --verbose --build-from-source, it looks like it is.

   Build type: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3)
   qmake vars: QMAKE_CC = clang QMAKE_CXX = clang++
   Build options:
   Configuration: c++11 c++14 c++1z
   Using C++ standard: c++1z

Assuming their bottles are built the same way.

@arowser
Copy link
Contributor

arowser commented May 25, 2016

Can one of the admins verify this patch?

@jonasschnelli
Copy link
Contributor

ACK 2692e1b

@jonasschnelli jonasschnelli merged commit 2692e1b into bitcoin:master Jun 2, 2016
jonasschnelli added a commit that referenced this pull request Jun 2, 2016
2692e1b [Doc] Simplify OS X build notes (fanquake)
@fanquake fanquake deleted the osx-build-notes branch June 12, 2016 05:23
codablock pushed a commit to codablock/dash that referenced this pull request Dec 22, 2017
2692e1b [Doc] Simplify OS X build notes (fanquake)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
2692e1b [Doc] Simplify OS X build notes (fanquake)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants