-
Notifications
You must be signed in to change notification settings - Fork 37.8k
[Doc] Simplify OS X build notes #8029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
Instructions: Homebrew | ||
Dependancies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependencies
f9c4dc2
to
c200770
Compare
Looks like protobuf supports the c++11 flag as well. |
ACK adding the c++11 flags and simplifying. Also, since it's no longer mentioned (hasn't been in a while, I suppose), we should remove the |
Add —c++11 flags to brew dependancies that support it Remove release-build section, this is covered by depends/release-notes
Changed step 4 to @theuni I'll start submitting PRs to Homebrew to update dependancies (and sub dependancies) that we use. |
@theuni Looking at the output of
Assuming their bottles are built the same way. |
Can one of the admins verify this patch? |
ACK 2692e1b |
2692e1b [Doc] Simplify OS X build notes (fanquake)
2692e1b [Doc] Simplify OS X build notes (fanquake)
2692e1b [Doc] Simplify OS X build notes (fanquake)
Add --c++11 flag to brew dependancies that support it
Remove release-build section, this is covered by depends/release-notes
@theuni can I get your thoughts on adding the --c++11 flag to brew dependancies?
Link to the rendered markdown