moveonly: move coincontrol to src/wallet
#8990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK 1ae5839 |
|
ACK 1ae5839 |
|
ACK 1ae5839 Super-micro-nit: in-place renaming the file make the list of includes non-sorted. The new name should be moved down in the include list. But I understand why it is done this way. |
We've given up on include sorting a long time ago. |
|
Yes, but it is de-facto standard and almost every new code follows it. But as I said, it is super-micro(not tm) nit. |
laanwj
added a commit
that referenced
this pull request
Oct 21, 2016
1ae5839 moveonly: move `coincontrol` to `src/wallet` (Wladimir J. van der Laan)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 13, 2018
1ae5839 moveonly: move `coincontrol` to `src/wallet` (Wladimir J. van der Laan)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
1ae5839 moveonly: move `coincontrol` to `src/wallet` (Wladimir J. van der Laan)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 15, 2019
1ae5839 moveonly: move `coincontrol` to `src/wallet` (Wladimir J. van der Laan)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coincontrol is a "transaction send settings" structure. There is no use of this outside the wallet.