Remove bogus assert on number of oubound connections. #8944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This value can be significantly higher if the users uses addnode
|
Also needed on 0.13, see https://github.com/TheBlueMatt/bitcoin/tree/2016-10-bad-assert-0.13 |
|
utACK 1ab21cf |
|
utACK 1ab21cf |
1 similar comment
|
utACK 1ab21cf |
laanwj
added a commit
that referenced
this pull request
Oct 18, 2016
1ab21cf Remove bogus assert on number of oubound connections. (Matt Corallo)
sickpig
referenced
this pull request
in sickpig/BitcoinUnlimited
Apr 14, 2017
1ab21cf Remove bogus assert on number of oubound connections. (Matt Corallo)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Oct 14, 2017
…ons. 1ab21cf Remove bogus assert on number of oubound connections. (Matt Corallo)
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Oct 18, 2018
This value can be significantly higher if the users uses addnode Github-Pull: bitcoin#8944 Rebased-From: 1ab21cf
random-zebra
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Jul 29, 2020
8d71860 Remove bogus assert on number of oubound connections. (Matt Corallo) Pull request description: Value can be significantly higher if the users uses addnode. Coming from upstream#[8944](bitcoin#8944) ACKs for top commit: random-zebra: utACK 8d71860 Fuzzbawls: utACK 8d71860 Tree-SHA512: 14ddf7163a07615700b41c5e83b08a3328dd4cc416d6d2128b67934fab08f58542ff89e27b9b21ac96647bf81f6376b8af1498fae37d0ca4b98785e37ec9cf5d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This value can be significantly higher if the users uses addnode