Define start and end time for segwit deployment #8937
Conversation
| @@ -93,8 +93,8 @@ class CMainParams : public CChainParams { | |||
|
|
|||
| // Deployment of SegWit (BIP141 and BIP143) | |||
|
utACK f9c23de |
1 similar comment
|
utACK f9c23de |
|
Start: http://www.wolframalpha.com/input/?i=unix+1479168000 12:00:00 am UTC | Tuesday, November 15, 2016 End: http://www.wolframalpha.com/input/?i=unix+1510704000 12:00:00 am UTC | Wednesday, November 15, 2017 utACK f9c23de |
|
11/15/2016 @ 12:00am (UTC) utACK f9c23de |
| @@ -91,10 +91,10 @@ class CMainParams : public CChainParams { | |||
| consensus.vDeployments[Consensus::DEPLOYMENT_CSV].nStartTime = 1462060800; // May 1st, 2016 | |||
| consensus.vDeployments[Consensus::DEPLOYMENT_CSV].nTimeout = 1493596800; // May 1st, 2017 | |||
|
|
|||
| // Deployment of SegWit (BIP141 and BIP143) | |||
| // Deployment of SegWit (BIP141, BIP143, and BIP147) | |||
There was a problem hiding this comment.
No need for comma before "and".
There was a problem hiding this comment.
NACK, Oxford comma for life.
| consensus.vDeployments[Consensus::DEPLOYMENT_SEGWIT].bit = 1; | ||
| consensus.vDeployments[Consensus::DEPLOYMENT_SEGWIT].nStartTime = 0; | ||
| consensus.vDeployments[Consensus::DEPLOYMENT_SEGWIT].nTimeout = 0; // Never / undefined | ||
| consensus.vDeployments[Consensus::DEPLOYMENT_SEGWIT].nStartTime = 1479168000; // November 15th, 2016. |
There was a problem hiding this comment.
No need for dot at the end of the line. This is the third format for simple date we use now (as shown in the Files changed in this PR) :-)
There was a problem hiding this comment.
Glory to ISO 8601. Should be 2016-11-15. ;)
| @@ -91,10 +91,10 @@ class CMainParams : public CChainParams { | |||
| consensus.vDeployments[Consensus::DEPLOYMENT_CSV].nStartTime = 1462060800; // May 1st, 2016 | |||
| consensus.vDeployments[Consensus::DEPLOYMENT_CSV].nTimeout = 1493596800; // May 1st, 2017 | |||
|
|
|||
| // Deployment of SegWit (BIP141 and BIP143) | |||
| // Deployment of SegWit (BIP141, BIP143, and BIP147) | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, I'm on the "against" side, sorry.
There was a problem hiding this comment.
BIP141, BIP143, BIP147,
C forever! ;-)
There was a problem hiding this comment.
Brit here, I approve of Oxford comma!
There was a problem hiding this comment.
honestly... does it even matter?!
|
ACK /me too for simple epoch conversion ;-) |
|
utACK f9c23de |
|
utACK f9c23de |
|
utACK f9c23de |
|
utACK f9c23de. Timestamps match those in the BIP update bitcoin/bips@5c2da7e, which matches the UTC dates in the mailing list post. Let's not hold this up on comment formatting minutia. |
f9c23de Define start and end time for segwit deployment (Pieter Wuille)
|
utACK 8b66659 |
See corresponding mailing list discussion (https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2016-October/013226.html) and BIP update PR (bitcoin/bips#464).