Set minimum required Boost to 1.47.0 #8920

fanquake · 2016-10-14T04:34:19Z

Boost is on the way out, but in the mean time, having the minimum set to 1.20.0 is misleading, and can lead to issues like #8868.

1.47.0 is the first version to include Chrono. See #8875 for some history.

paveljanik · 2016-10-14T06:29:21Z

build-aux/m4/ax_boost_base.m4

@@ -96,7 +96,7 @@ if test "x$want_boost" = "xyes"; then
        libsubdirs="lib64 libx32 lib lib64"
        ;;
      ppc64|s390x|sparc64|aarch64|ppc64le)
-        libsubdirs="lib64 lib lib64 ppc64le"


paveljanik · 2016-10-14T06:31:10Z

build-aux/m4/ax_boost_base.m4

@@ -33,7 +33,7 @@
 #   and this notice are preserved. This file is offered as-is, without any
 #   warranty.

-#serial 26
+#serial 27


The serial should reflect the original version used as a base - coming from https://www.gnu.org/software/autoconf-archive/ax_boost_base.html

paveljanik · 2016-10-14T06:33:29Z

So you are updating the file to match and at the same time upgrading the minimal requirement. Please always mention this in the PR text and not hide the first part.

Changes like this should be done in two commits, I think.

luke-jr · 2016-10-14T08:47:21Z

Concept ACK, but shouldn't some documentation need updating as well?

laanwj · 2016-10-15T07:14:48Z

build-aux/m4/ax_boost_base.m4

@@ -72,7 +72,7 @@ AC_ARG_WITH([boost-libdir],
 )

 if test "x$want_boost" = "xyes"; then
-    boost_lib_version_req=ifelse([$1], ,1.20.0,$1)
+    boost_lib_version_req=ifelse([$1], ,1.47.0,$1)


concept ACK - though personally I'd prefer passing in this version as a parameter from our configure.ac, if possible, instead of changing this upstream file

laanwj · 2016-10-15T07:16:52Z

Concept ACK, but shouldn't some documentation need updating as well?

If only we had documentation for minimum version requirements, it should be updated. But doesn't look like we do, build-unix only lists the libraries necessary not their minimum supported versions. We've never really kept track of those.

paveljanik

This looks much better, thank you!

ACK 6dd3723

paveljanik · 2016-10-17T06:49:45Z

Build log diff:

-checking for boostlib >= 1.20.0... yes
+checking for boostlib >= 1.47.0... yes

Great!

jonasschnelli · 2016-10-17T06:54:31Z

utACK 6dd3723

maflcko · 2016-10-17T08:00:24Z

utACK 6dd3723

6dd3723 Set minimum required Boost to 1.47.0 (fanquake) 282abd8 [build-aux] Boost_Base serial 27 (fanquake)

theuni · 2016-10-17T17:26:28Z

post-merge ACK.

Zenitur · 2016-11-04T19:16:48Z

An error when build with Boost 1.49: http://pastebin.com/b2JHAE01

paveljanik · 2016-11-05T11:55:16Z

@Zenitur Upstream bug https://svn.boost.org/trac/boost/ticket/6790

Zenitur · 2016-11-06T05:22:16Z

@paveljanik now it works. Thank you!

Github-Pull: bitcoin#8920 Rebased-From: 282abd8

Github-Pull: bitcoin#8920 Rebased-From: 6dd3723

Minimum boost version was bumped to 1.47.0 in bitcoin#8920, which means the configure step won't even pass with older boost. This version has boost filesystem v3, which means the (crappy) fallbacks for older versions can go.

Github-Pull: bitcoin#8920 Rebased-From: 282abd8

Github-Pull: bitcoin#8920 Rebased-From: 6dd3723

6dd3723 Set minimum required Boost to 1.47.0 (fanquake) 282abd8 [build-aux] Boost_Base serial 27 (fanquake)

Minimum boost version was bumped to 1.47.0 in bitcoin#8920, which means the configure step won't even pass with older boost. This version has boost filesystem v3, which means the (crappy) fallbacks for older versions can go. Conflicts: src/test/testutil.cpp

Github-Pull: bitcoin#8920 Rebased-From: 6dd3723

Github-Pull: bitcoin#8920 Rebased-From: 282abd8

Minimum boost version was bumped to 1.47.0 in bitcoin#8920, which means the configure step won't even pass with older boost. This version has boost filesystem v3, which means the (crappy) fallbacks for older versions can go.

fanquake added the Utils/log/libs label Oct 14, 2016

paveljanik reviewed Oct 14, 2016

View reviewed changes

laanwj reviewed Oct 15, 2016

View reviewed changes

laanwj assigned theuni Oct 15, 2016

laanwj mentioned this pull request Oct 15, 2016

Need documentation on minimum supported dependency versions #8923

Closed

fanquake mentioned this pull request Oct 17, 2016

Docs: Minimum required dependencies and current CVEs #8639

Closed

fanquake added 2 commits October 17, 2016 11:43

[build-aux] Boost_Base serial 27

282abd8

Set minimum required Boost to 1.47.0

6dd3723

fanquake force-pushed the set-minimum-boost branch from bc83e23 to 6dd3723 Compare October 17, 2016 03:44

paveljanik approved these changes Oct 17, 2016

View reviewed changes

laanwj merged commit 6dd3723 into bitcoin:master Oct 17, 2016

laanwj added a commit that referenced this pull request Oct 17, 2016

Merge #8920: Set minimum required Boost to 1.47.0

c901113

6dd3723 Set minimum required Boost to 1.47.0 (fanquake) 282abd8 [build-aux] Boost_Base serial 27 (fanquake)

fanquake deleted the set-minimum-boost branch October 17, 2016 11:45

luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Dec 2, 2016

[build-aux] Boost_Base serial 27

c134d92

Github-Pull: bitcoin#8920 Rebased-From: 282abd8

luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Dec 2, 2016

Set minimum required Boost to 1.47.0

40169dc

Github-Pull: bitcoin#8920 Rebased-From: 6dd3723

laanwj mentioned this pull request Feb 8, 2017

Bump minimum required Boost version #8875

Closed

laanwj mentioned this pull request Feb 9, 2017

Remove fallbacks for boost_filesystem < v3 #9727

Merged

schinzelh pushed a commit to dashpay/dash that referenced this pull request Oct 23, 2017

Boost_Base serial 27

74394f1

Github-Pull: bitcoin#8920 Rebased-From: 282abd8

schinzelh pushed a commit to dashpay/dash that referenced this pull request Oct 23, 2017

Set minimum required Boost to 1.47.0

938a6fb

Github-Pull: bitcoin#8920 Rebased-From: 6dd3723

codablock pushed a commit to codablock/dash that referenced this pull request Jan 12, 2018

Merge bitcoin#8920: Set minimum required Boost to 1.47.0

19316b7

6dd3723 Set minimum required Boost to 1.47.0 (fanquake) 282abd8 [build-aux] Boost_Base serial 27 (fanquake)

lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Oct 16, 2018

Set minimum required Boost to 1.47.0

cae922d

Github-Pull: bitcoin#8920 Rebased-From: 6dd3723

lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Oct 16, 2018

[build-aux] Boost_Base serial 27

31be10f

Github-Pull: bitcoin#8920 Rebased-From: 282abd8

hebasto mentioned this pull request Jul 13, 2019

Set minimum required Boost to 1.53.0 #16381

Closed

jnewbery mentioned this pull request Dec 11, 2020

Move SaltedHashers to separate file and add some new ones #19935

Merged

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Set minimum required Boost to 1.47.0 #8920

Set minimum required Boost to 1.47.0 #8920

Uh oh!

fanquake commented Oct 14, 2016 •

edited

Loading

Uh oh!

paveljanik Oct 14, 2016

Uh oh!

paveljanik Oct 14, 2016

Uh oh!

paveljanik commented Oct 14, 2016 •

edited

Loading

Uh oh!

luke-jr commented Oct 14, 2016

Uh oh!

laanwj Oct 15, 2016

Uh oh!

laanwj commented Oct 15, 2016

Uh oh!

paveljanik left a comment

Uh oh!

paveljanik commented Oct 17, 2016

Uh oh!

jonasschnelli commented Oct 17, 2016

Uh oh!

maflcko commented Oct 17, 2016

Uh oh!

theuni commented Oct 17, 2016

Uh oh!

Zenitur commented Nov 4, 2016

Uh oh!

paveljanik commented Nov 5, 2016

Uh oh!

Zenitur commented Nov 6, 2016

Uh oh!

Uh oh!

Set minimum required Boost to 1.47.0 #8920

Set minimum required Boost to 1.47.0 #8920

Uh oh!

Conversation

fanquake commented Oct 14, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paveljanik Oct 14, 2016

Choose a reason for hiding this comment

Uh oh!

paveljanik Oct 14, 2016

Choose a reason for hiding this comment

Uh oh!

paveljanik commented Oct 14, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luke-jr commented Oct 14, 2016

Uh oh!

laanwj Oct 15, 2016

Choose a reason for hiding this comment

Uh oh!

laanwj commented Oct 15, 2016

Uh oh!

paveljanik left a comment

Choose a reason for hiding this comment

Uh oh!

paveljanik commented Oct 17, 2016

Uh oh!

jonasschnelli commented Oct 17, 2016

Uh oh!

maflcko commented Oct 17, 2016

Uh oh!

theuni commented Oct 17, 2016

Uh oh!

Zenitur commented Nov 4, 2016

Uh oh!

paveljanik commented Nov 5, 2016

Uh oh!

Zenitur commented Nov 6, 2016

Uh oh!

Uh oh!

fanquake commented Oct 14, 2016 •

edited

Loading

paveljanik commented Oct 14, 2016 •

edited

Loading