[qa] fix nulldummy test #8841
Merged
[qa] fix nulldummy test #8841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
reviewed
Sep 29, 2016
| @@ -119,6 +119,9 @@ def tx_submit(self, node, tx, msg = ""): | |||
| node.sendrawtransaction(bytes_to_hex_str(tx.serialize_with_witness()), True) | |||
| except JSONRPCException as exp: | |||
| assert_equal(exp.error["message"], msg) | |||
| else: | |||
| if (msg): | |||
| assert(False) | |||
There was a problem hiding this comment.
To print the message on failure, what about something like
assert_equal('', msg)There was a problem hiding this comment.
revise as suggested. Thanks
8623ec0 to
41d5477
Compare
41d5477 to
46a4774
Compare
|
utACK 46a4774 |
laanwj
added a commit
that referenced
this pull request
Sep 30, 2016
46a4774 Fix nulldummy.py test (Johnson Lau)
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Oct 3, 2016
Github-Pull: bitcoin#8841 Rebased-From: 46a4774
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 30, 2018
46a4774 Fix nulldummy.py test (Johnson Lau)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
46a4774 Fix nulldummy.py test (Johnson Lau)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 28, 2019
46a4774 Fix nulldummy.py test (Johnson Lau)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Mar 2, 2019
46a4774 Fix nulldummy.py test (Johnson Lau)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry that I just find a minor bug in the test.
msgis used to indicate that the transaction should be rejected. However, before this fix, even if the tx was accepted with a non-emptymsg, the test would still pass.