bitcoin-util-test.py should fail if the output file is empty #8836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK da94697 |
|
utACK da94697 |
laanwj
added a commit
that referenced
this pull request
Sep 30, 2016
…mpty da94697 bitcoin-util-test.py should fail if the output file is empty (jnewbery)
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Oct 3, 2016
Github-Pull: bitcoin#8836 Rebased-From: da94697
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 12, 2018
…le is empty da94697 bitcoin-util-test.py should fail if the output file is empty (jnewbery)
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Nov 11, 2018
Github-Pull: bitcoin#8836 Rebased-From: da94697
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…le is empty da94697 bitcoin-util-test.py should fail if the output file is empty (jnewbery)
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Nov 9, 2020
bitcoin-util-test.py backports Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#8829 - bitcoin/bitcoin#8830 - bitcoin/bitcoin#8836 - bitcoin/bitcoin#8881 - bitcoin/bitcoin#9032 - bitcoin/bitcoin#9023 - bitcoin/bitcoin#9069 - bitcoin/bitcoin#9945
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the output_cmp file is empty, then
bitcoin-util-test.pywill pass the test without comparing its output to the expected output. This PR makes the test case fail if the output_cmp file is empty.This PR also fixes the txcreate2.json file so it's no longer empty (and is therefore actually testing something!)