Skip to content

Conversation

jnewbery
Copy link
Contributor

I've recently added new test cases that test bitoin-tx JSON output (#8829).

Those tests are run automatically by make check, but it was previously quite difficult to run those tests manually, since the script assumed that OS environment variables had been set. This PR allows the tests to be run manually, and adds documentation explaining how to do that.

@maflcko maflcko added the Tests label Sep 28, 2016
@@ -6,8 +6,25 @@
import os
import bctest
import buildenv
import sys
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this used for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops. Nothing now. I was originally using sys.argv, but then changed to use argparse. I'll remove it and squash the commits.

@maflcko
Copy link
Member

maflcko commented Sep 28, 2016

ACK 2e992b6

@jnewbery jnewbery force-pushed the test-bitcoin-util-manually branch from 2e992b6 to 7e88077 Compare September 28, 2016 19:42
@btcdrak
Copy link
Contributor

btcdrak commented Sep 29, 2016

ACK 7e88077

@jnewbery jnewbery force-pushed the test-bitcoin-util-manually branch from 7e88077 to b82f493 Compare September 29, 2016 12:55
@jnewbery
Copy link
Contributor Author

rebased

@maflcko
Copy link
Member

maflcko commented Sep 30, 2016

utACK b82f493

@laanwj laanwj merged commit b82f493 into bitcoin:master Sep 30, 2016
laanwj added a commit that referenced this pull request Sep 30, 2016
b82f493 Add option to run bitcoin-util-test.py manually (jnewbery)
@jnewbery jnewbery deleted the test-bitcoin-util-manually branch September 30, 2016 15:04
codablock pushed a commit to codablock/dash that referenced this pull request Jan 12, 2018
…ually

b82f493 Add option to run bitcoin-util-test.py manually (jnewbery)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
…ually

b82f493 Add option to run bitcoin-util-test.py manually (jnewbery)
zkbot added a commit to zcash/zcash that referenced this pull request Nov 9, 2020
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants