-
Notifications
You must be signed in to change notification settings - Fork 37.7k
[test] Add option to run bitcoin-util-test.py manually #8830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -6,8 +6,25 @@ | |||
import os | |||
import bctest | |||
import buildenv | |||
import sys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops. Nothing now. I was originally using sys.argv
, but then changed to use argparse
. I'll remove it and squash the commits.
ACK 2e992b6 |
2e992b6
to
7e88077
Compare
ACK 7e88077 |
7e88077
to
b82f493
Compare
rebased |
utACK b82f493 |
b82f493 Add option to run bitcoin-util-test.py manually (jnewbery)
…ually b82f493 Add option to run bitcoin-util-test.py manually (jnewbery)
…ually b82f493 Add option to run bitcoin-util-test.py manually (jnewbery)
bitcoin-util-test.py backports Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#8829 - bitcoin/bitcoin#8830 - bitcoin/bitcoin#8836 - bitcoin/bitcoin#8881 - bitcoin/bitcoin#9032 - bitcoin/bitcoin#9023 - bitcoin/bitcoin#9069 - bitcoin/bitcoin#9945
I've recently added new test cases that test bitoin-tx JSON output (#8829).
Those tests are run automatically by
make check
, but it was previously quite difficult to run those tests manually, since the script assumed that OS environment variables had been set. This PR allows the tests to be run manually, and adds documentation explaining how to do that.