-
Notifications
You must be signed in to change notification settings - Fork 37.8k
WIP: [qt] rework sync-overlay #8809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fa70cae
to
fa29b82
Compare
fa29b82
to
faca9f2
Compare
@MarcoFalke what does "Don't show integer progress in progress bar. (Already shown in front |
@paveljanik By default it shows the percentage twice: #8371 (comment). (Maybe not on osx) |
Thanks for doing this. Question:
Where is the information already visible? |
@MarcoFalke Aha! Thanks. Yes, I do not see it here. BTW - the progressbar on OS X doesn't show, what is 100%, it is a bold line showing nothing. |
Maybe we need to distinct the percentage information over PlatformStyles in order to not just display a non-value progress bar. |
@jonasschnelli Example: If you are synced 90% and the "Progress increase per hour" is 10%, then the estimated time until synced is 1 hour. Or: If you are synced 0% and the increase is 100% per hour, the estimated time is 1 hour. |
@MarcoFalke: I just though, the "Estimated time left" doesn't allow you to directly get a feeling on how fast you are syncing (in a comparable manner). |
@@ -276,31 +276,14 @@ QLabel { color: rgb(40,40,40); }</string> | |||
<property name="value"> | |||
<number>24</number> | |||
</property> | |||
<property name="format"> | |||
<string/> | |||
</property> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe there is a QT setting to not display the percentage information on a progress bar.
See hunk above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
* Remove the "Progress increase per hour" information, as it is redundant to the already displayed information and sounds potentially confusing. * Don't show integer progress in progress bar. (Already shown in front of progress bar) * Estimate the number of blocks left based on nPowTargetSpacing
faca9f2
to
76a5f1b
Compare
Closing for now. (Too controversial) |
What about the nPowTargetSpacing change? |
@jonasschnelli: As I understand your code, the gui may miss headers sometimes, so you added the " I don't think we should assume the gui knows the best header at all time. Thus, I removed the " |
Yes. I think #8821 makes sense. Will test soon. |
Remove the "Progress increase per hour" information, as it isredundant to the already displayed information and sounds potentially
confusing.
of progress bar)
(Follow-up of #8371)