Skip to content

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Sep 25, 2016

  • Remove the "Progress increase per hour" information, as it is
    redundant to the already displayed information and sounds potentially
    confusing.
  • Don't show integer progress in progress bar. (Already shown in front
    of progress bar)
  • Estimate the number of blocks left based on nPowTargetSpacing

(Follow-up of #8371)

@maflcko maflcko added the GUI label Sep 25, 2016
@maflcko maflcko added the Docs label Sep 25, 2016
@maflcko maflcko force-pushed the Mf1609-qtSyncInf branch 2 times, most recently from fa70cae to fa29b82 Compare September 25, 2016 22:34
@maflcko maflcko changed the title [qt] sync-overlay: Don't show redundant information [qt] rework sync-overlay Sep 25, 2016
@paveljanik
Copy link
Contributor

@MarcoFalke what does "Don't show integer progress in progress bar. (Already shown in front
of progress bar)" mean? What change is it?

@paveljanik
Copy link
Contributor

I see something like this with the current master:

screen shot 2016-09-26 at 13 15 29

@maflcko
Copy link
Member Author

maflcko commented Sep 26, 2016

@paveljanik By default it shows the percentage twice: #8371 (comment). (Maybe not on osx)

@jonasschnelli
Copy link
Contributor

Thanks for doing this.

Question:

Remove the "Progress increase per hour" information, as it is
redundant to the already displayed information and sounds potentially
confusing.

Where is the information already visible?
Why is it confusing?
IMO "progress increase per hours" is the only information which could one allow to get a feeling of how-fast he/she is currently syncing. But no strong opinion.

@paveljanik
Copy link
Contributor

@MarcoFalke Aha! Thanks. Yes, I do not see it here. BTW - the progressbar on OS X doesn't show, what is 100%, it is a bold line showing nothing.

@jonasschnelli
Copy link
Contributor

Maybe we need to distinct the percentage information over PlatformStyles in order to not just display a non-value progress bar.
Or maybe there is a QT setting to not display the percentage information on a progress bar.

@maflcko
Copy link
Member Author

maflcko commented Sep 26, 2016

@jonasschnelli Example: If you are synced 90% and the "Progress increase per hour" is 10%, then the estimated time until synced is 1 hour.

Or: If you are synced 0% and the increase is 100% per hour, the estimated time is 1 hour.

@jonasschnelli
Copy link
Contributor

@MarcoFalke: I just though, the "Estimated time left" doesn't allow you to directly get a feeling on how fast you are syncing (in a comparable manner).
IMO most information on the screen is redundant (except of maybe the last-block-time).

@@ -276,31 +276,14 @@ QLabel { color: rgb(40,40,40); }</string>
<property name="value">
<number>24</number>
</property>
<property name="format">
<string/>
</property>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe there is a QT setting to not display the percentage information on a progress bar.

See hunk above

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@maflcko maflcko changed the title [qt] rework sync-overlay WIP: [qt] rework sync-overlay Sep 27, 2016
* Remove the "Progress increase per hour" information, as it is
  redundant to the already displayed information and sounds potentially
  confusing.

* Don't show integer progress in progress bar. (Already shown in front
  of progress bar)

* Estimate the number of blocks left based on nPowTargetSpacing
@maflcko
Copy link
Member Author

maflcko commented Sep 27, 2016

Closing for now. (Too controversial)

@maflcko maflcko closed this Sep 27, 2016
@maflcko maflcko deleted the Mf1609-qtSyncInf branch September 27, 2016 18:47
@jonasschnelli
Copy link
Contributor

What about the nPowTargetSpacing change?
My understanding is, that once we have the headers-only-chain complete, we can give an adequate information about the remaining amount of blocks.

@maflcko
Copy link
Member Author

maflcko commented Sep 27, 2016

@jonasschnelli: As I understand your code, the gui may miss headers sometimes, so you added the "fHeaders-shortcut" to make sure the gui always knows the best header. Though, it seems a waste of resources to do this the way it is now: First, lock cs_main for each header, then drop the header if it is older than 30 days... This seems wasteful to me.

I don't think we should assume the gui knows the best header at all time. Thus, I removed the "fHeader-shortcut" in #8821. Please have a look at #8821 to see if it makes sense, we/I can do the gui polish in a later pull next month. The unresponsive gui is more important to fix now.

@jonasschnelli
Copy link
Contributor

Yes. I think #8821 makes sense. Will test soon.

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants