[rpc] Deprecate getinfo #8780

maflcko · 2016-09-21T18:52:14Z

This was replaced by getmininginfo, getnetworkinfo and getwalletinfo

maflcko · 2016-09-21T19:20:36Z

Added commit body per @gmaxwell

paveljanik · 2016-09-21T19:38:32Z

qa/rpc-tests/rpcbind_test.py

@@ -44,15 +44,15 @@ def run_bind_test(self, allow_ips, connect_to, addresses, expected):

    def run_allowip_test(self, allow_ips, rpchost, rpcport):
        '''
-        Start a node with rpcwallow IP, and request getinfo
+        Start a node with rpcwallow IP, and request getnetworkinfo


rpcwallow -> rpcallow

laanwj · 2016-09-22T03:05:21Z

src/rpc/misc.cpp

@@ -44,7 +44,7 @@ UniValue getinfo(const UniValue& params, bool fHelp)
    if (fHelp || params.size() != 0)
        throw runtime_error(
            "getinfo\n"
-            "Returns an object containing various state info.\n"
+            "\nDEPRECATED. Returns an object containing various state info.\n"


This method has been deprecated for years, we didn't even mention this in the help message yet? Ouch.

I wonder if anyone types in help getinfo. (Otherwise no one will see the DEPRECATED warning anyway)

Well, people use the help system. It's the only up-to-date RPC documentation that there is, and errors are usually found quickly.

But maybe not for old calls. Of course it may make sense to mention it in the release notes as well. I don't think we ever did, but even if so a reminder probably can't hurt.

laanwj · 2016-09-22T03:05:40Z

utACK ddddaaf

achow101 · 2016-09-22T03:11:34Z

This method has been deprecated for years

Wait, getinfo is deprecated? Since when?!

laanwj · 2016-09-22T03:38:40Z

My sarcasm meter isn't functioning this early in the morning, but at least since 2014: f9de17e . Probably even earlier, should be possible to find more discussion on github. Some of the more serious problems with it are:

It combines information from different subsystems (wallet, networking, blockchain, ...), so its implementation is messy by definition and has to lock all over the place
It is ill-defined and without focus - what information should be added, what shouldn't
It behaves differently with and without wallet (and what should it do with multiple wallets)

It basically still exists as a convenience for people using bitcoin-cli manually, but as that it could just as well be implemented client-side...

gmaxwell · 2016-09-22T18:52:32Z

Should we leave in some tests of getinfo in parallel as long as it still exists? We wouldn't want it to stop working by mistake.

laanwj · 2016-09-25T11:07:07Z

Agree with @gmaxwell - keeping at least one test that exercises getinfo makes sense. I don't think it's necessary to repeat all tests with getinfo and with the new call, though.

maflcko · 2016-09-25T13:08:18Z

Done

fa6e71b [qa] Add getinfo smoke tests and rework versionbits test (MarcoFalke) ddddaaf [rpc] Deprecate getinfo (MarcoFalke)

laanwj · 2016-09-30T14:12:05Z

It basically still exists as a convenience for people using bitcoin-cli manually, but as that it could just as well be implemented client-side...

FYI I just did this: #8843

Github-Pull: bitcoin#8780 Rebased-From: fa6e71b

fa6e71b [qa] Add getinfo smoke tests and rework versionbits test (MarcoFalke) ddddaaf [rpc] Deprecate getinfo (MarcoFalke)

maflcko added the RPC/REST/ZMQ label Sep 21, 2016

[rpc] Deprecate getinfo

ddddaaf

This was replaced by getmininginfo, getnetworkinfo and getwalletinfo

maflcko force-pushed the Mf1609-getinfoDeprecate branch from faa18e7 to ddddaaf Compare September 21, 2016 19:19

paveljanik reviewed Sep 21, 2016

View reviewed changes

laanwj reviewed Sep 22, 2016

View reviewed changes

dcousens approved these changes Sep 22, 2016

View reviewed changes

[qa] Add getinfo smoke tests and rework versionbits test

fa6e71b

laanwj merged commit fa6e71b into bitcoin:master Sep 26, 2016

laanwj added a commit that referenced this pull request Sep 26, 2016

Merge #8780: [rpc] Deprecate getinfo

dd20ed1

fa6e71b [qa] Add getinfo smoke tests and rework versionbits test (MarcoFalke) ddddaaf [rpc] Deprecate getinfo (MarcoFalke)

laanwj mentioned this pull request Sep 26, 2016

TODO for release notes 0.14.0 #8455

Closed

18 tasks

maflcko deleted the Mf1609-getinfoDeprecate branch September 26, 2016 13:06

laanwj mentioned this pull request Sep 29, 2016

rpc: Handle getinfo client-side in bitcoin-cli w/ -getinfo #8843

Closed

maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Oct 3, 2016

[qa] Add getinfo smoke tests and rework versionbits test

794b007

Github-Pull: bitcoin#8780 Rebased-From: fa6e71b

promag mentioned this pull request Sep 21, 2017

Why is getinfo being removed? #11382

Closed

fanquake mentioned this pull request Nov 13, 2017

Why was the 'getinfo' command removed? #11671

Closed

codablock pushed a commit to codablock/dash that referenced this pull request Jan 11, 2018

Merge bitcoin#8780: [rpc] Deprecate getinfo

0028dbf

fa6e71b [qa] Add getinfo smoke tests and rework versionbits test (MarcoFalke) ddddaaf [rpc] Deprecate getinfo (MarcoFalke)

meshcollider referenced this pull request Jan 24, 2018

(finally) remove getinfo in favor of more module-specific infos

aece8a4

bitcoinhodler mentioned this pull request Feb 2, 2018

Bitcoin Core v0.16: getinfo removed GlacierProtocol/GlacierProtocol#16

Closed

dagurval mentioned this pull request Mar 9, 2018

[qa] util: Move wait_bitcoinds() into stop_nodes() bitcoinxt/bitcoinxt#356

Merged

jnewbery mentioned this pull request Aug 14, 2018

[RPC] Remove getinfo deprecation warning #13891

Merged

andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019

Merge bitcoin#8780: [rpc] Deprecate getinfo

3b5e3ca

fa6e71b [qa] Add getinfo smoke tests and rework versionbits test (MarcoFalke) ddddaaf [rpc] Deprecate getinfo (MarcoFalke)

Talkless mentioned this pull request Jul 24, 2019

bitcoind_: LookupError: 'base64' is not a text encoding; use codecs.encode() to handle arbitrary codecs munin-monitoring/contrib#995

Closed

ankh2054 mentioned this pull request Oct 24, 2019

add getnetworkinfo RPC petertodd/python-bitcoinlib#217

Open

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[rpc] Deprecate getinfo #8780

[rpc] Deprecate getinfo #8780

Uh oh!

maflcko commented Sep 21, 2016 •

edited

Loading

Uh oh!

maflcko commented Sep 21, 2016

Uh oh!

paveljanik Sep 21, 2016

Uh oh!

laanwj Sep 22, 2016

Uh oh!

maflcko Sep 25, 2016

Uh oh!

laanwj Sep 25, 2016

Uh oh!

laanwj commented Sep 22, 2016

Uh oh!

achow101 commented Sep 22, 2016 •

edited

Loading

Uh oh!

laanwj commented Sep 22, 2016

Uh oh!

gmaxwell commented Sep 22, 2016

Uh oh!

laanwj commented Sep 25, 2016

Uh oh!

maflcko commented Sep 25, 2016

Uh oh!

laanwj commented Sep 30, 2016

Uh oh!

Uh oh!

[rpc] Deprecate getinfo #8780

[rpc] Deprecate getinfo #8780

Uh oh!

Conversation

maflcko commented Sep 21, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maflcko commented Sep 21, 2016

Uh oh!

paveljanik Sep 21, 2016

Choose a reason for hiding this comment

Uh oh!

laanwj Sep 22, 2016

Choose a reason for hiding this comment

Uh oh!

maflcko Sep 25, 2016

Choose a reason for hiding this comment

Uh oh!

laanwj Sep 25, 2016

Choose a reason for hiding this comment

Uh oh!

laanwj commented Sep 22, 2016

Uh oh!

achow101 commented Sep 22, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laanwj commented Sep 22, 2016

Uh oh!

gmaxwell commented Sep 22, 2016

Uh oh!

laanwj commented Sep 25, 2016

Uh oh!

maflcko commented Sep 25, 2016

Uh oh!

laanwj commented Sep 30, 2016

Uh oh!

Uh oh!

maflcko commented Sep 21, 2016 •

edited

Loading

achow101 commented Sep 22, 2016 •

edited

Loading