Skip to content

Qt refactors to better abstract wallet access #8774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 19, 2016
Merged

Qt refactors to better abstract wallet access #8774

merged 2 commits into from
Oct 19, 2016

Conversation

luke-jr
Copy link
Member

@luke-jr luke-jr commented Sep 21, 2016

Part of the refactorings needed for basic multiwallet (#8694)

@maflcko maflcko added the GUI label Sep 21, 2016
@maflcko
Copy link
Member

maflcko commented Sep 21, 2016

Concept ACK

jonasschnelli
jonasschnelli approved these changes Sep 22, 2016
View reviewed changes
Copy link
Contributor

@jonasschnelli jonasschnelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK ebcc14a

@luke-jr luke-jr force-pushed the multiwallet_prefactor_qt branch from ebcc14a to 178cd88 Compare October 4, 2016 20:30
@jonasschnelli
Copy link
Contributor

Tested ACK 178cd88

@jonasschnelli jonasschnelli merged commit 178cd88 into bitcoin:master Oct 19, 2016
jonasschnelli added a commit that referenced this pull request Oct 19, 2016
@jonasschnelli
Merge #8774: Qt refactors to better abstract wallet access
3e942a7 
178cd88 Qt/splash: Specifically keep track of which wallet(s) we are connected to for later disconnecting (Luke Dashjr)
1880aeb Qt: Get the private key for signing messages via WalletModel (Luke Dashjr)
codablock pushed a commit to codablock/dash that referenced this pull request Jan 13, 2018
@jonasschnelli @codablock
Merge bitcoin#8774: Qt refactors to better abstract wallet access
bd8e9fb 
178cd88 Qt/splash: Specifically keep track of which wallet(s) we are connected to for later disconnecting (Luke Dashjr)
1880aeb Qt: Get the private key for signing messages via WalletModel (Luke Dashjr)
@PastaPastaPasta PastaPastaPasta mentioned this pull request Nov 13, 2018
Closed
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@jonasschnelli @andvgal
Merge bitcoin#8774: Qt refactors to better abstract wallet access
5e04460 
178cd88 Qt/splash: Specifically keep track of which wallet(s) we are connected to for later disconnecting (Luke Dashjr)
1880aeb Qt: Get the private key for signing messages via WalletModel (Luke Dashjr)
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 15, 2019
@jonasschnelli @CryptoCentric
Merge bitcoin#8774: Qt refactors to better abstract wallet access
f440ce8 
178cd88 Qt/splash: Specifically keep track of which wallet(s) we are connected to for later disconnecting (Luke Dashjr)
1880aeb Qt: Get the private key for signing messages via WalletModel (Luke Dashjr)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@jonasschnelli jonasschnelli jonasschnelli approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luke-jr @maflcko @jonasschnelli