Inline CTxInWitness inside CTxIn #8589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6cfbcec to
0a14571
Compare
0a14571 to
c19f570
Compare
|
This needs a rebase. |
d531c7e to
e9632f5
Compare
|
Rebased on top of the new #8580. |
e9632f5 to
2341105
Compare
227c0dd to
c06459b
Compare
1123201 to
d25f575
Compare
d25f575 to
f6fb7ac
Compare
|
Rebased now #8580 is merged. Removes 80 lines of code! |
|
I am curious what this myhtical #9589 is! |
|
ACK |
|
Compiles cleanly utACK f6fb7ac |
|
Slightly-tested ACK f6fb7ac |
laanwj
added a commit
that referenced
this pull request
Dec 21, 2016
f6fb7ac Move CTxInWitness inside CTxIn (Pieter Wuille)
|
so much better |
maflcko
pushed a commit
that referenced
this pull request
Apr 25, 2019
bb530ef Disallow extended encoding for non-witness transactions (Pieter Wuille) Pull request description: BIP144 specifies that transactions without witness should use the legacy encoding, which is currently not enforced. This rule was present in the original SegWit implementation (#8149), but was subsequently dropped (#8589). As all hashes, txids, and weights are always computed over a reserialized version of a transaction, it is mostly harmless to permit extended encoding for non-segwit transactions, but I'd rather strictly follow the BIP. ACKs for commit bb530e: instagibbs: utACK bb530ef stevenroose: utACK bb530ef Tree-SHA512: 1aeccd6a555f43784fefb076ce2e8ad2f5ba7be49840544a50050d0390f82373f87201bf56cf8bb30841b4f9cd893b382261a080da875d4e11ab7051f8640dbe
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 27, 2019
…actions bb530ef Disallow extended encoding for non-witness transactions (Pieter Wuille) Pull request description: BIP144 specifies that transactions without witness should use the legacy encoding, which is currently not enforced. This rule was present in the original SegWit implementation (bitcoin#8149), but was subsequently dropped (bitcoin#8589). As all hashes, txids, and weights are always computed over a reserialized version of a transaction, it is mostly harmless to permit extended encoding for non-segwit transactions, but I'd rather strictly follow the BIP. ACKs for commit bb530e: instagibbs: utACK bitcoin@bb530ef stevenroose: utACK bb530ef Tree-SHA512: 1aeccd6a555f43784fefb076ce2e8ad2f5ba7be49840544a50050d0390f82373f87201bf56cf8bb30841b4f9cd893b382261a080da875d4e11ab7051f8640dbe
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #8452 on top of #8580.