[qt] Remove Priority from coincontrol dialog #8463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, I am still using it. In theory the date might be enough, but it's easier to tell at a glance from "low"/"medium"/"high" which are older. |
Please note there is also a column indicating the number of confirmations (not shown in my screenshot). So if you are interested in the ago of the coins, this should be sufficient. Also, looking at the Amount- and Confirmations-column should be sufficient to do priority estimation on the envelope/in your head, keeping in mind "medium" means one coinday (or 144 coinconfirmations) per 250kB. (Exact numbers are irrelevant, anyway) |
|
No strong opinion. But I guess priority will become more and more a relict. |
If you look at the tooltips right now, it implies the opposite: https://github.com/bitcoin/bitcoin/pull/8463/files#diff-409074603e1373817f983557bebc15daL653 |
|
@MarcoFalke:
... I meant that "priority" as a property of the bitcoin network becomes more and more a relict, something no longer has a significant value or use. I agree, we should remove it or at least reduce its significant (red label, etc.). |
|
Concept ACK |
1 similar comment
|
Concept ACK |
|
Tested a bit. |
| @@ -129,11 +126,9 @@ CoinControlDialog::CoinControlDialog(const PlatformStyle *platformStyle, QWidget | |||
| ui->treeWidget->setColumnWidth(COLUMN_ADDRESS, 290); | |||
| ui->treeWidget->setColumnWidth(COLUMN_DATE, 110); | |||
| ui->treeWidget->setColumnWidth(COLUMN_CONFIRMATIONS, 100); | |||
| ui->treeWidget->setColumnWidth(COLUMN_PRIORITY, 100); | |||
There was a problem hiding this comment.
I think you need to distribute the removed 100px to some other columns.
There was a problem hiding this comment.
Thanks for the help!
With resetguisettings I am getting this now:
|
Looks better. |
|
Done fa8dd78 |
jonasschnelli
added a commit
that referenced
this pull request
Aug 24, 2016
fa8dd78 [qt] Remove Priority from coincontrol dialog (MarcoFalke)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Sep 7, 2017
fa8dd78 [qt] Remove Priority from coincontrol dialog (MarcoFalke)
UdjinM6
pushed a commit
to dashpay/dash
that referenced
this pull request
Sep 9, 2017
* Merge bitcoin#7506: Use CCoinControl selection in CWallet::FundTransaction d6cc6a1 Use CCoinControl selection in CWallet::FundTransaction (João Barbosa) * Merge bitcoin#7732: [Qt] Debug window: replace "Build date" with "Datadir" fc737d1 [Qt] remove unused formatBuildDate method (Jonas Schnelli) 4856f1d [Qt] Debug window: replace "Build date" with "Datadir" (Jonas Schnelli) * Merge bitcoin#7707: [RPC][QT] UI support for abandoned transactions 8efed3b [Qt] Support for abandoned/abandoning transactions (Jonas Schnelli) * Merge bitcoin#7688: List solvability in listunspent output and improve help c3932b3 List solvability in listunspent output and improve help (Pieter Wuille) * Merge bitcoin#8006: Qt: Add option to disable the system tray icon 8b0e497 Qt: Add option to hide the system tray icon (Tyler Hardin) * Merge bitcoin#8073: qt: askpassphrasedialog: Clear pass fields on accept 02ce2a3 qt: askpassphrasedialog: Clear pass fields on accept (Pavel Vasin) * Merge bitcoin#8231: [Qt] fix a bug where the SplashScreen will not be hidden during startup b3e1348 [Qt] fix a bug where the SplashScreen will not be hidden during startup (Jonas Schnelli) * Merge bitcoin#8257: Do not ask a UI question from bitcoind 1acf1db Do not ask a UI question from bitcoind (Pieter Wuille) * Merge bitcoin#8463: [qt] Remove Priority from coincontrol dialog fa8dd78 [qt] Remove Priority from coincontrol dialog (MarcoFalke) * Merge bitcoin#8678: [Qt][CoinControl] fix UI bug that could result in paying unexpected fee 0480293 [Qt][CoinControl] fix UI bug that could result in paying unexpected fee (Jonas Schnelli) * Merge bitcoin#8672: Qt: Show transaction size in transaction details window c015634 qt: Adding transaction size to transaction details window (Hampus Sjöberg) \-- merge fix for s/size/total size/ fdf82fb Adding method GetTotalSize() to CTransaction (Hampus Sjöberg) * Merge bitcoin#8371: [Qt] Add out-of-sync modal info layer 08827df [Qt] modalinfolayer: removed unused comments, renamed signal, code style overhaul (Jonas Schnelli) d8b062e [Qt] only update "amount of blocks left" when the header chain is in-sync (Jonas Schnelli) e3245b4 [Qt] add out-of-sync modal info layer (Jonas Schnelli) e47052f [Qt] ClientModel add method to get the height of the header chain (Jonas Schnelli) a001f18 [Qt] Always pass the numBlocksChanged signal for headers tip changed (Jonas Schnelli) bd44a04 [Qt] make Out-Of-Sync warning icon clickable (Jonas Schnelli) 0904c3c [Refactor] refactor function that forms human readable text out of a timeoffset (Jonas Schnelli) * Merge bitcoin#8805: Trivial: Grammar and capitalization c9ce17b Trivial: Grammar and capitalization (Derek Miller) * Merge bitcoin#8885: gui: fix ban from qt console cb78c60 gui: fix ban from qt console (Cory Fields) * Merge bitcoin#8821: [qt] sync-overlay: Don't block during reindex fa85e86 [qt] sync-overlay: Don't show estimated number of headers left (MarcoFalke) faa4de2 [qt] sync-overlay: Don't block during reindex (MarcoFalke) * Support themes for new transaction_abandoned icon * Fix constructor call to COutput * Merge bitcoin#7842: RPC: do not print minping time in getpeerinfo when no ping received yet 62a6486 RPC: do not print ping info in getpeerinfo when no ping received yet, fix help (Pavel Janík) * Merge bitcoin#8918: Qt: Add "Copy URI" to payment request context menu 21f5a63 Qt: Add "Copy URI" to payment request context menu (Luke Dashjr) * Merge bitcoin#8925: qt: Display minimum ping in debug window. 1724a40 Display minimum ping in debug window. (R E Broadley) * Merge bitcoin#8972: [Qt] make warnings label selectable (jonasschnelli) ef0c9ee [Qt] make warnings label selectable (Jonas Schnelli) * Make background of warning icon transparent in modaloverlay * Merge bitcoin#9088: Reduce ambiguity of warning message 77cbbd9 Make warning message about wallet balance possibly being incorrect less ambiguous. (R E Broadley) * Replace Bitcoin with Dash in modal overlay * Remove clicked signals from labelWalletStatus and labelTransactionsStatus As both are really just labels, clicking on those is not possible. This is different in Bitcoin, where these labels are actually buttons. * Pull out modaloverlay show/hide into it's own if/else block and switch to time based check Also don't use masternodeSync.IsBlockchainSynced() for now as it won't report the blockchain being synced before the first block (or other MN data?) arrives. This would otherwise give the impression that sync is being stuck.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is anyone still using this? Even though the information is only shown for "experts", I don't think it adds value.
Please note that you could still send low fee/high prio transactions via the command line switch, but the GUI will no longer print the priority string:
