[Trivial] BIP9 parameters on regtest cleanup #8446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -996,10 +996,10 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler) | |||
| return InitError(strprintf("Invalid nTimeout (%s)", vDeploymentParams[2])); | |||
| } | |||
| bool found = false; | |||
| for (int i=0; i<(int)Consensus::MAX_VERSION_BITS_DEPLOYMENTS; ++i) | |||
| for (int j=0; j<(int)Consensus::MAX_VERSION_BITS_DEPLOYMENTS; ++j) | |||
There was a problem hiding this comment.
@btcdrak: See #8105. There is auto i a few lines above: https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L985
The warning issued is:
init.cpp:999:22: warning: declaration shadows a local variable [-Wshadow]
for (int i=0; i<(int)Consensus::MAX_VERSION_BITS_DEPLOYMENTS; ++i)
^
init.cpp:985:19: note: previous declaration is here
for (auto i : deployments) {
^
|
utACK 0fc00be |
|
utACK 0fc00be |
|
utACK 0fc00be |
|
utACK 0fc00be |
laanwj
added a commit
that referenced
this pull request
Aug 3, 2016
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor cleanup after 56c87e9