Skip to content

Conversation

sdaftuar
Copy link
Member

blockchain.py is failing on master and 0.12, due to a subtle merge conflict when #7194 was merged.

@laanwj Needs backport

@maflcko
Copy link
Member

maflcko commented Jan 18, 2016

Awesome, just was about to open the pull myself.

utACK 4a04879

@laanwj
Copy link
Member

laanwj commented Jan 18, 2016

ugh, went a bit too fast there
Thanks. ACK.

@laanwj laanwj added the Tests label Jan 18, 2016
@maflcko
Copy link
Member

maflcko commented Jan 18, 2016

Travis should re-evaluate pulls every 10 days, imo. The travis result from #7194 was more than 30 days old.

@laanwj
Copy link
Member

laanwj commented Jan 18, 2016

I usually manually check after merging (but before pushing), but skipped in this case as I wanted to merge a bunch low-risk/trivial ones at the same time. Bad idea.

@laanwj laanwj merged commit 4a04879 into bitcoin:master Jan 18, 2016
laanwj added a commit that referenced this pull request Jan 18, 2016
4a04879 Fix error in blockchain.py introduced in merge (Suhas Daftuar)
laanwj pushed a commit that referenced this pull request Jan 18, 2016
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants