[Tests] Eliminate race condition in mempool_packages.py #7368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK 4d10d2e. Also needs to be tagged with [Backport] |
laanwj
added a commit
that referenced
this pull request
Jan 18, 2016
4d10d2e Eliminate race condition in mempool_packages test (Suhas Daftuar)
random-zebra
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Apr 7, 2021
600dd4d Eliminate race condition in mempool_packages test (Suhas Daftuar) Pull request description: Solving the intermittent failures in mempool_packages test that happen way too often. Coming straight from bitcoin#7368. PD: thanks to my good zebra for finding the cause ACKs for top commit: random-zebra: utACK 600dd4d Tree-SHA512: 4fc5fdf3ced4f359268c0e761a7a16943ab1a88c4fa5573b50e89163bebe7d01b1b22d5b25fee3cc80a534acd36e1b92e3519646b02dd34f8645d3123b6ecbb1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed intermittent failures in the
mempool_packages.pyRPC test; turns out I introduced a race condition in a recent pull (#7062).Before this change, node1 could either be in sync or out of sync with node0 after
invalidateblockwas called, depending on how fast that happened. The test would fail if they were out of sync. This fixes the test by enforcing that their tips stay synced up.@laanwj Note that this bug is in 0.12, in case you think this should be backported or included in the next 0.12 release candidate.