Skip to content

Conversation

luke-jr
Copy link
Member

@luke-jr luke-jr commented Jan 13, 2016

Somehow these got missed

For opensource.org/licenses/MIT!
Github-Pull: bitcoin#7197
Rebased-From: 00423e1
@maflcko
Copy link
Member

maflcko commented Jan 13, 2016

At least two of them got missed on purpose.

@luke-jr luke-jr force-pushed the backports-for-0.12.0 branch from e8f2148 to e20704b Compare January 13, 2016 21:26
@@ -350,6 +350,20 @@ caching. A sample config for apache2 could look like:

</VirtualHost>

Asm script outputs now contain OP_CHECKLOCKTIMEVERIFY in place of OP_NOP2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest combining this with the other asm change related to signature flags, which is currently under "RPC: Low-level API changes".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@laanwj
Copy link
Member

laanwj commented Jan 13, 2016

utACK now that it contains no translation string changes anymore

@laanwj laanwj added this to the 0.12.0 milestone Jan 13, 2016
@maflcko
Copy link
Member

maflcko commented Jan 14, 2016

utACK e20704b

Missing: #7327

@laanwj laanwj merged commit f17b00b into bitcoin:0.12 Jan 18, 2016
laanwj added a commit that referenced this pull request Jan 18, 2016
f17b00b release-notes: Combine NOP2->CLTV asm change into "RPC: Low-level API changes" section (Luke Dashjr)
e20704b Replace some instances of formatWithUnit with formatHtmlWithUnit (fanquake)
6f8346d qt5: Use the fixed font the system recommends (MarcoFalke)
605de4a Rename OP_NOP2 to OP_CHECKLOCKTIMEVERIFY. (mb300sd)
6191a9b [RPC-Tests] add option to run rpc test over QT clients (Jonas Schnelli)
6307beb Note that reviewers should mention the commit hash of the commits they reviewed. (Patrick Strateman)
6092ff2 Set link from http:// to https:// (Suriyaa Kudo)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants