Removed comment about IsStandard for P2SH scripts #7266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since bitcoin#4365 (6259937) P2SH scripts do not have to be IsStandard scripts.
|
utACK |
1 similar comment
|
utACK |
|
ACK (why ut?) |
|
ACK zauguin@6cd198f |
|
@jonasschnelli because I haven't tested it? Sure, it should have 0 effect, but, it may not, hence, utACK. utACK @ 6cd198f |
|
@dcousens: Yes. Sure. But I can't see how removing a comment could change the compiled binary. |
|
ACK |
laanwj
added a commit
that referenced
this pull request
Jan 7, 2016
6cd198f Removed comment about IsStandard for P2SH scripts (Marcel Krüger)
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Feb 12, 2016
Since bitcoin#4365 (6259937) P2SH scripts do not have to be IsStandard scripts. Github-Pull: bitcoin#7266 Rebased-From: 6cd198f
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 9, 2017
6cd198f Removed comment about IsStandard for P2SH scripts (Marcel Krüger)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #4365 (6259937) P2SH scripts do not have to be IsStandard scripts.