Replace some instances of formatWithUnit with formatHtmlWithUnit #7255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strings in a HTML context should be using formatHtmlWithUnit.
|
light utACK |
|
|
||
| QString toolTip3 = tr("This label turns red if any recipient receives an amount smaller than %1.").arg(BitcoinUnits::formatWithUnit(nDisplayUnit, ::minRelayTxFee.GetFee(546))); | ||
| QString toolTip3 = tr("This label turns red if any recipient receives an amount smaller than %1.").arg(BitcoinUnits::formatHtmlWithUnit(nDisplayUnit, ::minRelayTxFee.GetFee(546))); |
There was a problem hiding this comment.
Not related to this PR: but we should remove the hardcoded 546 here. I think just removing the number and changing the text to something like "This label turns red if any recipient receives an amount smaller then the current dust threshold") .
There was a problem hiding this comment.
@fanquake: mind packing this into this PR?
There was a problem hiding this comment.
Looks like it's already used in this cpp file. So could as well make it calculate the threshold every time? https://github.com/fanquake/bitcoin/blob/5fdf32de7ed85a1a0aec7cdedb83f750f4a0f7ff/src/qt/coincontroldialog.cpp#L577
|
utACK |
|
ACK 6fd0a07 |
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 10, 2016
Strings in a HTML context should be using formatHtmlWithUnit. Github-Pull: bitcoin#7255 Rebased-From: 5fdf32d
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 10, 2016
Github-Pull: bitcoin#7255 Rebased-From: 6fd0a07
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 10, 2016
Strings in a HTML context should be using formatHtmlWithUnit. Github-Pull: bitcoin#7255 Rebased-From: 5fdf32d
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 10, 2016
Github-Pull: bitcoin#7255 Rebased-From: 6fd0a07
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 13, 2016
Strings in a HTML context should be using formatHtmlWithUnit. Github-Pull: bitcoin#7255 Rebased-From: 5fdf32d
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Feb 12, 2016
Github-Pull: bitcoin#7255 Rebased-From: 6fd0a07
UdjinM6
pushed a commit
to dashpay/dash
that referenced
this pull request
Sep 7, 2017
* Merge pull request bitcoin#7154 a3c3ddb [Qt] add InMempool() info to transaction details (Jonas Schnelli) * Merge pull request bitcoin#7218 fa5769e [qt] Fix misleading translation (MarcoFalke) fa8c8d7 torcontrol debug: Change to a blanket message that covers both cases (MarcoFalke) * Merge pull request bitcoin#7255 6fd0a07 Remove hardcoded fee from CoinControl ToolTip (fanquake) 5fdf32d Replace some instances of formatWithUnit with formatHtmlWithUnit (fanquake) * Merge pull request bitcoin#7263 a5a0831 Double semicolon cleanup. (21E14) * Merge pull request bitcoin#7334 fa989fb [qt] coincontrol workaround is still needed in qt5.4 (fixed in qt5.5) (MarcoFalke) * Merge pull request bitcoin#7329 9d263bd Typo fixes in comments (Chris Wheeler) * Merge bitcoin#7396: [Qt] Add option to increase/decrease font size in the console window 43abb02 [Qt] Add a new chevron/arrow icon for the console prompt line (Jonas Schnelli) 56c9e66 [Qt] keep scroll position in GUI console after changing font size (Jonas Schnelli) 3a3a927 [Qt] Add option to increase/decrease font size in the console window (Jonas Schnelli) * Merge bitcoin#7628: QT: Add 'copy full transaction details' option b51ed40 QT: Add 'copy full transaction details' option (Eric Shaw) * Merge bitcoin#7668: Fix history deletion bug after font size change 21e45a0 Fix history deletion bug after font change (Andrew C) * Copy/Move font size related icons into theme folders * Use formatTxDate for date/time in TxPlainTextRole
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strings in a HTML context should be using formatHtmlWithUnit.