Bugfix: comply with BIP 0014 ... #715
Conversation
|
NACK. |
|
I love nonsensical NACKs. Especially on bugfixes. |
|
All right, NACK: adds 40 lines of code and a bunch of confusing #ifdefs for no good reason. |
|
Adds 40 lines of code for complying with the community standard everyone accepted... |
|
Complying with the standards as you read it (I dont read it that way, but whatever) doesnt take 40 lines anyway. |
|
Indeed, it could be done in fewer if we had an unanimous consensus whether there should be a difference between how bitcoind and Bitcoin-Qt advertise themselves. But making it configurable so both camps can be happy does take slightly more code. |
…Satoshi and, if PUBLIC_CLIENT_NAME is defined, the front-end name after that
|
NAK also. Current client has been out there with current behavior, making the new standard not as widely accepted as implied. There are also disagreements over how one reads the standard. |
|
There is no current released client out there with the broken behaviour. Please merge this fix or reopen... |
|
This patch seems to change several things at once, but at least one is very reasonable imho, namely the fact that bitcoind now advertizes itself as Bitcoin-qt. A much simpler patch would allow fixing that. |
|
Actually, what about just changing the version string to "/Satoshi:0.6.0/" ? |
…r Params().GetConsensus().nBudgetPaymentsStartBlock Closes bitcoin#715
A couple of fixes for when shutdown is requested but blocks can still be connected
f3b6ca4 Skip wallet balance caching, when not in UI mode (dexX7)
... by sending the correct codebase name of Satoshi and, if PUBLIC_CLIENT_NAME is defined, the front-end name after that