rpc: Don't translate warning messages #7141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99be01c to
1a514e6
Compare
But keep translating them in the GUI. This - necessarily - requires duplication of a few messages. Alternative take on bitcoin#7134, that keeps the translations from being wiped. Also document GetWarnings() input argument. Fixes bitcoin#5895.
1a514e6 to
aabc897
Compare
|
Nice! This is the right way to do it. |
|
utACK aabc897 |
laanwj
added a commit
that referenced
this pull request
Dec 1, 2015
aabc897 rpc: Don't translate warning messages (Wladimir J. van der Laan)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But keep translating them in the GUI.
This - necessarily - requires duplication of a few messages. This would allow using different messages in GUI and RPC, but keep them the same for now.
Alternative take on #7134, that keeps the translations from being wiped.
Also document GetWarnings() input argument.