build: No need to check for leveldb atomics #7982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're guaranteed with c++11
|
utACK de98290 |
|
utACK de98290 This reminds me, we should make tinyformat use variadic template as well (TINYFORMAT_USE_VARIADIC_TEMPLATES) if that's not the case yet automatically. |
|
A quick test shows that it auto-detects and uses them automatically, at least on clang 3.9: #ifdef TINYFORMAT_USE_VARIADIC_TEMPLATES
#error Using variadic templates
#endifThe detection method is a tad outdated though: |
|
@laanwj Agreed, defining it explicitly couldn't hurt. |
laanwj
added a commit
that referenced
this pull request
May 4, 2016
de98290 build: No need to check for leveldb atomics (Cory Fields)
laanwj
added a commit
to laanwj/bitcoin
that referenced
this pull request
May 4, 2016
Now that we started using c++11, force use of variadic templates. The autodetection may be wonky on some compilers, see discussion [here](bitcoin#7982 (comment)) and is unnecessary for us anyhow.
deadalnix
pushed a commit
to deadalnix/bitcoin
that referenced
this pull request
Jan 19, 2017
Now that we started using c++11, force use of variadic templates. The autodetection may be wonky on some compilers, see discussion [here](bitcoin#7982 (comment)) and is unnecessary for us anyhow.
dagurval
pushed a commit
to dagurval/bitcoinxt
that referenced
this pull request
Apr 23, 2017
Now that we started using c++11, force use of variadic templates. The autodetection may be wonky on some compilers, see discussion [here](bitcoin/bitcoin#7982 (comment)) and is unnecessary for us anyhow.
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 20, 2017
de98290 build: No need to check for leveldb atomics (Cory Fields)
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Oct 21, 2018
Now that we started using c++11, force use of variadic templates. The autodetection may be wonky on some compilers, see discussion [here](bitcoin#7982 (comment)) and is unnecessary for us anyhow.
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Sep 25, 2020
Update LevelDB to upstream commit f545dfabf Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#7911 - bitcoin/bitcoin#7982 - bitcoin/bitcoin#8133 - bitcoin/bitcoin#8784 - Only the missing changes. - bitcoin/bitcoin#8826 - bitcoin/bitcoin#8613 - bitcoin/bitcoin#10544 - bitcoin/bitcoin#10633 - Only the changes to files and code we have. - bitcoin/bitcoin#10806 - bitcoin/bitcoin#10958 - bitcoin/bitcoin#12451 - bitcoin/bitcoin#13925 - bitcoin/bitcoin#15270 This upgrades LevelDB in the exact same commit progression as upstream, up to January 2019.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're guaranteed with c++11