depends: mac deploy Py3 compatibility (fixes macosx gitian build) #7792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the gitian MacOSX build, it was broken in bitcoin#7723. The patch to `native_mac_alias` should probably make it upstream.
de0fcd3 to
4f68868
Compare
|
utACK 4f68868 |
|
patch submitted upstream: https://bitbucket.org/al45tair/mac_alias/pull-requests/4/further-python-3-compatiblity/diff |
|
Ut ack. Thanks for upstreaming.
side-note: how do depends fare on xenial (I'm assuming that's not what
you're running here)? Before the deps themselves learn to cope, I suppose
it'll take a fair bit of patching. Or did we get lucky and this is all it
takes?
|
Haven't tried xenial depends or gitian builds yet, no. |
|
Closing as this is included in #7920, which should go in this week anyhow. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the gitian MacOSX build, it was broken in #7723.
The patch to
native_mac_aliasshould probably make it upstream.