devtools: make github-merge.py use py3 #7737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b83d7ad to
b4c7198
Compare
This makes github-merge.py the first developer tool to go all Python 3 (for context see bitcoin#7717). The changes are straightforward as the script already was `from __future__ import division,print_function,unicode_literals`. However urllib2 changed name, and json will only accept unicode data not bytes. This retains py2 compatibility for now: not strictly necessary as it's not used by the build system - but it was easy.
b4c7198 to
f11c5a3
Compare
|
utACK f11c5a3 |
|
I've been using this python3 version for about a week now, without problems. |
laanwj
added a commit
that referenced
this pull request
Mar 29, 2016
f11c5a3 devtools: make github-merge.py use py3 (Wladimir J. van der Laan)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 19, 2017
f11c5a3 devtools: make github-merge.py use py3 (Wladimir J. van der Laan)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
github-merge.pythe first developer tool to go all Python 3 (for context see #7717).The changes are straightforward as the script already was
from __future__ import division,print_function,unicode_literals.However urllib2 changed name, and json will only accept unicode data not bytes.
This retains py2 compatibility for now: not strictly necessary as the script is not used by the build system (see #7723) - but it was easy.