Skip to content

Conversation

btcdrak
Copy link
Contributor

@btcdrak btcdrak commented Mar 9, 2016

curl is required to fetch dependencies

requires backport to all branches

[ci skip]

curl is required to fetch dependencies

[ci skip]
@maflcko
Copy link
Member

maflcko commented Mar 9, 2016

ACK

@luke-jr
Copy link
Member

luke-jr commented Mar 9, 2016

The gitian descriptors should be installing this now, although I suppose this saves time.

@maflcko
Copy link
Member

maflcko commented Mar 9, 2016

As I understand this, they are only installed on the guest system: https://github.com/devrandom/gitian-builder/blob/bb4f92f6cbde6ee78e39ae35b0934da3b55e154d/bin/gbuild#L97

So this pull seems like a good place to revert #7614?

@luke-jr
Copy link
Member

luke-jr commented Mar 9, 2016

They're only needed on the guest system.

@maflcko
Copy link
Member

maflcko commented Mar 9, 2016

They're only needed on the guest system.

Then I fail to see why this pull "requires backport to all branches" considering that Debian is the host system.

Edit: I see, it's required for the optional step in https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#optional-seed-the-gitian-sources-cache-and-offline-git-repositories

@btcdrak
Copy link
Contributor Author

btcdrak commented Mar 9, 2016

Without this patch, make -C depends/... command fails to download the dependencies required for gitian builds.

@luke-jr
Copy link
Member

luke-jr commented Mar 9, 2016

@btcdrak But make -C depends/... is not part of the setup instructions... and inside the gitian environment curl is installed by the packages list.

@btcdrak
Copy link
Contributor Author

btcdrak commented Mar 9, 2016

@laanwj laanwj changed the title Add curl to Gitian setup instrustions Add curl to Gitian setup instructions Mar 11, 2016
@laanwj laanwj merged commit ce41cf0 into bitcoin:master Mar 14, 2016
laanwj added a commit that referenced this pull request Mar 14, 2016
ce41cf0 Add curl to Gitian setup instrustions (BtcDrak)
@btcdrak btcdrak deleted the curl branch March 14, 2016 11:26
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Apr 27, 2016
curl is required to fetch dependencies

Github-Pull: bitcoin#7658
Rebased-From: ce41cf0
@maflcko
Copy link
Member

maflcko commented Jun 9, 2016

Backported as part of #7938. Removing label 'Needs backport'.

thokon00 pushed a commit to faircoin/faircoin that referenced this pull request Jun 28, 2016
curl is required to fetch dependencies

Github-Pull: bitcoin#7658
Rebased-From: ce41cf0
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants