Add autocomplete to bitcoin-qt's console window. #7613

GamerSg · 2016-02-27T04:46:39Z

Would have preferred if the command arrays were in a vector, would have prevented hardcoding of array sizes in for loop. I will probably do that in another pull request.

luke-jr · 2016-02-27T04:48:57Z

Concept ACK.

jonasschnelli · 2016-02-27T08:12:23Z

Nice!
Concept ACK.
Will review/test soon.

paveljanik · 2016-02-27T10:02:23Z

Concept ACK. Nice!

The build without wallet failed - see https://travis-ci.org/bitcoin/bitcoin/jobs/112189472#L1844

qt/libbitcoinqt.a(qt_libbitcoinqt_a-rpcconsole.o): In function `RPCConsole::RPCConsole(PlatformStyle const*, QWidget*)':
rpcconsole.cpp:(.text+0x566a): undefined reference to `vWalletRPCCommands'

maflcko · 2016-02-27T17:00:23Z

src/qt/rpcconsole.cpp

@@ -274,6 +277,19 @@ RPCConsole::RPCConsole(const PlatformStyle *platformStyle, QWidget *parent) :
    connect(ui->fontSmallerButton, SIGNAL(clicked()), this, SLOT(fontSmaller()));
    connect(ui->btnClearTrafficGraph, SIGNAL(clicked()), ui->trafficGraph, SLOT(clear()));

+    //Setup autocomplete and attach it
+    QStringList wordList;
+    for (int i =0; i < 53; ++i)


Any reason why we are not using std::array?

You need to build the 53 dynamic by something like ARRAYLEN(vRPCCommands).

@MarcoFalke That would require C++11 which i believe at this point is not supported yet in the codebase.

@jonasschnelli Apparently this is much trickier than it would seem to be. Straightforward way would be to use vector but would be kind of redundant for a const array. Will see what i can do about it.

@GamerSg Right, somehow forgot we are still waiting on travis to get c++11 rolled out.

You could take a look at src/utilstrencodings.h which has a #define ARRAYLEN(array).

kirkalx · 2016-02-28T09:42:36Z

Concept ACK, nice idea.
Perhaps this could be implemented without making vRPCCommands etc. extern?
Nit: some of the spacing is a little unusual.

jonasschnelli · 2016-02-28T10:29:47Z

src/qt/rpcconsole.cpp

+    bool fDisableWallet = GetBoolArg("-disablewallet", false);
+    if(!fDisableWallet)
+    {//Only add commands if wallet is not disabled
+        for (int i =0; i < 43; ++i)


You need to build the 43 dynamic by something like ARRAYLEN(vWalletRPCCommands).

@GamerSg Are you still working on this? I'd like to see this merged :)

Yes. I also think this is a nice improvement. We just need to remove the magic numbers.
Just tell me or Marco if on of us should continue this (without losing you commit/author name).

ARRAYLEN will not work for an external array, the information is not available at compile time. Please see my suggestion below to add a call to TableRPC.

@MarcoFalke Sorry, been busy past few days. I'll iron out any remaining issues over the weekend.

As @laanwj said, sizeof(array) does not work either, because the data is in a seperate cpp file and unavailable at compile time to other compilation units.

maflcko · 2016-02-28T19:16:17Z

src/qt/rpcconsole.cpp

+    #ifdef ENABLE_WALLET
+    bool fDisableWallet = GetBoolArg("-disablewallet", false);
+    if(!fDisableWallet)
+    {//Only add commands if wallet is not disabled


No need for this comment. Also you don't have to parse the arg. Maybe try just if (pwalletMain)?

laanwj · 2016-03-03T13:21:23Z

Concept ACK

laanwj · 2016-03-07T17:59:52Z

Looks good to me now!
utACK after squash

kirkalx · 2016-03-08T04:20:45Z

Sweet, utACK after style nits
Refer doc/developer-notes.md for some coding style tips. Also a space after a comma, and before and after operators like = and << are always good things IMO :)

    for (size_t i =0; i < commandList.size(); ++i)
    {
        wordList<<commandList[i].c_str();
    }

    autoCompleter = new QCompleter(wordList,this);

jonasschnelli · 2016-03-08T09:26:32Z

Currently, the wallet RPC commands are missing.
You need to build up your autocomplete list in RPCConsole::setClientModel() (and only if the modal exists) instead of in RPCConsole:: RPCConsole(). This is required because of the more modular creation of the tableRPC (see #7307).

laanwj · 2016-03-11T08:02:08Z

@jonasschnelli good catch!

kirkalx · 2016-03-11T08:05:39Z

If you are still struggling with git for squashing, @GamerSg, Wladimir helped me with the same in #7458

GamerSg · 2016-03-11T13:55:21Z

Hi all, i just find time during the weekends to work on this, so ill fix up the remaining issues tomorrow.

Removed externs Added listCommands() to CRPCTable Move autocomplete init to RPCConsole::setClientModel()

GamerSg · 2016-03-12T05:20:17Z

Moved the initialisation to setClientModel() as @jonasschnelli suggested.
Squashed the commits as well.

maflcko · 2016-03-12T15:03:43Z

Looks like this works just fine, now.

ACK ce7413f:

paveljanik · 2016-03-12T16:59:41Z

Works OK. Please fix the indentation of "}" in rpcconsole.cpp.

jonasschnelli · 2016-03-14T08:18:23Z

Tested ACK ce7413f

ce7413f Add autocomplete to bitcoin-qt's console window. (Luv Khemani)

paveljanik · 2016-03-30T17:42:06Z

@GamerSg When you activate (Enter) one of the selected items from autocompleter, it is executed, but the entry line is not emptied... Fixed in #7772.

Origin: bitcoin/bitcoin#7613

ce7413f Add autocomplete to bitcoin-qt's console window. (Luv Khemani)

081cc02 Fix QCompleter popup regression (Hennadii Stepanov) Pull request description: The PR #8129 has introduced a regression with the `QCompleter` popup in the Debug window. How to reproduce: 1. open the Debug window; 2. go to the 'Console' tab; 3. start writing some RPC command and try to pick it from the list using arrow keys, press Enter. Note that the popup used to display completions is not being closed. To close it they should mouse click somewhere outside of the popup. The wrong behaviour of the `QCompleter` popup is observed on Linux Mint 19 and Windows 10. This PR fixes this regression. Refs: - #7613 - #7772 - #8129 Tree-SHA512: f3ba8d08e1c07619d4ef307544306b57be43e4e726770976cf0c2af95082bd66e2eefe8aabb9a3fad0601cd9e6e4dea0459b6a63eba512023234feb308484655

Backport Boost removal PRs Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#7613 - bitcoin/bitcoin#10502 - bitcoin/bitcoin#10193 - bitcoin/bitcoin#13961 - bitcoin/bitcoin#13734 - Only the second commit (we don't need the first). - bitcoin/bitcoin#14480 Part of #4819.

081cc02 Fix QCompleter popup regression (Hennadii Stepanov) Pull request description: The PR bitcoin#8129 has introduced a regression with the `QCompleter` popup in the Debug window. How to reproduce: 1. open the Debug window; 2. go to the 'Console' tab; 3. start writing some RPC command and try to pick it from the list using arrow keys, press Enter. Note that the popup used to display completions is not being closed. To close it they should mouse click somewhere outside of the popup. The wrong behaviour of the `QCompleter` popup is observed on Linux Mint 19 and Windows 10. This PR fixes this regression. Refs: - bitcoin#7613 - bitcoin#7772 - bitcoin#8129 Tree-SHA512: f3ba8d08e1c07619d4ef307544306b57be43e4e726770976cf0c2af95082bd66e2eefe8aabb9a3fad0601cd9e6e4dea0459b6a63eba512023234feb308484655

maflcko reviewed Feb 27, 2016
View reviewed changes

jonasschnelli reviewed Feb 28, 2016
View reviewed changes

jonasschnelli added the GUI label Feb 28, 2016

maflcko reviewed Feb 28, 2016
View reviewed changes

GamerSg force-pushed the autocomplete branch from 6f6d5f0 to b3c9a6b Compare March 5, 2016 04:05

Add autocomplete to bitcoin-qt's console window.

ce7413f

Removed externs Added listCommands() to CRPCTable Move autocomplete init to RPCConsole::setClientModel()

GamerSg force-pushed the autocomplete branch from 9cedec7 to ce7413f Compare March 12, 2016 05:05

jonasschnelli merged commit ce7413f into bitcoin:master Mar 14, 2016

jonasschnelli added a commit that referenced this pull request Mar 14, 2016

Merge #7613: Add autocomplete to bitcoin-qt's console window.

3798e5d

ce7413f Add autocomplete to bitcoin-qt's console window. (Luv Khemani)

AmirAbrams mentioned this pull request Jun 23, 2016

[UI] Add autocomplete to emercoin-qt's console window. emercoin/emercoin#11

Merged

Fuzzbawls mentioned this pull request Jul 28, 2016

Add autocomplete to hodlcoin-qt's console window. HOdlcoin/HOdlcoin#71

Merged

svost added a commit to svost/novacoin that referenced this pull request Feb 6, 2017

Add autocomplete to bitcoin-qt's console window

0f9f9e5

Origin: bitcoin/bitcoin#7613

svost added a commit to svost/novacoin that referenced this pull request Feb 6, 2017

Add autocomplete to novacoin-qt's console window

b92e093

Origin: bitcoin/bitcoin#7613

kyuupichan mentioned this pull request Mar 12, 2017

[backport] Qt Debug Window / Rpc Console improvements BitcoinUnlimited/BitcoinUnlimited#364

Merged

cddjr referenced this pull request in cddjr/BitcoinUnlimited Apr 6, 2017

Merge #7613: Add autocomplete to bitcoin-qt's console window.

5fb3aee

ce7413f Add autocomplete to bitcoin-qt's console window. (Luv Khemani)

Fuzzbawls mentioned this pull request Jul 25, 2017

[Qt] Add autocomplete to Qt client's debug console PIVX-Project/PIVX#225

Merged

hebasto mentioned this pull request Oct 9, 2018

qt: Fix QCompleter popup regression #14450

Merged

Pythonix mentioned this pull request Oct 8, 2020

gui: add autocomplete to rpc console gridcoin-community/Gridcoin-Research#1927

Merged

str4d mentioned this pull request Nov 23, 2020

Backport Boost removal PRs zcash/zcash#4877

Merged

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Add autocomplete to bitcoin-qt's console window. #7613

Add autocomplete to bitcoin-qt's console window. #7613

Uh oh!

Conversation

GamerSg commented Feb 27, 2016

Uh oh!

luke-jr commented Feb 27, 2016

Uh oh!

jonasschnelli commented Feb 27, 2016

Uh oh!

paveljanik commented Feb 27, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kirkalx commented Feb 28, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

laanwj commented Mar 3, 2016

Uh oh!

laanwj commented Mar 7, 2016

Uh oh!

kirkalx commented Mar 8, 2016

Uh oh!

jonasschnelli commented Mar 8, 2016

Uh oh!

laanwj commented Mar 11, 2016

Uh oh!

kirkalx commented Mar 11, 2016

Uh oh!

GamerSg commented Mar 11, 2016

Uh oh!

GamerSg commented Mar 12, 2016

Uh oh!

maflcko commented Mar 12, 2016

Uh oh!

paveljanik commented Mar 12, 2016

Uh oh!

jonasschnelli commented Mar 14, 2016

Uh oh!

paveljanik commented Mar 30, 2016

Uh oh!

Uh oh!