Skip to content

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Feb 26, 2016

No description provided.

@jonasschnelli
Copy link
Contributor

utACK.
Would be nice to first get #7576 and #7577 in...

@laanwj
Copy link
Member

laanwj commented Feb 29, 2016

utACK fa1ee8e

@sipa
Copy link
Member

sipa commented Mar 5, 2016

Concept ACK

@maflcko maflcko force-pushed the Mf1602-walletFileName branch 6 times, most recently from 20abbbb to fa3c9dc Compare March 14, 2016 12:33
@maflcko maflcko force-pushed the Mf1602-walletFileName branch from fa3c9dc to fa19b18 Compare March 14, 2016 12:54
@laanwj laanwj merged commit fa19b18 into bitcoin:master Mar 14, 2016
laanwj added a commit that referenced this pull request Mar 14, 2016
fa19b18 [wallet] Move hardcoded file name out of log messages (MarcoFalke)
@maflcko maflcko deleted the Mf1602-walletFileName branch March 14, 2016 12:57
codablock pushed a commit to codablock/dash that referenced this pull request Dec 19, 2017
…ages

fa19b18 [wallet] Move hardcoded file name out of log messages (MarcoFalke)
zkbot added a commit to zcash/zcash that referenced this pull request Dec 18, 2019
random-zebra added a commit to PIVX-Project/PIVX that referenced this pull request Aug 25, 2020
7e71759 Wallet: Split main logic from InitLoadWallet into CreateWalletFromFile (random-zebra)
e585dad [Wallet] refactor wallet/init interaction (random-zebra)
49646b2 [Refactor] Nuke zwalletMain global object (random-zebra)
f5f9df9 Wallet: Let the interval-flushing thread figure out the filename (Luke Dashjr)
74445e4 [wallet] Move hardcoded file name out of log messages (random-zebra)
3f1838d [Wallet] optimize return value of InitLoadWallet() (random-zebra)
539dea4 [Wallet] move "load wallet phase" to CWallet (random-zebra)
7644318 [Wallet] move wallet help string creation to CWallet (random-zebra)
a9d69b8 [trivial] Reuse translation and cleanup DEFAULT_* values (random-zebra)
cfd007a [Bug] Omit wallet-related options from -help when wallet not supported (random-zebra)
da642e6 [Refactor] More constant default values cleanup (random-zebra)
a45275a [Refactor] Implement CBaseChainParams::BaseParams(Network) (random-zebra)
09abb98 Constrain constant values to a single location in code (random-zebra)

Pull request description:

  Adapts the following refactoring PRs:

  - bitcoin#6961 Constrain constant values to a single location in code
  - bitcoin#7576 [Wallet] move wallet help string creation to CWallet
  - bitcoin#7577 move "load wallet phase" to CWallet
  - bitcoin#7608 Move hardcoded file name out of log messages
  - bitcoin#7691 refactor wallet/init interaction
  - bitcoin#8776 Wallet refactoring leading up to multiwallet

ACKs for top commit:
  furszy:
    re ACK 7e71759
  Fuzzbawls:
    ACK 7e71759

Tree-SHA512: 5fad328b9ddf8187af97d3d5fb285d0b67e73d51ac1bc44a3d57d0af86bce8b34efaab539b7bdbc4f9a2fa575a936f83788cffcc9c6d6d04cd3e63b19d399400
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants