Remove vfReachable and modify IsReachable to only use vfLimited. #7553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c003bc to
110b62f
Compare
We do not know that a class of Network is reachable, only that it is not.
|
Possibly related issue, there's some discussion there:
Concept ACK, I don't think we need both vfLimited and vfReachable, though this will have to be carefully checked to make sure it still respects onlynet, and proxies etc. No automatic tests for any of this. |
|
@laanwj Yes this will fix that issue. onlynet and proxy settings are unaffected |
|
Concept ack, trying to balance the two was confusing. |
|
Concept ACK |
laanwj
added a commit
that referenced
this pull request
Mar 11, 2016
…Limited. 110b62f Remove vfReachable and modify IsReachable to only use vfLimited. (Patrick Strateman)
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Apr 27, 2016
We do not know that a class of Network is reachable, only that it is not. Github-Pull: bitcoin#7553 Rebased-From: 110b62f
|
Backported as part of #7938. Removing label 'Needs backport'. |
thokon00
pushed a commit
to faircoin/faircoin
that referenced
this pull request
Jun 28, 2016
We do not know that a class of Network is reachable, only that it is not. Github-Pull: bitcoin#7553 Rebased-From: 110b62f
nomnombtc
pushed a commit
to nomnombtc/bitcoin
that referenced
this pull request
Nov 14, 2016
We do not know that a class of Network is reachable, only that it is not. Github-Pull: bitcoin#7553 Rebased-From: 110b62f
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Mar 26, 2017
Tor ephemeral hidden services Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6503 (included to reduce merge conflicts) - bitcoin/bitcoin#6639 - bitcoin/bitcoin#6643 - bitcoin/bitcoin#7090 - bitcoin/bitcoin#7035 - bitcoin/bitcoin#7170 - bitcoin/bitcoin#7218 (non-QT part) - bitcoin/bitcoin#7313 - bitcoin/bitcoin#7438 - bitcoin/bitcoin#7553 - bitcoin/bitcoin#7637 - bitcoin/bitcoin#7683 - bitcoin/bitcoin#7813 - bitcoin/bitcoin#7703 - bitcoin/bitcoin#8203 - bitcoin/bitcoin#9004 - bitcoin/bitcoin#9234 - bitcoin/bitcoin#9911 (partial) Closes #2061.
laanwj
added a commit
that referenced
this pull request
Jan 14, 2019
d6b076c Drop IsLimited in favor of IsReachable (Ben Woosley) Pull request description: These two methods have had the same meaning, but inverted, since 110b62f. Having one name for a single concept simplifies the code. This is a follow-up to #15051. /cc #7553 Tree-SHA512: 347ceb9e2a55ea06f4c01226411c7bbcade09dd82130e4c59d0824ecefd960875938022edbe5d4bfdf12b0552c9b4cb78b09a688284d707119571daf4eb371b4
This was referenced Jun 25, 2020
Merged
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 18, 2021
d6b076c Drop IsLimited in favor of IsReachable (Ben Woosley) Pull request description: These two methods have had the same meaning, but inverted, since 110b62f. Having one name for a single concept simplifies the code. This is a follow-up to bitcoin#15051. /cc bitcoin#7553 Tree-SHA512: 347ceb9e2a55ea06f4c01226411c7bbcade09dd82130e4c59d0824ecefd960875938022edbe5d4bfdf12b0552c9b4cb78b09a688284d707119571daf4eb371b4
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 18, 2021
d6b076c Drop IsLimited in favor of IsReachable (Ben Woosley) Pull request description: These two methods have had the same meaning, but inverted, since 110b62f. Having one name for a single concept simplifies the code. This is a follow-up to bitcoin#15051. /cc bitcoin#7553 Tree-SHA512: 347ceb9e2a55ea06f4c01226411c7bbcade09dd82130e4c59d0824ecefd960875938022edbe5d4bfdf12b0552c9b4cb78b09a688284d707119571daf4eb371b4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not know that a class of Network is reachable, only that it is not.