Clarify description of blockindex #7541
Conversation
|
utACK |
|
|
| @@ -1444,7 +1444,7 @@ UniValue listtransactions(const UniValue& params, bool fHelp) | |||
| " \"trusted\": xxx (bool) Whether we consider the outputs of this unconfirmed transaction safe to spend.\n" | |||
| " \"blockhash\": \"hashvalue\", (string) The block hash containing the transaction. Available for 'send' and 'receive'\n" | |||
| " category of transactions.\n" | |||
| " \"blockindex\": n, (numeric) The block index containing the transaction. Available for 'send' and 'receive'\n" | |||
| " \"blockindex\": n, (numeric) The position of the transaction in the block that includes it. Available for 'send' and 'receive'\n" | |||
There was a problem hiding this comment.
tiny nit: position seems slightly non-conventional?
The index of the transaction in the block that includes it.
There was a problem hiding this comment.
Agreed with this slight re-phrasing
There was a problem hiding this comment.
I'd prefer to stick with index too. It has a well-defined meaning, while position is too general (it could be a byte offset, or a set of 3D coordinates within the unit block...).
|
utACK 7f01e4e |
|
utACK |
|
ACK pinheadmz@ef40f6b after squash |
|
ACK ef40f6b0703fb2004183b85bdd2fb9e88b58b349. |
|
Before merging, can you please squash these changes into one commit? e.g. $ git rebase -i 8b70a64In the editor, replace the second 'pick' with 'f', then save and exit. git push -f origin master |
|
@laanwj thanks for your help |
7eef1d0 Clarify description of blockindex (Matthew Zipkin)
|
@laanwj I guess this could be backported to 0.12.1 Also, Post-merge ACK. |
see issues: bitcoin-dot-org/Bitcoin.org#1237 bitcoin#7532 Github-Pull: bitcoin#7541 Rebased-From: 7eef1d0
|
Backported as part of #7938. Removing label 'Needs backport'. |
see issues: bitcoin-dot-org/Bitcoin.org#1237 bitcoin#7532 Github-Pull: bitcoin#7541 Rebased-From: 7eef1d0
see issues:
bitcoin-dot-org/Bitcoin.org#1237
#7532