Add tags to mempool's mapTx indices #7539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK |
|
utACK 086da92 |
|
ping. If this looks fine to everyone it would be nice to have this merged, as it'll make some work I hope to PR soon on top of this somewhat cleaner. |
|
Concept ACK |
sipa
added a commit
that referenced
this pull request
Mar 5, 2016
086da92 Add tags to mempool's mapTx indices (Suhas Daftuar)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 19, 2017
086da92 Add tags to mempool's mapTx indices (Suhas Daftuar)
This was referenced Jul 4, 2020
furszy
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Oct 22, 2020
67f701c Add tags to mempool's mapTx indices (Suhas Daftuar) Pull request description: Straightforward back port bitcoin#7539 ACKs for top commit: random-zebra: utACK 67f701c Fuzzbawls: utACK 67f701c Tree-SHA512: 339e9252f68b4de89bdfa66c397e243170ca85b0721b81f66002b0059e2af6fcab3a7bb2e00fbaa4d568de1bf79389d762baa5d490649cc173c3fc8e93d53e11
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small refactor to how we use the boost multi_index in
CTxMemPool-- rather than have to use fixed index numbers in our code, I added some tags so that we can use logical names instead, so that e.g.nth_index<2>becomesindex<entry_time>.This was motivated by me rebasing some old work on to master, and I realized that the usage of fixed indices was error prone.
I didn't bother with a tag name for the zero-th index (txid), since nothing seems to explicitly use it, but I can add one if people think that'd be better.