RPC: do not launch Shutdown in a new thread in case we are running the UI #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leads to the bitcoin core being shut down while the UI is accessing it, and generally results in a segmentation fault or crash. In case it is desirable to make it possible to shutdown the GUI from its RPC server, we'll need to implement a signal for it. For the mean time, this is a safe stopgap.
| // Shutdown will take long enough that the response should get back | ||
| CreateThread(Shutdown, NULL); | ||
| return "bitcoin server stopping"; | ||
| #else | ||
| throw runtime_error("NYI: cannot shut down GUI with RPC command"); |
There was a problem hiding this comment.
I'm not familiar with the acronym "NYI" -- Nubile Young Icelanders ?
gavinandresen
added a commit
that referenced
this pull request
Nov 14, 2011
RPC: do not launch Shutdown in a new thread in case we are running the UI
coblee
referenced
this pull request
in litecoin-project/litecoin
Jul 17, 2012
RPC: do not launch Shutdown in a new thread in case we are running the UI
ptschip
pushed a commit
to ptschip/bitcoin
that referenced
this pull request
Jun 15, 2017
Small typo in allowed args for orphanpoolexpiry
fjahr
pushed a commit
to fjahr/bitcoin
that referenced
this pull request
Jul 24, 2019
ee9e68c Add a descriptive comment for secp256k1_ecmult_const. (Gregory Maxwell) Pull request description: Helps issue bitcoin#633 ACKs for commit ee9e68: Tree-SHA512: 552bebbd99bf8e8225ef6028e6a3bd188d412977d9c6caa90515041622accd2ea43e320217bf097180343921e967f4627a76c73e4529097bca50be414503e63b
rajarshimaitra
pushed a commit
to rajarshimaitra/bitcoin
that referenced
this pull request
Aug 5, 2021
Bump Bitcoin Core to latest version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leads to the bitcoin core being shut down while the UI is accessing it, and generally results in a segmentation fault or crash. In case it is desirable to make it possible to shutdown the GUI from its RPC server, we'll need to implement a signal for it. For the mean time, this is a safe stopgap.
Reproducing the bug:
Output:
Also changes the Warning to an Error (as it is kind of fatal, terminating the rpc thread).