Consensus: Consensus version of pow functions #6037
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing for now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes most of the undesired dependencies from the consensus pow functions.
CBlockIndex is still used, but only its attributes and none of the methods.
This is part of #5995.
It also relates with some miner PRs (like #4793 or #5957) since this will stop those log messages in regtest, allowing those PRs to use CheckProofOfWork directly in ScanHash. I believe that's something that at least @sipa and @21E14 will like.
Questions:
-Is it worth it to create miner::GetNextWorkRequiredLog() ?
-Should CheckProofOfWork() receive a reference to a CValidationState to be able to give the specific reason when it returns false?