Skip to content

Conversation

nl0x
Copy link

@nl0x nl0x commented Dec 13, 2011

This should fix #696 once translations are updated to reflect this change.

@laanwj
Copy link
Member

laanwj commented Dec 13, 2011

I agree with this change; you haven't only moved the \n outside the translated message but the flags themselves as well. This is good, as it allows changing the flags and white-space without affecting translations.

But a change like this does mean that all the translations have to be changed as well :/ Anyone up for the task?

@laanwj
Copy link
Member

laanwj commented Dec 16, 2011

I was wrong here -- the flags were already outside the translated text, it's just the \n that was moved out.

At least this makes it easier to fix up the other translations with a script.

@laanwj
Copy link
Member

laanwj commented Dec 16, 2011

You do need to re-run scripts/qt/extract_strings_qt.py after changing the strings in the core, so that the updated strings show up in the translations (are picked up by lupdate).

@gavinandresen
Copy link
Contributor

I'll write a little script to fix the translations.

Nils: how do changes get fed back into transifex?

@gavinandresen gavinandresen merged commit 43421af into bitcoin:master Dec 16, 2011
@nl0x
Copy link
Author

nl0x commented Dec 16, 2011

Changes to transifex: It should happen automagically (transifex is fetching the source file using a cronjob), but I can also force an update.

ptschip pushed a commit to ptschip/bitcoin that referenced this pull request Jul 21, 2017
dexX7 added a commit to dexX7/bitcoin that referenced this pull request Jul 30, 2018
78fe5fd Move setting properties of send-to-selfs into parsing (dexX7)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

german bitcoin-qt --help missing a lot of newlines in 0.5.0
3 participants