translations: Don't translate markup or force English grammar #6962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -312,8 +312,9 @@ void SendCoinsDialog::on_sendButton_clicked() | |||
| if(u != model->getOptionsModel()->getDisplayUnit()) | |||
| alternativeUnits.append(BitcoinUnits::formatHtmlWithUnit(u, totalAmount)); | |||
| } | |||
| questionString.append(tr("Total Amount %1<span style='font-size:10pt;font-weight:normal;'><br />(=%2)</span>") | |||
| .arg(BitcoinUnits::formatHtmlWithUnit(model->getOptionsModel()->getDisplayUnit(), totalAmount)) | |||
| questionString.append(tr("Total Amount %1") | |||
There was a problem hiding this comment.
Yes, this translation message was really ugly
|
utACK |
1 similar comment
|
utACK |
| @@ -499,6 +499,7 @@ std::string HelpMessage(HelpMessageMode mode) | |||
|
|
|||
| std::string LicenseInfo() | |||
| { | |||
| // todo: remove url's from translations on next change | |||
941ce42 to
6dd3a44
Compare
laanwj
added a commit
that referenced
this pull request
Nov 9, 2015
6dd3a44 translations: Don't translate markdown or force English grammar (MarcoFalke)
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Dec 18, 2019
Bitcoin 0.12 cleanup PRs 2 Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6631 - bitcoin/bitcoin#6664 - Only the first commit (we already had the second through bitcoin/bitcoin#6825). - bitcoin/bitcoin#6669 - bitcoin/bitcoin#6887 - Only the non-QT parts. - bitcoin/bitcoin#6962 - bitcoin/bitcoin#6822 - Only first and third commits (we already had the second through an earlier PR). - bitcoin/bitcoin#7136 - Excludes Travis CI changes, and fixes to documents we don't have anymore. - bitcoin/bitcoin#7084 - bitcoin/bitcoin#7509 - bitcoin/bitcoin#7617 - bitcoin/bitcoin#7726 Part of #2074.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.