Fix Boost 1.58.0 build for mips arch #6937
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK |
|
Though something is clearly going wrong in boost cross-compilation,
Arguably an upstream issue and it does make sense to include a workaround patch temporarily... |
|
Looks like this has been fixed upstream in boostorg/build@cbddcde |
|
Thanks @fanquake . Seems what they did is: Which is better as it explicitly defines which platforms can use -mXX (didn't know about power and sparc). An alternative would be to bump boost to 1.59 (which includes this). Seems to work fine in local testing. |
|
@theuni What do you think is best here? |
|
@laanwj Agree with a bump to 1.59. |
|
Closing in favor of #6980 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Boost 1.58 can't support build for MIPS32 on a x86_64 machine, the error message is" unrecognized command line option '-m32'". The Boost.Build for version 1.58.0 requires a patch for gcc.jam. This patch prevents bjam from adding -m32 and -m64 options to gcc compiler, when compiling for targets that use the mips1 arch.
Bug discussed here: openwrt/packages#1160