net: Disable upnp by default #6795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e977dcd to
e23ec46
Compare
Closed
e23ec46 to
2b54706
Compare
|
Right, fixed |
|
utACK |
|
NACK removal of configure option; please just change the options gitian uses so people don't need to hand-patch :( |
|
Concept ACK. I'm fine with removing the configure option, not sure we really need it. Its a very different world from when UPnP defaults were set, and I really dont think there is much need for either the GUI or bitcoind to default to UPnP on anymore. |
Common sentiment is that the miniupnpc codebase likely contains further vulnerabilities. I'd prefer to get rid of the dependency completely, but a compromise for now is to at least disable it by default.
2b54706 to
21d27eb
Compare
laanwj
added a commit
that referenced
this pull request
Oct 10, 2015
21d27eb net: Disable upnp by default (Wladimir J. van der Laan)
3 tasks
reddink
pushed a commit
to reddcoin-project/reddcoin-3.10
that referenced
this pull request
May 27, 2020
Common sentiment is that the miniupnpc codebase likely contains further vulnerabilities. I'd prefer to get rid of the dependency completely, but a compromise for now is to at least disable it by default. Rebased-From: 21d27eb Github-Pull: bitcoin#6795 (cherry picked from commit f2778e0) # Conflicts: # contrib/gitian-descriptors/gitian-win.yml
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Common sentiment is that the miniupnpc codebase likely contains further vulnerabilities (context: #6789).
I'd prefer to get rid of the dependency completely, but a compromise for now is to at least disable it by default, to prevent UPnP vulnerabilities being a structural danger to the network.
Also get rid of the confusing--[enable|disable]-upnp-defaultautoconf and define magic.Edit: needs backport to 0.11 and 0.10