Skip to content

Rewrite help texts for features enabled by default #6748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2015
Merged

Rewrite help texts for features enabled by default #6748

merged 1 commit into from
Oct 5, 2015

Conversation

paveljanik
Copy link
Contributor

As some features are enabled by default, configure --help should help the builder to disabled them. This PR changes configure --help output this way:

-  --enable-wallet         enable wallet (default is yes)
+  --disable-wallet        disable wallet (enabled by default)

-  --enable-tests          compile tests (default is yes)
+  --disable-tests         do not compile tests (default is to compile)

-  --enable-hardening      attempt to harden the resulting executables (default
-                          is yes)
+  --disable-hardening     do not attempt to harden the resulting executables
+                          (default is to harden)

-  --enable-ccache         use ccache for building (default is yes if ccache is
+  --disable-ccache        do not use ccache for building (default is to use if
                           found)

The other three occurrences (--enable-static, --enable-shared and --enable-fast-install) are unfortunately upstream...

@jonasschnelli
Copy link
Contributor

Was also thinking about this.
Thanks.

utACK.

@jgarzik
Copy link
Contributor

jgarzik commented Oct 2, 2015

ut ACK

@fanquake
Copy link
Member

fanquake commented Oct 3, 2015

utACK

1 similar comment
@petertodd
Copy link
Contributor

utACK

@laanwj laanwj merged commit 9ee5ac8 into bitcoin:master Oct 5, 2015
laanwj added a commit that referenced this pull request Oct 5, 2015
@laanwj
Merge pull request #6748
e10a4ab 
9ee5ac8 Rewrite help texts for features enabled by default. (Pavel Janík)
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Oct 22, 2015
[trivial] Rewrite help text for feature enabled by default
95f4291 
c.f bitcoin#6748
@str4d str4d mentioned this pull request Nov 12, 2019
Merged
zkbot added a commit to zcash/zcash that referenced this pull request Jan 30, 2020
@zkbot
Auto merge of #4222 - str4d:configure-updates, r=str4d
8e8a935 
./configure updates

Includes code cherry-picked from the following upstream Bitcoin Core PRs:

- bitcoin/bitcoin#6748
- bitcoin/bitcoin#12373
- bitcoin/bitcoin#12692
- bitcoin/bitcoin#12901
- bitcoin/bitcoin#13005
- bitcoin/bitcoin#13445
- bitcoin/bitcoin#12686
- bitcoin/bitcoin#16435

Part of #2074.
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@paveljanik @jonasschnelli @jgarzik @fanquake @petertodd @laanwj