Simple mempool protect #6673
Closed
Simple mempool protect #6673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indexes on: - Tx Hash - Fee Rate (fee-per-kb)
Associate with each CTxMemPoolEntry all the size/fees of descendant mempool transactions. Sort mempool by max(feerate of entry, feerate of descendants). Update statistics on-the-fly as transactions enter or leave the mempool. Also add ancestor and descendant limiting, so that transactions can be rejected if the number or size of unconfirmed ancestors exceeds a target, or if adding a transaction would cause some other mempool entry to have too many (or too large) a set of unconfirmed in- mempool descendants.
|
Seems to work (bitcoind master with -maxmempool=1): Green line (dynamic mem usage) keeps under 1MB: |
|
concept ACK, a lot of code though |
|
Somehow I can't see the new log messages "insufficient fee for mempool size" or "mempool full hard cap" in my debug.log. Maybe its worth analyzing why.. it looks like that the transactions get always rejected because of |
Introduce a maximum mempool size and a mininmum relay fee rate multiplier that increases by 10% for every 2% of the maximimum mempool size. Free transactions are disallowed after the first 2% band.
cc31c01 to
495dd9b
Compare
|
Closing in favor of #6722 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built off of #6654, this implements an exponential rising effective min relay feerate. This version implements 50 bands of 10% increase which is slightly over 100x at the top end. Thus 100x the configured min relay rate must be more than enough to dissuade spam.