Fix race condition on test node shutdown #6509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK |
| def wait_for_disconnections(self): | ||
| def disconnected(): | ||
| return all(node.closed for node in self.test_nodes) | ||
| wait_until(disconnected, timeout=10) |
There was a problem hiding this comment.
Maybe return wait_until so that callers know whether it succeeded or timed out? (same for other wait_for_XXX)
There was a problem hiding this comment.
Seems reasonable to me, changed.
laanwj
added a commit
that referenced
this pull request
Aug 17, 2015
45a6cce Fix race condition on test node shutdown (Casey Rodarmor)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a race condition where the block store or the transaction store might be accessed after being closed. To fix this, we wait until all connections are closed before closing the stores.
This race condition is tricky to trigger, but I hit it when writing an extended block acceptance test.