63d1ae5 Do all block index writes in a batch (Pieter Wuille)

63d1ae5 Do all block index writes in a batch (Pieter Wuille)

(cherry picked from commit dcc1304)

Backport from bitcoin bitcoin#5367

e515b1e [Node] Do all block index writes in a batch (Pieter Wuille)

Pull request description:

  Backport from bitcoin bitcoin#5367

ACKs for commit e515b1:
  Mrs-X:
    ACK e515b1e
  furszy:
    ACK [e515b1e](e515b1e)

Tree-SHA512: 8eff741bcbe357b7f6af0d1aea627f77498543efd117173ab2b4c325c3bc3ef3e761b6f4ad7cf70379b55daf68724bed2e10fe22a273b0fc1c3009fac8008a60

e515b1e [Node] Do all block index writes in a batch (Pieter Wuille)

Pull request description:

  Backport from bitcoin bitcoin/bitcoin#5367

ACKs for commit e515b1:
  Mrs-X:
    ACK PIVX-Project/PIVX@e515b1e
  furszy:
    ACK [e515b1e](PIVX-Project/PIVX@e515b1e)

Tree-SHA512: 8eff741bcbe357b7f6af0d1aea627f77498543efd117173ab2b4c325c3bc3ef3e761b6f4ad7cf70379b55daf68724bed2e10fe22a273b0fc1c3009fac8008a60

Squashed update of following commits:

From 6e7cdd5a072fdc69e49670dc99626f51163e9972 Mon Sep 17 00:00:00 2001
From: observerdev <dev@obsr.org>
Date: Tue, 2 Jul 2019 01:15:00 +0200
Subject: [PATCH] Squashed commit of the following:
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

commit 924ec4f6ddb35209f732d00288c80f9eff61a800
Merge: 92aa6c2da e515b1e9f
Author: Mrs-X <Mrs-X@users.noreply.github.com>
Date:   Tue Jun 25 22:52:54 2019 +0200

    Merge #932: [Node] Do all block index writes in a batch

    e515b1e [Node] Do all block index writes in a batch (Pieter Wuille)

    Pull request description:

      Backport from bitcoin https://github.com/bitcoin/bitcoin/pull/5367

    ACKs for commit e515b1:
      Mrs-X:
        ACK https://github.com/OBSR-Project/OBSR/pull/932/commits/e515b1e9f2309d27efea69beae6569ee92178d88
      furszy:
        ACK [e515b1e](https://github.com/OBSR-Project/OBSR/pull/932/commits/e515b1e9f2309d27efea69beae6569ee92178d88)

    Tree-SHA512: 8eff741bcbe357b7f6af0d1aea627f77498543efd117173ab2b4c325c3bc3ef3e761b6f4ad7cf70379b55daf68724bed2e10fe22a273b0fc1c3009fac8008a60

commit 92aa6c2daa3a0c10d15587a67bdb4e3f2e6d8367
Merge: 7e8855d91 7b4680a88
Author: Mrs-X <Mrs-X@users.noreply.github.com>
Date:   Tue Jun 25 22:46:08 2019 +0200

    Merge #934: [Build] Bump master to 3.3.99 (pre-3.4)

    7b4680a [Build] Bump master to 3.3.99 (pre-3.4) (Fuzzbawls)

    Pull request description:

      Now that 3.3 has been branched off, bump master to 3.3.99 (pre-3.4).
      Gitian descriptors reflect this as well.

    ACKs for commit 7b4680:
      Mrs-X:
        utACK https://github.com/OBSR-Project/OBSR/pull/934/commits/7b4680a881dcaddba82bddbd3161506358c99ac7

    Tree-SHA512: b582d3f9ede816d28902991e8b891a8e56261dcf9a857cdbc5af1787add52c402a66c0eebf1cfc8197dee7dc295a3410406f2e4e347e078232e9f4d2036459bb

commit 7b4680a881dcaddba82bddbd3161506358c99ac7
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 22 15:12:35 2019 -0700

    [Build] Bump master to 3.3.99 (pre-3.4)

    Now that 3.3 has been branched off, bump master to 3.3.99 (pre-3.4).
    Gitian descriptors reflect this as well.

commit e515b1e9f2309d27efea69beae6569ee92178d88
Author: Pieter Wuille <pieter.wuille@gmail.com>
Date:   Tue Nov 25 16:26:20 2014 +0100

    [Node] Do all block index writes in a batch

    Backport from bitcoin https://github.com/bitcoin/bitcoin/pull/5367

commit 7e8855d910f89ce478698a6dbcc5499dfc836cf1
Merge: 2482572f8 c447aecc1
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Tue Jun 18 03:00:40 2019 -0700

    Merge #929: [Net] Update hard-coded seeds

    c447aecc1b [Net] Update hard-coded seeds (Fuzzbawls)

    Pull request description:

      Updated hard-coded seeds based on uptime and availability from primary
      DNS seeder.

    ACKs for commit c447ae:

    Tree-SHA512: 4ca56e41e277092093eead76fbc229a130bb786790c784a91e0d78a724f35a6e6594c4daa82a9dda88f7ed2eae441bc371fa2b4ab3d50d203d518d667ecbd2a9

commit 2482572f89a3ac3854c6365e7fbef0e1a3480ca2
Merge: 49a69b893 6d642ba5d
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Tue Jun 18 03:00:01 2019 -0700

    Merge #928: [Qt] Update Translations

    6d642ba5d9 Update translations from Transifex (Fuzzbawls)
    d1b54b69b4 make translate (Fuzzbawls)

    Pull request description:

      Updates the source strings as well as pulls any new translations from Transifex

    ACKs for commit 6d642b:

    Tree-SHA512: ccde28ab2ec914a412dc004a13fb7a93a5e0476dab1d65d3d35b362b62cf8e95b73164be48618e4d884a0e0e439a1a43fdf9351567b09ffb46bee004d8149567

commit 49a69b89317ce166e30054ce52b52ef4a50ad658
Merge: 5061b486c cd1169993
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Tue Jun 18 02:59:18 2019 -0700

    Merge #926: [Doc] 3.3.0 Notable Changes

    cd11699936 [Doc] 3.3.0 Notable Changes (Fuzzbawls)

    Pull request description:

      Notable changes for 3.3.0

      #ci-skip

    ACKs for commit cd1169:

    Tree-SHA512: 6cb841dd65873c1c3cc7c7b03ab672ae17e0945e9872b3f53a4accf6b919f46aab9fbdc95753fd159cda88db86f2fcc087a15a3e1605fda170a99b6c50e0f7e9

commit 5061b486c2472d8dfdca54b082c6463d1a7db8e3
Merge: 048d1295d ab441f372
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Tue Jun 18 02:55:41 2019 -0700

    Merge #930: [Net] Add a couple new testnet checkpoints

    ab441f3728 [Net] Add a couple new testnet checkpoints (Fuzzbawls)

    Pull request description:

      1. `1106100` height that zc public spends became available
      2. `1112700` random recent testnet block that meets criteria

    ACKs for commit ab441f:

    Tree-SHA512: c138a71939e66a0a9ac598a25f6984c4f05f846533ded2a90f0430c7d71608baf81e48e8bd3ca71206794f3212c2f9e3e8ed5cd282f9c9d02a38db61f7585e85

commit 048d1295dcca447bb033d04465a298b9d409e6cf
Merge: 3323f2684 ef8df80d7
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Tue Jun 18 02:50:14 2019 -0700

    Merge #927: [Trivial] Update header copyright years

    ef8df80d78 [Trivial] Update header copyright years (Fuzzbawls)

    Pull request description:

      This updates the PIVX copyright year in file headers to the year that
      they were last updated.

    ACKs for commit ef8df8:

    Tree-SHA512: 7a343e6a0727962e5f3fb404e388f844c355c6318b4eb777562553744e54f0f475d1c7955c22158da21f2e660c286d5dc08a95296f9a7aa9ca2e2705892f6a6e

commit cd11699936c3c7c776c3deed9a39e984d17b2543
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Mon Jun 17 17:11:59 2019 -0700

    [Doc] 3.3.0 Notable Changes

commit ab441f3728652cb53bfc003795790abd0fbc2fb4
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Tue Jun 18 01:20:56 2019 -0700

    [Net] Add a couple new testnet checkpoints

    1. `1106100` height that zc public spends became available
    2. `1112700` random recent testnet block that meets criteria

commit 6d642ba5d92164b7e547ea8da9721bb426475e86
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Tue Jun 18 00:21:44 2019 -0700

    Update translations from Transifex

commit c447aecc1b84e3e7679c9d4a3c4395a22c17817c
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Tue Jun 18 00:36:08 2019 -0700

    [Net] Update hard-coded seeds

    Updated hard-coded seeds based on uptime and availability from primary
    DNS seeder.

commit ef8df80d783b4d4871bc74c658693ac1b670a84e
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Mon Jun 17 23:46:50 2019 -0700

    [Trivial] Update header copyright years

    This updates the PIVX copyright year in file headers to the year that
    they were last updated.

commit d1b54b69b4e8dc325fabb52019e281e2276d837e
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Mon Jun 17 23:34:54 2019 -0700

    make translate

commit 3323f26848d02bad4e6592d0440dfa106d51a88b
Merge: a9827a0e6 fe67706fd
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Mon Jun 17 23:25:16 2019 -0700

    Merge #824: [Refactor] Remove stale obfuscation code

    fe67706fd2 Remove more useless obfuscation code (Fuzzbawls)
    eed0a1d34e Remove more useless obfuscation code (Fuzzbawls)
    3bb5c768bf Remove unused functions in wallet.cpp (Fuzzbawls)
    166b2d31c8 Remove nAnonymizeObsrAmount and nLiquidityProvider (Fuzzbawls)
    886d806f58 Remove unused code in DoAutomaticDenominating (Fuzzbawls)
    742a7b187c [Qt] Remove unused obfuscationconfig (Fuzzbawls)

    Pull request description:

      Removal of "dead" code surrounding the defunct obfuscation feature.

      Obfuscation as a usable feature was removed in November 2017, but much of it's underlaying code remained. This PR aims to clean up and remove the now unnecessary code.

      Marking as [WIP] for the time being.

    ACKs for commit fe6770:
      random-zebra:
        ACK https://github.com/OBSR-Project/OBSR/commit/fe67706fd222168e4bb6a387566a48dbd667638c

    Tree-SHA512: 46ab7d035aa899677d1337c6a58def25e452c24db038b769e9e6f980ac43e03a34af968114facadcd62ec93eacf41de0a385f60d91630a0ac8425cd385d9a513

commit a9827a0e638910e582e02fd78f1d91b928dc4402
Merge: 484c070b2 88705a609
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Mon Jun 17 23:15:11 2019 -0700

    Merge #925: [Consensus] Time checks

    88705a6099 [Consensus] Guard time checks changes (warrows)
    105ee5fd07 [Consensus] Readd checks removed in 3b778f56fe2b5e5b363c8c6d794a848a84d630d1 (warrows)
    2621b7f3f7 [Refactoring] Move ContextualCheckZerocoinStake() to kernel.cpp (warrows)

    Pull request description:

      Two checks on the age of a transaction used to stake were removed by mistake in 3b778f5. We reintroduce them here.
      2621b7f is a bit of refactoring
      105ee5f is the real change
      88705a6 avoid checking blocks already in the blockchain

    ACKs for commit 88705a:
      furszy:
        ACK 👌  [88705a6](https://github.com/OBSR-Project/OBSR/pull/925/commits/88705a6099f0c42d122c5717fccd08f6485f0b0a)
      Fuzzbawls:
        ACK 88705a6

    Tree-SHA512: 13397aac35b1d8c6680993ba90a1266113baf25bd16410f408d7d16f9eaa93f7cd0f665224959c64dfac5725bdacc25bead9d65cd8d9bdcd5570b9434ebd851a

commit 484c070b229d3be0fad1a4a05c424ce5712a6187
Merge: 893183339 eea991536
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Mon Jun 17 23:09:35 2019 -0700

    Merge #911: [RPC] add 'getblockindexstats' function

    eea9915361 [RPC] fix locking strategy (random-zebra)
    49ef846774 [RPC] fix help texts (random-zebra)
    26b1f0ca33 [RPC] 'getblockindexstats': count public spends separately (random-zebra)
    7980f23c0c [RPC] fix fee calculation in 'getblockindexstats' and 'getfeeinfo' (random-zebra)
    689ac23f62 [RPC] add 'getblockindexstats' function (random-zebra)

    Pull request description:

      This introduces a new RPC method `getblockindexstats` to get aggregated BlockIndex data for a range of blocks:
      - transaction count
      - transaction count (including coinbase/coinstake txes)
      - zOBSR per-denom mint count
      - zOBSR per-denom spend count
      - total transaction bytes
      - total fees in block range
      - average fee per kB

      Since it expands the functionality of `getfeeinfo`, this method has been redirected to call `getblockindexstats` (over the **last** N blocks).

      To avoid code duplication with `getserials` and `getmintsinblocks`, the initial validation of the input params has been refactored in the function `validaterange()`.
      This also contains a fix to prevent the wallet from crashing when calling these functions over out-of-range blocks.

    ACKs for commit eea991:
      Fuzzbawls:
        ACK eea9915
      Warrows:
        ACK eea9915

    Tree-SHA512: fd424d27b09133f8e1b646044f6e48cb7be8e7b7f6bbe51797b229e7e1c5d721226022915876d3810b38e7c2eb6bb089a7e3b8df2b0487ac251bde405e1f964a

commit 893183339ec09e338ccb2b80bec7797d14eb25d8
Merge: a56cc2948 0608b9ca9
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Mon Jun 17 23:07:14 2019 -0700

    Merge #921: [Scripts] Overhaul supplemental python/shell scripts

    0608b9ca95 Misc updates (Fuzzbawls)
    616b1d531c Introduce clang-format-diff.py (Fuzzbawls)
    0367807d49 Introduce commit-script-check.sh (Fuzzbawls)
    28bd93359a Update gitian-build.py (Fuzzbawls)
    b0d7d07512 Update github-merge.py (Fuzzbawls)
    fe7bf507d4 Introduce gen-manpages.sh (Fuzzbawls)
    035dda7458 Introduce circular-dependencies.py (Fuzzbawls)
    70721b47ac Migrate update-translations.py to python3 (Fuzzbawls)
    1558ff775e Update install_db4.sh (Fuzzbawls)
    5c92f16656 Add multi-purpose copyright header script (Fuzzbawls)

    Tree-SHA512: 3cc0637288fe059c340bbaee8e5eda794df985280b739d8a976e6eaa7938bb24eb2bf554c4d1552cc5f45adcd1f1380e4ea390029ed9024f97bf80071918b9f4

commit a56cc2948d4a80b5698da90c4d15c417e697e8db
Merge: 95b584eff d24742cf3
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Mon Jun 17 23:01:48 2019 -0700

    Merge #920: [Docs] Overhaul documentation files

    d24742cf37 Remove redundant docs (Fuzzbawls)
    007cc8c289 Update src/test/README.md (Fuzzbawls)
    d2af9593e4 Introduce translation_strings_policy.md (Fuzzbawls)
    019b8f4e8c Update contrib/devtools/README.md (Fuzzbawls)
    2bc9d1b0f1 Update developer-notes.md (Fuzzbawls)
    d1a65fdcaf Update dnsseed-policy.md (Fuzzbawls)
    0b5c0c262b Update release-process.md (Fuzzbawls)
    9335a103d1 Update test/functional/README.md (Fuzzbawls)
    20f251336a Update doc/README.md (Fuzzbawls)
    5b4f73def6 Clean up whitespace in Doxyfile.in (Fuzzbawls)
    3cea76be03 Update and reformat init.md (Fuzzbawls)
    2f5efbd12c Reformat files.md (Fuzzbawls)
    df0d2ba1fe Introduce dependencies.md (Fuzzbawls)
    785b61cf56 Update zmq.md (Fuzzbawls)
    231f28e696 Update translation_process.md (Fuzzbawls)
    c5f6822af5 Update tor.md (Fuzzbawls)
    b7d0ec7696 Fix markdown in REST-interface.md (Fuzzbawls)
    4fa4cc4ff2 Update Contributing guidelines (Fuzzbawls)
    a544132207 Update build notes (Fuzzbawls)

    Tree-SHA512: ab422791c3e43d6e455d648c9b6b30943c176e03d2a0702135184108c8887bb39e4bb9c51bab9f9a04a130a297f8db879563e3b45f010c6b1f34482122b78681

commit 95b584effd1f090c3c44372e8a8f902ab1ca332d
Merge: 6f597629d 8695fd5fb
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Mon Jun 17 22:46:21 2019 -0700

    Merge #908: [NET] Non-running dns servers removed from chainParams.

    8695fd5fb5 Non-running dns servers removed + warrows dns added. (furszy)

    Tree-SHA512: ad98e116255c919d1f0765585578afdb64e0368393faa1954bf23162e705165aa11c8d810ac913bd0c7325a0da096fd99535de5cb66778ad5be15f6a5d81b8c8

commit 6f597629d80874dc95a73c08a5c2e7f488e78968
Merge: b38ef0483 9c0329c72
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Mon Jun 17 21:12:52 2019 -0700

    Merge #904: [zOBSR] Free memory from ToString()

    9c0329c72b [zerocoin] Free memory from ToString() (warrows)

    Tree-SHA512: c04bfcf1af3b9fd95cf6aa653367043d4a973805c37e820b3127a3198efbdb0f83eb82d8084409f17e059e44e7c653666899a5733dd1f272d0829ae0ceee388d

commit b38ef048389c6ba57d07c334fcc1cd7d0a8b4971
Merge: 473976c61 342f0341d
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Mon Jun 17 17:14:48 2019 -0700

    Merge #917: [Build] TravisCI Update

    342f0341de Disable known failing regression tests (Fuzzbawls)
    a5f887b00e [Travis] Update TravisCI from upstream (Fuzzbawls)

    Tree-SHA512: 0cf866696ffb6cff539a1412c95f1f10a6e031629f153aa9a01b5326b77bc7de53912c36d254c859e437d7c3035f466d3b3db79aab26cec4767c75e45e16559a

commit 473976c61925fd374e1964401bf0d9038a3be60c
Merge: 988b33dab d2136e30e
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Mon Jun 17 17:12:42 2019 -0700

    Merge #913: [Depends] Update from upstream

    d2136e30e0 depends: Update from upstream (Fuzzbawls)

    Tree-SHA512: 9ce1b15170113cd207090f8986efd809cc6f4859132140e1c09f573e1015115ff82d961d7fc21375f8a5346de6bea656bb3bfb190ab95c60c080145d8ea67137

commit 88705a6099f0c42d122c5717fccd08f6485f0b0a
Author: warrows <warrows@gamer666.fr>
Date:   Mon May 20 12:46:51 2019 +0200

    [Consensus] Guard time checks changes

    Guard these changes against the protocol version change enforcement

commit 105ee5fd078cf20854a18a4ec879adcfdda9970d
Author: warrows <warrows@gamer666.fr>
Date:   Tue Apr 23 16:54:10 2019 +0200

    [Consensus] Readd checks removed in 3b778f56fe2b5e5b363c8c6d794a848a84d630d1

    Two importants checks were removed while refactoring to add zOBSR
    staking. Their equivalents were added to zOBSR staking but missing for
    simple OBSR staking. We add them back with this commit.

commit 2621b7f3f7da1516472320255fa5b243ac40b750
Author: warrows <warrows@gamer666.fr>
Date:   Tue Apr 23 16:33:35 2019 +0200

    [Refactoring] Move ContextualCheckZerocoinStake() to kernel.cpp

    And call it in CheckProofOfStake() which is called by AcceptBlock()
    instead of calling it directly from AcceptBlock().

commit 0608b9ca95e96b0f34d02a9523cc0bdf05f3a1a9
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 03:57:17 2019 -0700

    Misc updates

commit 616b1d531ca907d9c2667b46920c4e686497289a
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 03:57:03 2019 -0700

    Introduce clang-format-diff.py

    This script can be used to format a diff to adhere to clang-format

commit 0367807d49ec9618725b31c5817501f51b751bf9
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 03:56:26 2019 -0700

    Introduce commit-script-check.sh

    This script can be used to verify scripted diff commits

commit 28bd93359abd5ed71b897cdf44e0bbfd48fe186f
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 03:55:34 2019 -0700

    Update gitian-build.py

    latest version from upstream, OBSRified

commit b0d7d07512ca2a27051699d06be206e0556f1fca
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 02:50:53 2019 -0700

    Update github-merge.py

commit fe7bf507d4c6b641033af0717c1156e32423cb15
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 02:47:33 2019 -0700

    Introduce gen-manpages.sh

    Script to update the man files in `doc/man/`

commit 035dda7458dc619b57bad4d0f501687b21b7c3e8
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 02:46:46 2019 -0700

    Introduce circular-dependencies.py

    This script can be used to find circular include dependencies in the
    code base. These should eventually be weeded out.

commit 70721b47acc89156c07bbec1f8779bb393ddd8c0
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 02:45:15 2019 -0700

    Migrate update-translations.py to python3

commit 1558ff775eb60bc416a1e443a74ea6210729bd93
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 02:44:34 2019 -0700

    Update install_db4.sh

commit 5c92f166568a3e7929c530ffac2fd3605ddbfa37
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 02:43:39 2019 -0700

    Add multi-purpose copyright header script

    This script includes options for reporting, adding, and updating
    copyright headers.

commit d24742cf372fd2c1e2ce9c01d276bfa4b6ffe302
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 02:11:16 2019 -0700

    Remove redundant docs

    These doc files are either completely redundant (documentation exists
    in-wallet/in-rpc, or more comprehensive guides elsewhere), or were left
    over fragments from when the code fork was done.

commit 007cc8c2893cbc5363abdbabd782b1e7b1fa2c8e
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 01:55:01 2019 -0700

    Update src/test/README.md

    Update the in-tree README.md with the contents of `doc/unit-tests.md`,
    and delete the redundant doc file.

commit d2af9593e4eef9d2e54c74a9f215ad05a2bc1280
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 01:43:48 2019 -0700

    Introduce translation_strings_policy.md

    Adds guidelines for adding new translation strings in the code

commit 019b8f4e8c36d58947beac66b12f4ea9eab9fe5d
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 01:38:04 2019 -0700

    Update contrib/devtools/README.md

    Prep for new/renamed scripts

commit 2bc9d1b0f1721a2e260a3b6569fe59d71bb45b4f
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 01:37:16 2019 -0700

    Update developer-notes.md

    Add TOC and expand on style guidelines as well as better describe
    testing cases.

commit d1a65fdcafe0fad1ea80af18ad1caa501830e013
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 01:35:18 2019 -0700

    Update dnsseed-policy.md

    grammatical fixes

commit 0b5c0c262b5f1b9a4aff4353885f179fc9766fbf
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 01:34:01 2019 -0700

    Update release-process.md

    Minor formatting and grammatical changes. Remove stale reference to the
    aarch64 gitian descriptor.

commit 9335a103d11a013e72cd51eba0c5c88b2cdfac8d
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 01:26:03 2019 -0700

    Update test/functional/README.md

    Added more details regarding the purpose, writing, and use of the
    regression test suite.

commit 20f251336a0e8af25147e1d03d39f3af45e97f28
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 01:24:22 2019 -0700

    Update doc/README.md

    Fix namings, outdated links, and sample commands

commit 5b4f73def60b63c5b1a80d7ea454d846a3322c4a
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 01:21:28 2019 -0700

    Clean up whitespace in Doxyfile.in

commit 3cea76be03aae8cd23d5b076ad187929a418f484
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 01:13:45 2019 -0700

    Update and reformat init.md

commit 2f5efbd12c2e427aa3b5f4738ed1a5d03985f756
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 01:12:11 2019 -0700

    Reformat files.md

    Changed to markdown table layout for ease of reading. Removed old
    bitcoin-only information for older versions that we never used.

commit df0d2ba1fe0bf61522236c6cd03d0c94010926e8
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 01:11:11 2019 -0700

    Introduce dependencies.md

    This file contains explicit dependency information used for release
    builds (version, link, etc).

commit 785b61cf5643f98113d4acbce7683bd11316e48b
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 01:07:34 2019 -0700

    Update zmq.md

    Typo fixes and update python to python3 in sample commands

commit 231f28e6964980580646a020215345f1c15cc14a
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 01:06:34 2019 -0700

    Update translation_process.md

    Fix some typos and refresh with more current information.

commit c5f6822af58e4312fdc97ec6e2d2264117cc27e9
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 01:05:22 2019 -0700

    Update tor.md

    Updated to consider more recent versions and features of the tor router
    (automatic hidden service creation/deletion).

commit b7d0ec7696f2f059cb78846af42e75c8d3675e1c
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 01:03:42 2019 -0700

    Fix markdown in REST-interface.md

commit 4fa4cc4ff25693306534495e2121b603f444542a
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 01:02:29 2019 -0700

    Update Contributing guidelines

    Mainly punctuation and styling changes. Added a section about rebasing
    pull requests.

commit a544132207c1386d9098a9aa8962d04dabfe5f09
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 01:01:09 2019 -0700

    Update build notes

    Also, remove the now redundant README_osx.md file

commit 988b33dab8d82d8a2c9cd77ac8c8e0665bf962c2
Merge: 5a43ea790 46ba7a2b9
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Mon Jun 17 03:28:39 2019 -0700

    Merge #924: [Backport] Max tip age to consider a node in IBD status customizable.

    46ba7a2b96 [Backport] Max tip age to consider a node in IBD status customizable. Backport from bitcoin##7208. (furszy)

    Tree-SHA512: 211479d05cc8226d0bdaa3432204467679b465dfdbcdcf58650ec2fcb415c60544f3ae354f8b460adc6cd7e2d56ce6b3a52dd77ac92017eb7f66d98a76051bb2

commit 8695fd5fb567251f10f65cb10ca1f6b104bcf57c
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Wed Jun 5 01:58:12 2019 +0200

    Non-running dns servers removed + warrows dns added.

    dns servers cleanup

    dns servers, add warrows servers

commit 5a43ea790ac6e772d6e1c3b7f485ff88e3c1995a
Merge: 0f98fd4d3 55127d126
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sun Jun 16 21:23:04 2019 -0700

    Merge #914: [Gitian] Bump gitian build versions

    55127d1264 [Gitian] Bump gitian build versions (Fuzzbawls)

    Tree-SHA512: 29c6681b76adfb69b2f741d9f50575da0f870df8b822cb2886e10f6d364713221db0a94b017de3e89943e6e52d3aa2d7856604f092b73af14caa0ab9dc0b21bc

commit eea9915361800081de7c27c0ba546766fca56732
Author: random-zebra <random.zebra@protonmail.com>
Date:   Mon Jun 17 02:30:42 2019 +0200

    [RPC] fix locking strategy

    - validaterange
    - getfeeinfo
    - geblockindexstats
    - getmintsinblocks
    - getserials

commit 0f98fd4d3fd5b0aa1287eb5763e7f97d344e962a
Merge: a4f02ed94 45ea523e1
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sun Jun 16 16:01:52 2019 -0700

    Merge #922: [Build] Fix app name casing in mac deploy related files

    45ea523e1a [Build] Fix app name casing in mac deploy related files (Fuzzbawls)

    Tree-SHA512: 79fd711f3db52e418f42b7cdcf26a4a68456e6727b1362837745eacfe1797eb8fb33a8a86812158c1e833862fca7fedc5e55ef0fa5d4a2d7eff654c646ea8214

commit a4f02ed94624c184318ca58e37e42d90c35cff37
Merge: c0233e4af 24d72d0f6
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sun Jun 16 00:37:29 2019 -0700

    Merge #916: [Staking] Don't assert if we were beaten to the block

    24d72d0f64 [code review] LogPrintf nit change (CaveSpectre11)
    019d26ac4c Don't assert if we were beaten to the block (CaveSpectre11)

    Tree-SHA512: 9818319df999ba21fb6f89dadf254f76ad02d14b4f35fcae5b8d9a6251a0be5212650f3834a61a90fad2a9e8ce242751a9c09f7325c9cccc60223a59a6b3f22c

commit 46ba7a2b963d861a374077fa613bab60def6e447
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Sun Jun 16 01:43:42 2019 +0200

    [Backport] Max tip age to consider a node in IBD status customizable. Backport from bitcoin##7208.

commit 45ea523e1a1d2f9ec9ba6fc9a4b73ba9c30d4ae3
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 14:53:19 2019 -0700

    [Build] Fix app name casing in mac deploy related files

    The app bundle's filename is `OBSR-Qt.app`, not `Obsr-Qt.app`.

commit c0233e4af6a4b9e6432904dad97e9798aae54fa7
Merge: 0417d52ef addeb0ac0
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 15 04:13:10 2019 -0700

    Merge #919: [zOBSR] Debug missing jump line.

    addeb0ac06 Update accumulators.cpp (Matias Furszyfer)

    Tree-SHA512: 56de08723ba12cb2b7f96b66ed5d6ee2c3912be6397ef1eb56b16d8c805425415b288d9b176981b8e720c6f195acdbfc1156bed5f7c31dcd9547a790cb585a52

commit 49ef846774e88698879f30ea1286da9cac66ccbd
Author: random-zebra <random.zebra@protonmail.com>
Date:   Sat Jun 15 11:46:52 2019 +0200

    [RPC] fix help texts

    - getblockindexstats
    - getmintsinblocks
    - getserials

commit 24d72d0f64eb7c4aff220e0e9401e31390b98737
Author: CaveSpectre11 <36988814+CaveSpectre11@users.noreply.github.com>
Date:   Fri Jun 14 19:45:55 2019 -0400

    [code review] LogPrintf nit change

commit addeb0ac0619d55c869eb346865b47dfea6cd1aa
Author: Matias Furszyfer <matiasfurszyfer@protonmail.com>
Date:   Fri Jun 14 15:12:33 2019 +0200

    Update accumulators.cpp

commit 0417d52ef9645fee98270277ea1a2ad508f835e9
Merge: 07c8fb8f8 c424f0f24
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Thu Jun 13 22:50:00 2019 -0700

    Merge #895: [QT] Options UI cleanup

    c424f0f244 Fix margins (Alko89)
    2d052155ff Hide zobsr related options. (Alko89)

    Tree-SHA512: 2944f28e4d2b4baa901a5c1a4bb991eb07bb81d33c285ec32971fa9485522320a6f583f5346c7fadceb2ab0e484f0cba521dc436cfa1586f75bfa05f13eeac9a

commit 07c8fb8f8896dcbb58e6084fb4867d8b1164bab5
Merge: 8a47747b5 b75d8bc0b
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Thu Jun 13 19:32:06 2019 -0700

    Merge #910: [Build] Clean all coverage files during make clean

    b75d8bc0bb [Build] Clean all coverage files during make clean (Fuzzbawls)

    Tree-SHA512: 5f0e0a4795ea770cabf326c91aea24094de9193684a295f82aa38b42840b0ea38f1a119ba30c6c20eedd1862f22133b66e606912da0f93b420e9ca0549704f41

commit 8a47747b596e113b673ccd2f11cd0da7714b575b
Merge: 8adeeb972 ca2fd101b
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Thu Jun 13 18:01:05 2019 -0700

    Merge #906: [Build] Add CMake Support

    ca2fd101ba use non-Cellar OpenSSL path for macOS (Fuzzbawls)
    69b0032749 fix config.h include file name (Fuzzbawls)
    d413496b01 [Build] Initial CMake support (Fuzzbawls)

    Tree-SHA512: 459d881a6128027c1b1fe6df13b0dce5fe484af377afece74ccc135a5e5ea320496165ffbdef70d806bd879be7cad39d4bfc3cdffbacfc2a61d0c8e53265b0ab

commit 8adeeb9727f0ecf13a4f5290dede8cefd014270a
Merge: be3aab4a0 c84e0e83b
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Thu Jun 13 16:24:34 2019 -0700

    Merge #902: [Tests] Add tests for CAddrMan

    c84e0e83ba [Code Style] Remove std namespace in test file (warrows)
    3355c86cce Increase test coverage for addrman and addrinfo (Ethan Heilman)
    d4da01588b Creates unittests for addrman, makes addrman testable. (EthanHeilman)

    Tree-SHA512: cd960109d8f3bdc46dfd58da2136a748aa8ecb1b3bacfa031af0a1544bd90514fe71b8fc63650e61c5872c7a42febc986616252550a71c510bdc7f9e1ab87e0f

commit be3aab4a00d56529abd8c69dc4076bbc5e5c0caa
Merge: 5f167c2c7 f3308f404
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Tue Jun 11 15:48:09 2019 -0700

    Merge #901: [RPC] Fix typos and oversights in listunspent

    f3308f404d Fix typos and oversights in listunspent (CaveSpectre11)

    Tree-SHA512: b6a4651b5ee27cf757e9effa1d692020823d7c4bbd66a56c990252fc80f7f3333abb1313b37a01f5d444f333c0d4782d4607ca5e4179cf4bac6db5a86cc15f78

commit 5f167c2c7efb59f8c2d2a5946fd1cad1d42b1fd2
Merge: 68c81c407 f912182d2
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Tue Jun 11 15:45:46 2019 -0700

    Merge #912: [Cleanup] compiler warnings in coinSpend object.

    f912182d27 [Cleanup] clang compiler warnings in coinSpend and publicCoinSpend fixed. (furszy)

    Tree-SHA512: 58dbe73519a8eece2a824a19f37b5219c1e189e395afc61f9fcfa54f195befd9f7a49500c4147684a9b58e96fa7ff7906fa956ae8ac249dc7094faaa6cd4a4b6

commit 342f0341de1fad3822a492073c2bba8daf41abff
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Mon Jun 10 22:46:50 2019 -0700

    Disable known failing regression tests

commit a5f887b00e7fd1d9625d869a5b39717200160241
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sun Jun 9 16:18:27 2019 -0700

    [Travis] Update TravisCI from upstream

    Most notable change here is the introduction of two breakpoints that
    will store the current cache and stop if the previous step took a long
    time. This is intended to avoid hitting the global time limit of 50
    minutes for builds that would need to rebuild the depends cache.

commit 26b1f0ca330901403ee456953943be17e7731578
Author: random-zebra <random.zebra@protonmail.com>
Date:   Tue Jun 11 17:33:01 2019 +0200

    [RPC] 'getblockindexstats': count public spends separately

commit 7980f23c0c1a99120908ca969b22daaf7ea5dccb
Author: random-zebra <random.zebra@protonmail.com>
Date:   Tue Jun 11 17:16:27 2019 +0200

    [RPC] fix fee calculation in 'getblockindexstats' and 'getfeeinfo'

commit 019d26ac4cdcdfdeacb2ab685562cbbb0df56380
Author: CaveSpectre11 <36988814+CaveSpectre11@users.noreply.github.com>
Date:   Mon Jun 10 12:19:55 2019 -0400

    Don't assert if we were beaten to the block

    A timing window exists where a wallet could be creating a new block from within the miner thread when a new block is received to the wallet.  This window will create a situation where TestBlockValidity() fails because the chain tip has changed between the time it created the new block and the time it tested the validity of the block.

    This situation would result in the wallet being asserted; however this is a little overkill.  rather than asserting if the tip has changed, it is better to throw the block away.

    This problem was revealed during a testnet test of an altcoin, and very prevalent when multiple wallet existed with the exact same number of staking coins received in the same transaction; or when multiple wallets were staking the same coins via import private key.  The problem happens significantly less in more normal circumstances, but was still observed in a testing environment with fast blocks.

    It is likely that this scenario has been encountered but never determined to be root cause, as a crashed wallet could be restarted, re-indexed and never investigated further.

commit 55127d126459b98a125a3ff1110a8ca7b7074350
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sun Jun 9 20:13:24 2019 -0700

    [Gitian] Bump gitian build versions

    Bumps the gitian build versions to 3.3, which should have been done
    right after 3.2 was branched off.

    At the same time, update to python3 explicitly and allow for some better
     error reporting.

commit ca2fd101ba951f268cf1a6102085fca28979b879
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sun Jun 9 18:30:00 2019 -0700

    use non-Cellar OpenSSL path for macOS

    removes the dependency on a specific version, as long as the installed
    version is 1.0.x. Also set the appropriate environment flags for OpenSSL
     on macOS.

    Note: the setting of these two environment variables would be better
    suited to a user's `~/.bash_profile` rather than being done within
    CMake, as doing it here is destructive.

commit d2136e30e09add2c120a717c02221ebff9b3331f
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sat Jun 8 03:28:54 2019 -0700

    depends: Update from upstream

commit f912182d27e143e168ae6567f31aee4b26d2ca49
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Sun Jun 9 22:24:13 2019 +0200

    [Cleanup] clang compiler warnings in coinSpend and publicCoinSpend fixed.

commit 68c81c407a06aa87f7baddfb640dfb1419359bda
Merge: 458b08c8f 93bc03763
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Fri Jun 7 16:34:18 2019 -0700

    Merge #903: [Log] Handle errors during log message formatting

    93bc03763b [Log] Handle errors during log message formatting (warrows)

    Tree-SHA512: 55acc54247ad0980a4ed28ff167d35bae5d437e6484bd5ebb8c9cf948e47751d2e7dc4e9c338d7a6d22301f85448b4e6b8c4f6dbf97d68168939d13bdecb310b

commit 689ac23f62b8dbfd4de99497085a4b068af70dc2
Author: random-zebra <random.zebra@protonmail.com>
Date:   Fri Jun 7 18:51:51 2019 +0200

    [RPC] add 'getblockindexstats' function

commit 69b0032749705dfb8ca425e2b40446dd4cc1b4e4
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Mon May 27 00:32:30 2019 -0700

    fix config.h include file name

commit d413496b01e527470742b3964594ec96b8ce994c
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Thu May 2 23:14:24 2019 -0700

    [Build] Initial CMake support

commit 458b08c8f230e808ac4e6505b67fb6350e112cdb
Merge: 4b22a0902 39f37c5c5
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Fri Jun 7 00:07:32 2019 -0700

    Merge #909: [Consensus] Mainnet public spend enforcement height set.

    39f37c5c52 mainnet public spend enforcement height set (furszy)

    Tree-SHA512: 41adff5fa6ed7458ef3dcbb33979716996168bff7eccc4759931e8231184462a75020485430d91f88373b6cd3d298d3c0d61a9758aab4e0da3e6ea64d84e3594

commit b75d8bc0bbae0decc572e37495c56368fbc2ec80
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Fri Jun 7 00:01:35 2019 -0700

    [Build] Clean all coverage files during make clean

    This adds extra paths that were left out and ensures that `.gcda` and `
    .gcno` files are properly cleaned up.

commit 39f37c5c52ad9c2b0c9e248fbb7c196658de2e89
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Fri Jun 7 08:24:23 2019 +0200

    mainnet public spend enforcement height set

commit 4b22a090248da20ddfa5ce5ca1c74487863d0b67
Merge: 65bd78894 a789d2163
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Thu Jun 6 21:50:12 2019 -0700

    Merge #899: [zOBSR] Disable zOBSR staking

    a789d21635 [zOBSR] Disable zerocoins inclusion in 'SelectStakeCoins' (random-zebra)

    Tree-SHA512: 92da55ee6efe3090ad1b279e3ad4d1f757ca70d0a4b1f820a36b4d5d6dcef126002fc6c2402b2b8d34618f212a192d8dc7505f98a0050691d152ba5a17fb1821

commit 65bd788945de04f8e5d54935ce4d70d5b30ac375
Merge: 855408c2c 834cbeb1c
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Thu Jun 6 21:43:26 2019 -0700

    Merge #897: [zOBSR] Disable zerocoin minting

    834cbeb1cc [RPC] enable mint only for regtest (random-zebra)
    dcc74f8815 [zOBSR][Consensus] fix 'Zerocoin_Block_Public_Spend_Enabled()' enforcement (random-zebra)
    3555f430d2 [Wallet] Disable automint (random-zebra)
    2708b6f3bd [Consensus] Disable zerocoin minting in contextual check (random-zebra)
    9f3fa2add4 [RPC] Disable zerocoin minting (random-zebra)
    fda5fff154 [GUI] Disable zerocoin minting (random-zebra)

    Tree-SHA512: a950267f03e570f01c17030ae5b6f1a71e8d1016589a7a03c03a0495463099e9ddf0dc36b83f0918ae1c02cd6686f9bf9d3df7924ca4ec514da21be203bfc3cf

commit 855408c2c3e7d67f3b0b0021661cbcaba07f5f4a
Merge: 3d496cc74 d6149cc12
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Thu Jun 6 21:35:18 2019 -0700

    Merge #891: [ZOBSR] Zerocoin public coin spend.

    d6149cc12e [Consensus] Testnet enforcement height. (furszy)
    28afbd2981 [zOBSR] v1 serials modulus fix + isStandardTx fix for publicSpends. (furszy)
    ddc3f15562 [Consensus] spork 15 activation + protocol version bump. (furszy)
    216a3174af [zOBSR] testnet publicSpend enforcement height set. (furszy)
    0393227b65 [Tests] add test reorg for public spend (random-zebra)
    2f750e5011 [RPC] add 'createrawzerocoinpublicspend' method (random-zebra)
    b5e2526da8 [zOBSR] publicCoinSpend version field included in the serialization for any future change. (furszy)
    46e453b8bc [zOBSR] reject priv coin spends on tx mempool acceptance. (furszy)
    afdb9d492c [RPC] Parse public spend on getserials rpc command. (furszy)
    88cdfc60ea [FUNCTIONAL TEST] old coinSpend transaction rejected. (furszy)
    3d0893ae81 [RPC] spendzerocoin command can now create old zc spends, only for regression tests (furszy)
    f46b80ed5e [FUNCTIONAL TEST][zOBSR] double spent serial validation. (furszy)
    fdfd999d10 [zOBSR[Unit Test] Possible redundant denomination validation. (furszy)
    507f7c8f5a [FUNCTIONAL TESTS] valid PublicCoinSpend transaction test. (furszy)
    262d5e7fce [zOBSR] mints coin control dialog min accumulation mature text removed + re mint change checkbox not visible anymore. (furszy)
    a8ce6717db [zOBSR] use new limit Zerocoin_MaxPublicSpendsPerTransaction for max num of inputs (random-zebra)
    e0decb1541 [zOBSR] prevent v1 zerocoins from being selected for PublicSpends (random-zebra)
    44398690d1 [zOBSR][Consensus] reject V1 serials spends. (furszy)
    cb4ffa16cb [zOBSR] remove enforcement from 'CreateZerocoinSpendTransaction' fixing the unit tests (random-zebra)
    657bb41293 [zOBSR][Cleanup] PublicSpend rebase onto IsZerocoin (random-zebra)
    3c74d6d2f1 [zOBSR] new protocol enforcement height added. Height not final, just randomly selected and tested on regtest. (furszy)
    f93001663b [zOBSR] rebase problems fixed. (Needs more testing) (furszy)
    e7dada8d62 [zOBSR] publicCoinSpend signature hash relevant data inclusion. (furszy)
    c8d519eb5d [zOBSR] zOBSR Maturity --> Minimum amount of coins accumulated no needed anymore. (furszy)
    0e8d0f90e4 [Wallet] public coin spend creation connected + first mem pool validation. (furszy)
    1db7c59847 [UNIT TEST] publicCoinSpend valid input creation and verification. (furszy)
    ca86660e7e [Zeroocoin] public coin spend script creation, validation and un/serialization. (furszy)

    Tree-SHA512: d333dbbf5dba407cf3766adcf42867e2af84951ca381df03c77c01b552ad6ed0721d1eea7ae312595c264196a409603823f36f06e97d377c61c2b7d983880245

commit 834cbeb1cc8af1c6b98104180f1736f4bd1c17a9
Author: random-zebra <random.zebra@protonmail.com>
Date:   Tue May 21 16:00:15 2019 +0200

    [RPC] enable mint only for regtest

commit dcc74f8815707346c9c5d42a061c56432760f043
Author: random-zebra <random.zebra@protonmail.com>
Date:   Wed May 15 01:28:02 2019 +0200

    [zOBSR][Consensus] fix 'Zerocoin_Block_Public_Spend_Enabled()' enforcement

commit 3555f430d2c250492d7362a77379a23c9a3b0116
Author: random-zebra <random.zebra@protonmail.com>
Date:   Thu May 2 11:18:29 2019 +0200

    [Wallet] Disable automint

commit 2708b6f3bdd8b28bdd20423fec2fc2df366ea413
Author: random-zebra <random.zebra@protonmail.com>
Date:   Tue Apr 30 11:54:20 2019 +0200

    [Consensus] Disable zerocoin minting in contextual check

commit 9f3fa2add468148c0791b75d99c8458a261fe3be
Author: random-zebra <random.zebra@protonmail.com>
Date:   Tue Apr 30 11:37:12 2019 +0200

    [RPC] Disable zerocoin minting

    disabling also remint of change of a zc spend

commit fda5fff1541c134a06994c8a823485253eb15fce
Author: random-zebra <random.zebra@protonmail.com>
Date:   Tue Apr 30 11:33:10 2019 +0200

    [GUI] Disable zerocoin minting

commit d6149cc12e883d0cf827da1d5ad76edd5629b01a
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Tue Jun 4 23:36:48 2019 +0200

    [Consensus] Testnet enforcement height.

commit 28afbd29814cd3fc92d9a1b4761919bcc72cd97f
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Tue May 21 15:27:22 2019 +0200

    [zOBSR] v1 serials modulus fix + isStandardTx fix for publicSpends.

    cleanup, publicCoinSpend object leftover removed + minor log added to CheckProofOfStake.

commit ddc3f15562c5df7e1627768cd573aa49b0a861d2
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Mon May 20 11:01:10 2019 +0200

    [Consensus] spork 15 activation + protocol version bump.

    [Consensus] spork 15 + min prev protocol version. (squash this later)

commit 216a3174affd4ba1ae7817af258d29ff722c7335
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Mon May 20 10:49:21 2019 +0200

    [zOBSR] testnet publicSpend enforcement height set.

    [zOBSR] v1 serials validation was not checked against the publicSpend height.

commit 0393227b6588c783f01edf1fc8bd8f128ab90ea2
Author: random-zebra <random.zebra@protonmail.com>
Date:   Sun May 19 23:14:04 2019 +0200

    [Tests] add test reorg for public spend

    [Unit Test] zc public spend test up-to-date with master.

commit 2f750e50116b403ac202f6683279b59a82dfdc33
Author: random-zebra <random.zebra@protonmail.com>
Date:   Sun May 19 23:13:30 2019 +0200

    [RPC] add 'createrawzerocoinpublicspend' method

commit b5e2526da8abc34f3d0a40913818c71bef817a26
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Fri May 17 01:37:25 2019 +0200

    [zOBSR] publicCoinSpend version field included in the serialization for any future change.

commit 46e453b8bc71645de706a64dbd196ebce5a7db80
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Thu May 16 20:24:11 2019 +0200

    [zOBSR] reject priv coin spends on tx mempool acceptance.

commit afdb9d492c7e666a82b85ebb22fb9416ef61aed2
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Thu May 16 19:08:59 2019 +0200

    [RPC] Parse public spend on getserials rpc command.

    [Cleanup] non used variable commented.

commit c84e0e83ba9ba556bd66ae50d6e4eb6a6b243bab
Author: warrows <warrows@gamer666.fr>
Date:   Mon May 20 16:47:23 2019 +0200

    [Code Style] Remove std namespace in test file

commit 3355c86ccedc7bf8b83eed2455c046d27cb56685
Author: Ethan Heilman <Ethan.R.Heilman@gmail.com>
Date:   Sat Dec 12 22:34:08 2015 -0500

    Increase test coverage for addrman and addrinfo

    Adds several unittests for CAddrMan and CAddrInfo.
    Increases the accuracy of addrman tests.
    Removes non-determinism in tests by overriding the random number generator.
    Extracts testing code from addrman class to test class.

commit d4da01588bda9a98ad21323663a9b8a78e3c59ee
Author: EthanHeilman <ethan.r.heilman@gmail.com>
Date:   Tue Sep 22 15:24:16 2015 -0400

    Creates unittests for addrman, makes addrman testable.

    Adds several unittests for addrman to verify it works as expected.
    Makes small modifications to addrman to allow deterministic and targeted tests.

commit 93bc03763be673bdac0edff86fffc0022a3e7a8b
Author: warrows <warrows@gamer666.fr>
Date:   Mon May 20 23:54:17 2019 +0200

    [Log] Handle errors during log message formatting

commit 9c0329c72b96af50a4bd8e971a31726346835d2d
Author: warrows <warrows@gamer666.fr>
Date:   Sun May 19 19:09:30 2019 +0200

    [zerocoin] Free memory from ToString()

    Simple fix for a minor memory leak

commit 88cdfc60ea88ac784718c11094e76c903b1ffe52
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Wed May 15 19:21:05 2019 +0200

    [FUNCTIONAL TEST] old coinSpend transaction rejected.

commit 3d0893ae81b134a8033d80d54133d9899731b48d
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Wed May 15 18:43:14 2019 +0200

    [RPC] spendzerocoin command can now create old zc spends, only for regression tests

commit f46b80ed5e86ce46e79367a755f11d143d7a1908
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Wed May 15 18:01:38 2019 +0200

    [FUNCTIONAL TEST][zOBSR] double spent serial validation.

commit fdfd999d10bfda638fcc45fc4768c8f40032db8a
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Wed May 15 17:40:51 2019 +0200

    [zOBSR[Unit Test] Possible redundant denomination validation.

commit 507f7c8f5a38155ebac9e2719474149c036f9dbe
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Wed May 15 17:24:10 2019 +0200

    [FUNCTIONAL TESTS] valid PublicCoinSpend transaction test.

commit 262d5e7fce41890943847c3ece65b0e77eb7ec1e
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Wed May 15 15:40:55 2019 +0200

    [zOBSR] mints coin control dialog min accumulation mature text removed + re mint change checkbox not visible anymore.

commit a8ce6717dba4202e7d5df1bf5182c3bd0225b2e4
Author: random-zebra <random.zebra@protonmail.com>
Date:   Wed May 15 06:38:29 2019 +0200

    [zOBSR] use new limit Zerocoin_MaxPublicSpendsPerTransaction for max num of inputs

commit e0decb154128a03b89ea363419770c704c607bf9
Author: random-zebra <random.zebra@protonmail.com>
Date:   Wed May 15 03:10:01 2019 +0200

    [zOBSR] prevent v1 zerocoins from being selected for PublicSpends

commit 44398690d1d4c3f63b9fefc88b9f7ae589f4c8a0
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Wed May 15 01:13:52 2019 +0200

    [zOBSR][Consensus] reject V1 serials spends.

commit cb4ffa16cbb53475e4cdc0e6d898911456a4ea5c
Author: random-zebra <random.zebra@protonmail.com>
Date:   Tue May 14 23:22:41 2019 +0200

    [zOBSR] remove enforcement from 'CreateZerocoinSpendTransaction' fixing the unit tests

commit 657bb41293adf08fa3cb0502fdeca06361420f87
Author: random-zebra <random.zebra@protonmail.com>
Date:   Tue May 14 23:22:13 2019 +0200

    [zOBSR][Cleanup] PublicSpend rebase onto IsZerocoin

commit 3c74d6d2f116d6a45bc665ba4af9bb827dad21b6
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Tue May 14 17:23:15 2019 +0200

    [zOBSR] new protocol enforcement height added. Height not final, just randomly selected and tested on regtest.

commit f93001663b999259dfbce2035e131caa7348850f
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Tue May 14 15:50:45 2019 +0200

    [zOBSR] rebase problems fixed. (Needs more testing)

commit e7dada8d621d51b400e8e3b7da339166747f2c27
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Mon May 13 21:45:21 2019 +0200

    [zOBSR] publicCoinSpend signature hash relevant data inclusion.

commit c8d519eb5d72f4ccdc53e0ad30ae56e0840eaf48
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Mon May 13 20:52:30 2019 +0200

    [zOBSR] zOBSR Maturity --> Minimum amount of coins accumulated no needed anymore.

commit 0e8d0f90e49566a82aedcb3da9db4a903c5c4a25
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Wed May 1 11:47:18 2019 +0200

    [Wallet] public coin spend creation connected + first mem pool validation.

    [Zerocoin] public coin spend improvements.

    [Zerocoin] publicCoinSpend validations connected to the accept txes flow.

    [Zerocoin] public spends not checked as regular inputs.

    [Zerocoin] publicCoinSpend validation as regular spends.

    non good solution for the coinSpend pointer inheritance issue but at least working

    [Zerocoin] ParseZerocoinPublicSpend moved into zobsrmodule file.

    cleanup unused field.

commit 1db7c59847d90f9a341bbbb66ead6ab4a9b2bbd0
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Wed May 1 11:44:58 2019 +0200

    [UNIT TEST] publicCoinSpend valid input creation and verification.

    [UNIT TEST] publicCoinSpend creation + validation completed.

commit ca86660e7ec2f9e66af7830517925e4dd539047c
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Wed May 1 11:44:26 2019 +0200

    [Zeroocoin] public coin spend script creation, validation and un/serialization.

commit 3d496cc74665a4e6ba8f3632d04842adf07ef657
Merge: 5f7559bc7 4e8f46a37
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Tue May 21 14:57:45 2019 -0700

    Merge #898: [Qt] Fixup duplicate label names

    4e8f46a376 [Qt] Fixup duplicate label names (Fuzzbawls)

    Tree-SHA512: 6cee761fae0d6d387523d286ddbc8fa6f61ef702ec406aa9108dedaccb1b8a0f343b7c01778f9d86be7e76e437d390e468c2593f2514c47350415da696744609

commit 5f7559bc7b9e9b6193fcbe2b12054a31708d1477
Merge: a99c2dd3b a4205f21b
Author: Mrs-X <Mrs-X@users.noreply.github.com>
Date:   Sat May 18 09:28:15 2019 +0200

    Merge #900: [UI] Fix improperly parented walletView and segmentation fault on QT 5.10

    a4205f2 [UI] Fix improperly parented walletView. (Julian Meyer)

    Tree-SHA512: ba523274a9e336a884f097dcff5a0e47e294517254350287dd0c2572c63010e63a33734707bcdca753f454f85c4bbe052817172b719e7ac66bcdbdef71d151a2

commit a99c2dd3bb2026279d279d9ef72df3bb63fc0a13
Merge: fc6b5a191 253c63eda
Author: Mrs-X <Mrs-X@users.noreply.github.com>
Date:   Fri May 17 15:15:12 2019 +0200

    Merge #875:  [Zerocoin] GMP BigNum: Fix limits for random number generators

    253c63e [Zerocoin] include 0 in randBignum() range (random-zebra)
    daeb752 [Test] Add tests for bignum random generators (random-zebra)
    5627807 [Zerocoin] Fix limits for random number generators in GMP bignum implementation (random-zebra)

    Tree-SHA512: c88ab99912683736a886065ecfbfd52aeb419357ee0e7eb6e3c1a09c22c3c316884bf8606f44d13e0f0fcb4de4137fb52339b556eb6e1a134b7aafff36c1d414

commit fc6b5a191dda9dc71ca841cbbdf74868bd4d76fb
Merge: a373fee90 c5054e4f7
Author: Mrs-X <Mrs-X@users.noreply.github.com>
Date:   Fri May 17 15:09:20 2019 +0200

    Merge #806: [Test] Create new per-test fixtures

    c5054e4 tests: add a BasicTestingSetup and apply to all tests (Wladimir J. van der Laan)
    962a1bc Reinitialize state in between individual unit tests. (Pieter Wuille)

    Tree-SHA512: 47bab117a394de5f7dc9079f940969df6e3369f96128c1009c55005d30adb1dbc048900f04649caae2976518cad1065419f1d91baebffe0c3f3c2d9897450c08

commit 253c63edad3bc75107ab5cf1c5e187569327e082
Author: random-zebra <random.zebra@protonmail.com>
Date:   Fri May 17 12:46:22 2019 +0200

    [Zerocoin] include 0 in randBignum() range

commit c5054e4f729b7c82c8768b688e66909d266b017f
Author: Wladimir J. van der Laan <laanwj@gmail.com>
Date:   Thu Mar 12 09:34:42 2015 +0100

    tests: add a BasicTestingSetup and apply to all tests

    Make sure that chainparams and logging is properly initialized. Doing
    this for every test may be overkill, but this initialization is so
    simple that that does not matter.

    This should fix the travis issues.

commit 962a1bca0aea4ab37032d1ef13323f85280e62a9
Author: Pieter Wuille <pieter.wuille@gmail.com>
Date:   Tue Mar 3 07:49:12 2015 -0800

    Reinitialize state in between individual unit tests.

    This changes the TestingSetup fixture to be per-unit-test rather than global.
    Most tests don't need it, so it's only invoked in a few.

commit f3308f404d18f9ff42c83e496dd8081de13c3c86
Author: CaveSpectre11 <36988814+CaveSpectre11@users.noreply.github.com>
Date:   Thu May 16 08:41:13 2019 -0400

    Fix typos and oversights in listunspent

commit a373fee908d0128c545dc4fcc96089feb7a8c8b5
Merge: 81038da4f 2fdc74b28
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Thu May 16 01:41:17 2019 -0700

    Merge #810: [Depends] Fix archs (fixes s390x and ppc64el builds on snap)

    2fdc74b280 update qt.mk with arch fix (see previous commit) (cevap)
    b22610c6f1 add QT patch for s390x, mips, powerpc and sparc (cevap)
    1a756e0066 Fix qt for m68k and alpha (cevap)
    f52a72ef0f Fix openssl for m68k and alpha (cevap)
    e12b4493fb Fix boost for m68k and alpha (cevap)
    32f2684b9e Fix openssl for sparc64 (cevap)
    5de083f1d6 Fix qt for sparc64 (cevap)
    f1e537e05d Fix boost for sparc64 (cevap)
    188d0ea7a4 Fix qt for powerpc/ppc64el (cevap)
    c590d072ab Fix openssl for powerpc/ppc64el (cevap)
    def4374308 Fix qt for s390x (cevap)
    ed61951516 Fix openssl for s390x (cevap)
    d1489c8985 Fix boost for s390x (cevap)

    Tree-SHA512: 90add202dde7c3252bdc92974936fa50daf66a34e29cfbbee3222771ea89d061466e39300d3449b5e8b43fd1d8b8828b694ad83624c959c7cc331463a7aef7f8

commit a4205f21b52876a642e9c68d7eac84430483202e
Author: Julian Meyer <julianmeyer2000@gmail.com>
Date:   Wed May 15 12:10:23 2019 -0700

    [UI] Fix improperly parented walletView.

    Fixes #789.

commit fe67706fd222168e4bb6a387566a48dbd667638c
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Thu Feb 28 12:23:36 2019 -0800

    Remove more useless obfuscation code

commit eed0a1d34ebc6b4fd43619d9296e2cfe1dbf5d43
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Thu Feb 28 01:38:15 2019 -0800

    Remove more useless obfuscation code

commit 3bb5c768bf8d40716843216155353fe18d4d451e
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Wed Feb 27 20:34:03 2019 -0800

    Remove unused functions in wallet.cpp

    these functions were used back when obfuscation existed and are no
    longer called anywhere in the source tree.

commit 166b2d31c8f438d17937335706b51df35856d98d
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Wed Feb 27 15:14:00 2019 -0800

    Remove nAnonymizeObsrAmount and nLiquidityProvider

    These two variables have been meaningless since zOBSR's introduction...

    Nuke them from orbit!

commit 886d806f58e692cb125a2b247b096a9b15cf1987
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Wed Feb 27 15:02:51 2019 -0800

    Remove unused code in DoAutomaticDenominating

    This function statically returns `false`, no need to have anything else
    here.

commit 742a7b187ca374e70dd6f6aaffc83b68badcfb7f
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Wed Feb 27 14:56:40 2019 -0800

    [Qt] Remove unused obfuscationconfig

    obfuscationconfig(.h/.cpp) are unused and not needed at all anymore.

commit 81038da4f8eb73c1a9a29a84b6cc62a21c8151f4
Merge: 0c071c3fd 4f6cd20b0
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Tue May 14 20:56:00 2019 -0700

    Merge #830: [Refactor] Remove BOOST_FOREACH

    4f6cd20b0d Cleanup clang's range loop analysis warnings (Fuzzbawls)
    e1c549e8a7 [Refactor] Remove useless BOOST includes and readd where needed (warrows)
    4d44c9781a [Refactoring] Replace BOOST FOREACH with for : (warrows)

    Tree-SHA512: a61e8968a28c86f33f753b693559a58a632e01b6408b7f0653772206fa9f20fb2df83e432ed74e33d1bed29a302ff4b98c30bbe53111faf1f50ed3acf8888190

commit a789d21635d02eefa5a5485b8c812fc249ce3a63
Author: random-zebra <random.zebra@protonmail.com>
Date:   Wed May 15 05:29:22 2019 +0200

    [zOBSR] Disable zerocoins inclusion in 'SelectStakeCoins'

commit 4f6cd20b0dcafd30e3b5bc9e61278b83dd411102
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Tue May 14 00:47:13 2019 -0700

    Cleanup clang's range loop analysis warnings

commit e1c549e8a798d0c818b49bb6089337ba61aaf3ed
Author: warrows <warrows@gamer666.fr>
Date:   Wed Mar 6 20:45:45 2019 +0100

    [Refactor] Remove useless BOOST includes and readd where needed

commit 4d44c9781a95bb80e81f48e551e791a1eeb8cb66
Author: warrows <warrows@gamer666.fr>
Date:   Wed Mar 6 20:05:20 2019 +0100

    [Refactoring] Replace BOOST FOREACH with for :

    Done using following script:

    -BEGIN VERIFY SCRIPT-
    sed -i 's/BOOST_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp
    ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
    -END VERIFY SCRIPT-

commit 4e8f46a376335ea271b5ac480644a013da0d4b47
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Tue May 14 16:24:29 2019 -0700

    [Qt] Fixup duplicate label names

    resolves compiler warnings about a label's name having been already used
    .

commit 0c071c3fd0d6d47cb9d03bc0abae7a98a6ccade4
Merge: b2fcefee9 f14569faa
Author: random-zebra <random.zebra@protonmail.com>
Date:   Wed May 15 00:23:19 2019 +0200

    Merge #888: [Zerocoin] remove CTransaction::IsZerocoinSpend/IsZerocoinMint

    f14569faa [Zerocoin] remove CTransaction::IsZerocoinSpend and CTransaction::IsZerocoinMint (random-zebra)

    Tree-SHA512: 0e7ab5ee37215454af1b09d25454bedaf8f92baf0ca598d5c639bb1b6f642ca93d21a8d2707af3c4cece06d7b6cd98a019e8b4c16712d774f23b5b41ee059a57

commit b2fcefee93cb0f3a088528018b59a7fdbf73c903
Merge: fddac44ea d7afebb47
Author: Mrs-X <Mrs-X@users.noreply.github.com>
Date:   Tue May 14 22:15:24 2019 +0200

    Merge #896: [UI] Simplify Qt margins.

    d7afebb [UI] Simplify Qt margins. No functional change. (warrows)

    Tree-SHA512: c29c1d416d81ccda15d90c26fcadc9b67dcd27b8b7bdbd55c951e0ddd6c809b0cc7cc0dfc3590dc45fa2fb4f0e5218d9da2a424cb3a953d9b542de34ab7b693c

commit c424f0f244b92b800a354b06e9d24935d539e99b
Author: Alko89 <alefer89@gmail.com>
Date:   Tue May 14 16:47:27 2019 +0200

    Fix margins

commit 2d052155ffcb7325546a118738f9cc3aa3a15cea
Author: Alko89 <alefer89@gmail.com>
Date:   Tue May 14 11:48:14 2019 +0200

    Hide zobsr related options.

commit d7afebb4795163e4904135c7f3b69379a9a57010
Author: warrows <warrows@gamer666.fr>
Date:   Tue May 14 15:39:31 2019 +0200

    [UI] Simplify Qt margins. No functional change.

commit fddac44eab2774bc19c50154e5eb1b290d1ad7fe
Merge: ec7993eac b5a525767
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Mon May 13 23:56:30 2019 -0700

    Merge #890: [Refactor] Remove unused setStakeSeen variable

    b5a525767a [Refactor] Remove unused setStakeSeen variable (warrows)

    Tree-SHA512: c5244b3cf269d3b6171a5b241265b98bffcfbf580cecbf9cc2741ea2b3374deb558459a8764f1931080331b11456a8d129dbcc3b6e59955f15bc184333e23ca8

commit b5a525767ae62a39f0a691a9345439b457f661b8
Author: warrows <warrows@gamer666.fr>
Date:   Wed May 8 17:58:57 2019 +0200

    [Refactor] Remove unused setStakeSeen variable

commit f14569faab4cee1130b68a29932dcde7b35899b2
Author: random-zebra <random.zebra@protonmail.com>
Date:   Wed May 8 16:08:20 2019 +0200

    [Zerocoin] remove CTransaction::IsZerocoinSpend and CTransaction::IsZerocoinMint

    - uniform IsZerocoinSpend/IsZerocoinMint CScript functions
    - refactor CTxIn::IsZerocoinSpend / CTxOut::IsZerocoinMint encapsulating CScript methods
    - add CTransaction methods: HasZerocoinMintOutputs / HasZerocoinSpendInputs
    - refactor CTransaction::ContainsZerocoins from previous 'HasZerocoin' functions
    - fix implementation of CTransaction::GetZerocoinMinted (from CTxOut)
    - remove extra checks for empty scripts (as those are done in CScript functions)

commit ec7993eac8d50fa54133807165f1ddb0597ef635
Merge: 013676df0 a0af2a752
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Tue May 7 23:39:07 2019 -0700

    Merge #887: [Net] Fix incorrect last checkpoint timestamp

    a0af2a7525 Fix incorrect last checkpoint timestamp (Fuzzbawls)

    Tree-SHA512: a34786fa8dbe777ed0d2d1a880c1d9d603c6771aba7619b912100f5a732bb5b1f98459afb26be7aab8c3ade60ff4501accb69e65f74186b0ae41057d03c68866

commit a0af2a75257a86f585580152e73de24b331c9264
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Tue May 7 23:29:39 2019 -0700

    Fix incorrect last checkpoint timestamp

commit 013676df00d3ebc7886ac655bd234bd45637021f
Merge: a890dc97c af28b90a4
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Tue May 7 16:55:57 2019 -0700

    Merge #884: [Net] Add additional checkpoints

    af28b90a4a [Net] Add additional checkpoints (Fuzzbawls)

    Tree-SHA512: c19201cd9999fb295c81f375182a685615ec5d117d74b175e4573f4cb5f32fc1c56c9871c3898cfd09c423fbdb6eddb1a4a1e95ec66894ec80765a4849fd83bf

commit af28b90a4ab119102ed995a20614025a55256526
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Tue May 7 15:58:05 2019 -0700

    [Net] Add additional checkpoints

    This adds two additional checkpoints for known split points

commit a890dc97cdbc7392273be204d7a09435e720eb77
Merge: 5f0d72659 754764be0
Author: Mrs-X <Mrs-X@users.noreply.github.com>
Date:   Tue May 7 22:25:22 2019 +0200

    Merge #880: [NET] Valid forked blocks rejected fix.

    754764b [Net] AcceptBlock, first prev block loaded from disk. (furszy)
    2c76194 [Net] Valid blocks from forks badly rejected due an invalid view of the available utxo set for forked chains + split height going one block further than what should be. (furszy)

    Tree-SHA512: 3ab04609b58686d38bd0238f7059f67d9bca326e9758aff57a0b0e02c79e1be4649eaaeebd0b35b020c8aa249805a56e57531dfae178fb532ceac67803730455

commit 754764be02af58b0b2059f580b40bf5f6380fa4d
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Tue May 7 11:19:54 2019 +0200

    [Net] AcceptBlock, first prev block loaded from disk.

commit 2c76194c757ddd6a9081ee555b191c6dbb326c50
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Sat May 4 11:10:22 2019 +0200

    [Net] Valid blocks from forks badly rejected due an invalid view of the available utxo set for forked chains + split height going one block further than what should be.

    [Net] acceptBlock, back to chain split was going one block further if prev was the previous block of the incoming block.

    [Net] coins cache view only has the tip view and not forks utxo chain view.

commit 5f0d72659c0dafc049e4b70678d14c3a2c475025
Merge: 54c8832d8 997116917
Author: Mrs-X <Mrs-X@users.noreply.github.com>
Date:   Thu May 2 22:57:05 2019 +0200

    Merge #879: [Refactor] Rename ui_interface.h file

    9971169 [Refactor] Rename ui_interface.h file (Fuzzbawls)

    Tree-SHA512: db41888a01d588c19888330f0333ee0ab34f5aabe2a7f139772ac540a02532bc75874667917cc163cde592124d5368704c169cd51ffdec4f494a033ab28e5eb9

commit 997116917c4278221c4e2693dcb570148d2f8340
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Mon Apr 29 01:14:36 2019 -0700

    [Refactor] Rename ui_interface.h file

    This file's naming convention is not in line with what is used
    everywhere else. Additionally, the `ui_` prefix is typically reserved
    for QMake's UIC pre-processor to generate compiler-compatible code from
    Qt's `.ui` files.

    Renaming this file opens the door to adding CMake build support
    **without** needing to hackishly work around this one file's name, and
    it becomes more in-line with the naming conventions used for every other
     source file.

commit 54c8832d80367f7862e4d9adb6ca73f7eb16ceda
Merge: 7e52f58b8 b079abfeb
Author: Mrs-X <Mrs-X@users.noreply.github.com>
Date:   Mon Apr 29 23:07:26 2019 +0200

    Merge #877: [RPC] Remove deprecated masternode/budget RPC commands

    b079abf [RPC] Remove deprecated masternode/budget RPC commands (Fuzzbawls)

    Tree-SHA512: da88e8746e09ab8617e6210e17d7305f95c4bd596d6d9502954ebf41dc9bba5675d6300b9166cb4b7ae697b3c997975b4750797c8227fab5e2f684867ab94711

commit daeb7520c195107f4253b0ef2672b1faa142fdaa
Author: random-zebra <random.zebra@protonmail.com>
Date:   Fri Apr 26 23:15:16 2019 +0200

    [Test] Add tests for bignum random generators

commit 56278072678ed6f15bdb4e6fe41d688c4010a029
Author: random-zebra <random.zebra@protonmail.com>
Date:   Fri Apr 26 03:39:48 2019 +0200

    [Zerocoin] Fix limits for random number generators in GMP bignum implementation

commit 7e52f58b82bfbdc4c76dd76b9451e57248026f31
Merge: 23f17ce02 4e4975b69
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Mon Apr 29 02:04:14 2019 -0700

    Merge #744: [Refactor] Refactor bignum header file into several files

    4e4975b699 [Refactor] Refactor bignum header file into several files (warrows)

    Tree-SHA512: 52f0ad549bfd03731ac388ad8f07ae59d960549f49ac1f73c228ce14b1ef227f34408efce6198997754a230f8fae879939cbcfb75ffc16045a774849129242b4

commit 23f17ce021938dc975cc73c09edfb8a8189a4cf2
Merge: cfa309252 6e4849052
Author: Mrs-X <Mrs-X@users.noreply.github.com>
Date:   Fri Apr 26 23:22:36 2019 +0200

    Merge #874: [Qt] Add new budget colors

    6e48490 [Budget] Guard against chainactive tip clash (warrows)
    3601d00 [Qt] Print the actual number of MN used for voting (warrows)
    89ce7ff [Qt] Add new colors for proposals (warrows)
    bda0322 [Refactoring] Add IsPassing function to CBudgetProposal (warrows)
    3ec04f7 [Refactor] Refactor CBudgetProposal::IsEstablished() (warrows)

    Tree-SHA512: 4508a378d5404a47d7e1a3bba1d163eb427a3980d6d1f73687c55ff7b8eaf7f9e85b704f495597e34dc393603cae843796ccea7ae4056a476caf94eaad9dbfe1

commit 6e484905295d59ef566ef35b371f4797796daf24
Author: warrows <warrows@gamer666.fr>
Date:   Tue Apr 23 13:23:01 2019 +0200

    [Budget] Guard against chainactive tip clash

commit 3601d0020c30487ae3c940126a685343318a3eef
Author: warrows <warrows@gamer666.fr>
Date:   Tue Apr 23 12:32:10 2019 +0200

    [Qt] Print the actual number of MN used for voting

commit 89ce7fff847d0fbfbbcd2bb153627ee3e30593c5
Author: warrows <warrows@gamer666.fr>
Date:   Tue Apr 23 11:37:02 2019 +0200

    [Qt] Add new colors for proposals

    Show passing (enough votes and whatnot) but unfunded (lack of funds in the budget)
    proposals in yellow and unestablished proposals (less than 24 hours
    since submission) in blue

commit bda03227cc1ca5e83da3d7d9e62d5d49fcc0f1d2
Author: warrows <warrows@gamer666.fr>
Date:   Tue Apr 23 12:53:42 2019 +0200

    [Refactoring] Add IsPassing function to CBudgetProposal

    Makes the code easier to read and allows for reusing of this functions
    in other places.

commit b079abfebd179fca33cc91728f4168e3b9b879c2
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Thu Apr 25 22:36:48 2019 -0700

    [RPC] Remove deprecated masternode/budget RPC commands

    The old `masternode` and `mnbudget` commands have been deprecated for
    quite some time now, and have had a note in their help descriptions
    stating as much. So, time to finally remove them for good.

commit 3ec04f7069a0127c88dc29ce8d388ae16ba160f0
Author: warrows <warrows@gamer666.fr>
Date:   Tue Apr 23 12:40:28 2019 +0200

    [Refactor] Refactor CBudgetProposal::IsEstablished()

    -Move IsEstablished function to cpp file
    -Use GetAdjustedTime() instead of GetTime() to avoid lack of consensus
    -Remove magic numbers …

Backport from bitcoin bitcoin/bitcoin#5367

Overview of adapted commits: https://github.com/ioncoincore/ion/tree/5305677c9ffb7cf8a5fa47dee654e668e1c9eba6

PR includes adapted versions of these original commits:

From 7491d6caf7ff8236ddf525e91f523655faca671c Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Fri, 22 Mar 2019 17:20:32 -0700
Subject: [PATCH] Fix wrapped serial functional test

The error message had changed


From 4da1dcad89481d18ceb8ed1b2dfbb6be1cc8f5c3 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Fri, 22 Mar 2019 17:23:27 -0700
Subject: [PATCH] Disable precompute for functional tests

The locking can interfere with block generation


From 4e4975b6990bba15062e4e8c3117e6cc368b06ae Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Thu, 11 Oct 2018 13:41:48 +0200
Subject: [PATCH] [Refactor] Refactor bignum header file into several files



From 3ec04f7069a0127c88dc29ce8d388ae16ba160f0 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 12:40:28 +0200
Subject: [PATCH] [Refactor] Refactor CBudgetProposal::IsEstablished()

-Move IsEstablished function to cpp file
-Use GetAdjustedTime() instead of GetTime() to avoid lack of consensus
-Remove magic numbers and declare them in chainparams


From b079abfebd179fca33cc91728f4168e3b9b879c2 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Thu, 25 Apr 2019 22:36:48 -0700
Subject: [PATCH] [RPC] Remove deprecated masternode/budget RPC commands

The old `masternode` and `mnbudget` commands have been deprecated for
quite some time now, and have had a note in their help descriptions
stating as much. So, time to finally remove them for good.


From bda03227cc1ca5e83da3d7d9e62d5d49fcc0f1d2 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 12:53:42 +0200
Subject: [PATCH] [Refactoring] Add IsPassing function to CBudgetProposal

Makes the code easier to read and allows for reusing of this functions
in other places.


From 89ce7fff847d0fbfbbcd2bb153627ee3e30593c5 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 11:37:02 +0200
Subject: [PATCH] [Qt] Add new colors for proposals

Show passing (enough votes and whatnot) but unfunded (lack of funds in the budget)
proposals in yellow and unestablished proposals (less than 24 hours
since submission) in blue


From 3601d0020c30487ae3c940126a685343318a3eef Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 12:32:10 +0200
Subject: [PATCH] [Qt] Print the actual number of MN used for voting



From 6e484905295d59ef566ef35b371f4797796daf24 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 13:23:01 +0200
Subject: [PATCH] [Budget] Guard against chainactive tip clash



From 56278072678ed6f15bdb4e6fe41d688c4010a029 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 26 Apr 2019 03:39:48 +0200
Subject: [PATCH] [Zerocoin] Fix limits for random number generators in GMP
 bignum implementation



From daeb7520c195107f4253b0ef2672b1faa142fdaa Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 26 Apr 2019 23:15:16 +0200
Subject: [PATCH] [Test] Add tests for bignum random generators



From 671452e Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Mon, 29 Apr 2019 01:14:36 -0700
Subject: [PATCH] Rename ui_interface.h file

This file's naming convention is not in line with what is used
everywhere else. Additionally, the `ui_` prefix is typically reserved
for QMake's UIC pre-processor to generate compiler-compatible code from
Qt's `.ui` files.

Renaming this file opens the door to adding CMake build support
**without** needing to hackishly work around this one file's name, and
it becomes more in-line with the naming conventions used for every other
 source file.


From 2c76194c757ddd6a9081ee555b191c6dbb326c50 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Sat, 4 May 2019 11:10:22 +0200
Subject: [PATCH] [Net] Valid blocks from forks badly rejected due an invalid
 view of the available utxo set for forked chains + split height going one
 block further than what should be.

[Net] acceptBlock, back to chain split was going one block further if prev was the previous block of the incoming block.

[Net] coins cache view only has the tip view and not forks utxo chain view.


From 754764be02af58b0b2059f580b40bf5f6380fa4d Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Tue, 7 May 2019 11:19:54 +0200
Subject: [PATCH] [Net] AcceptBlock, first prev block loaded from disk.



From f14569faab4cee1130b68a29932dcde7b35899b2 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Wed, 8 May 2019 16:08:20 +0200
Subject: [PATCH] [Zerocoin] remove CTransaction::IsZerocoinSpend and
 CTransaction::IsZerocoinMint

- uniform IsZerocoinSpend/IsZerocoinMint CScript functions
- refactor CTxIn::IsZerocoinSpend / CTxOut::IsZerocoinMint encapsulating CScript methods
- add CTransaction methods: HasZerocoinMintOutputs / HasZerocoinSpendInputs
- refactor CTransaction::ContainsZerocoins from previous 'HasZerocoin' functions
- fix implementation of CTransaction::GetZerocoinMinted (from CTxOut)
- remove extra checks for empty scripts (as those are done in CScript functions)


From b5a525767ae62a39f0a691a9345439b457f661b8 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Wed, 8 May 2019 17:58:57 +0200
Subject: [PATCH] [Refactor] Remove unused setStakeSeen variable



From d7afebb4795163e4904135c7f3b69379a9a57010 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 14 May 2019 15:39:31 +0200
Subject: [PATCH] [UI] Simplify Qt margins. No functional change.



From 2d052155ffcb7325546a118738f9cc3aa3a15cea Mon Sep 17 00:00:00 2001
From: Alko89 <alefer89@gmail.com>
Date: Tue, 14 May 2019 11:48:14 +0200
Subject: [PATCH] Hide xion related options.



From c424f0f244b92b800a354b06e9d24935d539e99b Mon Sep 17 00:00:00 2001
From: Alko89 <alefer89@gmail.com>
Date: Tue, 14 May 2019 16:47:27 +0200
Subject: [PATCH] Fix margins



From 4e8f46a376335ea271b5ac480644a013da0d4b47 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Tue, 14 May 2019 16:24:29 -0700
Subject: [PATCH] [Qt] Fixup duplicate label names

resolves compiler warnings about a label's name having been already used
.


From 4d44c9781a95bb80e81f48e551e791a1eeb8cb66 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Wed, 6 Mar 2019 20:05:20 +0100
Subject: [PATCH] [Refactoring] Replace BOOST FOREACH with for :

Done using following script:

-BEGIN VERIFY SCRIPT-
sed -i 's/BOOST_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp
./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
-END VERIFY SCRIPT-


From e1c549e8a798d0c818b49bb6089337ba61aaf3ed Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Wed, 6 Mar 2019 20:45:45 +0100
Subject: [PATCH] [Refactor] Remove useless BOOST includes and readd where
 needed



From 4f6cd20b0dcafd30e3b5bc9e61278b83dd411102 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Tue, 14 May 2019 00:47:13 -0700
Subject: [PATCH] Cleanup clang's range loop analysis warnings



From a789d21635d02eefa5a5485b8c812fc249ce3a63 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Wed, 15 May 2019 05:29:22 +0200
Subject: [PATCH] [xION] Disable zerocoins inclusion in 'SelectStakeCoins'



From 742a7b187ca374e70dd6f6aaffc83b68badcfb7f Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Wed, 27 Feb 2019 14:56:40 -0800
Subject: [PATCH] [Qt] Remove unused obfuscationconfig

obfuscationconfig(.h/.cpp) are unused and not needed at all anymore.


From 886d806f58e692cb125a2b247b096a9b15cf1987 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Wed, 27 Feb 2019 15:02:51 -0800
Subject: [PATCH] Remove unused code in DoAutomaticDenominating

This function statically returns `false`, no need to have anything else
here.


From 166b2d31c8f438d17937335706b51df35856d98d Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Wed, 27 Feb 2019 15:14:00 -0800
Subject: [PATCH] Remove nAnonymizeIonAmount and nLiquidityProvider

These two variables have been meaningless since xION's introduction...

Nuke them from orbit!


From 3bb5c768bf8d40716843216155353fe18d4d451e Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Wed, 27 Feb 2019 20:34:03 -0800
Subject: [PATCH] Remove unused functions in wallet.cpp

these functions were used back when obfuscation existed and are no
longer called anywhere in the source tree.


From eed0a1d34ebc6b4fd43619d9296e2cfe1dbf5d43 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Thu, 28 Feb 2019 01:38:15 -0800
Subject: [PATCH] Remove more useless obfuscation code



From fe67706fd222168e4bb6a387566a48dbd667638c Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Thu, 28 Feb 2019 12:23:36 -0800
Subject: [PATCH] Remove more useless obfuscation code



From a4205f21b52876a642e9c68d7eac84430483202e Mon Sep 17 00:00:00 2001
From: Julian Meyer <julianmeyer2000@gmail.com>
Date: Wed, 15 May 2019 12:10:23 -0700
Subject: [PATCH] [UI] Fix improperly parented walletView.

Fixes #789.


From f3308f404d18f9ff42c83e496dd8081de13c3c86 Mon Sep 17 00:00:00 2001
From: CaveSpectre11 <36988814+CaveSpectre11@users.noreply.github.com>
Date: Thu, 16 May 2019 08:41:13 -0400
Subject: [PATCH] Fix typos and oversights in listunspent



From 962a1bca0aea4ab37032d1ef13323f85280e62a9 Mon Sep 17 00:00:00 2001
From: Pieter Wuille <pieter.wuille@gmail.com>
Date: Tue, 3 Mar 2015 07:49:12 -0800
Subject: [PATCH] Reinitialize state in between individual unit tests.

This changes the TestingSetup fixture to be per-unit-test rather than global.
Most tests don't need it, so it's only invoked in a few.


From c5054e4f729b7c82c8768b688e66909d266b017f Mon Sep 17 00:00:00 2001
From: "Wladimir J. van der Laan" <laanwj@gmail.com>
Date: Thu, 12 Mar 2015 09:34:42 +0100
Subject: [PATCH] tests: add a BasicTestingSetup and apply to all tests

Make sure that chainparams and logging is properly initialized. Doing
this for every test may be overkill, but this initialization is so
simple that that does not matter.

This should fix the travis issues.


From 253c63edad3bc75107ab5cf1c5e187569327e082 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 17 May 2019 12:46:22 +0200
Subject: [PATCH] [Zerocoin] include 0 in randBignum() range



From ca86660e7ec2f9e66af7830517925e4dd539047c Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 1 May 2019 11:44:26 +0200
Subject: [PATCH] [Zeroocoin] public coin spend script creation, validation and
 un/serialization.



From 1db7c59847d90f9a341bbbb66ead6ab4a9b2bbd0 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 1 May 2019 11:44:58 +0200
Subject: [PATCH] [UNIT TEST] publicCoinSpend valid input creation and
 verification.

[UNIT TEST] publicCoinSpend creation + validation completed.


From 0e8d0f90e49566a82aedcb3da9db4a903c5c4a25 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 1 May 2019 11:47:18 +0200
Subject: [PATCH] [Wallet] public coin spend creation connected + first mem
 pool validation.

[Zerocoin] public coin spend improvements.

[Zerocoin] publicCoinSpend validations connected to the accept txes flow.

[Zerocoin] public spends not checked as regular inputs.

[Zerocoin] publicCoinSpend validation as regular spends.

non good solution for the coinSpend pointer inheritance issue but at least working

[Zerocoin] ParseZerocoinPublicSpend moved into xionmodule file.

cleanup unused field.


From c8d519eb5d72f4ccdc53e0ad30ae56e0840eaf48 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Mon, 13 May 2019 20:52:30 +0200
Subject: [PATCH] [xION] xION Maturity --> Minimum amount of coins accumulated
 no needed anymore.



From e7dada8d621d51b400e8e3b7da339166747f2c27 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Mon, 13 May 2019 21:45:21 +0200
Subject: [PATCH] [xION] publicCoinSpend signature hash relevant data
 inclusion.



From f93001663b999259dfbce2035e131caa7348850f Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Tue, 14 May 2019 15:50:45 +0200
Subject: [PATCH] [xION] rebase problems fixed. (Needs more testing)



From 3c74d6d2f116d6a45bc665ba4af9bb827dad21b6 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Tue, 14 May 2019 17:23:15 +0200
Subject: [PATCH] [xION] new protocol enforcement height added. Height not
 final, just randomly selected and tested on regtest.



From 657bb41293adf08fa3cb0502fdeca06361420f87 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 14 May 2019 23:22:13 +0200
Subject: [PATCH] [xION][Cleanup] PublicSpend rebase onto IsZerocoin



From cb4ffa16cbb53475e4cdc0e6d898911456a4ea5c Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 14 May 2019 23:22:41 +0200
Subject: [PATCH] [xION] remove enforcement from
 'CreateZerocoinSpendTransaction' fixing the unit tests



From 44398690d1d4c3f63b9fefc88b9f7ae589f4c8a0 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 01:13:52 +0200
Subject: [PATCH] [xION][Consensus] reject V1 serials spends.



From e0decb154128a03b89ea363419770c704c607bf9 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Wed, 15 May 2019 03:10:01 +0200
Subject: [PATCH] [xION] prevent v1 zerocoins from being selected for
 PublicSpends



From a8ce6717dba4202e7d5df1bf5182c3bd0225b2e4 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Wed, 15 May 2019 06:38:29 +0200
Subject: [PATCH] [xION] use new limit Zerocoin_MaxPublicSpendsPerTransaction
 for max num of inputs



From 262d5e7fce41890943847c3ece65b0e77eb7ec1e Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 15:40:55 +0200
Subject: [PATCH] [xION] mints coin control dialog min accumulation mature text
 removed + re mint change checkbox not visible anymore.



From 507f7c8f5a38155ebac9e2719474149c036f9dbe Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 17:24:10 +0200
Subject: [PATCH] [FUNCTIONAL TESTS] valid PublicCoinSpend transaction test.



From fdfd999d10bfda638fcc45fc4768c8f40032db8a Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 17:40:51 +0200
Subject: [PATCH] [xION[Unit Test] Possible redundant denomination validation.



From f46b80ed5e86ce46e79367a755f11d143d7a1908 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 18:01:38 +0200
Subject: [PATCH] [FUNCTIONAL TEST][xION] double spent serial validation.



From 3d0893ae81b134a8033d80d54133d9899731b48d Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 18:43:14 +0200
Subject: [PATCH] [RPC] spendzerocoin command can now create old zc spends,
 only for regression tests



From 88cdfc60ea88ac784718c11094e76c903b1ffe52 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 19:21:05 +0200
Subject: [PATCH] [FUNCTIONAL TEST] old coinSpend transaction rejected.



From 9c0329c72b96af50a4bd8e971a31726346835d2d Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Sun, 19 May 2019 19:09:30 +0200
Subject: [PATCH] [zerocoin] Free memory from ToString()

Simple fix for a minor memory leak


From 93bc03763be673bdac0edff86fffc0022a3e7a8b Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Mon, 20 May 2019 23:54:17 +0200
Subject: [PATCH] [Log] Handle errors during log message formatting



From d4da01588bda9a98ad21323663a9b8a78e3c59ee Mon Sep 17 00:00:00 2001
From: EthanHeilman <ethan.r.heilman@gmail.com>
Date: Tue, 22 Sep 2015 15:24:16 -0400
Subject: [PATCH] Creates unittests for addrman, makes addrman testable.

Adds several unittests for addrman to verify it works as expected.
Makes small modifications to addrman to allow deterministic and targeted tests.


From 3355c86ccedc7bf8b83eed2455c046d27cb56685 Mon Sep 17 00:00:00 2001
From: Ethan Heilman <Ethan.R.Heilman@gmail.com>
Date: Sat, 12 Dec 2015 22:34:08 -0500
Subject: [PATCH] Increase test coverage for addrman and addrinfo

Adds several unittests for CAddrMan and CAddrInfo.
Increases the accuracy of addrman tests.
Removes non-determinism in tests by overriding the random number generator.
Extracts testing code from addrman class to test class.


From c84e0e83ba9ba556bd66ae50d6e4eb6a6b243bab Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Mon, 20 May 2019 16:47:23 +0200
Subject: [PATCH] [Code Style] Remove std namespace in test file



From afdb9d492c7e666a82b85ebb22fb9416ef61aed2 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Thu, 16 May 2019 19:08:59 +0200
Subject: [PATCH] [RPC] Parse public spend on getserials rpc command.

[Cleanup] non used variable commented.


From 46e453b8bc71645de706a64dbd196ebce5a7db80 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Thu, 16 May 2019 20:24:11 +0200
Subject: [PATCH] [xION] reject priv coin spends on tx mempool acceptance.



From b5e2526da8abc34f3d0a40913818c71bef817a26 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Fri, 17 May 2019 01:37:25 +0200
Subject: [PATCH] [xION] publicCoinSpend version field included in the
 serialization for any future change.



From 2f750e50116b403ac202f6683279b59a82dfdc33 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Sun, 19 May 2019 23:13:30 +0200
Subject: [PATCH] [RPC] add 'createrawzerocoinpublicspend' method



From 0393227b6588c783f01edf1fc8bd8f128ab90ea2 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Sun, 19 May 2019 23:14:04 +0200
Subject: [PATCH] [Tests] add test reorg for public spend

[Unit Test] zc public spend test up-to-date with master.


From 216a3174affd4ba1ae7817af258d29ff722c7335 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Mon, 20 May 2019 10:49:21 +0200
Subject: [PATCH] [xION] testnet publicSpend enforcement height set.

[xION] v1 serials validation was not checked against the publicSpend height.


From 28afbd29814cd3fc92d9a1b4761919bcc72cd97f Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Tue, 21 May 2019 15:27:22 +0200
Subject: [PATCH] [xION] v1 serials modulus fix + isStandardTx fix for
 publicSpends.

cleanup, publicCoinSpend object leftover removed + minor log added to CheckProofOfStake.


From fda5fff1541c134a06994c8a823485253eb15fce Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 30 Apr 2019 11:33:10 +0200
Subject: [PATCH] [GUI] Disable zerocoin minting



From 9f3fa2add468148c0791b75d99c8458a261fe3be Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 30 Apr 2019 11:37:12 +0200
Subject: [PATCH] [RPC] Disable zerocoin minting

disabling also remint of change of a zc spend


From 2708b6f3bdd8b28bdd20423fec2fc2df366ea413 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 30 Apr 2019 11:54:20 +0200
Subject: [PATCH] [Consensus] Disable zerocoin minting in contextual check



From 3555f430d2c250492d7362a77379a23c9a3b0116 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Thu, 2 May 2019 11:18:29 +0200
Subject: [PATCH] [Wallet] Disable automint



From dcc74f8815707346c9c5d42a061c56432760f043 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Wed, 15 May 2019 01:28:02 +0200
Subject: [PATCH] [xION][Consensus] fix 'Zerocoin_Block_Public_Spend_Enabled()'
 enforcement



From 834cbeb1cc8af1c6b98104180f1736f4bd1c17a9 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 21 May 2019 16:00:15 +0200
Subject: [PATCH] [RPC] enable mint only for regtest



From b75d8bc0bbae0decc572e37495c56368fbc2ec80 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Fri, 7 Jun 2019 00:01:35 -0700
Subject: [PATCH] [Build] Clean all coverage files during make clean

This adds extra paths that were left out and ensures that `.gcda` and `
.gcno` files are properly cleaned up.


From d413496b01e527470742b3964594ec96b8ce994c Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Thu, 2 May 2019 23:14:24 -0700
Subject: [PATCH] [Build] Initial CMake support



From 69b0032749705dfb8ca425e2b40446dd4cc1b4e4 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Mon, 27 May 2019 00:32:30 -0700
Subject: [PATCH] fix config.h include file name



From 689ac23f62b8dbfd4de99497085a4b068af70dc2 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 7 Jun 2019 18:51:51 +0200
Subject: [PATCH] [RPC] add 'getblockindexstats' function



From f912182d27e143e168ae6567f31aee4b26d2ca49 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Sun, 9 Jun 2019 22:24:13 +0200
Subject: [PATCH] [Cleanup] clang compiler warnings in coinSpend and
 publicCoinSpend fixed.



From d2136e30e09add2c120a717c02221ebff9b3331f Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 8 Jun 2019 03:28:54 -0700
Subject: [PATCH] depends: Update from upstream



From ca2fd101ba951f268cf1a6102085fca28979b879 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sun, 9 Jun 2019 18:30:00 -0700
Subject: [PATCH] use non-Cellar OpenSSL path for macOS

removes the dependency on a specific version, as long as the installed
version is 1.0.x. Also set the appropriate environment flags for OpenSSL
 on macOS.

Note: the setting of these two environment variables would be better
suited to a user's `~/.bash_profile` rather than being done within
CMake, as doing it here is destructive.


From 55127d126459b98a125a3ff1110a8ca7b7074350 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sun, 9 Jun 2019 20:13:24 -0700
Subject: [PATCH] [Gitian] Bump gitian build versions

Bumps the gitian build versions to 3.3, which should have been done
right after 3.2 was branched off.

At the same time, update to python3 explicitly and allow for some better
 error reporting.


From 019d26ac4cdcdfdeacb2ab685562cbbb0df56380 Mon Sep 17 00:00:00 2001
From: CaveSpectre11 <36988814+CaveSpectre11@users.noreply.github.com>
Date: Mon, 10 Jun 2019 12:19:55 -0400
Subject: [PATCH] Don't assert if we were beaten to the block

A timing window exists where a wallet could be creating a new block from within the miner thread when a new block is received to the wallet.  This window will create a situation where TestBlockValidity() fails because the chain tip has changed between the time it created the new block and the time it tested the validity of the block.

This situation would result in the wallet being asserted; however this is a little overkill.  rather than asserting if the tip has changed, it is better to throw the block away.

This problem was revealed during a testnet test of an altcoin, and very prevalent when multiple wallet existed with the exact same number of staking coins received in the same transaction; or when multiple wallets were staking the same coins via import private key.  The problem happens significantly less in more normal circumstances, but was still observed in a testing environment with fast blocks.

It is likely that this scenario has been encountered but never determined to be root cause, as a crashed wallet could be restarted, re-indexed and never investigated further.


From 7980f23c0c1a99120908ca969b22daaf7ea5dccb Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 11 Jun 2019 17:16:27 +0200
Subject: [PATCH] [RPC] fix fee calculation in 'getblockindexstats' and
 'getfeeinfo'



From 26b1f0ca330901403ee456953943be17e7731578 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 11 Jun 2019 17:33:01 +0200
Subject: [PATCH] [RPC] 'getblockindexstats': count public spends separately



From a5f887b00e7fd1d9625d869a5b39717200160241 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sun, 9 Jun 2019 16:18:27 -0700
Subject: [PATCH] [Travis] Update TravisCI from upstream

Most notable change here is the introduction of two breakpoints that
will store the current cache and stop if the previous step took a long
time. This is intended to avoid hitting the global time limit of 50
minutes for builds that would need to rebuild the depends cache.


From addeb0ac0619d55c869eb346865b47dfea6cd1aa Mon Sep 17 00:00:00 2001
From: Matias Furszyfer <matiasfurszyfer@protonmail.com>
Date: Fri, 14 Jun 2019 15:12:33 +0200
Subject: [PATCH] Update accumulators.cpp



From 24d72d0f64eb7c4aff220e0e9401e31390b98737 Mon Sep 17 00:00:00 2001
From: CaveSpectre11 <36988814+CaveSpectre11@users.noreply.github.com>
Date: Fri, 14 Jun 2019 19:45:55 -0400
Subject: [PATCH] [code review] LogPrintf nit change



From 49ef846774e88698879f30ea1286da9cac66ccbd Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Sat, 15 Jun 2019 11:46:52 +0200
Subject: [PATCH] [RPC] fix help texts

- getblockindexstats
- getmintsinblocks
- getserials


From 46ba7a2b963d861a374077fa613bab60def6e447 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Sun, 16 Jun 2019 01:43:42 +0200
Subject: [PATCH] [Backport] Max tip age to consider a node in IBD status
 customizable. Backport from bitcoin##7208.



From eea9915361800081de7c27c0ba546766fca56732 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Mon, 17 Jun 2019 02:30:42 +0200
Subject: [PATCH] [RPC] fix locking strategy

- validaterange
- getfeeinfo
- geblockindexstats
- getmintsinblocks
- getserials


From 4fa4cc4ff25693306534495e2121b603f444542a Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:02:29 -0700
Subject: [PATCH] Update Contributing guidelines

Mainly punctuation and styling changes. Added a section about rebasing
pull requests.


From c5f6822af58e4312fdc97ec6e2d2264117cc27e9 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:05:22 -0700
Subject: [PATCH] Update tor.md

Updated to consider more recent versions and features of the tor router
(automatic hidden service creation/deletion).


From 231f28e6964980580646a020215345f1c15cc14a Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:06:34 -0700
Subject: [PATCH] Update translation_process.md

Fix some typos and refresh with more current information.


From 785b61cf5643f98113d4acbce7683bd11316e48b Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:07:34 -0700
Subject: [PATCH] Update zmq.md

Typo fixes and update python to python3 in sample commands


From df0d2ba1fe0bf61522236c6cd03d0c94010926e8 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:11:11 -0700
Subject: [PATCH] Introduce dependencies.md

This file contains explicit dependency information used for release
builds (version, link, etc).


From 2f5efbd12c2e427aa3b5f4738ed1a5d03985f756 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:12:11 -0700
Subject: [PATCH] Reformat files.md

Changed to markdown table layout for ease of reading. Removed old
bitcoin-only information for older versions that we never used.


From 3cea76be03aae8cd23d5b076ad187929a418f484 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:13:45 -0700
Subject: [PATCH] Update and reformat init.md



From 5b4f73def60b63c5b1a80d7ea454d846a3322c4a Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:21:28 -0700
Subject: [PATCH] Clean up whitespace in Doxyfile.in



From 20f251336a0e8af25147e1d03d39f3af45e97f28 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:24:22 -0700
Subject: [PATCH] Update doc/README.md

Fix namings, outdated links, and sample commands


From 9335a103d11a013e72cd51eba0c5c88b2cdfac8d Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:26:03 -0700
Subject: [PATCH] Update test/functional/README.md

Added more details regarding the purpose, writing, and use of the
regression test suite.


From 0b5c0c262b5f1b9a4aff4353885f179fc9766fbf Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:34:01 -0700
Subject: [PATCH] Update release-process.md

Minor formatting and grammatical changes. Remove stale reference to the
aarch64 gitian descriptor.


From d1a65fdcafe0fad1ea80af18ad1caa501830e013 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:35:18 -0700
Subject: [PATCH] Update dnsseed-policy.md

grammatical fixes


From 2bc9d1b0f1721a2e260a3b6569fe59d71bb45b4f Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:37:16 -0700
Subject: [PATCH] Update developer-notes.md

Add TOC and expand on style guidelines as well as better describe
testing cases.


From 019b8f4e8c36d58947beac66b12f4ea9eab9fe5d Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:38:04 -0700
Subject: [PATCH] Update contrib/devtools/README.md

Prep for new/renamed scripts


From d2af9593e4eef9d2e54c74a9f215ad05a2bc1280 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:43:48 -0700
Subject: [PATCH] Introduce translation_strings_policy.md

Adds guidelines for adding new translation strings in the code


From 007cc8c2893cbc5363abdbabd782b1e7b1fa2c8e Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:55:01 -0700
Subject: [PATCH] Update src/test/README.md

Update the in-tree README.md with the contents of `doc/unit-tests.md`,
and delete the redundant doc file.


From 1558ff775eb60bc416a1e443a74ea6210729bd93 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 02:44:34 -0700
Subject: [PATCH] Update install_db4.sh



From 70721b47acc89156c07bbec1f8779bb393ddd8c0 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 02:45:15 -0700
Subject: [PATCH] Migrate update-translations.py to python3



From 035dda7458dc619b57bad4d0f501687b21b7c3e8 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 02:46:46 -0700
Subject: [PATCH] Introduce circular-dependencies.py

This script can be used to find circular include dependencies in the
code base. These should eventually be weeded out.


From b0d7d07512ca2a27051699d06be206e0556f1fca Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 02:50:53 -0700
Subject: [PATCH] Update github-merge.py



From 28bd93359abd5ed71b897cdf44e0bbfd48fe186f Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 03:55:34 -0700
Subject: [PATCH] Update gitian-build.py

latest version from upstream, IONified


From 0367807d49ec9618725b31c5817501f51b751bf9 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 03:56:26 -0700
Subject: [PATCH] Introduce commit-script-check.sh

This script can be used to verify scripted diff commits


From 0608b9ca95e96b0f34d02a9523cc0bdf05f3a1a9 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 03:57:17 -0700
Subject: [PATCH] Misc updates



From 2621b7f3f7da1516472320255fa5b243ac40b750 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 16:33:35 +0200
Subject: [PATCH] [Refactoring] Move ContextualCheckZerocoinStake() to
 kernel.cpp

And call it in CheckProofOfStake() which is called by AcceptBlock()
instead of calling it directly from AcceptBlock().


From 105ee5fd078cf20854a18a4ec879adcfdda9970d Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 16:54:10 +0200
Subject: [PATCH] [Consensus] Readd checks removed in
 3b778f56fe2b5e5b363c8c6d794a848a84d630d1

Two importants checks were removed while refactoring to add xION
staking. Their equivalents were added to xION staking but missing for
simple ION staking. We add them back with this commit.


From 88705a6099f0c42d122c5717fccd08f6485f0b0a Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Mon, 20 May 2019 12:46:51 +0200
Subject: [PATCH] [Consensus] Guard time checks changes

Guard these changes against the protocol version change enforcement


From d1b54b69b4e8dc325fabb52019e281e2276d837e Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Mon, 17 Jun 2019 23:34:54 -0700
Subject: [PATCH] make translate



From e515b1e9f2309d27efea69beae6569ee92178d88 Mon Sep 17 00:00:00 2001
From: Pieter Wuille <pieter.wuille@gmail.com>
Date: Tue, 25 Nov 2014 16:26:20 +0100
Subject: [PATCH] [Node] Do all block index writes in a batch

Backport from bitcoin bitcoin/bitcoin#5367


From 7c9859f40d7d6c5f1eda99569c818fd456b5353c Mon Sep 17 00:00:00 2001
From: Mrs-X <Mrs-X@users.noreply.github.com>
Date: Thu, 20 Jun 2019 13:39:32 +0200
Subject: [PATCH] [Qt] Add blockhash + datadir to information tab



From cde9d134672ac87ac941a8ca296f823887267c63 Mon Sep 17 00:00:00 2001
From: Isidoro Ghezzi <isidoro.ghezzi@icloud.com>
Date: Wed, 17 Oct 2018 16:12:42 +0200
Subject: [PATCH] show the progress of functional test
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

example (added the progress index `n/m`)
```
1/107 - wallet_hd.py passed, Duration: 27 s
.........................................................................................
2/107 - mining_getblocktemplate_longpoll.py passed, Duration: 72 s
..................................................................
3/107 - feature_maxuploadtarget.py passed, Duration: 78 s
```

- clear dots line
```
$ test/functional/test_runner.py -t can_trash
Temporary test directory at can_trash/test_runner_₿_🏃_20181018_220600
1/105 - wallet_hd.py passed, Duration: 21 s
2/105 - mining_getblocktemplate_longpoll.py passed, Duration: 71 s
3/105 - feature_maxuploadtarget.py passed, Duration: 68 s
..................
```

- don't print the `dot` progressive if `--quiet`

- done_str
- nothing commit to check again travis tests


From a57939f00de8a874c099a341713cc6c79b35e5cc Mon Sep 17 00:00:00 2001
From: Chun Kuan Lee <ken2812221@gmail.com>
Date: Tue, 30 Oct 2018 21:06:44 +0800
Subject: [PATCH] tests: Print dots by default



From ae0b4d028d237d0eadbb035668c3c13598195d3b Mon Sep 17 00:00:00 2001
From: Steven Roose <steven@stevenroose.org>
Date: Fri, 22 Feb 2019 18:06:34 +0000
Subject: [PATCH] tests: Print remaining jobs in test_runner.py

This helps finding out which tests fail to finish.


From e4945a25b4d1482caf965a8ce1127d433ea39927 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 9 Jul 2019 09:45:27 +0200
Subject: [PATCH] [Travis] Log more info



From 1fa0bf37438ff9fcaa759e1754b41caa8dce93ee Mon Sep 17 00:00:00 2001
From: MarcoFalke <falke.marco@gmail.com>
Date: Fri, 14 Jun 2019 10:31:07 -0400
Subject: [PATCH] travis: Fix caching issues



From 1aa76d07e5c981295c3495c694803ea63b277ee8 Mon Sep 17 00:00:00 2001
From: MarcoFalke <falke.marco@gmail.com>
Date: Fri, 14 Jun 2019 10:49:00 -0400
Subject: [PATCH] travis: Use absolute paths for cache dirs



From 5fbf26caf62c8788682a9e828f4004ce6310f923 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 9 Jul 2019 15:22:59 +0200
Subject: [PATCH] [Travis] Give more time to tests

Travis was regularly failing because the full test suite with coverage
takestoo much time.
Bitcoin has some optimisations in there which allows them to give less
time to the test part of the process. We don't so until we do, we have
to reserve more time. We will probably have to restart manually more
travis jobs but that's the only way to have them run to the end.

Overview of adapted commits: https://github.com/ioncoincore/ion/commits/5305677c9ffb7cf8a5fa47dee654e668e1c9eba6

PR includes adapted versions of these original commits:

From 7491d6caf7ff8236ddf525e91f523655faca671c Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Fri, 22 Mar 2019 17:20:32 -0700
Subject: [PATCH] Fix wrapped serial functional test

The error message had changed

From 4da1dcad89481d18ceb8ed1b2dfbb6be1cc8f5c3 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Fri, 22 Mar 2019 17:23:27 -0700
Subject: [PATCH] Disable precompute for functional tests

The locking can interfere with block generation

From 4e4975b6990bba15062e4e8c3117e6cc368b06ae Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Thu, 11 Oct 2018 13:41:48 +0200
Subject: [PATCH] [Refactor] Refactor bignum header file into several files

From 3ec04f7069a0127c88dc29ce8d388ae16ba160f0 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 12:40:28 +0200
Subject: [PATCH] [Refactor] Refactor CBudgetProposal::IsEstablished()

-Move IsEstablished function to cpp file
-Use GetAdjustedTime() instead of GetTime() to avoid lack of consensus
-Remove magic numbers and declare them in chainparams

From b079abfebd179fca33cc91728f4168e3b9b879c2 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Thu, 25 Apr 2019 22:36:48 -0700
Subject: [PATCH] [RPC] Remove deprecated masternode/budget RPC commands

The old `masternode` and `mnbudget` commands have been deprecated for
quite some time now, and have had a note in their help descriptions
stating as much. So, time to finally remove them for good.

From bda03227cc1ca5e83da3d7d9e62d5d49fcc0f1d2 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 12:53:42 +0200
Subject: [PATCH] [Refactoring] Add IsPassing function to CBudgetProposal

Makes the code easier to read and allows for reusing of this functions
in other places.

From 89ce7fff847d0fbfbbcd2bb153627ee3e30593c5 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 11:37:02 +0200
Subject: [PATCH] [Qt] Add new colors for proposals

Show passing (enough votes and whatnot) but unfunded (lack of funds in the budget)
proposals in yellow and unestablished proposals (less than 24 hours
since submission) in blue

From 3601d0020c30487ae3c940126a685343318a3eef Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 12:32:10 +0200
Subject: [PATCH] [Qt] Print the actual number of MN used for voting

From 6e484905295d59ef566ef35b371f4797796daf24 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 13:23:01 +0200
Subject: [PATCH] [Budget] Guard against chainactive tip clash

From 56278072678ed6f15bdb4e6fe41d688c4010a029 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 26 Apr 2019 03:39:48 +0200
Subject: [PATCH] [Zerocoin] Fix limits for random number generators in GMP
 bignum implementation

From daeb7520c195107f4253b0ef2672b1faa142fdaa Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 26 Apr 2019 23:15:16 +0200
Subject: [PATCH] [Test] Add tests for bignum random generators

From 671452e Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Mon, 29 Apr 2019 01:14:36 -0700
Subject: [PATCH] Rename ui_interface.h file

This file's naming convention is not in line with what is used
everywhere else. Additionally, the `ui_` prefix is typically reserved
for QMake's UIC pre-processor to generate compiler-compatible code from
Qt's `.ui` files.

Renaming this file opens the door to adding CMake build support
**without** needing to hackishly work around this one file's name, and
it becomes more in-line with the naming conventions used for every other
 source file.

From 2c76194c757ddd6a9081ee555b191c6dbb326c50 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Sat, 4 May 2019 11:10:22 +0200
Subject: [PATCH] [Net] Valid blocks from forks badly rejected due an invalid
 view of the available utxo set for forked chains + split height going one
 block further than what should be.

[Net] acceptBlock, back to chain split was going one block further if prev was the previous block of the incoming block.

[Net] coins cache view only has the tip view and not forks utxo chain view.

From 754764be02af58b0b2059f580b40bf5f6380fa4d Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Tue, 7 May 2019 11:19:54 +0200
Subject: [PATCH] [Net] AcceptBlock, first prev block loaded from disk.

From f14569faab4cee1130b68a29932dcde7b35899b2 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Wed, 8 May 2019 16:08:20 +0200
Subject: [PATCH] [Zerocoin] remove CTransaction::IsZerocoinSpend and
 CTransaction::IsZerocoinMint

- uniform IsZerocoinSpend/IsZerocoinMint CScript functions
- refactor CTxIn::IsZerocoinSpend / CTxOut::IsZerocoinMint encapsulating CScript methods
- add CTransaction methods: HasZerocoinMintOutputs / HasZerocoinSpendInputs
- refactor CTransaction::ContainsZerocoins from previous 'HasZerocoin' functions
- fix implementation of CTransaction::GetZerocoinMinted (from CTxOut)
- remove extra checks for empty scripts (as those are done in CScript functions)

From b5a525767ae62a39f0a691a9345439b457f661b8 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Wed, 8 May 2019 17:58:57 +0200
Subject: [PATCH] [Refactor] Remove unused setStakeSeen variable

From d7afebb4795163e4904135c7f3b69379a9a57010 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 14 May 2019 15:39:31 +0200
Subject: [PATCH] [UI] Simplify Qt margins. No functional change.

From 2d052155ffcb7325546a118738f9cc3aa3a15cea Mon Sep 17 00:00:00 2001
From: Alko89 <alefer89@gmail.com>
Date: Tue, 14 May 2019 11:48:14 +0200
Subject: [PATCH] Hide xion related options.

From c424f0f244b92b800a354b06e9d24935d539e99b Mon Sep 17 00:00:00 2001
From: Alko89 <alefer89@gmail.com>
Date: Tue, 14 May 2019 16:47:27 +0200
Subject: [PATCH] Fix margins

From 4e8f46a376335ea271b5ac480644a013da0d4b47 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Tue, 14 May 2019 16:24:29 -0700
Subject: [PATCH] [Qt] Fixup duplicate label names

resolves compiler warnings about a label's name having been already used
.

From 4d44c9781a95bb80e81f48e551e791a1eeb8cb66 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Wed, 6 Mar 2019 20:05:20 +0100
Subject: [PATCH] [Refactoring] Replace BOOST FOREACH with for :

Done using following script:

-BEGIN VERIFY SCRIPT-
sed -i 's/BOOST_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp
./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
-END VERIFY SCRIPT-

From e1c549e8a798d0c818b49bb6089337ba61aaf3ed Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Wed, 6 Mar 2019 20:45:45 +0100
Subject: [PATCH] [Refactor] Remove useless BOOST includes and readd where
 needed

From 4f6cd20b0dcafd30e3b5bc9e61278b83dd411102 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Tue, 14 May 2019 00:47:13 -0700
Subject: [PATCH] Cleanup clang's range loop analysis warnings

From a789d21635d02eefa5a5485b8c812fc249ce3a63 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Wed, 15 May 2019 05:29:22 +0200
Subject: [PATCH] [xION] Disable zerocoins inclusion in 'SelectStakeCoins'

From 742a7b187ca374e70dd6f6aaffc83b68badcfb7f Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Wed, 27 Feb 2019 14:56:40 -0800
Subject: [PATCH] [Qt] Remove unused obfuscationconfig

obfuscationconfig(.h/.cpp) are unused and not needed at all anymore.

From 886d806f58e692cb125a2b247b096a9b15cf1987 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Wed, 27 Feb 2019 15:02:51 -0800
Subject: [PATCH] Remove unused code in DoAutomaticDenominating

This function statically returns `false`, no need to have anything else
here.

From 166b2d31c8f438d17937335706b51df35856d98d Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Wed, 27 Feb 2019 15:14:00 -0800
Subject: [PATCH] Remove nAnonymizeIonAmount and nLiquidityProvider

These two variables have been meaningless since xION's introduction...

Nuke them from orbit!

From 3bb5c768bf8d40716843216155353fe18d4d451e Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Wed, 27 Feb 2019 20:34:03 -0800
Subject: [PATCH] Remove unused functions in wallet.cpp

these functions were used back when obfuscation existed and are no
longer called anywhere in the source tree.

From eed0a1d34ebc6b4fd43619d9296e2cfe1dbf5d43 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Thu, 28 Feb 2019 01:38:15 -0800
Subject: [PATCH] Remove more useless obfuscation code

From fe67706fd222168e4bb6a387566a48dbd667638c Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Thu, 28 Feb 2019 12:23:36 -0800
Subject: [PATCH] Remove more useless obfuscation code

From a4205f21b52876a642e9c68d7eac84430483202e Mon Sep 17 00:00:00 2001
From: Julian Meyer <julianmeyer2000@gmail.com>
Date: Wed, 15 May 2019 12:10:23 -0700
Subject: [PATCH] [UI] Fix improperly parented walletView.

Fixes #789.

From f3308f404d18f9ff42c83e496dd8081de13c3c86 Mon Sep 17 00:00:00 2001
From: CaveSpectre11 <36988814+CaveSpectre11@users.noreply.github.com>
Date: Thu, 16 May 2019 08:41:13 -0400
Subject: [PATCH] Fix typos and oversights in listunspent

From 962a1bca0aea4ab37032d1ef13323f85280e62a9 Mon Sep 17 00:00:00 2001
From: Pieter Wuille <pieter.wuille@gmail.com>
Date: Tue, 3 Mar 2015 07:49:12 -0800
Subject: [PATCH] Reinitialize state in between individual unit tests.

This changes the TestingSetup fixture to be per-unit-test rather than global.
Most tests don't need it, so it's only invoked in a few.

From c5054e4f729b7c82c8768b688e66909d266b017f Mon Sep 17 00:00:00 2001
From: "Wladimir J. van der Laan" <laanwj@gmail.com>
Date: Thu, 12 Mar 2015 09:34:42 +0100
Subject: [PATCH] tests: add a BasicTestingSetup and apply to all tests

Make sure that chainparams and logging is properly initialized. Doing
this for every test may be overkill, but this initialization is so
simple that that does not matter.

This should fix the travis issues.

From 253c63edad3bc75107ab5cf1c5e187569327e082 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 17 May 2019 12:46:22 +0200
Subject: [PATCH] [Zerocoin] include 0 in randBignum() range

From ca86660e7ec2f9e66af7830517925e4dd539047c Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 1 May 2019 11:44:26 +0200
Subject: [PATCH] [Zeroocoin] public coin spend script creation, validation and
 un/serialization.

From 1db7c59847d90f9a341bbbb66ead6ab4a9b2bbd0 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 1 May 2019 11:44:58 +0200
Subject: [PATCH] [UNIT TEST] publicCoinSpend valid input creation and
 verification.

[UNIT TEST] publicCoinSpend creation + validation completed.

From 0e8d0f90e49566a82aedcb3da9db4a903c5c4a25 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 1 May 2019 11:47:18 +0200
Subject: [PATCH] [Wallet] public coin spend creation connected + first mem
 pool validation.

[Zerocoin] public coin spend improvements.

[Zerocoin] publicCoinSpend validations connected to the accept txes flow.

[Zerocoin] public spends not checked as regular inputs.

[Zerocoin] publicCoinSpend validation as regular spends.

non good solution for the coinSpend pointer inheritance issue but at least working

[Zerocoin] ParseZerocoinPublicSpend moved into xionmodule file.

cleanup unused field.

From c8d519eb5d72f4ccdc53e0ad30ae56e0840eaf48 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Mon, 13 May 2019 20:52:30 +0200
Subject: [PATCH] [xION] xION Maturity --> Minimum amount of coins accumulated
 no needed anymore.

From e7dada8d621d51b400e8e3b7da339166747f2c27 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Mon, 13 May 2019 21:45:21 +0200
Subject: [PATCH] [xION] publicCoinSpend signature hash relevant data
 inclusion.

From f93001663b999259dfbce2035e131caa7348850f Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Tue, 14 May 2019 15:50:45 +0200
Subject: [PATCH] [xION] rebase problems fixed. (Needs more testing)

From 3c74d6d2f116d6a45bc665ba4af9bb827dad21b6 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Tue, 14 May 2019 17:23:15 +0200
Subject: [PATCH] [xION] new protocol enforcement height added. Height not
 final, just randomly selected and tested on regtest.

From 657bb41293adf08fa3cb0502fdeca06361420f87 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 14 May 2019 23:22:13 +0200
Subject: [PATCH] [xION][Cleanup] PublicSpend rebase onto IsZerocoin

From cb4ffa16cbb53475e4cdc0e6d898911456a4ea5c Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 14 May 2019 23:22:41 +0200
Subject: [PATCH] [xION] remove enforcement from
 'CreateZerocoinSpendTransaction' fixing the unit tests

From 44398690d1d4c3f63b9fefc88b9f7ae589f4c8a0 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 01:13:52 +0200
Subject: [PATCH] [xION][Consensus] reject V1 serials spends.

From e0decb154128a03b89ea363419770c704c607bf9 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Wed, 15 May 2019 03:10:01 +0200
Subject: [PATCH] [xION] prevent v1 zerocoins from being selected for
 PublicSpends

From a8ce6717dba4202e7d5df1bf5182c3bd0225b2e4 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Wed, 15 May 2019 06:38:29 +0200
Subject: [PATCH] [xION] use new limit Zerocoin_MaxPublicSpendsPerTransaction
 for max num of inputs

From 262d5e7fce41890943847c3ece65b0e77eb7ec1e Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 15:40:55 +0200
Subject: [PATCH] [xION] mints coin control dialog min accumulation mature text
 removed + re mint change checkbox not visible anymore.

From 507f7c8f5a38155ebac9e2719474149c036f9dbe Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 17:24:10 +0200
Subject: [PATCH] [FUNCTIONAL TESTS] valid PublicCoinSpend transaction test.

From fdfd999d10bfda638fcc45fc4768c8f40032db8a Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 17:40:51 +0200
Subject: [PATCH] [xION[Unit Test] Possible redundant denomination validation.

From f46b80ed5e86ce46e79367a755f11d143d7a1908 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 18:01:38 +0200
Subject: [PATCH] [FUNCTIONAL TEST][xION] double spent serial validation.

From 3d0893ae81b134a8033d80d54133d9899731b48d Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 18:43:14 +0200
Subject: [PATCH] [RPC] spendzerocoin command can now create old zc spends,
 only for regression tests

From 88cdfc60ea88ac784718c11094e76c903b1ffe52 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 19:21:05 +0200
Subject: [PATCH] [FUNCTIONAL TEST] old coinSpend transaction rejected.

From 9c0329c72b96af50a4bd8e971a31726346835d2d Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Sun, 19 May 2019 19:09:30 +0200
Subject: [PATCH] [zerocoin] Free memory from ToString()

Simple fix for a minor memory leak

From 93bc03763be673bdac0edff86fffc0022a3e7a8b Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Mon, 20 May 2019 23:54:17 +0200
Subject: [PATCH] [Log] Handle errors during log message formatting

From d4da01588bda9a98ad21323663a9b8a78e3c59ee Mon Sep 17 00:00:00 2001
From: EthanHeilman <ethan.r.heilman@gmail.com>
Date: Tue, 22 Sep 2015 15:24:16 -0400
Subject: [PATCH] Creates unittests for addrman, makes addrman testable.

Adds several unittests for addrman to verify it works as expected.
Makes small modifications to addrman to allow deterministic and targeted tests.

From 3355c86ccedc7bf8b83eed2455c046d27cb56685 Mon Sep 17 00:00:00 2001
From: Ethan Heilman <Ethan.R.Heilman@gmail.com>
Date: Sat, 12 Dec 2015 22:34:08 -0500
Subject: [PATCH] Increase test coverage for addrman and addrinfo

Adds several unittests for CAddrMan and CAddrInfo.
Increases the accuracy of addrman tests.
Removes non-determinism in tests by overriding the random number generator.
Extracts testing code from addrman class to test class.

From c84e0e83ba9ba556bd66ae50d6e4eb6a6b243bab Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Mon, 20 May 2019 16:47:23 +0200
Subject: [PATCH] [Code Style] Remove std namespace in test file

From afdb9d492c7e666a82b85ebb22fb9416ef61aed2 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Thu, 16 May 2019 19:08:59 +0200
Subject: [PATCH] [RPC] Parse public spend on getserials rpc command.

[Cleanup] non used variable commented.

From 46e453b8bc71645de706a64dbd196ebce5a7db80 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Thu, 16 May 2019 20:24:11 +0200
Subject: [PATCH] [xION] reject priv coin spends on tx mempool acceptance.

From b5e2526da8abc34f3d0a40913818c71bef817a26 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Fri, 17 May 2019 01:37:25 +0200
Subject: [PATCH] [xION] publicCoinSpend version field included in the
 serialization for any future change.

From 2f750e50116b403ac202f6683279b59a82dfdc33 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Sun, 19 May 2019 23:13:30 +0200
Subject: [PATCH] [RPC] add 'createrawzerocoinpublicspend' method

From 0393227b6588c783f01edf1fc8bd8f128ab90ea2 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Sun, 19 May 2019 23:14:04 +0200
Subject: [PATCH] [Tests] add test reorg for public spend

[Unit Test] zc public spend test up-to-date with master.

From 216a3174affd4ba1ae7817af258d29ff722c7335 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Mon, 20 May 2019 10:49:21 +0200
Subject: [PATCH] [xION] testnet publicSpend enforcement height set.

[xION] v1 serials validation was not checked against the publicSpend height.

From 28afbd29814cd3fc92d9a1b4761919bcc72cd97f Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Tue, 21 May 2019 15:27:22 +0200
Subject: [PATCH] [xION] v1 serials modulus fix + isStandardTx fix for
 publicSpends.

cleanup, publicCoinSpend object leftover removed + minor log added to CheckProofOfStake.

From fda5fff1541c134a06994c8a823485253eb15fce Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 30 Apr 2019 11:33:10 +0200
Subject: [PATCH] [GUI] Disable zerocoin minting

From 9f3fa2add468148c0791b75d99c8458a261fe3be Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 30 Apr 2019 11:37:12 +0200
Subject: [PATCH] [RPC] Disable zerocoin minting

disabling also remint of change of a zc spend

From 2708b6f3bdd8b28bdd20423fec2fc2df366ea413 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 30 Apr 2019 11:54:20 +0200
Subject: [PATCH] [Consensus] Disable zerocoin minting in contextual check

From 3555f430d2c250492d7362a77379a23c9a3b0116 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Thu, 2 May 2019 11:18:29 +0200
Subject: [PATCH] [Wallet] Disable automint

From dcc74f8815707346c9c5d42a061c56432760f043 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Wed, 15 May 2019 01:28:02 +0200
Subject: [PATCH] [xION][Consensus] fix 'Zerocoin_Block_Public_Spend_Enabled()'
 enforcement

From 834cbeb1cc8af1c6b98104180f1736f4bd1c17a9 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 21 May 2019 16:00:15 +0200
Subject: [PATCH] [RPC] enable mint only for regtest

From b75d8bc0bbae0decc572e37495c56368fbc2ec80 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Fri, 7 Jun 2019 00:01:35 -0700
Subject: [PATCH] [Build] Clean all coverage files during make clean

This adds extra paths that were left out and ensures that `.gcda` and `
.gcno` files are properly cleaned up.

From d413496b01e527470742b3964594ec96b8ce994c Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Thu, 2 May 2019 23:14:24 -0700
Subject: [PATCH] [Build] Initial CMake support

From 69b0032749705dfb8ca425e2b40446dd4cc1b4e4 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Mon, 27 May 2019 00:32:30 -0700
Subject: [PATCH] fix config.h include file name

From 689ac23f62b8dbfd4de99497085a4b068af70dc2 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 7 Jun 2019 18:51:51 +0200
Subject: [PATCH] [RPC] add 'getblockindexstats' function

From f912182d27e143e168ae6567f31aee4b26d2ca49 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Sun, 9 Jun 2019 22:24:13 +0200
Subject: [PATCH] [Cleanup] clang compiler warnings in coinSpend and
 publicCoinSpend fixed.

From d2136e30e09add2c120a717c02221ebff9b3331f Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 8 Jun 2019 03:28:54 -0700
Subject: [PATCH] depends: Update from upstream

From ca2fd101ba951f268cf1a6102085fca28979b879 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sun, 9 Jun 2019 18:30:00 -0700
Subject: [PATCH] use non-Cellar OpenSSL path for macOS

removes the dependency on a specific version, as long as the installed
version is 1.0.x. Also set the appropriate environment flags for OpenSSL
 on macOS.

Note: the setting of these two environment variables would be better
suited to a user's `~/.bash_profile` rather than being done within
CMake, as doing it here is destructive.

From 55127d126459b98a125a3ff1110a8ca7b7074350 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sun, 9 Jun 2019 20:13:24 -0700
Subject: [PATCH] [Gitian] Bump gitian build versions

Bumps the gitian build versions to 3.3, which should have been done
right after 3.2 was branched off.

At the same time, update to python3 explicitly and allow for some better
 error reporting.

From 019d26ac4cdcdfdeacb2ab685562cbbb0df56380 Mon Sep 17 00:00:00 2001
From: CaveSpectre11 <36988814+CaveSpectre11@users.noreply.github.com>
Date: Mon, 10 Jun 2019 12:19:55 -0400
Subject: [PATCH] Don't assert if we were beaten to the block

A timing window exists where a wallet could be creating a new block from within the miner thread when a new block is received to the wallet.  This window will create a situation where TestBlockValidity() fails because the chain tip has changed between the time it created the new block and the time it tested the validity of the block.

This situation would result in the wallet being asserted; however this is a little overkill.  rather than asserting if the tip has changed, it is better to throw the block away.

This problem was revealed during a testnet test of an altcoin, and very prevalent when multiple wallet existed with the exact same number of staking coins received in the same transaction; or when multiple wallets were staking the same coins via import private key.  The problem happens significantly less in more normal circumstances, but was still observed in a testing environment with fast blocks.

It is likely that this scenario has been encountered but never determined to be root cause, as a crashed wallet could be restarted, re-indexed and never investigated further.

From 7980f23c0c1a99120908ca969b22daaf7ea5dccb Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 11 Jun 2019 17:16:27 +0200
Subject: [PATCH] [RPC] fix fee calculation in 'getblockindexstats' and
 'getfeeinfo'

From 26b1f0ca330901403ee456953943be17e7731578 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 11 Jun 2019 17:33:01 +0200
Subject: [PATCH] [RPC] 'getblockindexstats': count public spends separately

From a5f887b00e7fd1d9625d869a5b39717200160241 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sun, 9 Jun 2019 16:18:27 -0700
Subject: [PATCH] [Travis] Update TravisCI from upstream

Most notable change here is the introduction of two breakpoints that
will store the current cache and stop if the previous step took a long
time. This is intended to avoid hitting the global time limit of 50
minutes for builds that would need to rebuild the depends cache.

From addeb0ac0619d55c869eb346865b47dfea6cd1aa Mon Sep 17 00:00:00 2001
From: Matias Furszyfer <matiasfurszyfer@protonmail.com>
Date: Fri, 14 Jun 2019 15:12:33 +0200
Subject: [PATCH] Update accumulators.cpp

From 24d72d0f64eb7c4aff220e0e9401e31390b98737 Mon Sep 17 00:00:00 2001
From: CaveSpectre11 <36988814+CaveSpectre11@users.noreply.github.com>
Date: Fri, 14 Jun 2019 19:45:55 -0400
Subject: [PATCH] [code review] LogPrintf nit change

From 49ef846774e88698879f30ea1286da9cac66ccbd Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Sat, 15 Jun 2019 11:46:52 +0200
Subject: [PATCH] [RPC] fix help texts

- getblockindexstats
- getmintsinblocks
- getserials

From 46ba7a2b963d861a374077fa613bab60def6e447 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Sun, 16 Jun 2019 01:43:42 +0200
Subject: [PATCH] [Backport] Max tip age to consider a node in IBD status
 customizable. Backport from bitcoin##7208.

From eea9915361800081de7c27c0ba546766fca56732 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Mon, 17 Jun 2019 02:30:42 +0200
Subject: [PATCH] [RPC] fix locking strategy

- validaterange
- getfeeinfo
- geblockindexstats
- getmintsinblocks
- getserials

From 4fa4cc4ff25693306534495e2121b603f444542a Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:02:29 -0700
Subject: [PATCH] Update Contributing guidelines

Mainly punctuation and styling changes. Added a section about rebasing
pull requests.

From c5f6822af58e4312fdc97ec6e2d2264117cc27e9 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:05:22 -0700
Subject: [PATCH] Update tor.md

Updated to consider more recent versions and features of the tor router
(automatic hidden service creation/deletion).

From 231f28e6964980580646a020215345f1c15cc14a Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:06:34 -0700
Subject: [PATCH] Update translation_process.md

Fix some typos and refresh with more current information.

From 785b61cf5643f98113d4acbce7683bd11316e48b Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:07:34 -0700
Subject: [PATCH] Update zmq.md

Typo fixes and update python to python3 in sample commands

From df0d2ba1fe0bf61522236c6cd03d0c94010926e8 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:11:11 -0700
Subject: [PATCH] Introduce dependencies.md

This file contains explicit dependency information used for release
builds (version, link, etc).

From 2f5efbd12c2e427aa3b5f4738ed1a5d03985f756 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:12:11 -0700
Subject: [PATCH] Reformat files.md

Changed to markdown table layout for ease of reading. Removed old
bitcoin-only information for older versions that we never used.

From 3cea76be03aae8cd23d5b076ad187929a418f484 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:13:45 -0700
Subject: [PATCH] Update and reformat init.md

From 5b4f73def60b63c5b1a80d7ea454d846a3322c4a Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:21:28 -0700
Subject: [PATCH] Clean up whitespace in Doxyfile.in

From 20f251336a0e8af25147e1d03d39f3af45e97f28 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:24:22 -0700
Subject: [PATCH] Update doc/README.md

Fix namings, outdated links, and sample commands

From 9335a103d11a013e72cd51eba0c5c88b2cdfac8d Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:26:03 -0700
Subject: [PATCH] Update test/functional/README.md

Added more details regarding the purpose, writing, and use of the
regression test suite.

From 0b5c0c262b5f1b9a4aff4353885f179fc9766fbf Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:34:01 -0700
Subject: [PATCH] Update release-process.md

Minor formatting and grammatical changes. Remove stale reference to the
aarch64 gitian descriptor.

From d1a65fdcafe0fad1ea80af18ad1caa501830e013 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:35:18 -0700
Subject: [PATCH] Update dnsseed-policy.md

grammatical fixes

From 2bc9d1b0f1721a2e260a3b6569fe59d71bb45b4f Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:37:16 -0700
Subject: [PATCH] Update developer-notes.md

Add TOC and expand on style guidelines as well as better describe
testing cases.

From 019b8f4e8c36d58947beac66b12f4ea9eab9fe5d Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:38:04 -0700
Subject: [PATCH] Update contrib/devtools/README.md

Prep for new/renamed scripts

From d2af9593e4eef9d2e54c74a9f215ad05a2bc1280 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:43:48 -0700
Subject: [PATCH] Introduce translation_strings_policy.md

Adds guidelines for adding new translation strings in the code

From 007cc8c2893cbc5363abdbabd782b1e7b1fa2c8e Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:55:01 -0700
Subject: [PATCH] Update src/test/README.md

Update the in-tree README.md with the contents of `doc/unit-tests.md`,
and delete the redundant doc file.

From 1558ff775eb60bc416a1e443a74ea6210729bd93 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 02:44:34 -0700
Subject: [PATCH] Update install_db4.sh

From 70721b47acc89156c07bbec1f8779bb393ddd8c0 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 02:45:15 -0700
Subject: [PATCH] Migrate update-translations.py to python3

From 035dda7458dc619b57bad4d0f501687b21b7c3e8 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 02:46:46 -0700
Subject: [PATCH] Introduce circular-dependencies.py

This script can be used to find circular include dependencies in the
code base. These should eventually be weeded out.

From b0d7d07512ca2a27051699d06be206e0556f1fca Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 02:50:53 -0700
Subject: [PATCH] Update github-merge.py

From 28bd93359abd5ed71b897cdf44e0bbfd48fe186f Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 03:55:34 -0700
Subject: [PATCH] Update gitian-build.py

latest version from upstream, IONified

From 0367807d49ec9618725b31c5817501f51b751bf9 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 03:56:26 -0700
Subject: [PATCH] Introduce commit-script-check.sh

This script can be used to verify scripted diff commits

From 0608b9ca95e96b0f34d02a9523cc0bdf05f3a1a9 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 03:57:17 -0700
Subject: [PATCH] Misc updates

From 2621b7f3f7da1516472320255fa5b243ac40b750 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 16:33:35 +0200
Subject: [PATCH] [Refactoring] Move ContextualCheckZerocoinStake() to
 kernel.cpp

And call it in CheckProofOfStake() which is called by AcceptBlock()
instead of calling it directly from AcceptBlock().

From 105ee5fd078cf20854a18a4ec879adcfdda9970d Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 16:54:10 +0200
Subject: [PATCH] [Consensus] Readd checks removed in
 3b778f56fe2b5e5b363c8c6d794a848a84d630d1

Two importants checks were removed while refactoring to add xION
staking. Their equivalents were added to xION staking but missing for
simple ION staking. We add them back with this commit.

From 88705a6099f0c42d122c5717fccd08f6485f0b0a Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Mon, 20 May 2019 12:46:51 +0200
Subject: [PATCH] [Consensus] Guard time checks changes

Guard these changes against the protocol version change enforcement

From d1b54b69b4e8dc325fabb52019e281e2276d837e Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Mon, 17 Jun 2019 23:34:54 -0700
Subject: [PATCH] make translate

From e515b1e9f2309d27efea69beae6569ee92178d88 Mon Sep 17 00:00:00 2001
From: Pieter Wuille <pieter.wuille@gmail.com>
Date: Tue, 25 Nov 2014 16:26:20 +0100
Subject: [PATCH] [Node] Do all block index writes in a batch

Backport from bitcoin bitcoin/bitcoin#5367

From 7c9859f40d7d6c5f1eda99569c818fd456b5353c Mon Sep 17 00:00:00 2001
From: Mrs-X <Mrs-X@users.noreply.github.com>
Date: Thu, 20 Jun 2019 13:39:32 +0200
Subject: [PATCH] [Qt] Add blockhash + datadir to information tab

From cde9d134672ac87ac941a8ca296f823887267c63 Mon Sep 17 00:00:00 2001
From: Isidoro Ghezzi <isidoro.ghezzi@icloud.com>
Date: Wed, 17 Oct 2018 16:12:42 +0200
Subject: [PATCH] show the progress of functional test
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

example (added the progress index `n/m`)
```
1/107 - wallet_hd.py passed, Duration: 27 s
.........................................................................................
2/107 - mining_getblocktemplate_longpoll.py passed, Duration: 72 s
..................................................................
3/107 - feature_maxuploadtarget.py passed, Duration: 78 s
```

- clear dots line
```
$ test/functional/test_runner.py -t can_trash
Temporary test directory at can_trash/test_runner_₿_🏃_20181018_220600
1/105 - wallet_hd.py passed, Duration: 21 s
2/105 - mining_getblocktemplate_longpoll.py passed, Duration: 71 s
3/105 - feature_maxuploadtarget.py passed, Duration: 68 s
..................
```

- don't print the `dot` progressive if `--quiet`

- done_str
- nothing commit to check again travis tests

From a57939f00de8a874c099a341713cc6c79b35e5cc Mon Sep 17 00:00:00 2001
From: Chun Kuan Lee <ken2812221@gmail.com>
Date: Tue, 30 Oct 2018 21:06:44 +0800
Subject: [PATCH] tests: Print dots by default

From ae0b4d028d237d0eadbb035668c3c13598195d3b Mon Sep 17 00:00:00 2001
From: Steven Roose <steven@stevenroose.org>
Date: Fri, 22 Feb 2019 18:06:34 +0000
Subject: [PATCH] tests: Print remaining jobs in test_runner.py

This helps finding out which tests fail to finish.

From e4945a25b4d1482caf965a8ce1127d433ea39927 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 9 Jul 2019 09:45:27 +0200
Subject: [PATCH] [Travis] Log more info

From 1fa0bf37438ff9fcaa759e1754b41caa8dce93ee Mon Sep 17 00:00:00 2001
From: MarcoFalke <falke.marco@gmail.com>
Date: Fri, 14 Jun 2019 10:31:07 -0400
Subject: [PATCH] travis: Fix caching issues

From 1aa76d07e5c981295c3495c694803ea63b277ee8 Mon Sep 17 00:00:00 2001
From: MarcoFalke <falke.marco@gmail.com>
Date: Fri, 14 Jun 2019 10:49:00 -0400
Subject: [PATCH] travis: Use absolute paths for cache dirs

From 5fbf26caf62c8788682a9e828f4004ce6310f923 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 9 Jul 2019 15:22:59 +0200
Subject: [PATCH] [Travis] Give more time to tests

Travis was regularly failing because the full test suite with coverage
takestoo much time.
Bitcoin has some optimisations in there which allows them to give less
time to the test part of the process. We don't so until we do, we have
to reserve more time. We will probably have to restart manually more
travis jobs but that's the only way to have them run to the end.

Backport from bitcoin bitcoin/bitcoin#5367

Backport from bitcoin bitcoin/bitcoin#5367

Backport from bitcoin bitcoin/bitcoin#5367

Backport from bitcoin bitcoin/bitcoin#5367

Backport from bitcoin bitcoin/bitcoin#5367

Backport from bitcoin bitcoin/bitcoin#5367

* Do all block index writes in a batch

Backport from bitcoin bitcoin/bitcoin#5367

* Add blockhash + datadir to information tab

* Fix permissions

* show the progress of functional test

example (added the progress index `n/m`)
```
1/107 - wallet_hd.py passed, Duration: 27 s
.........................................................................................
2/107 - mining_getblocktemplate_longpoll.py passed, Duration: 72 s
..................................................................
3/107 - feature_maxuploadtarget.py passed, Duration: 78 s
```

- clear dots line
```
$ test/functional/test_runner.py -t can_trash
Temporary test directory at can_trash/test_runner_₿_🏃_20181018_220600
1/105 - wallet_hd.py passed, Duration: 21 s
2/105 - mining_getblocktemplate_longpoll.py passed, Duration: 71 s
3/105 - feature_maxuploadtarget.py passed, Duration: 68 s
..................
```

- don't print the `dot` progressive if `--quiet`

- done_str
- nothing commit to check again travis tests

* tests: Print dots by default

* tests: Print remaining jobs in test_runner.py

This helps finding out which tests fail to finish.

* travis: Fix caching issues

* Log more info

* Use references instead of copies in for loops

turning on `-Wrange-loop-analysis` shows a number of compiler warnings
with c++11 for loops creating copies when references would suffice.

This cleans up those warnings.

* travis: Use absolute paths for cache dirs

* Remove (explicitely) unused tx comparator

We remove the '==' and '!=' operators from CMutableTransaction.
These comparators are never explicitely used in our code.
As it turns out, it was used implicitely and created this situation:
PIVX-Project/PIVX#510
So this change fixes #510.

* Give more time to tests

Travis was regularly failing because the full test suite with coverage
takestoo much time.
Bitcoin has some optimisations in there which allows them to give less
time to the test part of the process. We don't so until we do, we have
to reserve more time. We will probably have to restart manually more
travis jobs but that's the only way to have them run to the end.

* Sync github-merge.py with upstream

Pulls in further updates to the script from upstream since #921 was
merged.

* Move ThreadStakeMinter out of net.cpp

This moves the implementation function and thread creation to a more
appropriate file (`miner.cpp`).

* Remove all "using namespace" statements

This goes towards following more closely the coding guidelines.

* Replace tabs with spaces

* Add info about '--with-unsupported-ssl'

Compilation with openssl version more recent than 1.0.1 is not advised but still possible. We need t let self compilers know about that.

* Trivial: typo fixes

* Spelling - Wither -> Whether

* Do not fail when warnings are written to stderr

print stderr with the test result instead

* zc public spend parse crash in wallet startup fixed.

* Combine parameter checking of budget commands

* Correct issues with budget commands

* Convert runtime_error to JSONRPCError

* Add Spork functional test and update RegTest spork key

Signed off by: FornaxA

* Enable Spork messages on RegTest net

* Remove GetCoinAge

This function is never used, and never will be; Nuke it from orbit.

* require valid URL scheme on budget commands

* Modify miner and staking thread for efficency

* Remove Bitcoin Core 0.8 block hardlinking

* Don't create new keys when generating PoS blocks

key creation for coinbase output is a waste for PoS blocks and can be removed

* Upstream upgrades: stake modifier V2

Overview of original commits: https://github.com/PIVX-Project/PIVX/pull/983/commits

PR includes adapted versions of these original commits:

commit bf1651452cef40f72f6edc4a71515c15a24c6264
Author: random-zebra <random.zebra@protonmail.com>
Date:   Sun Aug 25 23:59:37 2019 +0200

    [Consensus] New modifier enforcement height changed for mainnet

commit 6b6ef3232ded7280479103fe861585e56c1500d4
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sun Aug 25 14:36:57 2019 -0700

    Don't load old stake modifier from disk after changeover height

commit d085ed0a749c058565da9634f7e2b137c9d331b4
Author: random-zebra <random.zebra@protonmail.com>
Date:   Sun Aug 25 16:44:35 2019 +0200

    [Consensus] Fix old block version check (including v.6)

commit b1416f51e23d137ab24cfb816fec61db4da49b46
Author: random-zebra <random.zebra@protonmail.com>
Date:   Sun Aug 25 12:15:05 2019 +0200

    [Tests] fix blocks/maturity fakestake_accepted

commit c212587680a739dc33309dfe7a90e0cc0fd0329d
Author: random-zebra <random.zebra@protonmail.com>
Date:   Sun Aug 25 12:14:26 2019 +0200

    [PoS] fix regtest nBlockStakeModifierlV2 and cbase maturity

commit dddca50c3d0483bec1028d9a649e317a3c802305
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Fri Aug 23 21:04:25 2019 -0700

    Use better JSON key names in block coinstake output

    Also add help description for new keys

commit 28351113255136779a76f2af72d08ca781f774c2
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Fri Aug 23 20:03:45 2019 -0700

    Don't shadow global fDebug

    conditional log output in kernel.cpp functions can use the global fDebug variable instead of their own.

commit 85fa96eadd69fe8913b8028cb63b1d327df0a004
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Fri Aug 23 23:14:05 2019 -0300

    [Consensus] New modifier enforcement height set.

commit a74f6cf848cdd024e3513669e75b0d7e76492ec3
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Sat Aug 17 14:50:28 2019 -0300

    [GUI] sendCoinsdialog, removing zero tx fee checkbox and label.

commit 6a33fffd0fbd74f673afe9673a77d1d0875f4118
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Wed Aug 14 15:01:11 2019 -0300

    [Mempool] // As zero fee transactions are not going to be accepted in the near future (4.0) and the code will be fully refactored soon.
              // This is just a quick inline towards that goal, the mempool by default will not accept them. Blocking
              // any subsequent network relay.

    [SQUASH] Permitting free txes only in regtest.

commit 6c69cfef4da94b83eb7aecf383f0d5e837da538d
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Thu Aug 22 17:13:14 2019 -0300

    [PoS] * GetKernelStakeModifier, look for the next block in the mapBlockIndex and not in the chainActive and look for it based on the next block hash and not based on height.
        * Contextual zPIV stake, invalid height contextual check, using tip instead of prev height + 1.

commit d3db3e621ca65fa6f0b1916611cbc83388c146a0
Author: random-zebra <random.zebra@protonmail.com>
Date:   Wed Aug 21 04:25:25 2019 +0200

    [PoS] Stake(): Add check for staked blocks in the future

commit f8777c649dec25a7d59119e16e331059d0e8483d
Author: random-zebra <random.zebra@protonmail.com>
Date:   Wed Aug 21 00:22:55 2019 +0200

    [Refactor] Add future block time drift to chainparams

commit 8c7522bb88042098dc531835add65a7394be7751
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Thu Aug 22 12:37:48 2019 -0300

    [PoS] Compute old modifier, invalid integer division removal plus extra logging for the stake modifier height added.

commit beaba470d90875c857736084e7f85cccae9b91d9
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Wed Aug 21 16:55:37 2019 -0300

    [RPC] getblock, validate that PoS blocks to return the coin stake data.

commit 81446bba545ec46c58bfc5316ef32e46298af6d0
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Wed Aug 21 14:23:49 2019 -0300

    [PoS][RPC] getblock command, adding more information about the coin stake tx.

commit 820e08c1645031a06065ea369c8673d5f9559a07
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Wed Aug 21 12:01:45 2019 -0300

    [PoS][RPC][Refactor] GetHashProofOfStake and initStakeInput methods created, better method responsibility division from the CheckStakeKernelHash to be able to get the information for the getblock rpc command and possible future tests.

commit 4d5cc97e76a30b669f9574a2fc080cdff83b588d
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Mon Aug 19 15:38:04 2019 -0300

    [Wallet] Staking, unreacheable code removed..

commit 41ccf6b86b48949fc18dae6728359f87073770b1
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Mon Aug 19 15:28:21 2019 -0300

    [PoS][Wallet] CreateCoinStake, if the block is from the future then start on a future time.

commit ffb0dd558d8cba9d06ed3dd68eaa371f245780d0
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Mon Aug 19 12:16:14 2019 -0300

    [Trivial] logging, removing none required jump lines.

    [Trivial] Cleaning jump lines in not needed logging.

commit 843dc56cd6a119861cff8eb21ee9a969a08480bd
Author: random-zebra <random.zebra@protonmail.com>
Date:   Mon Aug 19 16:18:07 2019 +0200

    [PoS] Allign ComputeStakeModifier (v2) to nHeight logic

    [PoS] cleaning not used stakeTargetHit method + fixing bad nHeight in
    the new compute modifier method.

commit 4c2493470ff4afcfba5b49cf53b2a73a28a0c0a2
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Mon Aug 19 11:13:34 2019 -0300

    [PoS] read/write block index modifier based on height and not block version.

commit 6297e7745ac3b714e67adaeefd67c635d4675294
Author: random-zebra <random.zebra@protonmail.com>
Date:   Sun Aug 18 15:22:01 2019 +0200

    [Core] Introduce Blocks version 6

    [SQUASH] Cleanup proof-of-stake debug log

commit b8c59aed098bb89a7debbd05ab54198879a443ca
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Sat Aug 17 00:16:35 2019 -0300

    [PoS] CheckStakeKernelHash, was checking the previous block instead of
    the block under review.

    [PoS] CheckProofOfStake, stop searching a block on disk when it's
    absolutely not needed.
     * Not used variable nTargetTimespan in chainParams removed.

commit 0d31ac2e9bc659181ecd4ac2bb904ff7db984318
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Fri Aug 16 23:42:04 2019 -0300

    [Wallet] HasMintableCoins, don't call GetAdjustedTime on every cycle of the loop.

commit d94931f9a30bc6406ba588417663fcb280a565ff
Author: random-zebra <random.zebra@protonmail.com>
Date:   Sat Aug 17 03:26:09 2019 +0200

    [Trivial] Add logs to CheckKernelHash

    [SQUASH] Fix nTimeTx bug in Stake()

commit eab9944d064b647a1485dd9a00713696c82023da
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Fri Aug 16 19:56:25 2019 -0300

    version bumped

commit 117f815458a828d1e8e7c564c2e5a79a5387d0fa
Author: random-zebra <random.zebra@protonmail.com>
Date:   Fri Aug 16 22:25:19 2019 +0200

    [PoS] New logic for stake input maturity

    require it to be nStakeMinDepth deep instead of nStkaMinAge old.

commit d805952ea52b5ebb977b654c6ca108df3fd9e934
Author: random-zebra <random.zebra@protonmail.com>
Date:   Fri Aug 16 02:13:41 2019 +0200

    [Wallet] SelectStakeCoins using block time and fix GetBlocksToMaturity

commit 01ed69a471c6fa19761103a1f1917d1930e83526
Author: random-zebra <random.zebra@protonmail.com>
Date:   Fri Aug 16 02:03:53 2019 +0200

    [PoS] Remove extra nTime check in Stake()

commit 74d85c2a42f864f734adb2a994c1ab9c2a792a45
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Thu Aug 15 17:02:33 2019 -0300

    [Refactor][PoS] Do not calculate the prevBlock medianTimePast on every cycle of the CreateCoinStake loop.

commit a48a7a503afb5210483f7d1b238ea07a1883dfd0
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Thu Aug 15 17:00:45 2019 -0300

    [Trivial] Compiler warning, uint_32 compared against int.

commit e9c07d0749d3b99374af956eeae87962ddbdb9e6
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Thu Aug 15 12:25:16 2019 -0300

    [Consensus] V2 modifier protocol change, two new fields in chainparams nStakeMinAgeV2Modifier and nMaturityV2Modifier.

commit 3b97fc0cac807cb4e311780daa16da752c440020
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Tue Aug 13 20:12:31 2019 -0300

    [PoS] Cleaning GetStakeModifierSelectionInterval() constant method +
    other redundancies.

    [PoS][Refactor] CPivStake, caching data + removing redundant method
    calls.

    [PoS] Fix error in nSelectionIntervalStart integer division

commit 3c1fd7a838c5ed8e271bb2f83eb9e7f19ddf10be
Author: random-zebra <random.zebra@protonmail.com>
Date:   Tue Aug 13 23:34:25 2019 +0200

    [PoS] Stake Modifier V2

commit f73a27f0b7ac392718efc83de1741830566ff68d
Author: random-zebra <random.zebra@protonmail.com>
Date:   Tue Aug 13 22:04:15 2019 +0200

    [Core] Do not check block if it's not the one needed

    also there's no need to count mints and spends here

commit 1e4c86421d1b0410a7edee284cdb33df672eaea8
Author: random-zebra <random.zebra@protonmail.com>
Date:   Tue Aug 13 22:01:21 2019 +0200

    [Cleanup] Clean error messages in CheckBlock

    [Cleanup] Remove unused 'GetWeight()' function

    [Cleanup] Remove unneeded variables

commit 401a986e9f79a869edff74faaea452bded32cf5b
Author: random-zebra <random.zebra@protonmail.com>
Date:   Tue Aug 13 21:49:43 2019 +0200

    [Consensus] Placeholder block height for modifier V2 enforcement

Reference: bitcoin#5367

Backport from bitcoin bitcoin/bitcoin#5367

e515b1e [Node] Do all block index writes in a batch (Pieter Wuille)

Pull request description:

  Backport from bitcoin bitcoin/bitcoin#5367

ACKs for commit e515b1:
  Mrs-X:
    ACK PIVX-Project/PIVX@e515b1e
  furszy:
    ACK [e515b1e](PIVX-Project/PIVX@e515b1e)

Tree-SHA512: 8eff741bcbe357b7f6af0d1aea627f77498543efd117173ab2b4c325c3bc3ef3e761b6f4ad7cf70379b55daf68724bed2e10fe22a273b0fc1c3009fac8008a60

# Conflicts:
#	src/main.cpp

* Merge #812: [Regtest][Tests][RPC] Regtest mode + Test suite.

fced4e26fe [Tests] fake_stake: reverse stake hash byte order (random-zebra)
a85cdad03c [Tests] fake_stake: use hashStake for kernel computation (random-zebra)
6aa5ddbff8 [Tests] fake_stake: remove random prevout from spending (random-zebra)
8e370da804 [RPC] add mint hashStake to listmintedzerocoins output (random-zebra)
0d865a8978 [Tests] fake_stake: use a copy for spendingPrevouts (random-zebra)
0f209b3da8 [Tests] fake_stake: docstrings and comments (random-zebra)
322ce79a67 [Tests] fake_stake: fix checksum computation (random-zebra)
7aae5b1e8b [Tests] fake_stake: fix empty spending_prevouts (random-zebra)
c7555e1b84 [Tests] fake_stake: collect prevouts from create_spam_block (random-zebra)
1d699432f2 [RPC] Add call 'getchecksumblock' (random-zebra)
2e7eacc4c4 [Tests] fix line separators in Test03 (random-zebra)
c6c81a7cd2 [Tests] fake_stake: test03 updated (random-zebra)
0d8cf5500d [Tests] remove trailing whitespace from README.md (random-zebra)
9302f5a046 [Tests] fake_stake: test01 & test02 updated (random-zebra)
e0efe4d530 [Tests] unique 'get_prevout' method for both pos and zpos stakes (random-zebra)
9318335525 [Tests] remove trailing whitespaces (random-zebra)
67284ce22a [RPC] add mint block height to 'listmintedzerocoins' (random-zebra)
d783229568 [Tests] get correct nStakeModifier (random-zebra)
78e838ee32 [Tests] fix solve_stake nTime / nStakeModifier (random-zebra)
a428c83609 PoS block creation uniqueness. (furszy)
dd07bd1a50 [Tests] fix proof of stake target in block class (random-zebra)
030e557b93 [Tests] fake_stake: fix test 01 block numbers (random-zebra)
fe54e9b92a [RPC] fix signrawtransaction hack to allow signing of spent inputs (random-zebra)
79e364354f regtest lastPoWBlock and zerocoin block start decreased to not waste lifetime waiting for the tests. (furszy)
42e9c01a85 More logging in block generation. (furszy)
0aa9bafbf4 fake stake test4 (furszy)
8315a42a7b pivx_fake_stake: test03 almost complete (random-zebra)
1ad11ad9f7 RPC createrawzerocoinstake: fix vout[0], add priv-key (random-zebra)
ad65ac4e0a REGTEST: Fix bug on GetModifier (random-zebra)
47f0503b19 RPC: hack MintToTxIn to allow spending an already spent zpiv on regtest (random-zebra)
3092cfc0c2 add empty output to createrawzerocoinstake (random-zebra)
c5a6a67349 log CWallet::MintToTxIn errors (random-zebra)
252f4ab43e pivx_fake_stake: zerocoin prevouts (random-zebra)
22769817ae GetModifier for regtest zPoS hardcoded to prev block stake modifier (furszy)
63bd40e064 pivx_fake_stake: test_spam method refactoring (random-zebra)
1df9240727 pivx_fake_stake: add test descriptions (random-zebra)
79e746eb3d zerocoin mint + spent (furszy)
9eea8837aa half test3 completed (furszy)
23236e7499 pivx_fake_stake: select test from command line (random-zebra)
44d2e9a1c2 pivx_fake_stake: get_prevouts (random-zebra)
1b27b90e8b pivx_fake_stake Test05 - update blockcount in forks (random-zebra)
88e0dc6442 pivx_fake_stake Test05 - more blocks fix (random-zebra)
bf3b732dc5 pivx_fake_stake Test05 - more blocks (random-zebra)
a25f2e84a2 pivx_fake_stake Test05 (random-zebra)
427f2f168b test05 completed, rejection of double spend coin stake input on the same block on main/forked chain (furszy)
3cbf43e7db test05 (furszy)
f7a48260c6 Add 'createrawzerocoinstake' method (random-zebra)
70d859e055 test_02 working good. (furszy)
ed63600142 PIVX_fake_stake: zerocoin tests (random-zebra)
07b981af88 no time validation for regtest (furszy)
47c2c65721 import bytes_to_hex on test_02 fix (furszy)
c02002bdd4 PIVX_fake_stake: fix coinstake out value (random-zebra)
35f09e5d21 submitblock assertion on test_02 (furszy)
d0c0dccff5 PIVX_fake_stake: fix coinbase nHeight merge (random-zebra)
2cf7ae1939 PIVX_fake_stake: fix txes in create_spam_block (random-zebra)
ef01bd8141 zPoS running on regtest :) (furszy)
5405d1ce2d Zerocoin fixed on regtest & PoS blocks generation fixes. (furszy)
158bd2b215 regtest PoS generate valid blocks (furszy)
71a3743108 Tests: fixup a conditional check for python block creation (Fuzzbawls)
b3950ff436 Tests: update nothingatstake test file (Fuzzbawls)
f40f576eb3 stakemodifier fixed for regtest (furszy)
80a2aec5df Tests: serialize block signature when present (Fuzzbawls)
9cec3bd2f5 RPC: hack signrawtransaction to allow signing an already spent input (Fuzzbawls)
5c0f0b99ed WIP: port the test for "fake stake" issue test (Fuzzbawls)
b074cd0e42 RPC: return the used stake modifier in getblock (Fuzzbawls)
1ffc443ba6 Regtest: mine the correct version blocks (Fuzzbawls)
3d588ead42 Tests: Remove whitespace in default conf file (Fuzzbawls)
ebdc552408 Fixup the walletdump command and python test (Fuzzbawls)
37b29c7e61 [Tests] Add Basic BIP38 RPC functionality test (Fuzzbawls)
c2cfff0a23 Tests: add size field to test json (Fuzzbawls)
2155506247 Add rpm contrib files (Fuzzbawls)
4e62dd9ee8 Main: reject non-final transactions using nLocktime from entering the mempool. (Fuzzbawls)
4c71b5694a [RPC] Ensure Tx/Budget input hashes are of the proper length (Fuzzbawls)
7d37c1c207 [RPC] Update and harden many raw transaction RPC commands (Fuzzbawls)
262f76a9d0 [RPC] Error early when block doesn't start with a coinbase transaction (Fuzzbawls)
7e0476b25a RPC: Add waitforblock/waitfornewblock/waitforblockheight (Fuzzbawls)
22bfe7ea2c [Tests] Initial update for regression test suite tests (Fuzzbawls)
93fd9f0501 Update block generation code to enable regtest mode (Fuzzbawls)
25fc43698b Build: add test runner packaging to configure (Fuzzbawls)

Tree-SHA512: 09bcd3c727eb85103451cf971e0bc3a27eca205318ebb6c600a26ddc97f58ef456aa6768c9e94fd5c484da5071887e5b50c2bcf90318cfe2c9178c0c746a408b

# Conflicts:
#	Makefile.am
#	configure.ac
#	qa/pull-tester/run-bitcoind-for-test.sh.in
#	qa/pull-tester/tests-config.sh.in
#	qa/rpc-tests/README.md
#	qa/rpc-tests/proxy_test.py
#	qa/rpc-tests/python-bitcoinrpc/bitcoinrpc/__init__.py
#	qa/rpc-tests/python-bitcoinrpc/bitcoinrpc/authproxy.py
#	qa/rpc-tests/python-bitcoinrpc/setup.py
#	qa/rpc-tests/util.py
#	qa/rpc-tests/util.sh
#	qa/rpc-tests/wallet.py
#	src/Makefile.qt.include
#	src/main.cpp
#	src/miner.cpp
#	src/pow.cpp
#	src/rpcmining.cpp
#	src/rpcrawtransaction.cpp
#	src/rpcwallet.cpp
#	src/stakeinput.cpp
#	src/wallet.cpp
#	test/util/bitcoin-util-test.py
#	test/util/data/blanktxv1.json
#	test/util/data/tt-delin1-out.json
#	test/util/data/tt-delout1-out.json
#	test/util/data/tt-locktime317000-out.json
#	test/util/data/txcreate1.json
#	test/util/data/txcreate2.json
#	test/util/data/txcreatescript1.json

* Fixed compile error

* Merge #803: [NET] Invalid blocks from forks stored on disk fix + blocks DoS spam filter.

61a6ea7558 AcceptBlock() for-each loops variables moved to const (furszy)
e1974d23f3 AcceptBlock() check for double spent serials only on main chain flag. (furszy)
babdfb0f26 remove extra debug lines in AcceptBlock (random-zebra)
a9178bc6e0 AcceptBlock: contextual zcspend check on main chain (random-zebra)
0d49570f20 AcceptBlock() block stored log removed (furszy)
b74921756a Fix bug on AcceptBlock when pindex is null (random-zebra)
45883b9fb6 AcceptBlock() invalid isBlockFromFork flag (furszy)
6a16049dfa AcceptBlock() reject blocks double spending the coin stake input inside the same block (furszy)
da1b6836a5 block spam filter, validate non null nodestate (furszy)
84de55a11c AcceptBlock() isBlockFromFork flag not contemplating prev blocks from forks fixed (furszy)
4219339521 AcceptBlock() - not accept blocks from a forked chain that exceed the max reorg limit (furszy)
47759e113c AcceptBlock(), reject invalid PoS stake (furszy)
e237823000 validate non null pfrom on blockspamfilter check (furszy)
c2e5459dff AcceptBlock(), serial double spend on the same block validation (furszy)
3f5091986c zPoS validations of forked chains before store them + inputs check on prev split main chain (furszy)
64804b4bee Invalid blocks from forks stored on disk fix + blocks DoS spam filter. (furszy)

Tree-SHA512: 6c5a7fda3eb81dc8b030c9ba624e5101f552ef9cecc839a79237b705c314171c0e9c66ecd8bfd207081c6759272140cf3bdf0da7af6ac4695f0c09b74fb1ba45

# Conflicts:
#	src/main.cpp

* Merge #817: [Wallet] Fix segfault with runtime -disablewallet

bae276a Don't bother checking obfuscation messages (Fuzzbawls)
837f25f [Wallet] Fix segfault with runtime -disablewallet (Fuzzbawls)

Tree-SHA512: a8dd502897cdc82f206a1805f7b1ae51960344c3fa32640c9dc6c271768e7db718bc2f57034e8fabfd1b402e589e531419d1e8af8a25eee71d89a6b79ce3a679

# Conflicts:
#	src/main.cpp

* Merge #821: [RPC] Fixup signrawtransaction on regtest

e87231b62b [RPC] Fixup signrawtransaction on regtest (Fuzzbawls)

Tree-SHA512: 1e1b9c25abf9b2406b5065b0b348100fe60e13a258d874d681c6df4094a86ecf3e226e39e6c3e1d8b07fa853634c35249f65652641d13741c426c4c9053e7b36

* Merge #822: [Tests] Integrate fake stake tests into parent test suite

52b509468f Remove stale qtum python scripts (Fuzzbawls)
c0d8dcb8c9 [Tests] Integrate fake stake tests into parent test suite (Fuzzbawls)

Tree-SHA512: b0f9d559b3a8a4d0da3d400dfbe57fa15933a3c569732c4d7d10e147e7d5cd5f70a6f5231c862e4ca5f7f3efdb2de5890fe4755cbee5c41b00a4ab34a015c2e4

* Merge #826: [Qt] Fix a windows only crash when r-clicking a proposal

0015d08c75 [Qt] Fix a windows only crash when r-clicking a proposal (warrows)

Tree-SHA512: 7e9507e4ffbbca6b41d9c9b18d31f7ebfddf01d5abbfd083b2fcbf6d7d398c20391bdc4fc4903c8d1b338d0c78929920264eb6352bbcaa9b2baf1c11df965cc5

* Merge #838: [RPC][Test] spendrawzerocoin + wrapped serials functional test

c3352f0dbd [Test] add 'zerocoin' to the list of good prefixes in test_runner (random-zebra)
78f1a241ae [Test] wrapped serials: use multiple random values for K (random-zebra)
bf0cf52d37 [RPC] fix spendrawzerocoin string parsing (random-zebra)
025d2855f9 [Tests] Add Wrapping Serials Test (random-zebra)
7373704842 [RPC] Add spendrawzerocoin (random-zebra)

Tree-SHA512: 707c015b2b40bf6f34999aa7b1a62b1e1be4b8c4d9b0e830ed78ebf2f74a362883708d6204cfadd95f5d6520feb19fc1ba4b8a12549c6cc40c40dc2ab56fb2e9

* Merge #837: [Zerocoin][UNIT TEST][RPC] Wrapped serials.

6eff5fa970 fix zPIV supply recalculation (random-zebra)
2676ca3626 newline character added to recalculate wrapped serials supply logging (furszy)
da43659dd2 Initialize nSupplyBeforeFakeSerial to 0 in TestNet and RegTest (random-zebra)
c46de31dc4 Fix Wrapped Serials inflated zPIV supply recalculation (random-zebra)
13691861f8 zerocoin contextual spend check log invalid serials (furszy)
0240f27e5f log rejection serial block height (furszy)
ab6a134f2b invalid fake serial rejection (furszy)
010d03591c zpiv recalculation moved in init and added in connectblock (furszy)
bd6b26b466 fix tabs in SoK (random-zebra)
41a2bcca29 fix bitSize typo in bignum for openssl (random-zebra)
29c1791815 inflation methods moved to cpp (furszy)
027c9ffcb6 wrapped serial inflation trigger recalculation (furszy)
a3d725a42a Zerocoin supply, wrapped serials inflation + some minor modifications (furszy)
b3660cbb2e SoK invalid range check. (furszy)
ad3a3c717b remove tab spaces (furszy)
ed15e21eb8 Fix isBlockBetweenFakeSerialAttackRange check (random-zebra)
8e7cf5ab4e Fix IsValidCommitmentToCoinRange check (random-zebra)
a936e03c22 getserials ambiguous Pair constructor in bitsize blocking clang compilation fix (furszy)
bd529a0f6e [UNIT TEST] wrapped serial coinSpend check (furszy)
1217868777 [RPC] Add getserials method (random-zebra)
9fe8dabc4f fix isValidSerial always true check (random-zebra)
913e48cda8 wrapped range fix (furszy)
46a5231574 wrapped serials check in acceptToMemPool method (furszy)
edfdb4c30b prints in console commented (furszy)
18e55ed179 fake serials attack enforcement (furszy)

Tree-SHA512: fe6eaf26257c25377982d44ff1cdd839edf6f71daa5607fc98397b4a3fcd26ae78db54c781038e4f9ff8a7ad1d460ce109909184852bb620435e10dcba6a638c

# Conflicts:
#	src/init.cpp
#	src/libzerocoin/bignum.h
#	src/main.cpp
#	src/main.h
#	src/primitives/zerocoin.h

* Fixed compile error

* Merge #840: [QT] cleanup, remove old trading dialog form

56dd114 cleanup, remove trading dialog form (furszy)

Tree-SHA512: 824547803f5b854c51c22ca87149608725036c5ddee1922ceef7bdc71fcaeac440e77da3c51f7fe44b29269a57990d5ddfd674ca52b4de6ebd6fd36f847f55e8

# Conflicts:
#	src/qt/forms/tradingdialog.ui

* Merge #847: Fix to display missing clock5.png tx image

dc168d1 fix to display missing clock5.png tx image (joeuhren)

Tree-SHA512: d10828e76ad1b2e034b013a1c3cac9cf79dfdc642a11d1a6493d615a19982d50fc09343b3b39171ba7c25202f29ed0532f1bc539c42fbdad37a19e58adcc48b1

* Merge #815: [Doc] Update release notes with forthcoming 3.2.0 changes

f86890b256 more notes for RPC commands and gitian build script (Fuzzbawls)
c39053bb73 Add more release notes (Fuzzbawls)
68e3e925b5 Initial release notes for v3.2.0 (Fuzzbawls)

Tree-SHA512: de06f5d6d913d21cd0ac329ff5a69e915f3ab5afae82ed471e496e2d718562a3a2cf010d20279f76f8ba6397394cfb21ba6cbe9da1385eed36d4f07c00f29161

# Conflicts:
#	doc/release-notes.md

* Fixed coin name

* In progress multi-input witness generation.

# Conflicts:
#	src/accumulators.cpp
#	src/accumulators.h
#	src/chainparams.cpp
#	src/kernel.cpp
#	src/miner.cpp
#	src/wallet.cpp

* more progress

* More progress on caching spend data.

# Conflicts:
#	src/Makefile.am
#	src/init.cpp
#	src/miner.cpp
#	src/rpcblockchain.cpp
#	src/test/zerocoin_implementation_tests.cpp
#	src/wallet.cpp
#	src/wallet.h
#	src/walletdb.h
#	src/zpiv/zpivtracker.cpp
#	src/zpiv/zpivtracker.h
#	src/zpiv/zpivwallet.cpp
#	src/zpiv/zpivwallet.h
#	src/zpivtracker.cpp
#	src/zpivtracker.h
#	src/zpivwallet.cpp
#	src/zpivwallet.h
#	src/zvittracker.cpp
#	src/zvittracker.h
#	src/zvitwallet.cpp
#	src/zvitwallet.h

* Fixed compile error

* Fixed compile error

* Remove security level from zerocoin spending.

# Conflicts:
#	src/qt/privacydialog.cpp
#	src/rpcwallet.cpp
#	src/wallet.cpp

* prevent infinate loop in miner

* ensure override is set for GetSerialHash()

* Include dependent headers in stakeinput.h

* set the accumulator start height when initializing the witness

* remove spam log output in stakeTargetHit()

* add benchmarking to zPIV spend inner functions

* fully initialize member variables when setting the witness data

* don't duplicate function call

* benchmark fixup

* don't hold cd_spendcache for the entire loop

* Remove security level from UI

* Add clearspendcache RPC command

# Conflicts:
#	src/rpcserver.cpp
#	src/rpcserver.h

* re-add zpivchain.h (fixes merge conflict error)

# Conflicts:
#	src/Makefile.am
#	src/init.cpp
#	src/test/zerocoin_implementation_tests.cpp
#	src/zvit/zvitwallet.cpp

* more work on pre-computing

# Conflicts:
#	src/wallet.cpp
#	src/zvit/zvittracker.cpp

* Make GetSerialHash return const again

* Fix RPC spendzerocoin

* Precompute zPIV spends in a dedicated thread

Moves the spend precomputation process into it's own thread, instead of
being tied to the staking thread.

Loop currently has a 5000ms sleep at the end so as to not overconsume
locks.

# Conflicts:
#	src/wallet.cpp
#	src/wallet.h

* Qt: Add precomputed percentage indicator column to zPIV control UI

Adds a new column to the zPIV control UI showing the mint's completed
precompute percentage.

* Allow zPIV precomputing to be disabled

Adds a new command line (conf) option `-precompute` to disable
precomputing. Default is to enable.

# Conflicts:
#	src/init.cpp

* Add Databasing of zpiv precomputes, they are not encrypted yet

* Update precompute cache

# Conflicts:
#	src/init.cpp

* Fix rebase conflicts from precomputing

# Conflicts:
#	src/rpcserver.h

* Clear database cache with rpc call

* Convert precompute cache into LRU cache

* Add global boolean, that stop precompute cache lock

* reorg + refactoring + conflicts

# Conflicts:
#	src/lightzvitthread.h
#	src/rpcblockchain.cpp
#	src/wallet.h
#	src/zvit/accumulators.h

* precomputation-upstream conflicts solved

# Conflicts:
#	src/rpcblockchain.cpp
#	src/rpcrawtransaction.cpp

* getaccumulatorwitness method fix

# Conflicts:
#	src/rpcblockchain.cpp

* re added LNZP removed files

# Conflicts:
#	src/Makefile.am

* Remove duplicate functions from rebase

* Fix assertion failure in mining/staking

Need to explicitely set pindexPrev and nHeight within the locked scope.

* Fixup coinspend unit test header includes

* Fix wrapped serial functional test

The error message had changed

* Remove security level in `DoZpivSpend()` call

* Disable precompute for functional tests

The locking can interfere with block generation

* Fixup the interface_rest functional test

* Better logging for CheckCoinSpend

Also re-introduce the regtest specific conditional

* Prevent lock spamming when no stakable inputs are present

* Cleanup arbitrary sleep times in CreateCoinStake

* Fixup bad logprintf

* fixup makefile.am

* Don't error out when a range has already been computed

When a range of blocks has already been computed, use that existing data
 instead of erroring out. This is used in the zPoS pipeline where, after
  precomputation, the passed `pindexCheckpoint` is likely to be at a
  block height below the accumulator's tip/end.

* Fix irrelevant receipt status message

Since security level has been removed, this status message needed to be
changed.

Also removed some stale unused code that was left over from when
security level was used.

* Reduce log spam

New debug category "staking" added with some previous `LogPrintf`
messages recategorized to reduce log spam.

Also noted both "staking" and "precompute" in the init help message and
added them to the "pivx" umbrella category.

# Conflicts:
#	src/init.cpp
#	src/util.cpp

* Fixed compile error

* Merge #843: [Net] Increment Protocol Version

7241582ba3 [Net] Increment Protocol Version (Fuzzbawls)

Tree-SHA512: 12f2b784837de572ca0d96167dc51f355d5d0b042c53fb006186112639388ef5bddfe601fc99af64d3c0ab58013aa7add451616d29073f3b8fc6dfb4d29dce7d

# Conflicts:
#	src/version.h

* v3.2.0 Release

# Conflicts:
#	configure.ac
#	doc/release-notes.md

* [macOS] Remove DS_Store WindowBounds bytes object

Github-Pull: #858
Rebased-From: 21f50784c39d2c87776edb7b959d92d63b95b339

* Don't return an invalid state when shutting down the wallet

When the shutdown process is started, it is possible that the call to
`ValidateAccumulatorCheckpoint()` in `ConnectBlock()` will fail. Instead
 of returning an invalid state, which causes the block to pass through
 `InvalidChainFound()`, just return a stateless error if a shutdown has
 been requested.

Github-Pull: #865
Rebased-From: 8126729c7800d801f0f067d9a2257b8ad74c1a9f

* [Qt] Stop using a solid white image as a border image

This seems to be causing an issue on macOS, resulting in odd magenta
pinstripes. Instead, just set the WalletFrame's background to solid
white via hexcode.

Github-Pull: #863
Rebased-From: 9a855a8b50a3be548f3d8df7a7fc4f00baef0f73

* Remove now-unused image files

Github-Pull: #863
Rebased-From: 38e92f3a2678571cae2908d2140bb2f41e339143

# Conflicts:
#	src/qt/res/images/walletFrame.png
#	src/qt/res/images/walletFrame_bg.png

* [QT] Fix a display bug about zPIV mints

When opening the zPIV coin selection in privacy tab, if the wallet is
locked the message for all mints is that the seed is wrong. This commit
fixes it by replacing the message and stating that the locked wallet
prevents precomputation and spending.

Github-Pull: #852
Rebased-From: 94bea35e5569c323a667d8204bc2d23b15d4dc29

* [Net] Add new checkpoints for mainnet/testnet

This adds two new checkpoints for mainnet:
 * Block 1679090 - first block with a wrapped serial
 * Block 1686229 - last block that zPIV was active

Also for testnet:
 * Block 1016800 - Arbitrary recent block

Github-Pull: #861
Rebased-From: 9ce73e55db0f0c3013c08bee06648c40b705b86a

# Conflicts:
#	src/chainparams.cpp

* [Qt] Prevent double deletion of progress dialog

When `showProgress()` is passed a `100` int value, the dialog is deleted
. If the function is passed a `100` int value a second time in the same
scope, like what happens at the end of `RecalculateZPIVSpent()` and
`RecalculateZPIVSupply()`, it results in a segfault.

This change standardizes the process by first initializing the progress
dialog with a `0` value, updating to a maximum of a `99` value inside
the loop, and finally closing with a `100` value after the loop has
completed.

Github-Pull: #860
Rebased-From: fa0e1f301cb4c668706a14df8ae6e149c714ef6f

* [Build] Update debian contrib files

Github-Pull: #866
Rebased-From: 51616cb0d71541326b5060f7f93a51889c61cfc6

# Conflicts:
#	Makefile.am
#	contrib/debian/README.md
#	contrib/debian/changelog
#	contrib/debian/manpages/pivx-qt.1
#	contrib/debian/manpages/pivx.conf.5
#	contrib/debian/manpages/pivxd.1
#	contrib/debian/pivx-qt.desktop
#	contrib/debian/pivx-qt.install
#	contrib/debian/pivxd.bash-completion
#	contrib/debian/pivxd.install
#	contrib/debian/pivxd.manpages
#	share/ui.rc

* [Performances] Decrease the number of wasted CPU cycles

Github-Pull: #868
Rebased-From: 97720be5b945d1d490f6f6fa940b4620f6bbdb12

* PIVX Core v3.2.1 Release

# Conflicts:
#	doc/release-notes.md

* [Net] Valid blocks from forks badly rejected due an invalid view of the available utxo set for forked chains + split height going one block further than what should be.

[Net] acceptBlock, back to chain split was going one block further if prev was the previous block of the incoming block.

[Net] coins cache view only has the tip view and not forks utxo chain view.

Github-Pull: #880
Rebased-From: 2c76194c757ddd6a9081ee555b191c6dbb326c50

* [Net] AcceptBlock, first prev block loaded from disk.

Github-Pull: #880
Rebased-From: 754764be02af58b0b2059f580b40bf5f6380fa4d

* [Net] Add additional checkpoints

This adds two additional checkpoints for known split points

Github-Pull: #884
Rebased-From: af28b90a4ab119102ed995a20614025a55256526

# Conflicts:
#	src/chainparams.cpp

* Fix incorrect last checkpoint timestamp

Github-Pull: #887
Rebased-From: a0af2a75257a86f585580152e73de24b331c9264

# Conflicts:
#	src/chainparams.cpp

* 3.2.2 Release

# Conflicts:
#	doc/release-notes.md

* Fixed compile error

* Fixed coin name

* Fixed coin name

* Fixed coin name

* Merged branch pr/49

* Merge #890: [Refactor] Remove unused setStakeSeen variable

b5a525767a [Refactor] Remove unused setStakeSeen variable (warrows)

Tree-SHA512: c5244b3cf269d3b6171a5b241265b98bffcfbf580cecbf9cc2741ea2b3374deb558459a8764f1931080331b11456a8d129dbcc3b6e59955f15bc184333e23ca8

# Conflicts:
#	src/main.cpp

* Fixed compile error

* Merge #896: [UI] Simplify Qt margins.

d7afebb [UI] Simplify Qt margins. No functional change. (warrows)

Tree-SHA512: c29c1d416d81ccda15d90c26fcadc9b67dcd27b8b7bdbd55c951e0ddd6c809b0cc7cc0dfc3590dc45fa2fb4f0e5218d9da2a424cb3a953d9b542de34ab7b693c

# Conflicts:
#	src/qt/forms/masternodelist.ui

* Merge #888: [Zerocoin] remove CTransaction::IsZerocoinSpend/IsZerocoinMint

f14569faa [Zerocoin] remove CTransaction::IsZerocoinSpend and CTransaction::IsZerocoinMint (random-zebra)

Tree-SHA512: 0e7ab5ee37215454af1b09d25454bedaf8f92baf0ca598d5c639bb1b6f642ca93d21a8d2707af3c4cece06d7b6cd98a019e8b4c16712d774f23b5b41ee059a57

# Conflicts:
#	src/blocksignature.cpp
#	src/main.cpp
#	src/miner.cpp
#	src/qt/privacydialog.cpp
#	src/qt/transactionrecord.cpp

* Fixed compile error

* Merge #830: [Refactor] Remove BOOST_FOREACH

4f6cd20b0d Cleanup clang's range loop analysis warnings (Fuzzbawls)
e1c549e8a7 [Refactor] Remove useless BOOST includes and readd where needed (warrows)
4d44c9781a [Refactoring] Replace BOOST FOREACH with for : (warrows)

Tree-SHA512: a61e8968a28c86f33f753b693559a58a632e01b6408b7f0653772206fa9f20fb2df83e432ed74e33d1bed29a302ff4b98c30bbe53111faf1f50ed3acf8888190

# Conflicts:
#	src/activemasternode.cpp
#	src/init.cpp
#	src/masternode-budget.cpp
#	src/masternodeman.cpp
#	src/net.cpp
#	src/obfuscation.cpp
#	src/qt/masternodelist.cpp
#	src/swifttx.cpp
#	src/wallet.cpp

* Removed more BOOST_FOREACH and fixed compile error

* Merge #810: [Depends] Fix archs (fixes s390x and ppc64el builds on snap)

2fdc74b280 update qt.mk with arch fix (see previous commit) (cevap)
b22610c6f1 add QT patch for s390x, mips, powerpc and sparc (cevap)
1a756e0066 Fix qt for m68k and alpha (cevap)
f52a72ef0f Fix openssl for m68k and alpha (cevap)
e12b4493fb Fix boost for m68k and alpha (cevap)
32f2684b9e Fix openssl for sparc64 (cevap)
5de083f1d6 Fix qt for sparc64 (cevap)
f1e537e05d Fix boost for sparc64 (cevap)
188d0ea7a4 Fix qt for powerpc/ppc64el (cevap)
c590d072ab Fix openssl for powerpc/ppc64el (cevap)
def4374308 Fix qt for s390x (cevap)
ed61951516 Fix openssl for s390x (cevap)
d1489c8985 Fix boost for s390x (cevap)

Tree-SHA512: 90add202dde7c3252bdc92974936fa50daf66a34e29cfbbee3222771ea89d061466e39300d3449b5e8b43fd1d8b8828b694ad83624c959c7cc331463a7aef7f8

# Conflicts:
#	depends/packages/openssl.mk
#	depends/packages/qt.mk

* Merge #806: [Test] Create new per-test fixtures

c5054e4 tests: add a BasicTestingSetup and apply to all tests (Wladimir J. van der Laan)
962a1bc Reinitialize state in between individual unit tests. (Pieter Wuille)

Tree-SHA512: 47bab117a394de5f7dc9079f940969df6e3369f96128c1009c55005d30adb1dbc048900f04649caae2976518cad1065419f1d91baebffe0c3f3c2d9897450c08

# Conflicts:
#	src/Makefile.test.include
#	src/test/test_vitae.cpp
#	src/test/zerocoin_denomination_tests.cpp
#	src/test/zerocoin_implementation_tests.cpp

* Fixed coin name

* Merge #875:  [Zerocoin] GMP BigNum: Fix limits for random number generators

253c63e [Zerocoin] include 0 in randBignum() range (random-zebra)
daeb752 [Test] Add tests for bignum random generators (random-zebra)
5627807 [Zerocoin] Fix limits for random number generators in GMP bignum implementation (random-zebra)

Tree-SHA512: c88ab99912683736a886065ecfbfd52aeb419357ee0e7eb6e3c1a09c22c3c316884bf8606f44d13e0f0fcb4de4137fb52339b556eb6e1a134b7aafff36c1d414

# Conflicts:
#	src/libzerocoin/bignum.h
#	src/libzerocoin/bignum_gmp.cpp
#	src/libzerocoin/bignum_openssl.cpp
#	src/test/zerocoin_implementation_tests.cpp

* Updated big number from upstream

* Merge #900: [UI] Fix improperly parented walletView and segmentation fault on QT 5.10

a4205f2 [UI] Fix improperly parented walletView. (Julian Meyer)

Tree-SHA512: ba523274a9e336a884f097dcff5a0e47e294517254350287dd0c2572c63010e63a33734707bcdca753f454f85c4bbe052817172b719e7ac66bcdbdef71d151a2

* Merge #898: [Qt] Fixup duplicate label names

4e8f46a376 [Qt] Fixup duplicate label names (Fuzzbawls)

Tree-SHA512: 6cee761fae0d6d387523d286ddbc8fa6f61ef702ec406aa9108dedaccb1b8a0f343b7c01778f9d86be7e76e437d390e468c2593f2514c47350415da696744609

* [Zeroocoin] public coin spend script creation, validation and un/serialization.

# Conflicts:
#	src/Makefile.am
#	src/zvit/zpivmodule.cpp
#	src/zvit/zpivmodule.h

* Fixed compile error

* [UNIT TEST] publicCoinSpend valid input creation and verification.

[UNIT TEST] publicCoinSpend creation + validation completed.

* [Wallet] public coin spend creation connected + first mem pool validation.

[Zerocoin] public coin spend improvements.

[Zerocoin] publicCoinSpend validations connected to the accept txes flow.

[Zerocoin] public spends not checked as regular inputs.

[Zerocoin] publicCoinSpend validation as regular spends.

non good solution for the coinSpend pointer inheritance issue but at least working

[Zerocoin] ParseZerocoinPublicSpend moved into zpivmodule file.

cleanup unused field.

# Conflicts:
#	src/main.cpp
#	src/main.h
#	src/qt/transactionrecord.cpp
#	src/wallet.h
#	src/zvit/zvitmodule.cpp
#	src/zvit/zvitmodule.h
#	src/zvitchain.cpp

* [zPIV] zPIV Maturity --> Minimum amount of coins accumulated no needed anymore.

# Conflicts:
#	src/wallet.cpp

* [zPIV] publicCoinSpend signature hash relevant data inclusion.

* [zPIV] rebase problems fixed. (Needs more testing)

* Fixed compile error

* [zPIV] new protocol enforcement height added. Height not final, just randomly selected and tested on regtest.

* [zPIV][Cleanup] PublicSpend rebase onto IsZerocoin

# Conflicts:
#	src/zvit/zvitmodule.cpp

* [zPIV] remove enforcement from 'CreateZerocoinSpendTransaction' fixing the unit tests

# Conflicts:
#	src/test/zerocoin_transactions_tests.cpp

* [zPIV][Consensus] reject V1 serials spends.

* [zPIV] prevent v1 zerocoins from being selected for PublicSpends

# Conflicts:
#	src/wallet.cpp
#	src/zvit/zvittracker.cpp

* [zPIV] use new limit Zerocoin_MaxPublicSpendsPerTransaction for max num of inputs

# Conflicts:
#	src/qt/privacydialog.cpp
#	src/wallet.cpp

* [zPIV] mints coin control dialog min accumulation mature text removed + re mint change checkbox not visible anymore.

# Conflicts:
#	src/qt/privacydialog.cpp

* [FUNCTIONAL TESTS] valid PublicCoinSpend transaction test.

* [zPIV[Unit Test] Possible redundant denomination validation.

* [FUNCTIONAL TEST][zPIV] double spent serial validation.

* [RPC] spendzerocoin command can now create old zc spends, only for regression tests

# Conflicts:
#	src/rpcserver.h
#	src/rpcwallet.cpp

* [RPC] Parse public spend on getserials rpc command.

[Cleanup] non used variable commented.

# Conflicts:
#	src/qt/privacydialog.cpp
#	src/rpcblockchain.cpp

* [zPIV] reject priv coin spends on tx mempool acceptance.

* [zPIV] publicCoinSpend version field included in the serialization for any future change.

* [RPC] add 'createrawzerocoinpublicspend' method

* [Tests] add test reorg for public spend

[Unit Test] zc public spend test up-to-date with master.

# Conflicts:
#	src/test/zerocoin_transactions_tests.cpp

* [zPIV] testnet publicSpend enforcement height set.

[zPIV] v1 serials validation was not checked against the publicSpend height.

* [Consensus] spork 15 activation + protocol version bump.

[Consensus] spork 15 + min prev protocol version. (squash this later)

# Conflicts:
#	src/main.cpp
#	src/version.h

* [zPIV] v1 serials modulus fix + isStandardTx fix for publicSpends.

cleanup, publicCoinSpend object leftover removed + minor log added to CheckProofOfStake.

* [Consensus] Testnet enforcement height.

* [GUI] Disable zerocoin minting

# Conflicts:
#	src/qt/forms/privacydialog.ui
#	src/qt/privacydialog.cpp
#	src/qt/privacydialog.h

* [RPC] Disable zerocoin minting

disabling also remint of change of a zc spend

# Conflicts:
#	src/rpcwallet.cpp

* [Consensus] Disable zerocoin minting in contextual check

* [Wallet] Disable automint

* [zPIV][Consensus] fix 'Zerocoin_Block_Public_Spend_Enabled()' enforcement

* [RPC] enable mint only for regtest

# Conflicts:
#	src/rpcwallet.cpp

* Merge #899: [zPIV] Disable zPIV staking

a789d21635 [zPIV] Disable zerocoins inclusion in 'SelectStakeCoins' (random-zebra)

Tree-SHA512: 92da55ee6efe3090ad1b279e3ad4d1f757ca70d0a4b1f820a36b4d5d6dcef126002fc6c2402b2b8d34618f212a192d8dc7505f98a0050691d152ba5a17fb1821

# Conflicts:
#	src/wallet.cpp

* Merge #909: [Consensus] Mainnet public spend enforcement height set.

39f37c5c52 mainnet public spend enforcement height set (furszy)

Tree-SHA512: 41adff5fa6ed7458ef3dcbb33979716996168bff7eccc4759931e8231184462a75020485430d91f88373b6cd3d298d3c0d61a9758aab4e0da3e6ea64d84e3594

* Merge #903: [Log] Handle errors during log message formatting

93bc03763b [Log] Handle errors during log message formatting (warrows)

Tree-SHA512: 55acc54247ad0980a4ed28ff167d35bae5d437e6484bd5ebb8c9cf948e47751d2e7dc4e9c338d7a6d22301f85448b4e6b8c4f6dbf97d68168939d13bdecb310b

* Merge #912: [Cleanup] compiler warnings in coinSpend object.

f912182d27 [Cleanup] clang compiler warnings in coinSpend and publicCoinSpend fixed. (furszy)

Tree-SHA512: 58dbe73519a8eece2a824a19f37b5219c1e189e395afc61f9fcfa54f195befd9f7a49500c4147684a9b58e96fa7ff7906fa956ae8ac249dc7094faaa6cd4a4b6

* Merge #901: [RPC] Fix typos and oversights in listunspent

f3308f404d Fix typos and oversights in listunspent (CaveSpectre11)

Tree-SHA512: b6a4651b5ee27cf757e9effa1d692020823d7c4bbd66a56c990252fc80f7f3333abb1313b37a01f5d444f333c0d4782d4607ca5e4179cf4bac6db5a86cc15f78

* Merge #902: [Tests] Add tests for CAddrMan

c84e0e83ba [Code Style] Remove std namespace in test file (warrows)
3355c86cce Increase test coverage for addrman and addrinfo (Ethan Heilman)
d4da01588b Creates unittests for addrman, makes addrman testable. (EthanHeilman)

Tree-SHA512: cd960109d8f3bdc46dfd58da2136a748aa8ecb1b3bacfa031af0a1544bd90514fe71b8fc63650e61c5872c7a42febc986616252550a71c510bdc7f9e1ab87e0f

* Merge #906: [Build] Add CMake Support

ca2fd101ba use non-Cellar OpenSSL path for macOS (Fuzzbawls)
69b0032749 fix config.h include file name (Fuzzbawls)
d413496b01 [Build] Initial CMake support (Fuzzbawls)

Tree-SHA512: 459d881a6128027c1b1fe6df13b0dce5fe484af377afece74ccc135a5e5ea320496165ffbdef70d806bd879be7cad39d4bfc3cdffbacfc2a61d0c8e53265b0ab

# Conflicts:
#	src/compat/byteswap.h
#	src/compat/endian.h

* Merge #910: [Build] Clean all coverage files during make clean

b75d8bc0bb [Build] Clean all coverage files during make clean (Fuzzbawls)

Tree-SHA512: 5f0e0a4795ea770cabf326c91aea24094de9193684a295f82aa38b42840b0ea38f1a119ba30c6c20eedd1862f22133b66e606912da0f93b420e9ca0549704f41

* Merge #895: [QT] Options UI cleanup

c424f0f244 Fix margins (Alko89)
2d052155ff Hide zpiv related options. (Alko89)

Tree-SHA512: 2944f28e4d2b4baa901a5c1a4bb991eb07bb81d33c285ec32971fa9485522320a6f583f5346c7fadceb2ab0e484f0cba521dc436cfa1586f75bfa05f13eeac9a

# Conflicts:
#	src/qt/forms/optionsdialog.ui

* Merge #919: [zPIV] Debug missing jump line.

addeb0ac06 Update accumulators.cpp (Matias Furszyfer)

Tree-SHA512: 56de08723ba12cb2b7f96b66ed5d6ee2c3912be6397ef1eb56b16d8c805425415b288d9b176981b8e720c6f195acdbfc1156bed5f7c31dcd9547a790cb585a52

* Merge #916: [Staking] Don't assert if we were beaten to the block

24d72d0f64 [code review] LogPrintf nit change (CaveSpectre11)
019d26ac4c Don't assert if we were beaten to the block (CaveSpectre11)

Tree-SHA512: 9818319df999ba21fb6f89dadf254f76ad02d14b4f35fcae5b8d9a6251a0be5212650f3834a61a90fad2a9e8ce242751a9c09f7325c9cccc60223a59a6b3f22c

* Merge #922: [Build] Fix app name casing in mac deploy related files

45ea523e1a [Build] Fix app name casing in mac deploy related files (Fuzzbawls)

Tree-SHA512: 79fd711f3db52e418f42b7cdcf26a4a68456e6727b1362837745eacfe1797eb8fb33a8a86812158c1e833862fca7fedc5e55ef0fa5d4a2d7eff654c646ea8214

# Conflicts:
#	contrib/macdeploy/detached-sig-create.sh
#	contrib/macdeploy/fancy.plist

* Merge #914: [Gitian] Bump gitian build versions

55127d1264 [Gitian] Bump gitian build versions (Fuzzbawls)

Tree-SHA512: 29c6681b76adfb69b2f741d9f50575da0f870df8b822cb2886e10f6d364713221db0a94b017de3e89943e6e52d3aa2d7856604f092b73af14caa0ab9dc0b21bc

# Conflicts:
#	contrib/gitian-descriptors/gitian-linux.yml
#	contrib/gitian-descriptors/gitian-osx-signer.yml
#	contrib/gitian-descriptors/gitian-osx.yml
#	contrib/gitian-descriptors/gitian-win-signer.yml
#	contrib/gitian-descriptors/gitian-win.yml

* Merge #924: [Backport] Max tip age to consider a node in IBD status customizable.

46ba7a2b96 [Backport] Max tip age to consider a node in IBD status customizable. Backport from bitcoin##7208. (furszy)

Tree-SHA512: 211479d05cc8226d0bdaa3432204467679b465dfdbcdcf58650ec2fcb415c60544f3ae354f8b460adc6cd7e2d56ce6b3a52dd77ac92017eb7f66d98a76051bb2

# Conflicts:
#	src/init.cpp
#	src/main.cpp

* Merge #913: [Depends] Update from upstream

d2136e30e0 depends: Update from upstream (Fuzzbawls)

Tree-SHA512: 9ce1b15170113cd207090f8986efd809cc6f4859132140e1c09f573e1015115ff82d961d7fc21375f8a5346de6bea656bb3bfb190ab95c60c080145d8ea67137

# Conflicts:
#	.travis.yml
#	configure.ac
#	depends/Makefile
#	depends/README.md
#	depends/config.site.in
#	depends/packages/expat.mk
#	depends/packages/miniupnpc.mk
#	depends/packages/native_biplist.mk
#	depends/packages/native_mac_alias.mk
#	depends/packages/packages.mk
#	src/Makefile.am

* Fixed compile error

* Merge #917: [Build] TravisCI Update

342f0341de Disable known failing regression tests (Fuzzbawls)
a5f887b00e [Travis] Update TravisCI from upstream (Fuzzbawls)

Tree-SHA512: 0cf866696ffb6cff539a1412c95f1f10a6e031629f153aa9a01b5326b77bc7de53912c36d254c859e437d7c3035f466d3b3db79aab26cec4767c75e45e16559a

# Conflicts:
#	.travis.yml
#	.travis/lint_04_install.sh
#	.travis/test_03_before_install.sh
#	.travis/test_04_install.sh
#	.travis/test_06_script_a.sh

* Merge #904: [zPIV] Free memory from ToString()

9c0329c72b [zerocoin] Free memory from ToString() (warrows)

Tree-SHA512: c04bfcf1af3b9fd95cf6aa653367043d4a973805c37e820b3127a3198efbdb0f83eb82d8084409f17e059e44e7c653666899a5733dd1f272d0829ae0ceee388d

* Merge #908: [NET] Non-running dns servers removed from chainParams.

8695fd5fb5 Non-running dns servers removed + warrows dns added. (furszy)

Tree-SHA512: ad98e116255c919d1f0765585578afdb64e0368393faa1954bf23162e705165aa11c8d810ac913bd0c7325a0da096fd99535de5cb66778ad5be15f6a5d81b8c8

# Conflicts:
#	src/chainparams.cpp

* Merge #920: [Docs] Overhaul documentation files

d24742cf37 Remove redundant docs (Fuzzbawls)
007cc8c289 Update src/test/README.md (Fuzzbawls)
d2af9593e4 Introduce translation_strings_policy.md (Fuzzbawls)
019b8f4e8c Update contrib/devtools/README.md (Fuzzbawls)
2bc9d1b0f1 Update developer-notes.md (Fuzzbawls)
d1a65fdcaf Update dnsseed-policy.md (Fuzzbawls)
0b5c0c262b Update release-process.md (Fuzzbawls)
9335a103d1 Update test/functional/README.md (Fuzzbawls)
20f251336a Update doc/README.md (Fuzzbawls)
5b4f73def6 Clean up whitespace in Doxyfile.in (Fuzzbawls)
3cea76be03 Update and reformat init.md (Fuzzbawls)
2f5efbd12c Reformat files.md (Fuzzbawls)
df0d2ba1fe Introduce dependencies.md (Fuzzbawls)
785b61cf56 Update zmq.md (Fuzzbawls)
231f28e696 Update translation_process.md (Fuzzbawls)
c5f6822af5 Update tor.md (Fuzzbawls)
b7d0ec7696 Fix markdown in REST-interface.md (Fuzzbawls)
4fa4cc4ff2 Update Contributing guidelines (Fuzzbawls)
a544132207 Update build notes (Fuzzbawls)

Tree-SHA512: ab422791c3e43d6e455d648c9b6b30943c176e03d2a0702135184108c8887bb39e4bb9c51bab9f9a04a130a297f8db879563e3b45f010c6b1f34482122b78681

# Conflicts:
#	CONTRIBUTING.md
#	contrib/devtools/README.md
#	doc/Doxyfile.in
#	doc/README.md
#	doc/README_osx.md
#	doc/REST-interface.md
#	doc/bootstrap.md
#	doc/build-osx.md
#	doc/build-unix.md
#	doc/build-windows.md
#	doc/developer-notes.md
#	doc/dnsseed-policy.md
#	doc/files.md
#	doc/guide-startmany.md
#	doc/init.md
#	doc/masternode-budget.md
#	doc/masternode_conf.md
#	doc/multiwallet-qt.md
#	doc/release-process.md
#	doc/swifttx.md
#	doc/tor.md
#	doc/translation_process.md
#	doc/unit-tests.md
#	doc/zmq.md
#	src/test/README.md
#	test/functional/README.md

* Merge #921: [Scripts] Overhaul supplemental python/shell scripts

0608b9ca95 Misc updates (Fuzzbawls)
616b1d531c Introduce clang-format-diff.py (Fuzzbawls)
0367807d49 Introduce commit-script-check.sh (Fuzzbawls)
28bd93359a Update gitian-build.py (Fuzzbawls)
b0d7d07512 Update github-merge.py (Fuzzbawls)
fe7bf507d4 Introduce gen-manpages.sh (Fuzzbawls)
035dda7458 Introduce circular-dependencies.py (Fuzzbawls)
70721b47ac Migrate update-translations.py to python3 (Fuzzbawls)
1558ff775e Update install_db4.sh (Fuzzbawls)
5c92f16656 Add multi-purpose copyright header script (Fuzzbawls)

Tree-SHA512: 3cc0637288fe059c340bbaee8e5eda794df985280b739d8a976e6eaa7938bb24eb2bf554c4d1552cc5f45adcd1f1380e4ea390029ed9024f97bf80071918b9f4

# Conflicts:
#	contrib/devtools/security-check.py
#	contrib/gitian-build.py
#	contrib/install_db4.sh

* Merge #911: [RPC] add 'getblockindexstats' function

eea9915361 [RPC] fix locking strategy (random-zebra)
49ef846774 [RPC] fix help texts (random-zebra)
26b1f0ca33 [RPC] 'getblockindexstats': count public spends separately (random-zebra)
7980f23c0c [RPC] fix fee calculation in 'getblockindexstats' and 'getfeeinfo' (random-zebra)
689ac23f62 [RPC] add 'getblockindexstats' function (random-zebra)

Pull request description:

  This introduces a new RPC method `getblockindexstats` to get aggregated BlockIndex data for a range of blocks:
  - transaction count
  - transaction count (including coinbase/coinstake txes)
  - zPIV per-denom mint count
  - zPIV per-denom spend count
  - total transaction bytes
  - total fees in block range
  - average fee per kB

  Since it expands the functionality of `getfeeinfo`, this method has been redirected to call `getblockindexstats` (over the **last** N blocks).

  To avoid code duplication with `getserials` and `getmintsinblocks`, the initial validation of the input params has been refactored in the function `validaterange()`.
  This also contains a fix to prevent the wallet from crashing when calling these functions over out-of-range blocks.

ACKs for commit eea991:
  Fuzzbawls:
    ACK eea9915
  Warrows:
    ACK eea9915

Tree-SHA512: fd424d27b09133f8e1b646044f6e48cb7be8e7b7f6bbe51797b229e7e1c5d721226022915876d3810b38e7c2eb6bb089a7e3b8df2b0487ac251bde405e1f964a

* Merge #925: [Consensus] Time checks

88705a6099 [Consensus] Guard time checks changes (warrows)
105ee5fd07 [Consensus] Readd checks removed in 3b778f56fe2b5e5b363c8c6d794a848a84d630d1 (warrows)
2621b7f3f7 [Refactoring] Move ContextualCheckZerocoinStake() to kernel.cpp (warrows)

Pull request description:

  Two checks on the age of a transaction used to stake were removed by mistake in 3b778f5. We reintroduce them here.
  2621b7f is a bit of refactoring
  105ee5f is the real change
  88705a6 avoid checking blocks already in the blockchain

ACKs for commit 88705a:
  furszy:
    ACK 👌  [88705a6](https://github.com/PIVX-Project/PIVX/pull/925/commits/88705a6099f0c42d122c5717fccd08f6485f0b0a)
  Fuzzbawls:
    ACK 88705a6

Tree-SHA512: 13397aac35b1d8c6680993ba90a1266113baf25bd16410f408d7d16f9eaa93f7cd0f665224959c64dfac5725bdacc25bead9d65cd8d9bdcd5570b9434ebd851a

# Conflicts:
#	src/kernel.cpp
#	src/main.cpp

* Fixed compile error

* Merge #824: [Refactor] Remove stale obfuscation code

fe67706fd2 Remove more useless obfuscation code (Fuzzbawls)
eed0a1d34e Remove more useless obfuscation code (Fuzzbawls)
3bb5c768bf Remove unused functions in wallet.cpp (Fuzzbawls)
166b2d31c8 Remove nAnonymizePivxAmount and nLiquidityProvider (Fuzzbawls)
886d806f58 Remove unused code in DoAutomaticDenominating (Fuzzbawls)
742a7b187c [Qt] Remove unused obfuscationconfig (Fuzzbawls)

Pull request description:

  Removal of "dead" code surrounding the defunct obfuscation feature.

  Obfuscation as a usable feature was removed in November 2017, but much of it's underlaying code remained. This PR aims to clean up and remove the now unnecessary code.

  Marking as [WIP] for the time being.

ACKs for commit fe6770:
  random-zebra:
    ACK https://github.com/PIVX-Project/PIVX/commit/fe67706fd222168e4bb6a387566a48dbd667638c

Tree-SHA512: 46ab7d035aa899677d1337c6a58def25e452c24db038b769e9e6f980ac43e03a34af968114facadcd62ec93eacf41de0a385f60d91630a0ac8425cd385d9a513

# Conflicts:
#	src/init.cpp
#	src/obfuscation.cpp
#	src/obfuscation.h
#	src/qt/obfuscationconfig.cpp
#	src/qt/obfuscationconfig.h
#	src/qt/optionsmodel.cpp
#	src/util.cpp
#	src/util.h
#	src/wallet.cpp

* Fixed compile error

* Merge #930: [Net] Add a couple new testnet checkpoints

ab441f3728 [Net] Add a couple new testnet checkpoints (Fuzzbawls)

Pull request description:

  1. `1106100` height that zc public spends became available
  2. `1112700` random recent testnet block that meets criteria

ACKs for commit ab441f:

Tree-SHA512: c138a71939e66a0a9ac598a25f6984c4f05f846533ded2a90f0430c7d71608baf81e48e8bd3ca71206794f3212c2f9e3e8ed5cd282f9c9d02a38db61f7585e85

* Merge #926: [Doc] 3.3.0 Notable Changes

cd11699936 [Doc] 3.3.0 Notable Changes (Fuzzbawls)

Pull request description:

  Notable changes for 3.3.0

  #ci-skip

ACKs for commit cd1169:

Tree-SHA512: 6cb841dd65873c1c3cc7c7b03ab672ae17e0945e9872b3f53a4accf6b919f46aab9fbdc95753fd159cda88db86f2fcc087a15a3e1605fda170a99b6c50e0f7e9

# Conflicts:
#	doc/release-notes.md

* Fixed coin name

* Merge #929: [Net] Update hard-coded seeds

c447aecc1b [Net] Update hard-coded seeds (Fuzzbawls)

Pull request description:

  Updated hard-coded seeds based on uptime and availability from primary
  DNS seeder.

ACKs for commit c447ae:

Tree-SHA512: 4ca56e41e277092093eead76fbc229a130bb786790c784a91e0d78a724f35a6e6594c4daa82a9dda88f7ed2eae441bc371fa2b4ab3d50d203d518d667ecbd2a9

# Conflicts:
#	src/chainparamsseeds.h

* PIVX Core v3.3.0

# Conflicts:
#	configure.ac
#	doc/release-notes.md

* Fixed coin name

* Fixed coin name

* Fixed coin name

* Updated doxyfile

* Merge #934: [Build] Bump master to 3.3.99 (pre-3.4)

7b4680a [Build] Bump master to 3.3.99 (pre-3.4) (Fuzzbawls)

Pull request description:

  Now that 3.3 has been branched off, bump master to 3.3.99 (pre-3.4).
  Gitian descriptors reflect this as well.

ACKs for commit 7b4680:
  Mrs-X:
    utACK https://github.com/PIVX-Project/PIVX/pull/934/commits/7b4680a881dcaddba82bddbd3161506358c99ac7

Tree-SHA512: b582d3f9ede816d28902991e8b891a8e56261dcf9a857cdbc5af1787add52c402a66c0eebf1cfc8197dee7dc295a3410406f2e4e347e078232e9f4d2036459bb

# Conflicts:
#	configure.ac
#	contrib/gitian-descriptors/gitian-linux.yml
#	contrib/gitian-descriptors/gitian-osx.yml
#	contrib/gitian-descriptors/gitian-win.yml

* Merge #932: [Node] Do all block index writes in a batch

e515b1e [Node] Do all block index writes in a batch (Pieter Wuille)

Pull request description:

  Backport from bitcoin https://github.com/bitcoin/bitcoin/pull/5367

ACKs for commit e515b1:
  Mrs-X:
    ACK https://github.com/PIVX-Project/PIVX/pull/932/commits/e515b1e9f2309d27efea69beae6569ee92178d88
  furszy:
    ACK [e515b1e](https://github.com/PIVX-Project/PIVX/pull/932/commits/e515b1e9f2309d27efea69beae6569ee92178d88)

Tree-SHA512: 8eff741bcbe357b7f6af0d1aea627f77498543efd117173ab2b4c325c3bc3ef3e761b6f4ad7cf70379b55daf68724bed2e10fe22a273b0fc1c3009fac8008a60

# Conflicts:
#	src/main.cpp

* Merge #933: [Qt] Add blockhash + datadir to information tab

7c9859f [Qt] Add blockhash + datadir to information tab (Mrs-X)

Pull request description:

  Added the block hash of the latest block to the Tools -> Information tab.
  And, while I was at it, added the used data-directory (similar to upstream).

  ![InfoTab](https://user-images.githubusercontent.com/22873440/59847234-3febb200-9362-11e9-982e-1d8742e47c4d.png)

ACKs for commit 7c9859:
  Fuzzbawls:
    ACK 7c9859f

Tree-SHA512: dcfa1443253255c1eaa8773e47d53e4541a01f956636f8c6f710d7d048eee33e7ceea8151c0cc619b382b3ce67472a594fc229d434af3c9e62c27c86686d9edd

# Conflicts:
#	src/qt/forms/rpcconsole.ui

* show the progress of functional test

example (added the progress index `n/m`)
```
1/107 - wallet_hd.py passed, Duration: 27 s
.........................................................................................
2/107 - mining_getblocktemplate_longpoll.py passed, Duration: 72 s
..................................................................
3/107 - feature_maxuploadtarget.py passed, Duration: 78 s
```

- clear dots line
```
$ test/functional/test_runner.py -t can_trash
Temporary test directory at can_trash/test_runner_₿_🏃_20181018_220600
1/105 - wallet_hd.py passed, Duration: 21 s
2/105 - mining_getblocktemplate_longpoll.py passed, Duration: 71 s
3/105 - feature_maxuploadtarget.py passed, Duration: 68 s
..................
```

- don't print the `dot` progressive if `--quiet`

- done_str
- nothing commit to check again travis tests

* tests: Print dots by default

* tests: Print remaining jobs in test_runner.py

This helps finding out which tests fail to finish.

* travis: Fix caching issues

* [Travis] Log more info

* travis: Use absolute paths for cache dirs

* [Travis] Give more time to tests

Travis was regularly failing because the full test suite with coverage
takestoo much time.
Bitcoin has some optimisations in there which allows them to give less
time to the test part of the process. We don't so until we do, we have
to reserve more time. We will probably have to restart manually more
travis jobs but that's the only way to have them run to the end.

* Merge #947: [Scripts] Sync github-merge.py with upstream

cd9a6edfea [Scripts] Sync github-merge.py with upstream (Fuzzbawls)

Pull request description:

  Pulls in further updates to the script from upstream since #921 was
  merged.

  Most notably, this allows for shorter commit hashes in ACK/utACK comments/reviews

ACKs for commit cd9a6e:

Tree-SHA512: 0aef9f8e587ba3045628d6bce6ed9d29c2efbc0ac70ebfe7f0ba0ff52f3b9f23abd6d85095f783510868c9d35c15cfe63dbe885b9f02889867b7a71cc2a78bff

* Merge #949: [Refactor] Remove all "using namespace" statements

ef41333993fc7f9a8b1a845766b68f15576bd4c2 [Refactor] Replace tabs with spaces (warrows)
604d365c5ee12c2273789fd3afa2f496e8550eb1 [Refactor] Remove all "using namespace" statements (warrows)

Pull request description:

  This goes towards following more closely the coding guidelines.
  No functional change.

ACKs for top commit:
  random-zebra:
    ACK https://github.com/PIVX-Project/PIVX/pull/949/commits/ef41333993fc7f9a8b1a845766b68f15576bd4c2
  Fuzzbawls:
    ACK ef41333993fc7f9a8b1a845766b68f15576bd4c2

Tree-SHA512: 18b1744a397a9ade766456980f980ea915c468c9484ff61401c3e96b4008c6c615bb4dbf533009bedb89297aaec5f1dc7cd0b27aafcb08d3088fb7abd579cf87

# Conflicts:
#	src/activemasternode.cpp
#	src/activemasternode.h
#	src/init.cpp
#	src/main.cpp
#	src/main.h
#	src/masternode-budget.cpp
#	src/masternode.cpp
#	src/masternode.h
#	src/masternodeman.cpp
#	src/masternodeman.h
#	src/net.cpp
#	src/obfuscation-relay.cpp
#	src/obfuscation-relay.h
#	src/obfuscation.cpp
#	src/obfuscation.h
#	src/qt/multisigdialog.cpp
#	src/qt/pivxstrings.cpp
#	src/qt/privacydialog.cpp
#	src/qt/transactiondesc.cpp
#	src/qt/vitae.cpp
#	src/qt/walletmodel.cpp
#	src/rpcblockchain.cpp
#	src/rpcdump.cpp
#	src/rpcmasternode-budget.cpp
#	src/rpcmasternode.cpp
#	src/rpcmining.cpp
#	src/rpcmisc.cpp
#	src/rpcrawtransaction.cpp
#	src/rpcserver.h
#	src/rpcwallet.cpp
#	src/stakeinput.cpp
#	src/test/zerocoin_transactions_tests.cpp
#	src/timedata.cpp
#	src/util.cpp
#	src/vitae-tx.cpp
#	src/wallet.cpp
#	src/wallet.h
#	src/walletdb.cpp
#	src/walletdb.h
#	src/zvit/zvitwallet.cpp

* Fixed compile error

* Removed more "using namespace" statements

* Merge #939: [Wallet] Remove (explicitely) unused tx comparator

3da857b52879c186295057a5f91ec731cd65e3de [Wallet] Remove (explicitely) unused tx comparator (warrows)

Pull request description:

  '==' and '!=' operators in CMutableTransaction are never used explicitly.
  Them being used implicitly is probably what causes #510. There is no good reason to keep them and BTC removed them here: https://github.com/bitcoin/bitcoin/pull/13443
  Should fix #510

ACKs for top commit:
  Fuzzbawls:
    ACK 3da857b52879c186295057a5f91ec731cd65e3de

Tree-SHA512: f5874d794b0a43b1290c977b10d16b1a8078b09862886f34bcdcc65e5a1ef2b9eb1c3e43dfe4711861609cf5a6c92d35180e37a95f5d5afcbac16854d5189dee

* Merge #951: [Trivial] typo fixes

639b43dee61c5d918bc5538eb563de376d51ee78 [Trivial] Spelling - Wither -> Whether (Cave Spectre)
c9a2cc35d201421b3de20a539f1598372a36efae Trivial: typo fixes (Cave Spectre)

Pull request description:

  "monthly" instead of "monthy"
  "budget" instead of "buddget"

  Also included "std::" on the throw runtime_error for a smoother merge with #949

ACKs for top commit:
  Fuzzbawls:
    ACK 639b43dee61c5d918bc5538eb563de376d51ee78

Tree-SHA512: 3e6d72e4842c4e2100e6252b4b452da9368c76583dee9bf7427e73fc1f8115fbcd059bd7869d7f43e9b40f7026a65b07a0d916f6fc9df5f76c93eb08145437dc

# Conflicts:
#	src/rpcmasternode-budget.cpp

* Merge #941: [Refactor] Move ThreadStakeMinter out of net.cpp

42fe4040acff08450168416ccf35413abdc1747a [Refactor] Move ThreadStakeMinter out of net.cpp (Fuzzbawls)

Pull request description:

  This moves the implementation function and thread creation to a more
  appropriate file (`miner.cpp`).

  Resolves #938

ACKs for top commit:
  CaveSpectre11:
    ACK https://github.com/PIVX-Project/PIVX/commit/42fe4040acff08450168416ccf35413abdc1747a
  random-zebra:
    ACK https://github.com/PIVX-Project/PIVX/pull/941/commits/42fe4040acff08450168416ccf35413abdc1747a
  furszy:
    utACK [42fe404](https://github.com/PIVX-Project/PIVX/pull/941/commits/42fe4040acff08450168416ccf35413abdc1747a)

Tree-SHA512: d3417f03cab63aa41b1ff0fb4d391d42f4448b83efe70391d4014407008af34eb265a23b5807ebecb90cf9637fb74e5b330b02c92e7038e5400a5f16608800ee

# Conflicts:
#	src/net.cpp

* Merge #961: [Trivial][Tests] Do not fail test when warnings are written to stderr

20aab1152afa3a0ef71ffeb05d4dd4eb171ba116 [Tests] Do not fail when warnings are written to stderr (random-zebra)

Pull request description:

  Fixes https://github.com/PIVX-Project/PIVX/issues/960

  Rationale: the test result should be set only through `assert`s in the test and not rely on what's printed on the console. Furthermore, as shown in the issue, stderr could contain simple warnings that don't affect the test's outcome.
  If stderr is not empty though, print its content.

  Also re-sort tests by duration.

ACKs for top commit:
  Fuzzbawls:
    ACK 20aab1152afa3a0ef71ffeb05d4dd4eb171ba116
  Warrows:
    utACK 20aab11

Tree-SHA512: 34685dd81b7849d761eb3427a3f67c825605b58d985d3c992491007ac84085632b6c5a24427ac53e8c6f340b3becf68e5b0a036bf2614b47f20ab9886b027432

* Merge #964: [Refactor] Combine parameter checking of budget commands

983d97a86c6450c85a0411eed5b533e3109c1aea [Refactor] Combine parameter checking of budget commands (Cave Spectre)

Pull request description:

  ### **Release notes**
  - [Refactor] Move common budget parameter checking code into a function

  ### **Details**
  The code in both `preparebudget` and `submitbudget` used the same parameter checking.  This pulls that parameter checking and loading into a common routine used by both; for ease of improvements and adjustments to the parameter checking... so the risk of not adjusting them consistently in both routines is removed.

  ### **Note**
  The early discussion below is based on a combined PR that addressed this, plus #950 and a PR to be named later.  The decision was made to split and focus; so the discussions can be independent of each other and refactor as needed.

ACKs for top commit:
  Fuzzbawls:
    ACK 983d97a86c6450c85a0411eed5b533e3109c1aea
  random-zebra:
    ACK https://github.com/PIVX-Project/PIVX/commit/983d97a86c6450c85a0411eed5b533e3109c1aea

Tree-SHA512: a88eb41e06d1936db77f1cd9c4f04360b446c48d27652d57dfd6e4b119140d56e24b24e00e0ac48890cc78d4130f8f688a711f74899f9c9301d1aba22dff5315

# Conflicts:
#	src/rpcmasternode-budget.cpp

* Merge #952: [Staking] Prevent potential negative out values during stake splitting

139d333dd9c294e13115bfd8e1b1a8d7ad1e9d2e Minting: Prevent potential negative out values (Cave Spectre)

Pull request description:

  On the rare occasion that a small UTXO wins a stake; and that user has (by lack of understanding, or by error) configured a very small StakeSplitThreshold; they can end up in a situation where their extremely lucky stake win fails at consensus because of the way the stake split is calculated.

  The logic split the block reward between the two outputs; along with the input.  However if that input is significantly small, and the block reward is significantly weighted to the masternode; then the potential for a negative (and thus very very large) output would be created in the second side of the split.  This is due to the fact that the full masternode reward is taken out of the "previous" output (`vout[i - 1]`).

  This is a rare, if not relatively impossible, scenario with PIVX at it's current state, but the potential grows much larger when coin parameters are re-arranged; e.g. small stakes with a heavy weight onto the masternode reward.  i.e. a stake split of 5, with a block reward of 10, and 90% to the masternode.   15 ends up split into vout[1] and vout[2], both receiving 7.5; yet FillBlockPayee will subtract 9 from vout[2]; resulting in a negative wrapped to a large positive.

  This logic simply puts the reward that will be deducted from into the second vout.  So with the above numbers; vout[1] is split to 2.5, vout[2] is initially 12.5 and then after the unknown (at that time) masternode fee of 9, is reduced to 3.5; no longer going negative.

  Of course this is an extreme example; but the potential still exists.

  Alternatively, restrictions could be placed on setstakesplitthreshold to prevent the user from setting a threshold dangerously low; or a minstake could be setup to prevent a stake small enough to be a problem from being considered.  However, this seems like the best solution to the problem; by handling it without adding a lot of logic to collect the chain parameters and set limits that make sense to whatever chosen configuration is used.

ACKs for top commit:
  random-zebra:
    ACK https://github.com/PIVX-Project/PIVX/pull/952/commits/139d333dd9c294e13115bfd8e1b1a8d7ad1e9d2e
  Warrows:
    utACK 139d333
  Mrs-X:
    utACK https://github.com/PIVX-Project/PIVX/pull/952/commits/139d333dd9c294e13115bfd8e1b1a8d7ad1e9d2e and merging...

Tree-SHA512: 2b8b91adeb5b5f053e60087f3f3b350228491a6be4970180d68475c11610f95fa62fb9e2583f8fff7e7b567fec3d2105ffa48246cc4addb3914cfb37ee3e312d

* Updated fundamental node

* Merge #971: [Wallet][zPIV] zc public spend parse crash in wallet startup.

12c44cafdeb49ec0b5fbe5815cb4fa431bc2a934 [Wallet][zPIV] zc public spend parse crash in wallet startup fixed. (furszy)

Pull request description:

  ### Crash Details
  Essentially the crash happens when the wallet.dat file contains a zc public spend transaction (input) and the user have removed the chain data.

  Specifically inside the `decomposeTransaction` in the `TransactionRecord` class the wallet tries to parse the `publicCoinSpend` looking for every output that is linked to the transaction, as there is no information about the output in disk, the wallet throws a runtime error on the startup blocking the initialization (only two ways to surpass this issue for current users:

  1) Download the snapshot.
  2) Start the wallet with another wallet.dat file and let it sync until the required output data is downloaded).

  --------
  ### Fix
  Use only the coin spend serial and not try to parse + validate the whole object, there is no need to do it there, if the transaction is in the internal wallet txes map then it means that it passed all of the validations.

ACKs for top commit:
  Warrows:
    ACK 12c44ca
  Fuzzbawls:
    ACK 12c44cafdeb49ec0b5fbe5815cb4fa431bc2a934
  random-zebra:
    ACK https://github.com/PIVX-Project/PIVX/pull/971/commits/12c44cafdeb49ec0b5fbe5815cb4fa431bc2a934 and merging...

Tree-SHA512: 6b15b5f99fd85ddbf1349c71f62a3287ae4194b6b345ca2b72849ff72c72e4709b092e95ff5cfb6c5a2d9ff52cc30380b6eba34ffedb825e8b3c5764d63c65cb

# Conflicts:
#	src/zvit/zvitmodule.cpp

* Merge #974: [Tests] Add Spork functional test and update RegTest spork key

db702dcc200f9c70562039d422de2ec36c3248f9 [Tests] Enable Spork messages on RegTest net (random-zebra)
421956f80325331bd145c83e4e182687dfe13c00 [Tests] Add Spork functional test and update RegTest spork key (random-zebra)

Pull request description:

  This adds a first basic functional test for the spork RPC.
  The spork key for RegTestNet is updated, and the relative private key is provided in the comment so anyone is able to test (prior to this, there was no public key set for RegNet so it inherited the TestNet value).

ACKs for top commit:
  Warrows:
    Very nice: ACK db702dcc200f9c70562039d422de2ec36c3248f9
  Fuzzbawls:
    ACK db702dcc200f9c70562039d422de2ec36c3248f9

Tree-SHA512: 507ca538a7f399ad1872ccdce689e2d144311adb6355cdcc16d0526272ca748b1fa9fecab3c681c4d5cf73898fb686774ced179a318404bc67452abf4666f707

* Merge #965: [RPC] Correct issues with budget commands

72611349f10c94de54162ab1a226a81dd9af35fd [Review] Convert runtime_error to JSONRPCError (Cave Spectre)
f7ac53b2d5de29951240718680443b62acfa6db2 [RPC] Correct issues with budget commands (Cave Spectre)

Pull request description:

  ### **Release notes**
  - [RPC] Fix potential wallet crashes in budget commands
  - [RPC] Remove unnecessary conditionals in parameter checking of budget commands

  ### **Details**
  **wallet segfault**
  `preparebudget`, invoked before the wallet has fully started, caused a segfault and crashed.  This was due to the lack of checking for `pwalletMain` before referencing cs_wallet.  This is solved with a throw error to tell the user to try again after the wallet has started.

  Furthermore; both `preparebudget` and `submitbudget` has a check for `pindexPrev` to conditionalize the assignment of nBlockMin (which references `pindexPrev->nHeight`); however later checks, `pindexPrev->nHeight` is referenced even if the pindexPrev check failed; which would have caused a crash if pindexPrev was NULL.  This would occur if `chainActive->Tip()` returns null.  Given the logic of `getnextsuperblock`, the check added to preparebudget and submitbudget will generate a throw error if there is no active chain tip.

  **Remove unnecessary conditionals and code**
  `pindexPrev` is loaded from `chainActive.Tip()` pindexPrev->nHeight is checked multiple times in the parameter checking.  For ease of reading, pindexPrev->nHeight is now saved in a variable as it is used multiple times in the execution of the RPC commands in question.  Likewise, two function calls are used to determine the constant length of a budget cycle `Params().GetBudgetCycleBlocks()`; and is used several times.  Storing this information in a constant is more efficient then several calls for the information.

  nBlockMin is determined (the next superblock).  However later nNext was defined to be the exact same thing.  It's not necessary to build them both.

  By nature of validating that the chosen budget cycle block is greater than the current block, and validating the number of cycles is greater than zero; the need to check the end of the budget cycle is unnecessary.

  Having a separate throw message for choosing the wrong block (not a budget block), and specifying a block that has passed is unnecessary.  These have been combined so that the user, putting in the wrong block, is informed, in both cases, what the next budget block is.

  ### **Note**
  This PR was originally part of #964, but split out to distinguish between these changes and the other's refactoring.

ACKs for top commit:
  random-zebra:
    ACK https://github.com/PIVX-Project/PIVX/pull/965/commits/72611349f10c94de54162ab1a226a81dd9af35fd
  Fuzzbawls:
    ACK 72611349f10c94de54162ab1a226a81dd9af35fd

Tree-SHA512: b0ccabae52d02767971104353b48d4efb76926017d7099b52b341d525710aa3a70d343c92c260048bb1c288990a914730a4dd0832578f07e96abb384d628cd4e

# Conflicts:
#	src/rpcmasternode-budget.cpp

* Updated fundamental node

* Merge #915: Modify GetNextWorkRequired to set Target Limit correctly

2bef330bc538d7b84a36915a8c60cb2ff7260bcf [Review] Move block identification to chainparams to support testnet also (Cave Spectre)
9294bbfd4629b2bacd62c9c4b55d92d248c0becc Modify GetNextWorkRequired to set Target Limit correctly on first PoS block (CaveSpectre11)

Pull request description:

  GetNextWorkRequired() was not setting the work required properly on the first Proof of Stake block.  The code section to cap the work at the bnTargetLimit wasn't called on that first block, but rather on the second Proof of Stake block.

  The end result is that the first PoS block uses the difficulty from the PoW, rather than capping it at the target limit; with the second PoS block capping it at the target limit:

  `uint256 bnTargetLimit = (~uint256(0) >> 24);`

  Creating a difficulty problem should the final PoW difficulty be greater than bnTargetLimit.

  ---
  This code has been tested on an altcoin; and I can provide debug output demonstrating the shift of the TargetLimit to 00000FFFF the block after the first PoS block should it be desired.

ACKs for top commit:
  random-zebra:
    ACK https://github.com/PIVX-Project/PIVX/pull/91…

Reference: bitcoin#5367

Backport from bitcoin bitcoin/bitcoin#5367

Overview of adapted commits: https://github.com/ioncoincore/ion/commits/5305677c9ffb7cf8a5fa47dee654e668e1c9eba6

PR includes adapted versions of these original commits:

From 7491d6c Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Fri, 22 Mar 2019 17:20:32 -0700
Subject: [PATCH] Fix wrapped serial functional test

The error message had changed

From 4da1dca Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Fri, 22 Mar 2019 17:23:27 -0700
Subject: [PATCH] Disable precompute for functional tests

The locking can interfere with block generation

From 4e4975b Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Thu, 11 Oct 2018 13:41:48 +0200
Subject: [PATCH] [Refactor] Refactor bignum header file into several files

From 3ec04f7 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 12:40:28 +0200
Subject: [PATCH] [Refactor] Refactor CBudgetProposal::IsEstablished()

-Move IsEstablished function to cpp file
-Use GetAdjustedTime() instead of GetTime() to avoid lack of consensus
-Remove magic numbers and declare them in chainparams

From b079abf Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Thu, 25 Apr 2019 22:36:48 -0700
Subject: [PATCH] [RPC] Remove deprecated masternode/budget RPC commands

The old `masternode` and `mnbudget` commands have been deprecated for
quite some time now, and have had a note in their help descriptions
stating as much. So, time to finally remove them for good.

From bda0322 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 12:53:42 +0200
Subject: [PATCH] [Refactoring] Add IsPassing function to CBudgetProposal

Makes the code easier to read and allows for reusing of this functions
in other places.

From 89ce7ff Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 11:37:02 +0200
Subject: [PATCH] [Qt] Add new colors for proposals

Show passing (enough votes and whatnot) but unfunded (lack of funds in the budget)
proposals in yellow and unestablished proposals (less than 24 hours
since submission) in blue

From 3601d00 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 12:32:10 +0200
Subject: [PATCH] [Qt] Print the actual number of MN used for voting

From 6e48490 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 13:23:01 +0200
Subject: [PATCH] [Budget] Guard against chainactive tip clash

From 5627807 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 26 Apr 2019 03:39:48 +0200
Subject: [PATCH] [Zerocoin] Fix limits for random number generators in GMP
 bignum implementation

From daeb752 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 26 Apr 2019 23:15:16 +0200
Subject: [PATCH] [Test] Add tests for bignum random generators

From 671452e3f5f1dbebf89aacabff3253eb1cfa7a40 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Mon, 29 Apr 2019 01:14:36 -0700
Subject: [PATCH] Rename ui_interface.h file

This file's naming convention is not in line with what is used
everywhere else. Additionally, the `ui_` prefix is typically reserved
for QMake's UIC pre-processor to generate compiler-compatible code from
Qt's `.ui` files.

Renaming this file opens the door to adding CMake build support
**without** needing to hackishly work around this one file's name, and
it becomes more in-line with the naming conventions used for every other
 source file.

From 2c76194 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Sat, 4 May 2019 11:10:22 +0200
Subject: [PATCH] [Net] Valid blocks from forks badly rejected due an invalid
 view of the available utxo set for forked chains + split height going one
 block further than what should be.

[Net] acceptBlock, back to chain split was going one block further if prev was the previous block of the incoming block.

[Net] coins cache view only has the tip view and not forks utxo chain view.

From 754764b Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Tue, 7 May 2019 11:19:54 +0200
Subject: [PATCH] [Net] AcceptBlock, first prev block loaded from disk.

From f14569f Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Wed, 8 May 2019 16:08:20 +0200
Subject: [PATCH] [Zerocoin] remove CTransaction::IsZerocoinSpend and
 CTransaction::IsZerocoinMint

- uniform IsZerocoinSpend/IsZerocoinMint CScript functions
- refactor CTxIn::IsZerocoinSpend / CTxOut::IsZerocoinMint encapsulating CScript methods
- add CTransaction methods: HasZerocoinMintOutputs / HasZerocoinSpendInputs
- refactor CTransaction::ContainsZerocoins from previous 'HasZerocoin' functions
- fix implementation of CTransaction::GetZerocoinMinted (from CTxOut)
- remove extra checks for empty scripts (as those are done in CScript functions)

From b5a5257 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Wed, 8 May 2019 17:58:57 +0200
Subject: [PATCH] [Refactor] Remove unused setStakeSeen variable

From d7afebb Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 14 May 2019 15:39:31 +0200
Subject: [PATCH] [UI] Simplify Qt margins. No functional change.

From 2d05215 Mon Sep 17 00:00:00 2001
From: Alko89 <alefer89@gmail.com>
Date: Tue, 14 May 2019 11:48:14 +0200
Subject: [PATCH] Hide xion related options.

From c424f0f Mon Sep 17 00:00:00 2001
From: Alko89 <alefer89@gmail.com>
Date: Tue, 14 May 2019 16:47:27 +0200
Subject: [PATCH] Fix margins

From 4e8f46a Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Tue, 14 May 2019 16:24:29 -0700
Subject: [PATCH] [Qt] Fixup duplicate label names

resolves compiler warnings about a label's name having been already used
.

From 4d44c97 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Wed, 6 Mar 2019 20:05:20 +0100
Subject: [PATCH] [Refactoring] Replace BOOST FOREACH with for :

Done using following script:

-BEGIN VERIFY SCRIPT-
sed -i 's/BOOST_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp
./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
-END VERIFY SCRIPT-

From e1c549e Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Wed, 6 Mar 2019 20:45:45 +0100
Subject: [PATCH] [Refactor] Remove useless BOOST includes and readd where
 needed

From 4f6cd20 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Tue, 14 May 2019 00:47:13 -0700
Subject: [PATCH] Cleanup clang's range loop analysis warnings

From a789d21 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Wed, 15 May 2019 05:29:22 +0200
Subject: [PATCH] [xION] Disable zerocoins inclusion in 'SelectStakeCoins'

From 742a7b1 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Wed, 27 Feb 2019 14:56:40 -0800
Subject: [PATCH] [Qt] Remove unused obfuscationconfig

obfuscationconfig(.h/.cpp) are unused and not needed at all anymore.

From 886d806 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Wed, 27 Feb 2019 15:02:51 -0800
Subject: [PATCH] Remove unused code in DoAutomaticDenominating

This function statically returns `false`, no need to have anything else
here.

From 166b2d3 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Wed, 27 Feb 2019 15:14:00 -0800
Subject: [PATCH] Remove nAnonymizeIonAmount and nLiquidityProvider

These two variables have been meaningless since xION's introduction...

Nuke them from orbit!

From 3bb5c76 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Wed, 27 Feb 2019 20:34:03 -0800
Subject: [PATCH] Remove unused functions in wallet.cpp

these functions were used back when obfuscation existed and are no
longer called anywhere in the source tree.

From eed0a1d Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Thu, 28 Feb 2019 01:38:15 -0800
Subject: [PATCH] Remove more useless obfuscation code

From fe67706 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Thu, 28 Feb 2019 12:23:36 -0800
Subject: [PATCH] Remove more useless obfuscation code

From a4205f2 Mon Sep 17 00:00:00 2001
From: Julian Meyer <julianmeyer2000@gmail.com>
Date: Wed, 15 May 2019 12:10:23 -0700
Subject: [PATCH] [UI] Fix improperly parented walletView.

Fixes dashpay#789.

From f3308f4 Mon Sep 17 00:00:00 2001
From: CaveSpectre11 <36988814+CaveSpectre11@users.noreply.github.com>
Date: Thu, 16 May 2019 08:41:13 -0400
Subject: [PATCH] Fix typos and oversights in listunspent

From 962a1bc Mon Sep 17 00:00:00 2001
From: Pieter Wuille <pieter.wuille@gmail.com>
Date: Tue, 3 Mar 2015 07:49:12 -0800
Subject: [PATCH] Reinitialize state in between individual unit tests.

This changes the TestingSetup fixture to be per-unit-test rather than global.
Most tests don't need it, so it's only invoked in a few.

From c5054e4 Mon Sep 17 00:00:00 2001
From: "Wladimir J. van der Laan" <laanwj@gmail.com>
Date: Thu, 12 Mar 2015 09:34:42 +0100
Subject: [PATCH] tests: add a BasicTestingSetup and apply to all tests

Make sure that chainparams and logging is properly initialized. Doing
this for every test may be overkill, but this initialization is so
simple that that does not matter.

This should fix the travis issues.

From 253c63e Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 17 May 2019 12:46:22 +0200
Subject: [PATCH] [Zerocoin] include 0 in randBignum() range

From ca86660 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 1 May 2019 11:44:26 +0200
Subject: [PATCH] [Zeroocoin] public coin spend script creation, validation and
 un/serialization.

From 1db7c59 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 1 May 2019 11:44:58 +0200
Subject: [PATCH] [UNIT TEST] publicCoinSpend valid input creation and
 verification.

[UNIT TEST] publicCoinSpend creation + validation completed.

From 0e8d0f9 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 1 May 2019 11:47:18 +0200
Subject: [PATCH] [Wallet] public coin spend creation connected + first mem
 pool validation.

[Zerocoin] public coin spend improvements.

[Zerocoin] publicCoinSpend validations connected to the accept txes flow.

[Zerocoin] public spends not checked as regular inputs.

[Zerocoin] publicCoinSpend validation as regular spends.

non good solution for the coinSpend pointer inheritance issue but at least working

[Zerocoin] ParseZerocoinPublicSpend moved into xionmodule file.

cleanup unused field.

From c8d519e Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Mon, 13 May 2019 20:52:30 +0200
Subject: [PATCH] [xION] xION Maturity --> Minimum amount of coins accumulated
 no needed anymore.

From e7dada8 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Mon, 13 May 2019 21:45:21 +0200
Subject: [PATCH] [xION] publicCoinSpend signature hash relevant data
 inclusion.

From f930016 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Tue, 14 May 2019 15:50:45 +0200
Subject: [PATCH] [xION] rebase problems fixed. (Needs more testing)

From 3c74d6d Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Tue, 14 May 2019 17:23:15 +0200
Subject: [PATCH] [xION] new protocol enforcement height added. Height not
 final, just randomly selected and tested on regtest.

From 657bb41 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 14 May 2019 23:22:13 +0200
Subject: [PATCH] [xION][Cleanup] PublicSpend rebase onto IsZerocoin

From cb4ffa1 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 14 May 2019 23:22:41 +0200
Subject: [PATCH] [xION] remove enforcement from
 'CreateZerocoinSpendTransaction' fixing the unit tests

From 4439869 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 01:13:52 +0200
Subject: [PATCH] [xION][Consensus] reject V1 serials spends.

From e0decb1 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Wed, 15 May 2019 03:10:01 +0200
Subject: [PATCH] [xION] prevent v1 zerocoins from being selected for
 PublicSpends

From a8ce671 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Wed, 15 May 2019 06:38:29 +0200
Subject: [PATCH] [xION] use new limit Zerocoin_MaxPublicSpendsPerTransaction
 for max num of inputs

From 262d5e7 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 15:40:55 +0200
Subject: [PATCH] [xION] mints coin control dialog min accumulation mature text
 removed + re mint change checkbox not visible anymore.

From 507f7c8 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 17:24:10 +0200
Subject: [PATCH] [FUNCTIONAL TESTS] valid PublicCoinSpend transaction test.

From fdfd999 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 17:40:51 +0200
Subject: [PATCH] [xION[Unit Test] Possible redundant denomination validation.

From f46b80e Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 18:01:38 +0200
Subject: [PATCH] [FUNCTIONAL TEST][xION] double spent serial validation.

From 3d0893a Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 18:43:14 +0200
Subject: [PATCH] [RPC] spendzerocoin command can now create old zc spends,
 only for regression tests

From 88cdfc6 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 19:21:05 +0200
Subject: [PATCH] [FUNCTIONAL TEST] old coinSpend transaction rejected.

From 9c0329c Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Sun, 19 May 2019 19:09:30 +0200
Subject: [PATCH] [zerocoin] Free memory from ToString()

Simple fix for a minor memory leak

From 93bc037 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Mon, 20 May 2019 23:54:17 +0200
Subject: [PATCH] [Log] Handle errors during log message formatting

From d4da015 Mon Sep 17 00:00:00 2001
From: EthanHeilman <ethan.r.heilman@gmail.com>
Date: Tue, 22 Sep 2015 15:24:16 -0400
Subject: [PATCH] Creates unittests for addrman, makes addrman testable.

Adds several unittests for addrman to verify it works as expected.
Makes small modifications to addrman to allow deterministic and targeted tests.

From 3355c86 Mon Sep 17 00:00:00 2001
From: Ethan Heilman <Ethan.R.Heilman@gmail.com>
Date: Sat, 12 Dec 2015 22:34:08 -0500
Subject: [PATCH] Increase test coverage for addrman and addrinfo

Adds several unittests for CAddrMan and CAddrInfo.
Increases the accuracy of addrman tests.
Removes non-determinism in tests by overriding the random number generator.
Extracts testing code from addrman class to test class.

From c84e0e8 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Mon, 20 May 2019 16:47:23 +0200
Subject: [PATCH] [Code Style] Remove std namespace in test file

From afdb9d4 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Thu, 16 May 2019 19:08:59 +0200
Subject: [PATCH] [RPC] Parse public spend on getserials rpc command.

[Cleanup] non used variable commented.

From 46e453b Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Thu, 16 May 2019 20:24:11 +0200
Subject: [PATCH] [xION] reject priv coin spends on tx mempool acceptance.

From b5e2526 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Fri, 17 May 2019 01:37:25 +0200
Subject: [PATCH] [xION] publicCoinSpend version field included in the
 serialization for any future change.

From 2f750e5 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Sun, 19 May 2019 23:13:30 +0200
Subject: [PATCH] [RPC] add 'createrawzerocoinpublicspend' method

From 0393227 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Sun, 19 May 2019 23:14:04 +0200
Subject: [PATCH] [Tests] add test reorg for public spend

[Unit Test] zc public spend test up-to-date with master.

From 216a317 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Mon, 20 May 2019 10:49:21 +0200
Subject: [PATCH] [xION] testnet publicSpend enforcement height set.

[xION] v1 serials validation was not checked against the publicSpend height.

From 28afbd2 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Tue, 21 May 2019 15:27:22 +0200
Subject: [PATCH] [xION] v1 serials modulus fix + isStandardTx fix for
 publicSpends.

cleanup, publicCoinSpend object leftover removed + minor log added to CheckProofOfStake.

From fda5fff Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 30 Apr 2019 11:33:10 +0200
Subject: [PATCH] [GUI] Disable zerocoin minting

From 9f3fa2a Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 30 Apr 2019 11:37:12 +0200
Subject: [PATCH] [RPC] Disable zerocoin minting

disabling also remint of change of a zc spend

From 2708b6f Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 30 Apr 2019 11:54:20 +0200
Subject: [PATCH] [Consensus] Disable zerocoin minting in contextual check

From 3555f43 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Thu, 2 May 2019 11:18:29 +0200
Subject: [PATCH] [Wallet] Disable automint

From dcc74f8 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Wed, 15 May 2019 01:28:02 +0200
Subject: [PATCH] [xION][Consensus] fix 'Zerocoin_Block_Public_Spend_Enabled()'
 enforcement

From 834cbeb Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 21 May 2019 16:00:15 +0200
Subject: [PATCH] [RPC] enable mint only for regtest

From b75d8bc Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Fri, 7 Jun 2019 00:01:35 -0700
Subject: [PATCH] [Build] Clean all coverage files during make clean

This adds extra paths that were left out and ensures that `.gcda` and `
.gcno` files are properly cleaned up.

From d413496 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Thu, 2 May 2019 23:14:24 -0700
Subject: [PATCH] [Build] Initial CMake support

From 69b0032 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Mon, 27 May 2019 00:32:30 -0700
Subject: [PATCH] fix config.h include file name

From 689ac23 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 7 Jun 2019 18:51:51 +0200
Subject: [PATCH] [RPC] add 'getblockindexstats' function

From f912182 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Sun, 9 Jun 2019 22:24:13 +0200
Subject: [PATCH] [Cleanup] clang compiler warnings in coinSpend and
 publicCoinSpend fixed.

From d2136e3 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 8 Jun 2019 03:28:54 -0700
Subject: [PATCH] depends: Update from upstream

From ca2fd10 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sun, 9 Jun 2019 18:30:00 -0700
Subject: [PATCH] use non-Cellar OpenSSL path for macOS

removes the dependency on a specific version, as long as the installed
version is 1.0.x. Also set the appropriate environment flags for OpenSSL
 on macOS.

Note: the setting of these two environment variables would be better
suited to a user's `~/.bash_profile` rather than being done within
CMake, as doing it here is destructive.

From 55127d1 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sun, 9 Jun 2019 20:13:24 -0700
Subject: [PATCH] [Gitian] Bump gitian build versions

Bumps the gitian build versions to 3.3, which should have been done
right after 3.2 was branched off.

At the same time, update to python3 explicitly and allow for some better
 error reporting.

From 019d26a Mon Sep 17 00:00:00 2001
From: CaveSpectre11 <36988814+CaveSpectre11@users.noreply.github.com>
Date: Mon, 10 Jun 2019 12:19:55 -0400
Subject: [PATCH] Don't assert if we were beaten to the block

A timing window exists where a wallet could be creating a new block from within the miner thread when a new block is received to the wallet.  This window will create a situation where TestBlockValidity() fails because the chain tip has changed between the time it created the new block and the time it tested the validity of the block.

This situation would result in the wallet being asserted; however this is a little overkill.  rather than asserting if the tip has changed, it is better to throw the block away.

This problem was revealed during a testnet test of an altcoin, and very prevalent when multiple wallet existed with the exact same number of staking coins received in the same transaction; or when multiple wallets were staking the same coins via import private key.  The problem happens significantly less in more normal circumstances, but was still observed in a testing environment with fast blocks.

It is likely that this scenario has been encountered but never determined to be root cause, as a crashed wallet could be restarted, re-indexed and never investigated further.

From 7980f23 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 11 Jun 2019 17:16:27 +0200
Subject: [PATCH] [RPC] fix fee calculation in 'getblockindexstats' and
 'getfeeinfo'

From 26b1f0c Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 11 Jun 2019 17:33:01 +0200
Subject: [PATCH] [RPC] 'getblockindexstats': count public spends separately

From a5f887b Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sun, 9 Jun 2019 16:18:27 -0700
Subject: [PATCH] [Travis] Update TravisCI from upstream

Most notable change here is the introduction of two breakpoints that
will store the current cache and stop if the previous step took a long
time. This is intended to avoid hitting the global time limit of 50
minutes for builds that would need to rebuild the depends cache.

From addeb0a Mon Sep 17 00:00:00 2001
From: Matias Furszyfer <matiasfurszyfer@protonmail.com>
Date: Fri, 14 Jun 2019 15:12:33 +0200
Subject: [PATCH] Update accumulators.cpp

From 24d72d0 Mon Sep 17 00:00:00 2001
From: CaveSpectre11 <36988814+CaveSpectre11@users.noreply.github.com>
Date: Fri, 14 Jun 2019 19:45:55 -0400
Subject: [PATCH] [code review] LogPrintf nit change

From 49ef846 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Sat, 15 Jun 2019 11:46:52 +0200
Subject: [PATCH] [RPC] fix help texts

- getblockindexstats
- getmintsinblocks
- getserials

From 46ba7a2 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Sun, 16 Jun 2019 01:43:42 +0200
Subject: [PATCH] [Backport] Max tip age to consider a node in IBD status
 customizable. Backport from bitcoin#bitcoin#7208.

From eea9915 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Mon, 17 Jun 2019 02:30:42 +0200
Subject: [PATCH] [RPC] fix locking strategy

- validaterange
- getfeeinfo
- geblockindexstats
- getmintsinblocks
- getserials

From 4fa4cc4 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:02:29 -0700
Subject: [PATCH] Update Contributing guidelines

Mainly punctuation and styling changes. Added a section about rebasing
pull requests.

From c5f6822 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:05:22 -0700
Subject: [PATCH] Update tor.md

Updated to consider more recent versions and features of the tor router
(automatic hidden service creation/deletion).

From 231f28e Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:06:34 -0700
Subject: [PATCH] Update translation_process.md

Fix some typos and refresh with more current information.

From 785b61c Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:07:34 -0700
Subject: [PATCH] Update zmq.md

Typo fixes and update python to python3 in sample commands

From df0d2ba Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:11:11 -0700
Subject: [PATCH] Introduce dependencies.md

This file contains explicit dependency information used for release
builds (version, link, etc).

From 2f5efbd Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:12:11 -0700
Subject: [PATCH] Reformat files.md

Changed to markdown table layout for ease of reading. Removed old
bitcoin-only information for older versions that we never used.

From 3cea76b Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:13:45 -0700
Subject: [PATCH] Update and reformat init.md

From 5b4f73d Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:21:28 -0700
Subject: [PATCH] Clean up whitespace in Doxyfile.in

From 20f2513 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:24:22 -0700
Subject: [PATCH] Update doc/README.md

Fix namings, outdated links, and sample commands

From 9335a10 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:26:03 -0700
Subject: [PATCH] Update test/functional/README.md

Added more details regarding the purpose, writing, and use of the
regression test suite.

From 0b5c0c2 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:34:01 -0700
Subject: [PATCH] Update release-process.md

Minor formatting and grammatical changes. Remove stale reference to the
aarch64 gitian descriptor.

From d1a65fd Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:35:18 -0700
Subject: [PATCH] Update dnsseed-policy.md

grammatical fixes

From 2bc9d1b Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:37:16 -0700
Subject: [PATCH] Update developer-notes.md

Add TOC and expand on style guidelines as well as better describe
testing cases.

From 019b8f4 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:38:04 -0700
Subject: [PATCH] Update contrib/devtools/README.md

Prep for new/renamed scripts

From d2af959 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:43:48 -0700
Subject: [PATCH] Introduce translation_strings_policy.md

Adds guidelines for adding new translation strings in the code

From 007cc8c Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:55:01 -0700
Subject: [PATCH] Update src/test/README.md

Update the in-tree README.md with the contents of `doc/unit-tests.md`,
and delete the redundant doc file.

From 1558ff7 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 02:44:34 -0700
Subject: [PATCH] Update install_db4.sh

From 70721b4 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 02:45:15 -0700
Subject: [PATCH] Migrate update-translations.py to python3

From 035dda7 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 02:46:46 -0700
Subject: [PATCH] Introduce circular-dependencies.py

This script can be used to find circular include dependencies in the
code base. These should eventually be weeded out.

From b0d7d07 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 02:50:53 -0700
Subject: [PATCH] Update github-merge.py

From 28bd933 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 03:55:34 -0700
Subject: [PATCH] Update gitian-build.py

latest version from upstream, IONified

From 0367807 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 03:56:26 -0700
Subject: [PATCH] Introduce commit-script-check.sh

This script can be used to verify scripted diff commits

From 0608b9c Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 03:57:17 -0700
Subject: [PATCH] Misc updates

From 2621b7f Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 16:33:35 +0200
Subject: [PATCH] [Refactoring] Move ContextualCheckZerocoinStake() to
 kernel.cpp

And call it in CheckProofOfStake() which is called by AcceptBlock()
instead of calling it directly from AcceptBlock().

From 105ee5f Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 16:54:10 +0200
Subject: [PATCH] [Consensus] Readd checks removed in
 3b778f5

Two importants checks were removed while refactoring to add xION
staking. Their equivalents were added to xION staking but missing for
simple ION staking. We add them back with this commit.

From 88705a6 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Mon, 20 May 2019 12:46:51 +0200
Subject: [PATCH] [Consensus] Guard time checks changes

Guard these changes against the protocol version change enforcement

From d1b54b6 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Mon, 17 Jun 2019 23:34:54 -0700
Subject: [PATCH] make translate

From e515b1e Mon Sep 17 00:00:00 2001
From: Pieter Wuille <pieter.wuille@gmail.com>
Date: Tue, 25 Nov 2014 16:26:20 +0100
Subject: [PATCH] [Node] Do all block index writes in a batch

Backport from bitcoin bitcoin#5367

From 7c9859f Mon Sep 17 00:00:00 2001
From: Mrs-X <Mrs-X@users.noreply.github.com>
Date: Thu, 20 Jun 2019 13:39:32 +0200
Subject: [PATCH] [Qt] Add blockhash + datadir to information tab

From cde9d13 Mon Sep 17 00:00:00 2001
From: Isidoro Ghezzi <isidoro.ghezzi@icloud.com>
Date: Wed, 17 Oct 2018 16:12:42 +0200
Subject: [PATCH] show the progress of functional test
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

example (added the progress index `n/m`)
```
1/107 - wallet_hd.py passed, Duration: 27 s
.........................................................................................
2/107 - mining_getblocktemplate_longpoll.py passed, Duration: 72 s
..................................................................
3/107 - feature_maxuploadtarget.py passed, Duration: 78 s
```

- clear dots line
```
$ test/functional/test_runner.py -t can_trash
Temporary test directory at can_trash/test_runner_₿_🏃_20181018_220600
1/105 - wallet_hd.py passed, Duration: 21 s
2/105 - mining_getblocktemplate_longpoll.py passed, Duration: 71 s
3/105 - feature_maxuploadtarget.py passed, Duration: 68 s
..................
```

- don't print the `dot` progressive if `--quiet`

- done_str
- nothing commit to check again travis tests

From a57939f Mon Sep 17 00:00:00 2001
From: Chun Kuan Lee <ken2812221@gmail.com>
Date: Tue, 30 Oct 2018 21:06:44 +0800
Subject: [PATCH] tests: Print dots by default

From ae0b4d0 Mon Sep 17 00:00:00 2001
From: Steven Roose <steven@stevenroose.org>
Date: Fri, 22 Feb 2019 18:06:34 +0000
Subject: [PATCH] tests: Print remaining jobs in test_runner.py

This helps finding out which tests fail to finish.

From e4945a2 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 9 Jul 2019 09:45:27 +0200
Subject: [PATCH] [Travis] Log more info

From 1fa0bf3 Mon Sep 17 00:00:00 2001
From: MarcoFalke <falke.marco@gmail.com>
Date: Fri, 14 Jun 2019 10:31:07 -0400
Subject: [PATCH] travis: Fix caching issues

From 1aa76d0 Mon Sep 17 00:00:00 2001
From: MarcoFalke <falke.marco@gmail.com>
Date: Fri, 14 Jun 2019 10:49:00 -0400
Subject: [PATCH] travis: Use absolute paths for cache dirs

From 5fbf26c Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 9 Jul 2019 15:22:59 +0200
Subject: [PATCH] [Travis] Give more time to tests

Travis was regularly failing because the full test suite with coverage
takestoo much time.
Bitcoin has some optimisations in there which allows them to give less
time to the test part of the process. We don't so until we do, we have
to reserve more time. We will probably have to restart manually more
travis jobs but that's the only way to have them run to the end.

…oncoincore#3)

Overview of adapted commits: https://github.com/ioncoincore/ion/commits/5305677c9ffb7cf8a5fa47dee654e668e1c9eba6

PR includes adapted versions of these original commits:

From 7491d6c Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Fri, 22 Mar 2019 17:20:32 -0700
Subject: [PATCH] Fix wrapped serial functional test

The error message had changed

From 4da1dca Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Fri, 22 Mar 2019 17:23:27 -0700
Subject: [PATCH] Disable precompute for functional tests

The locking can interfere with block generation

From 4e4975b Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Thu, 11 Oct 2018 13:41:48 +0200
Subject: [PATCH] [Refactor] Refactor bignum header file into several files

From 3ec04f7 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 12:40:28 +0200
Subject: [PATCH] [Refactor] Refactor CBudgetProposal::IsEstablished()

-Move IsEstablished function to cpp file
-Use GetAdjustedTime() instead of GetTime() to avoid lack of consensus
-Remove magic numbers and declare them in chainparams

From b079abf Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Thu, 25 Apr 2019 22:36:48 -0700
Subject: [PATCH] [RPC] Remove deprecated masternode/budget RPC commands

The old `masternode` and `mnbudget` commands have been deprecated for
quite some time now, and have had a note in their help descriptions
stating as much. So, time to finally remove them for good.

From bda0322 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 12:53:42 +0200
Subject: [PATCH] [Refactoring] Add IsPassing function to CBudgetProposal

Makes the code easier to read and allows for reusing of this functions
in other places.

From 89ce7ff Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 11:37:02 +0200
Subject: [PATCH] [Qt] Add new colors for proposals

Show passing (enough votes and whatnot) but unfunded (lack of funds in the budget)
proposals in yellow and unestablished proposals (less than 24 hours
since submission) in blue

From 3601d00 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 12:32:10 +0200
Subject: [PATCH] [Qt] Print the actual number of MN used for voting

From 6e48490 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 13:23:01 +0200
Subject: [PATCH] [Budget] Guard against chainactive tip clash

From 5627807 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 26 Apr 2019 03:39:48 +0200
Subject: [PATCH] [Zerocoin] Fix limits for random number generators in GMP
 bignum implementation

From daeb752 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 26 Apr 2019 23:15:16 +0200
Subject: [PATCH] [Test] Add tests for bignum random generators

From 671452e3f5f1dbebf89aacabff3253eb1cfa7a40 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Mon, 29 Apr 2019 01:14:36 -0700
Subject: [PATCH] Rename ui_interface.h file

This file's naming convention is not in line with what is used
everywhere else. Additionally, the `ui_` prefix is typically reserved
for QMake's UIC pre-processor to generate compiler-compatible code from
Qt's `.ui` files.

Renaming this file opens the door to adding CMake build support
**without** needing to hackishly work around this one file's name, and
it becomes more in-line with the naming conventions used for every other
 source file.

From 2c76194 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Sat, 4 May 2019 11:10:22 +0200
Subject: [PATCH] [Net] Valid blocks from forks badly rejected due an invalid
 view of the available utxo set for forked chains + split height going one
 block further than what should be.

[Net] acceptBlock, back to chain split was going one block further if prev was the previous block of the incoming block.

[Net] coins cache view only has the tip view and not forks utxo chain view.

From 754764b Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Tue, 7 May 2019 11:19:54 +0200
Subject: [PATCH] [Net] AcceptBlock, first prev block loaded from disk.

From f14569f Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Wed, 8 May 2019 16:08:20 +0200
Subject: [PATCH] [Zerocoin] remove CTransaction::IsZerocoinSpend and
 CTransaction::IsZerocoinMint

- uniform IsZerocoinSpend/IsZerocoinMint CScript functions
- refactor CTxIn::IsZerocoinSpend / CTxOut::IsZerocoinMint encapsulating CScript methods
- add CTransaction methods: HasZerocoinMintOutputs / HasZerocoinSpendInputs
- refactor CTransaction::ContainsZerocoins from previous 'HasZerocoin' functions
- fix implementation of CTransaction::GetZerocoinMinted (from CTxOut)
- remove extra checks for empty scripts (as those are done in CScript functions)

From b5a5257 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Wed, 8 May 2019 17:58:57 +0200
Subject: [PATCH] [Refactor] Remove unused setStakeSeen variable

From d7afebb Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 14 May 2019 15:39:31 +0200
Subject: [PATCH] [UI] Simplify Qt margins. No functional change.

From 2d05215 Mon Sep 17 00:00:00 2001
From: Alko89 <alefer89@gmail.com>
Date: Tue, 14 May 2019 11:48:14 +0200
Subject: [PATCH] Hide xion related options.

From c424f0f Mon Sep 17 00:00:00 2001
From: Alko89 <alefer89@gmail.com>
Date: Tue, 14 May 2019 16:47:27 +0200
Subject: [PATCH] Fix margins

From 4e8f46a Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Tue, 14 May 2019 16:24:29 -0700
Subject: [PATCH] [Qt] Fixup duplicate label names

resolves compiler warnings about a label's name having been already used
.

From 4d44c97 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Wed, 6 Mar 2019 20:05:20 +0100
Subject: [PATCH] [Refactoring] Replace BOOST FOREACH with for :

Done using following script:

-BEGIN VERIFY SCRIPT-
sed -i 's/BOOST_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp
./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
-END VERIFY SCRIPT-

From e1c549e Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Wed, 6 Mar 2019 20:45:45 +0100
Subject: [PATCH] [Refactor] Remove useless BOOST includes and readd where
 needed

From 4f6cd20 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Tue, 14 May 2019 00:47:13 -0700
Subject: [PATCH] Cleanup clang's range loop analysis warnings

From a789d21 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Wed, 15 May 2019 05:29:22 +0200
Subject: [PATCH] [xION] Disable zerocoins inclusion in 'SelectStakeCoins'

From 742a7b1 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Wed, 27 Feb 2019 14:56:40 -0800
Subject: [PATCH] [Qt] Remove unused obfuscationconfig

obfuscationconfig(.h/.cpp) are unused and not needed at all anymore.

From 886d806 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Wed, 27 Feb 2019 15:02:51 -0800
Subject: [PATCH] Remove unused code in DoAutomaticDenominating

This function statically returns `false`, no need to have anything else
here.

From 166b2d3 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Wed, 27 Feb 2019 15:14:00 -0800
Subject: [PATCH] Remove nAnonymizeIonAmount and nLiquidityProvider

These two variables have been meaningless since xION's introduction...

Nuke them from orbit!

From 3bb5c76 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Wed, 27 Feb 2019 20:34:03 -0800
Subject: [PATCH] Remove unused functions in wallet.cpp

these functions were used back when obfuscation existed and are no
longer called anywhere in the source tree.

From eed0a1d Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Thu, 28 Feb 2019 01:38:15 -0800
Subject: [PATCH] Remove more useless obfuscation code

From fe67706 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Thu, 28 Feb 2019 12:23:36 -0800
Subject: [PATCH] Remove more useless obfuscation code

From a4205f2 Mon Sep 17 00:00:00 2001
From: Julian Meyer <julianmeyer2000@gmail.com>
Date: Wed, 15 May 2019 12:10:23 -0700
Subject: [PATCH] [UI] Fix improperly parented walletView.

Fixes dashpay#789.

From f3308f4 Mon Sep 17 00:00:00 2001
From: CaveSpectre11 <36988814+CaveSpectre11@users.noreply.github.com>
Date: Thu, 16 May 2019 08:41:13 -0400
Subject: [PATCH] Fix typos and oversights in listunspent

From 962a1bc Mon Sep 17 00:00:00 2001
From: Pieter Wuille <pieter.wuille@gmail.com>
Date: Tue, 3 Mar 2015 07:49:12 -0800
Subject: [PATCH] Reinitialize state in between individual unit tests.

This changes the TestingSetup fixture to be per-unit-test rather than global.
Most tests don't need it, so it's only invoked in a few.

From c5054e4 Mon Sep 17 00:00:00 2001
From: "Wladimir J. van der Laan" <laanwj@gmail.com>
Date: Thu, 12 Mar 2015 09:34:42 +0100
Subject: [PATCH] tests: add a BasicTestingSetup and apply to all tests

Make sure that chainparams and logging is properly initialized. Doing
this for every test may be overkill, but this initialization is so
simple that that does not matter.

This should fix the travis issues.

From 253c63e Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 17 May 2019 12:46:22 +0200
Subject: [PATCH] [Zerocoin] include 0 in randBignum() range

From ca86660 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 1 May 2019 11:44:26 +0200
Subject: [PATCH] [Zeroocoin] public coin spend script creation, validation and
 un/serialization.

From 1db7c59 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 1 May 2019 11:44:58 +0200
Subject: [PATCH] [UNIT TEST] publicCoinSpend valid input creation and
 verification.

[UNIT TEST] publicCoinSpend creation + validation completed.

From 0e8d0f9 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 1 May 2019 11:47:18 +0200
Subject: [PATCH] [Wallet] public coin spend creation connected + first mem
 pool validation.

[Zerocoin] public coin spend improvements.

[Zerocoin] publicCoinSpend validations connected to the accept txes flow.

[Zerocoin] public spends not checked as regular inputs.

[Zerocoin] publicCoinSpend validation as regular spends.

non good solution for the coinSpend pointer inheritance issue but at least working

[Zerocoin] ParseZerocoinPublicSpend moved into xionmodule file.

cleanup unused field.

From c8d519e Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Mon, 13 May 2019 20:52:30 +0200
Subject: [PATCH] [xION] xION Maturity --> Minimum amount of coins accumulated
 no needed anymore.

From e7dada8 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Mon, 13 May 2019 21:45:21 +0200
Subject: [PATCH] [xION] publicCoinSpend signature hash relevant data
 inclusion.

From f930016 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Tue, 14 May 2019 15:50:45 +0200
Subject: [PATCH] [xION] rebase problems fixed. (Needs more testing)

From 3c74d6d Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Tue, 14 May 2019 17:23:15 +0200
Subject: [PATCH] [xION] new protocol enforcement height added. Height not
 final, just randomly selected and tested on regtest.

From 657bb41 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 14 May 2019 23:22:13 +0200
Subject: [PATCH] [xION][Cleanup] PublicSpend rebase onto IsZerocoin

From cb4ffa1 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 14 May 2019 23:22:41 +0200
Subject: [PATCH] [xION] remove enforcement from
 'CreateZerocoinSpendTransaction' fixing the unit tests

From 4439869 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 01:13:52 +0200
Subject: [PATCH] [xION][Consensus] reject V1 serials spends.

From e0decb1 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Wed, 15 May 2019 03:10:01 +0200
Subject: [PATCH] [xION] prevent v1 zerocoins from being selected for
 PublicSpends

From a8ce671 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Wed, 15 May 2019 06:38:29 +0200
Subject: [PATCH] [xION] use new limit Zerocoin_MaxPublicSpendsPerTransaction
 for max num of inputs

From 262d5e7 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 15:40:55 +0200
Subject: [PATCH] [xION] mints coin control dialog min accumulation mature text
 removed + re mint change checkbox not visible anymore.

From 507f7c8 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 17:24:10 +0200
Subject: [PATCH] [FUNCTIONAL TESTS] valid PublicCoinSpend transaction test.

From fdfd999 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 17:40:51 +0200
Subject: [PATCH] [xION[Unit Test] Possible redundant denomination validation.

From f46b80e Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 18:01:38 +0200
Subject: [PATCH] [FUNCTIONAL TEST][xION] double spent serial validation.

From 3d0893a Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 18:43:14 +0200
Subject: [PATCH] [RPC] spendzerocoin command can now create old zc spends,
 only for regression tests

From 88cdfc6 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Wed, 15 May 2019 19:21:05 +0200
Subject: [PATCH] [FUNCTIONAL TEST] old coinSpend transaction rejected.

From 9c0329c Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Sun, 19 May 2019 19:09:30 +0200
Subject: [PATCH] [zerocoin] Free memory from ToString()

Simple fix for a minor memory leak

From 93bc037 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Mon, 20 May 2019 23:54:17 +0200
Subject: [PATCH] [Log] Handle errors during log message formatting

From d4da015 Mon Sep 17 00:00:00 2001
From: EthanHeilman <ethan.r.heilman@gmail.com>
Date: Tue, 22 Sep 2015 15:24:16 -0400
Subject: [PATCH] Creates unittests for addrman, makes addrman testable.

Adds several unittests for addrman to verify it works as expected.
Makes small modifications to addrman to allow deterministic and targeted tests.

From 3355c86 Mon Sep 17 00:00:00 2001
From: Ethan Heilman <Ethan.R.Heilman@gmail.com>
Date: Sat, 12 Dec 2015 22:34:08 -0500
Subject: [PATCH] Increase test coverage for addrman and addrinfo

Adds several unittests for CAddrMan and CAddrInfo.
Increases the accuracy of addrman tests.
Removes non-determinism in tests by overriding the random number generator.
Extracts testing code from addrman class to test class.

From c84e0e8 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Mon, 20 May 2019 16:47:23 +0200
Subject: [PATCH] [Code Style] Remove std namespace in test file

From afdb9d4 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Thu, 16 May 2019 19:08:59 +0200
Subject: [PATCH] [RPC] Parse public spend on getserials rpc command.

[Cleanup] non used variable commented.

From 46e453b Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Thu, 16 May 2019 20:24:11 +0200
Subject: [PATCH] [xION] reject priv coin spends on tx mempool acceptance.

From b5e2526 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Fri, 17 May 2019 01:37:25 +0200
Subject: [PATCH] [xION] publicCoinSpend version field included in the
 serialization for any future change.

From 2f750e5 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Sun, 19 May 2019 23:13:30 +0200
Subject: [PATCH] [RPC] add 'createrawzerocoinpublicspend' method

From 0393227 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Sun, 19 May 2019 23:14:04 +0200
Subject: [PATCH] [Tests] add test reorg for public spend

[Unit Test] zc public spend test up-to-date with master.

From 216a317 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Mon, 20 May 2019 10:49:21 +0200
Subject: [PATCH] [xION] testnet publicSpend enforcement height set.

[xION] v1 serials validation was not checked against the publicSpend height.

From 28afbd2 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Tue, 21 May 2019 15:27:22 +0200
Subject: [PATCH] [xION] v1 serials modulus fix + isStandardTx fix for
 publicSpends.

cleanup, publicCoinSpend object leftover removed + minor log added to CheckProofOfStake.

From fda5fff Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 30 Apr 2019 11:33:10 +0200
Subject: [PATCH] [GUI] Disable zerocoin minting

From 9f3fa2a Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 30 Apr 2019 11:37:12 +0200
Subject: [PATCH] [RPC] Disable zerocoin minting

disabling also remint of change of a zc spend

From 2708b6f Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 30 Apr 2019 11:54:20 +0200
Subject: [PATCH] [Consensus] Disable zerocoin minting in contextual check

From 3555f43 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Thu, 2 May 2019 11:18:29 +0200
Subject: [PATCH] [Wallet] Disable automint

From dcc74f8 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Wed, 15 May 2019 01:28:02 +0200
Subject: [PATCH] [xION][Consensus] fix 'Zerocoin_Block_Public_Spend_Enabled()'
 enforcement

From 834cbeb Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 21 May 2019 16:00:15 +0200
Subject: [PATCH] [RPC] enable mint only for regtest

From b75d8bc Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Fri, 7 Jun 2019 00:01:35 -0700
Subject: [PATCH] [Build] Clean all coverage files during make clean

This adds extra paths that were left out and ensures that `.gcda` and `
.gcno` files are properly cleaned up.

From d413496 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Thu, 2 May 2019 23:14:24 -0700
Subject: [PATCH] [Build] Initial CMake support

From 69b0032 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Mon, 27 May 2019 00:32:30 -0700
Subject: [PATCH] fix config.h include file name

From 689ac23 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 7 Jun 2019 18:51:51 +0200
Subject: [PATCH] [RPC] add 'getblockindexstats' function

From f912182 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Sun, 9 Jun 2019 22:24:13 +0200
Subject: [PATCH] [Cleanup] clang compiler warnings in coinSpend and
 publicCoinSpend fixed.

From d2136e3 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 8 Jun 2019 03:28:54 -0700
Subject: [PATCH] depends: Update from upstream

From ca2fd10 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sun, 9 Jun 2019 18:30:00 -0700
Subject: [PATCH] use non-Cellar OpenSSL path for macOS

removes the dependency on a specific version, as long as the installed
version is 1.0.x. Also set the appropriate environment flags for OpenSSL
 on macOS.

Note: the setting of these two environment variables would be better
suited to a user's `~/.bash_profile` rather than being done within
CMake, as doing it here is destructive.

From 55127d1 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sun, 9 Jun 2019 20:13:24 -0700
Subject: [PATCH] [Gitian] Bump gitian build versions

Bumps the gitian build versions to 3.3, which should have been done
right after 3.2 was branched off.

At the same time, update to python3 explicitly and allow for some better
 error reporting.

From 019d26a Mon Sep 17 00:00:00 2001
From: CaveSpectre11 <36988814+CaveSpectre11@users.noreply.github.com>
Date: Mon, 10 Jun 2019 12:19:55 -0400
Subject: [PATCH] Don't assert if we were beaten to the block

A timing window exists where a wallet could be creating a new block from within the miner thread when a new block is received to the wallet.  This window will create a situation where TestBlockValidity() fails because the chain tip has changed between the time it created the new block and the time it tested the validity of the block.

This situation would result in the wallet being asserted; however this is a little overkill.  rather than asserting if the tip has changed, it is better to throw the block away.

This problem was revealed during a testnet test of an altcoin, and very prevalent when multiple wallet existed with the exact same number of staking coins received in the same transaction; or when multiple wallets were staking the same coins via import private key.  The problem happens significantly less in more normal circumstances, but was still observed in a testing environment with fast blocks.

It is likely that this scenario has been encountered but never determined to be root cause, as a crashed wallet could be restarted, re-indexed and never investigated further.

From 7980f23 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 11 Jun 2019 17:16:27 +0200
Subject: [PATCH] [RPC] fix fee calculation in 'getblockindexstats' and
 'getfeeinfo'

From 26b1f0c Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 11 Jun 2019 17:33:01 +0200
Subject: [PATCH] [RPC] 'getblockindexstats': count public spends separately

From a5f887b Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sun, 9 Jun 2019 16:18:27 -0700
Subject: [PATCH] [Travis] Update TravisCI from upstream

Most notable change here is the introduction of two breakpoints that
will store the current cache and stop if the previous step took a long
time. This is intended to avoid hitting the global time limit of 50
minutes for builds that would need to rebuild the depends cache.

From addeb0a Mon Sep 17 00:00:00 2001
From: Matias Furszyfer <matiasfurszyfer@protonmail.com>
Date: Fri, 14 Jun 2019 15:12:33 +0200
Subject: [PATCH] Update accumulators.cpp

From 24d72d0 Mon Sep 17 00:00:00 2001
From: CaveSpectre11 <36988814+CaveSpectre11@users.noreply.github.com>
Date: Fri, 14 Jun 2019 19:45:55 -0400
Subject: [PATCH] [code review] LogPrintf nit change

From 49ef846 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Sat, 15 Jun 2019 11:46:52 +0200
Subject: [PATCH] [RPC] fix help texts

- getblockindexstats
- getmintsinblocks
- getserials

From 46ba7a2 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Sun, 16 Jun 2019 01:43:42 +0200
Subject: [PATCH] [Backport] Max tip age to consider a node in IBD status
 customizable. Backport from bitcoin#bitcoin#7208.

From eea9915 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Mon, 17 Jun 2019 02:30:42 +0200
Subject: [PATCH] [RPC] fix locking strategy

- validaterange
- getfeeinfo
- geblockindexstats
- getmintsinblocks
- getserials

From 4fa4cc4 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:02:29 -0700
Subject: [PATCH] Update Contributing guidelines

Mainly punctuation and styling changes. Added a section about rebasing
pull requests.

From c5f6822 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:05:22 -0700
Subject: [PATCH] Update tor.md

Updated to consider more recent versions and features of the tor router
(automatic hidden service creation/deletion).

From 231f28e Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:06:34 -0700
Subject: [PATCH] Update translation_process.md

Fix some typos and refresh with more current information.

From 785b61c Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:07:34 -0700
Subject: [PATCH] Update zmq.md

Typo fixes and update python to python3 in sample commands

From df0d2ba Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:11:11 -0700
Subject: [PATCH] Introduce dependencies.md

This file contains explicit dependency information used for release
builds (version, link, etc).

From 2f5efbd Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:12:11 -0700
Subject: [PATCH] Reformat files.md

Changed to markdown table layout for ease of reading. Removed old
bitcoin-only information for older versions that we never used.

From 3cea76b Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:13:45 -0700
Subject: [PATCH] Update and reformat init.md

From 5b4f73d Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:21:28 -0700
Subject: [PATCH] Clean up whitespace in Doxyfile.in

From 20f2513 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:24:22 -0700
Subject: [PATCH] Update doc/README.md

Fix namings, outdated links, and sample commands

From 9335a10 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:26:03 -0700
Subject: [PATCH] Update test/functional/README.md

Added more details regarding the purpose, writing, and use of the
regression test suite.

From 0b5c0c2 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:34:01 -0700
Subject: [PATCH] Update release-process.md

Minor formatting and grammatical changes. Remove stale reference to the
aarch64 gitian descriptor.

From d1a65fd Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:35:18 -0700
Subject: [PATCH] Update dnsseed-policy.md

grammatical fixes

From 2bc9d1b Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:37:16 -0700
Subject: [PATCH] Update developer-notes.md

Add TOC and expand on style guidelines as well as better describe
testing cases.

From 019b8f4 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:38:04 -0700
Subject: [PATCH] Update contrib/devtools/README.md

Prep for new/renamed scripts

From d2af959 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:43:48 -0700
Subject: [PATCH] Introduce translation_strings_policy.md

Adds guidelines for adding new translation strings in the code

From 007cc8c Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 01:55:01 -0700
Subject: [PATCH] Update src/test/README.md

Update the in-tree README.md with the contents of `doc/unit-tests.md`,
and delete the redundant doc file.

From 1558ff7 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 02:44:34 -0700
Subject: [PATCH] Update install_db4.sh

From 70721b4 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 02:45:15 -0700
Subject: [PATCH] Migrate update-translations.py to python3

From 035dda7 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 02:46:46 -0700
Subject: [PATCH] Introduce circular-dependencies.py

This script can be used to find circular include dependencies in the
code base. These should eventually be weeded out.

From b0d7d07 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 02:50:53 -0700
Subject: [PATCH] Update github-merge.py

From 28bd933 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 03:55:34 -0700
Subject: [PATCH] Update gitian-build.py

latest version from upstream, IONified

From 0367807 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 03:56:26 -0700
Subject: [PATCH] Introduce commit-script-check.sh

This script can be used to verify scripted diff commits

From 0608b9c Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Sat, 15 Jun 2019 03:57:17 -0700
Subject: [PATCH] Misc updates

From 2621b7f Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 16:33:35 +0200
Subject: [PATCH] [Refactoring] Move ContextualCheckZerocoinStake() to
 kernel.cpp

And call it in CheckProofOfStake() which is called by AcceptBlock()
instead of calling it directly from AcceptBlock().

From 105ee5f Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 23 Apr 2019 16:54:10 +0200
Subject: [PATCH] [Consensus] Readd checks removed in
 3b778f5

Two importants checks were removed while refactoring to add xION
staking. Their equivalents were added to xION staking but missing for
simple ION staking. We add them back with this commit.

From 88705a6 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Mon, 20 May 2019 12:46:51 +0200
Subject: [PATCH] [Consensus] Guard time checks changes

Guard these changes against the protocol version change enforcement

From d1b54b6 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Mon, 17 Jun 2019 23:34:54 -0700
Subject: [PATCH] make translate

From e515b1e Mon Sep 17 00:00:00 2001
From: Pieter Wuille <pieter.wuille@gmail.com>
Date: Tue, 25 Nov 2014 16:26:20 +0100
Subject: [PATCH] [Node] Do all block index writes in a batch

Backport from bitcoin bitcoin#5367

From 7c9859f Mon Sep 17 00:00:00 2001
From: Mrs-X <Mrs-X@users.noreply.github.com>
Date: Thu, 20 Jun 2019 13:39:32 +0200
Subject: [PATCH] [Qt] Add blockhash + datadir to information tab

From cde9d13 Mon Sep 17 00:00:00 2001
From: Isidoro Ghezzi <isidoro.ghezzi@icloud.com>
Date: Wed, 17 Oct 2018 16:12:42 +0200
Subject: [PATCH] show the progress of functional test
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

example (added the progress index `n/m`)
```
1/107 - wallet_hd.py passed, Duration: 27 s
.........................................................................................
2/107 - mining_getblocktemplate_longpoll.py passed, Duration: 72 s
..................................................................
3/107 - feature_maxuploadtarget.py passed, Duration: 78 s
```

- clear dots line
```
$ test/functional/test_runner.py -t can_trash
Temporary test directory at can_trash/test_runner_₿_🏃_20181018_220600
1/105 - wallet_hd.py passed, Duration: 21 s
2/105 - mining_getblocktemplate_longpoll.py passed, Duration: 71 s
3/105 - feature_maxuploadtarget.py passed, Duration: 68 s
..................
```

- don't print the `dot` progressive if `--quiet`

- done_str
- nothing commit to check again travis tests

From a57939f Mon Sep 17 00:00:00 2001
From: Chun Kuan Lee <ken2812221@gmail.com>
Date: Tue, 30 Oct 2018 21:06:44 +0800
Subject: [PATCH] tests: Print dots by default

From ae0b4d0 Mon Sep 17 00:00:00 2001
From: Steven Roose <steven@stevenroose.org>
Date: Fri, 22 Feb 2019 18:06:34 +0000
Subject: [PATCH] tests: Print remaining jobs in test_runner.py

This helps finding out which tests fail to finish.

From e4945a2 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 9 Jul 2019 09:45:27 +0200
Subject: [PATCH] [Travis] Log more info

From 1fa0bf3 Mon Sep 17 00:00:00 2001
From: MarcoFalke <falke.marco@gmail.com>
Date: Fri, 14 Jun 2019 10:31:07 -0400
Subject: [PATCH] travis: Fix caching issues

From 1aa76d0 Mon Sep 17 00:00:00 2001
From: MarcoFalke <falke.marco@gmail.com>
Date: Fri, 14 Jun 2019 10:49:00 -0400
Subject: [PATCH] travis: Use absolute paths for cache dirs

From 5fbf26c Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 9 Jul 2019 15:22:59 +0200
Subject: [PATCH] [Travis] Give more time to tests

Travis was regularly failing because the full test suite with coverage
takestoo much time.
Bitcoin has some optimisations in there which allows them to give less
time to the test part of the process. We don't so until we do, we have
to reserve more time. We will probably have to restart manually more
travis jobs but that's the only way to have them run to the end.

Reference: bitcoin/bitcoin#5367