If this get merged I will make a pull for bitcoin.org as well.

Nak. I'd prefer not to do this.

Ok. Any specific reason why you prefer not to do it?

Independent of whether or not this pull request is accepted, I would suggest squashing these commits into a single commit only. Normally I am a strong supporter of individual, numerous and atomic commits, but when the commit message between each never differs, there's really no strong reason to use many individual commits to accomplish what could be done with just one.

Yes, I also agree that it should be squashed... right now it's hard to review and would harm bisect.. Just didn't mention it because I don't think this should go in at all.

The source code isn't the right place to advocate a new word. This change doesn't improve clarity, but it touches a lot of files. Pedantically, I don't know how much "blockchain" makes much sense as a free standing concept; After all, you could apply some minor serialization and commitment transformations and no longer have a blockchain at all, but still have bitcoin identically functional.

NACK on source-code, source-docs level.
It complicates searches.
Does not really improve the bitcoin project.

I would also say, the "blockchain" (bitcoin) is a "block chain". Block chain is more a type of trusted storage.

Blockchain is not really a new word. It is used along with block chain and block-chain all over the repo. This is a move to establish a standard.

The code is pretty consistent currently; it's hyphenated in four places. The Bitcoin core source isn't the place to establish word standards (esp not by making dozens of commits.)

Ok. I see your point about squashing these commits into one. Just need to do some research on how to do that.

This is known colloquially as urinating into the wind.

The same nerds got twisted about when "e-mail" became "email".

"blockchain" is just fine, and appears to be coming into common usage.

I don't think anyone is complaining about the word, just the changes. :)

Squashing these commits into one in #5248

For future reference, please do not create a new pull request for the same change. That just makes it more difficult to track previous comments.

Typically, after squashing, you push the new branch to the github branch associated with the pull request using "git push --force"

Meta: We should put this in a doc somewhere...

Ok, I will research that. I have just been using Firefox until today. Steep learning curve :)