Add a SECURE style flag for ThreadSafeMessageBox, which indicates that the message contains sensitive information #5095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,6 +14,9 @@ | |||
|
|
|||
| static bool noui_ThreadSafeMessageBox(const std::string& message, const std::string& caption, unsigned int style) | |||
| { | |||
| bool fSecure = style & CClientUIInterface::SECURE; | |||
| style ^= CClientUIInterface::SECURE; | |||
There was a problem hiding this comment.
Sure you don't mean:
style &= ~CClientUIInterface::SECURE
here?
There was a problem hiding this comment.
Whoops, yep. The first version had that line inside an if (fSecure) block. Fixing...
|
Looks like an acceptable solution to me (apart from sipa's nit). |
…t the message contains sensitive information. This keeps the message from being output to the debug log by bitcoind. Fixes a possible security risk when starting bitcoind in server mode without the 'rpcpassword' option configured, resulting in the "suggested" password being output to the debug log.
ea48502 to
d4746d5
Compare
|
Pushed an update last night fixing sipa's correct nit. |
|
laanwj
added a commit
that referenced
this pull request
Oct 20, 2014
d4746d5 Add a SECURE style flag for ThreadSafeMessageBox, which indicates that the message contains sensitive information. This keeps the message from being output to the debug log by bitcoind. Fixes a possible security risk when starting bitcoind in server mode without the 'rpcpassword' option configured, resulting in the "suggested" password being output to the debug log. (Mark Friedenbach)
|
Tested ACK |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the message from being output to the debug log by bitcoind. Fixes a possible security risk when starting bitcoind in server mode without the 'rpcpassword' option configured, resulting in the "suggested" password being output to the debug log.
Fixes #5094.